le32 tag;
/* Size of the data of this tagged item, in bytes. This excludes this
- * header and should be a multiple of 8.
- *
- * (Actually, the MS implementation seems to round this up to an 8 byte
- * boundary when calculating the offset to the next tagged item, but
- * uses this length unmodified when validating the item. We might as
- * well do the same.) */
+ * header and should be a multiple of 8. */
le32 length;
/* Variable length data */
hdr = (struct tagged_item_header *)p;
tag = le32_to_cpu(hdr->tag);
- len = le32_to_cpu(hdr->length);
+ len = ALIGN(le32_to_cpu(hdr->length), 8);
+ /* Length overflow? */
+ if (unlikely(len > len_remaining - sizeof(struct tagged_item_header)))
+ return NULL;
+
+ /* Matches the item we wanted? */
if (tag == desired_tag && len >= min_data_len)
return hdr->data;
- len = (len + 7) & ~7;
- if (len_remaining <= sizeof(struct tagged_item_header) + len)
- return NULL;
len_remaining -= sizeof(struct tagged_item_header) + len;
p += sizeof(struct tagged_item_header) + len;
}
/* We prepend the item instead of appending it because it's easier. */
- itemsize = sizeof(struct tagged_item_header) + len;
+ itemsize = sizeof(struct tagged_item_header) + ALIGN(len, 8);
newsize = itemsize + inode->i_extra_size;
buf = MALLOC(newsize);
hdr = (struct tagged_item_header *)buf;
hdr->tag = cpu_to_le32(tag);
hdr->length = cpu_to_le32(len);
- return hdr->data;
+ return memset(hdr->data, 0, ALIGN(len, 8));
}
static inline struct wimlib_unix_data_disk *