From 90f7dd42bf7335eb1de33577e425796dfaa21209 Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Sun, 9 Feb 2014 18:22:35 -0600 Subject: [PATCH 1/1] mount_image.c: Use well-defined check in flags_writable() No effect on Linux, but it's more correct to explicitly check for the O_ACCMODE bits being O_WRONLY or O_RDWR. --- src/mount_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mount_image.c b/src/mount_image.c index 04be3f6f..586722e5 100644 --- a/src/mount_image.c +++ b/src/mount_image.c @@ -164,7 +164,8 @@ get_lookup_flags(const struct wimfs_context *ctx) static inline int flags_writable(int open_flags) { - return open_flags & (O_RDWR | O_WRONLY); + int accmode = (open_flags & O_ACCMODE); + return (accmode == O_RDWR || accmode == O_WRONLY); } /* -- 2.43.0