From: Eric Biggers <ebiggers3@gmail.com>
Date: Fri, 9 May 2014 16:07:57 +0000 (-0500)
Subject: update_image.c: Avoid unnecessary string duplications
X-Git-Tag: v1.7.0~220
X-Git-Url: https://wimlib.net/git/?p=wimlib;a=commitdiff_plain;h=f32f8032fbced9b9e00771cdf8bcc28d214ba199

update_image.c: Avoid unnecessary string duplications
---

diff --git a/src/update_image.c b/src/update_image.c
index a009dc6f..892049cf 100644
--- a/src/update_image.c
+++ b/src/update_image.c
@@ -1369,9 +1369,7 @@ free_update_commands(struct wimlib_update_command *cmds, size_t num_cmds)
 		for (size_t i = 0; i < num_cmds; i++) {
 			switch (cmds[i].op) {
 			case WIMLIB_UPDATE_OP_ADD:
-				FREE(cmds[i].add.fs_source_path);
 				FREE(cmds[i].add.wim_target_path);
-				FREE(cmds[i].add.config_file);
 				break;
 			case WIMLIB_UPDATE_OP_DELETE:
 				FREE(cmds[i].delete_.wim_path);
@@ -1402,18 +1400,12 @@ copy_update_commands(const struct wimlib_update_command *cmds,
 		cmds_copy[i].op = cmds[i].op;
 		switch (cmds[i].op) {
 		case WIMLIB_UPDATE_OP_ADD:
-			cmds_copy[i].add.fs_source_path =
-				TSTRDUP(cmds[i].add.fs_source_path);
+			cmds_copy[i].add.fs_source_path = cmds[i].add.fs_source_path;
 			cmds_copy[i].add.wim_target_path =
 				canonicalize_wim_path(cmds[i].add.wim_target_path);
-			if (!cmds_copy[i].add.fs_source_path ||
-			    !cmds_copy[i].add.wim_target_path)
+			if (!cmds_copy[i].add.wim_target_path)
 				goto oom;
-			if (cmds[i].add.config_file) {
-				cmds_copy[i].add.config_file = TSTRDUP(cmds[i].add.config_file);
-				if (!cmds_copy[i].add.config_file)
-					goto oom;
-			}
+			cmds_copy[i].add.config_file = cmds[i].add.config_file;
 			cmds_copy[i].add.add_flags = cmds[i].add.add_flags;
 			break;
 		case WIMLIB_UPDATE_OP_DELETE: