From: Eric Biggers <ebiggers3@gmail.com>
Date: Mon, 10 Feb 2014 00:22:35 +0000 (-0600)
Subject: mount_image.c: Use well-defined check in flags_writable()
X-Git-Tag: v1.6.2~30
X-Git-Url: https://wimlib.net/git/?p=wimlib;a=commitdiff_plain;h=90f7dd42bf7335eb1de33577e425796dfaa21209;hp=5c1b50fdca21aaaddbdb34f5f7beec7d67016984;ds=sidebyside

mount_image.c: Use well-defined check in flags_writable()

No effect on Linux, but it's more correct to explicitly check for
the O_ACCMODE bits being O_WRONLY or O_RDWR.
---

diff --git a/src/mount_image.c b/src/mount_image.c
index 04be3f6f..586722e5 100644
--- a/src/mount_image.c
+++ b/src/mount_image.c
@@ -164,7 +164,8 @@ get_lookup_flags(const struct wimfs_context *ctx)
 static inline int
 flags_writable(int open_flags)
 {
-	return open_flags & (O_RDWR | O_WRONLY);
+	int accmode = (open_flags & O_ACCMODE);
+	return (accmode == O_RDWR || accmode == O_WRONLY);
 }
 
 /*