X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=tests%2Ftest-imagex-mount;h=a75c4cd82dfd78c41c21dfed034a87af896c3a67;hp=cd3317afc1ba554527563a1a7a7125439fe7c182;hb=ae4ea9fadca8e98341fedd543417bf6a204b2005;hpb=54193a504d8dcf1e2dfae727c76cd1b44884518b

diff --git a/tests/test-imagex-mount b/tests/test-imagex-mount
index cd3317af..a75c4cd8 100755
--- a/tests/test-imagex-mount
+++ b/tests/test-imagex-mount
@@ -1,44 +1,39 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # Test WIM mounting
 
 set -e
-srcdir=${srcdir:-.}
-srcdir=`realpath $srcdir`
 cd tests
+srcdir="${srcdir:-.}/.."
+srcdir="$(cd $srcdir; pwd)"
+. "$srcdir/tests/tests-common.sh"
 
-imagex() {
-	echo "imagex $@"
-	../imagex $@  > /dev/null
-}
+TEST_SUBDIR=tmpdir_test-imagex-mount
 
-imagex_info() {
-	echo "imagex info $@"
-	../imagex info "$@"
+skip_test() {
+	cd ..
+	cleanup
+	exit 77
 }
 
-imagex_mountrw() {
-	echo "imagex mountrw $@"
-	../imagex mountrw --debug "$@" &> mount.log &
-	while ! mountpoint $2 >& /dev/null; do
-		sleep 0.01;
-	done
-	return 0
+imagex_unmount() {
+	# Give the --lazy flag to work around a problem testing on Ubuntu and
+	# other OS's running Gnome, as they have a daemon
+	# "gvfs-gdu-volume-monitor" that apparently likes to randomly read
+	# filesystems that get mounted, thereby stopping them from being
+	# unmounted.
+	imagex unmount "$@" --lazy
 }
 
 cleanup() {
-	if mountpoint tmp &> /dev/null; then
-		fusermount -u tmp > /dev/null;
-	fi
-	if mountpoint tmp.mnt &> /dev/null; then
-		fusermount -u tmp.mnt > /dev/null;
-	fi
-	rm -rf dir* tmp* *.wim *.swm empty.wim tmp.orig tmp.mnt \
-			tmp.apply mount.log
+	fusermount -u $TEST_SUBDIR/tmp &> /dev/null || true
+	fusermount -u $TEST_SUBDIR/tmp.mnt &> /dev/null || true
+	rm -rf $TEST_SUBDIR
 }
+
 init() {
 	mkdir dir
-	cp $srcdir/src/*.c $srcdir/src/*.h dir
+	cp $srcdir/src/*.c dir
 	mkdir dir/subdir
 	echo 'hello' > dir/subdir/hello
 	echo 'hello' > dir/subdir/hello2
@@ -50,18 +45,18 @@ init() {
 	echo 'testing' > dir2/file
 	dd if=/dev/zero of=dir2/zeroes bs=4096 count=5
 	mkdir tmp.empty tmp.mnt tmp.apply tmp.orig
-	imagex capture tmp.empty empty.wim
+	imagex capture tmp.empty empty.wim --norpfix
 }
 
-error() {
-	echo "**********************************************"
-	echo "                  Test failure                "
-	echo $*
-	echo "**********************************************"
-	exit 1
-}
+if [ ! -r /dev/fuse ]; then
+	echo "WARNING: /dev/fuse is not readable."
+	echo "Skipping WIM mounting checks"
+	skip_test
+fi
 
 cleanup
+mkdir $TEST_SUBDIR
+cd $TEST_SUBDIR
 init
 
 # imagex mount
@@ -74,27 +69,30 @@ for flag in "--compress=none" "--compress=maximum" "--compress=fast"; do
 	fi
 	mkdir tmp
 	if ! imagex mount dir.wim dir tmp; then
-		error "Failde to mount test WIM read-only"
+		error "Failed to mount test WIM read-only. " \
+		      "Please read any error messages above before reporting this test failure. "\
+		      "Perhaps you don't have FUSE installed, or the FUSE kernel module isn't" \
+		      "loaded, or you aren't a member of the FUSE group?"
 	fi
 	echo "Testing extracting file from mounted read-only WIM"
-	if ! cp tmp/lz.c lz.c; then
+	if ! cp tmp/lz77.c lz77.c; then
 		error "Failed to extract file from read-only mounted WIM"
 	fi
-	if ! diff -q dir/lz.c lz.c; then
+	if ! diff -q dir/lz77.c lz77.c; then
 		error "Extracted file does not match copy in mounted WIM"
 	fi
-	if ! diff -q tmp/lz.c dir/lz.c; then
+	if ! diff -q tmp/lz77.c dir/lz77.c; then
 		error "Extractef file does not match original"
 	fi
-	rm -f lz.c
+	rm -f lz77.c
 	echo "Testing modifying mounted read-only WIM (should fail)"
-	if rm tmp/lz.c; then
+	if rm tmp/lz77.c; then
 		error "Removing file from read-only mounted WIM didn't fail"
 	fi
 	if touch tmp/newfile; then
 		error "Creating file on read-only mounted WIM didn't fail"
 	fi
-	if echo 3 > tmp/lz.c; then
+	if echo 3 > tmp/lz77.c; then
 		error "Writing to file on read-only mounted WIM didn't fail"
 	fi
 	echo "Testing diff of mounted read-only WIM with original directory"
@@ -102,14 +100,14 @@ for flag in "--compress=none" "--compress=maximum" "--compress=fast"; do
 		error "Recursive diff of read-only mounted WIM with original directory failed"
 	fi
 	echo "Testing unmount of read-only filesystem"
-	if ! imagex unmount tmp; then
+	if ! imagex_unmount tmp; then
 		error "Unmounting read-only WIM failed"
 	fi
 	echo "Testing unmount of read-only filesystem with --commit given"
 	if ! imagex mount dir.wim dir tmp; then
 		error "Failed to re-mount WIM read-only"
 	fi
-	if ! imagex unmount tmp --commit; then
+	if ! imagex_unmount tmp --commit; then
 		error "Failed to unmount read-only WIM with --commit flag (should be ignored)"
 	fi
 	rm -rf tmp dir.wim
@@ -125,24 +123,24 @@ if ! imagex mountrw dir.wim dir tmp; then
 	error "Failed to mount test WIM read-write"
 fi
 echo "Testing unmounting WIM unmodified"
-if ! imagex unmount tmp; then
+if ! imagex_unmount tmp; then
 	error "Failed to unmount test WIM unmodified"
 fi
 echo "Testing unmounting WIM unmodified with --commit and --check"
 if ! imagex mountrw dir.wim dir tmp; then
 	error "Failed to re-mount test WIM read-write"
 fi
-if ! imagex unmount tmp --commit --check; then
+if ! imagex_unmount tmp --commit --check; then
 	error "Failed to unmount read-write mounted WIM with changes commited (no changes made)"
 fi
 echo "Testing removing file from mounted WIM"
 if ! imagex mountrw dir.wim dir tmp; then
 	error "Failed to re-mount test WIM read-write"
 fi
-if ! rm tmp/lz.c; then
+if ! rm tmp/lz77.c; then
 	error "Failed to remove file from read-write mounted WIM"
 fi
-if test -f tmp/lz.c; then
+if test -f tmp/lz77.c; then
 	error "Removing file from read-write mounted WIM failed"
 fi
 echo "Testing making directory in mounted WIM"
@@ -159,7 +157,7 @@ fi
 if ! test -f tmp/newdir/empty_file; then
 	error "New empty file not created correctly in read-write mounted WIM"
 fi
-if ! test "`stat -c %s tmp/newdir/empty_file`" = 0; then
+if ! test "`get_file_size tmp/newdir/empty_file`" = 0; then
 	error "New empty file in read-write mounted WIM is not empty"
 fi
 echo "Testing making new non-empty file in mounted WIM"
@@ -173,10 +171,10 @@ if ! diff -q tmp/newdir/zeroes1 tmp/newdir/zeroes2; then
 	error "New files in mounted WIM not made correctly"
 fi
 echo "Unmounting WIM with changes committed and --check"
-if ! imagex unmount tmp --commit --check; then
+if ! imagex_unmount tmp --commit --check; then
 	error "Failed to unmount read-write mounted WIM"
 fi
-if test "`imagex_info dir.wim | grep Integrity | awk '{print $3}'`" != "yes"; then
+if test "`imagex info dir.wim | grep Integrity | awk '{print $3}'`" != "yes"; then
 	error "Integrity information was not included"
 fi
 rm -rf tmp
@@ -186,16 +184,16 @@ fi
 if ! diff -q tmp/newdir/zeroes1 tmp/newdir/zeroes2; then
 	error "The new non-empty files we made in the read-write mounted WIM were not extracted correctly"
 fi
-if test `stat -c %s tmp/newdir/empty_file` != 0; then
+if test `get_file_size tmp/newdir/empty_file` != 0; then
 	error "The new empty file we made in the read-write mounted WIM was not extracted correctly"
 fi
-if test `stat -c %s tmp/newdir/zeroes1` != 4096; then
+if test `get_file_size tmp/newdir/zeroes1` != 4096; then
 	error "The new non-empty files we made in the read-write mounted WIM were not extracted correctly"
 fi
 
 # Now do some tests using tar.
 do_tree_cmp() {
-	if ! ./tree-cmp $1 $2; then
+	if ! ../tree-cmp $1 $2; then
 		if [ -x /usr/bin/tree ]; then
 			echo "Dumping tree of applied image"
 			tree $2 --inodes -F -s --noreport
@@ -226,7 +224,7 @@ do_test() {
 	tar cf ../test.tar .
 	cd ..
 
-	if ! imagex_mountrw test.wim tmp.mnt; then
+	if ! imagex mountrw test.wim tmp.mnt --unix-data; then
 		error "Failed to mount WIM read-write"
 	fi
 
@@ -256,7 +254,7 @@ do_test() {
 
 	# Unmount the WIM, apply it, and diff the original tree with the applied
 	# tree
-	if ! imagex unmount tmp.mnt --commit; then
+	if ! imagex_unmount tmp.mnt --commit; then
 		error "Failed to unmount WIM mounted read-write"
 	fi
 	if ! imagex apply test.wim tmp.apply; then
@@ -266,10 +264,12 @@ do_test() {
 	rm -rf tmp.orig/* tmp.apply/*
 }
 
-. common_tests.sh
+. $srcdir/tests/common_tests.sh
 
-cleanup
 
 echo "**********************************************************"
 echo "                 WIM mount tests passed                   "
 echo "**********************************************************"
+
+cd ..
+cleanup