X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=src%2Fwrite.c;h=a431871b43792b557c2d6796ead0e16874aa98e7;hp=a23aa450d211c63e27227fd170f6e8b1b3713367;hb=cecdece7933824c248a1b07021ce576f0f9d6892;hpb=d00c015780432f419a793c459ca332b7892bfe2a diff --git a/src/write.c b/src/write.c index a23aa450..a431871b 100644 --- a/src/write.c +++ b/src/write.c @@ -1339,25 +1339,77 @@ static int write_stream_list(struct list_head *stream_list, FILE *out_fp, &progress); } +struct lte_overwrite_prepare_args { + WIMStruct *wim; + off_t end_offset; + struct list_head *stream_list; +}; + +static int lte_overwrite_prepare(struct lookup_table_entry *lte, void *arg) +{ + struct lte_overwrite_prepare_args *args = arg; + + if (lte->resource_location == RESOURCE_IN_WIM && + lte->wim == args->wim && + lte->resource_entry.offset + lte->resource_entry.size > args->end_offset) + { + ERROR("The following resource is after the XML data:"); + print_lookup_table_entry(lte); + return WIMLIB_ERR_RESOURCE_ORDER; + } -static int dentry_find_streams_to_write(struct dentry *dentry, - void *wim) + lte->out_refcnt = lte->refcnt; + memcpy(<e->output_resource_entry, <e->resource_entry, + sizeof(struct resource_entry)); + if (!(lte->resource_entry.flags & WIM_RESHDR_FLAG_METADATA)) { + wimlib_assert(lte->resource_location != RESOURCE_NONEXISTENT); + if (lte->resource_location != RESOURCE_IN_WIM || lte->wim != args->wim) + list_add(<e->staging_list, args->stream_list); + } + return 0; +} + +static int wim_find_new_streams(WIMStruct *wim, off_t end_offset, + struct list_head *stream_list) +{ + struct lte_overwrite_prepare_args args = { + .wim = wim, + .end_offset = end_offset, + .stream_list = stream_list, + }; + + return for_lookup_table_entry(wim->lookup_table, + lte_overwrite_prepare, &args); +} + +static int inode_find_streams_to_write(struct inode *inode, + struct lookup_table *table, + struct list_head *stream_list) { - WIMStruct *w = wim; - struct list_head *stream_list = w->private; struct lookup_table_entry *lte; - for (unsigned i = 0; i <= dentry->d_inode->num_ads; i++) { - lte = inode_stream_lte(dentry->d_inode, i, w->lookup_table); - if (lte && ++lte->out_refcnt == 1) - list_add_tail(<e->staging_list, stream_list); + for (unsigned i = 0; i <= inode->num_ads; i++) { + lte = inode_stream_lte(inode, i, table); + if (lte) { + if (lte->out_refcnt == 0) + list_add_tail(<e->staging_list, stream_list); + lte->out_refcnt += inode->link_count; + } } return 0; } -static int find_streams_to_write(WIMStruct *w) +static int image_find_streams_to_write(WIMStruct *w) { - return for_dentry_in_tree(wim_root_dentry(w), - dentry_find_streams_to_write, w); + struct inode *inode; + struct hlist_node *cur; + struct hlist_head *inode_list; + + inode_list = &wim_get_current_image_metadata(w)->inode_list; + hlist_for_each_entry(inode, cur, inode_list, hlist) { + inode_find_streams_to_write(inode, w->lookup_table, + (struct list_head*)w->private); + } + return 0; } static int write_wim_streams(WIMStruct *w, int image, int write_flags, @@ -1368,7 +1420,7 @@ static int write_wim_streams(WIMStruct *w, int image, int write_flags, for_lookup_table_entry(w->lookup_table, lte_zero_out_refcnt, NULL); LIST_HEAD(stream_list); w->private = &stream_list; - for_image(w, image, find_streams_to_write); + for_image(w, image, image_find_streams_to_write); return write_stream_list(&stream_list, w->out_fp, wimlib_get_compression_type(w), write_flags, num_threads, progress_func); @@ -1537,22 +1589,24 @@ out: } #if defined(HAVE_SYS_FILE_H) && defined(HAVE_FLOCK) -int lock_wim(FILE *fp, const char *path) +int lock_wim(WIMStruct *w, FILE *fp) { int ret = 0; - if (fp) { + if (fp && !w->wim_locked) { ret = flock(fileno(fp), LOCK_EX | LOCK_NB); if (ret != 0) { if (errno == EWOULDBLOCK) { ERROR("`%s' is already being modified or has been " "mounted read-write\n" - " by another process!", path); + " by another process!", w->filename); ret = WIMLIB_ERR_ALREADY_LOCKED; } else { WARNING("Failed to lock `%s': %s", - path, strerror(errno)); + w->filename, strerror(errno)); ret = 0; } + } else { + w->wim_locked = 1; } } return ret; @@ -1651,43 +1705,12 @@ out: return ret; } -static int lte_overwrite_prepare(struct lookup_table_entry *lte, - void *ignore) -{ - memcpy(<e->output_resource_entry, <e->resource_entry, - sizeof(struct resource_entry)); - lte->out_refcnt = 0; - return 0; -} - -static int check_resource_offset(struct lookup_table_entry *lte, void *arg) +static bool any_images_modified(WIMStruct *w) { - wimlib_assert(lte->out_refcnt <= lte->refcnt); - if (lte->out_refcnt < lte->refcnt) { - off_t end_offset = *(u64*)arg; - if (lte->resource_entry.offset + - lte->resource_entry.size > end_offset) - { - ERROR("The following resource is after the XML data:"); - print_lookup_table_entry(lte); - return WIMLIB_ERR_RESOURCE_ORDER; - } - } - return 0; -} - -static int find_new_streams(struct lookup_table_entry *lte, void *arg) -{ - if (lte->out_refcnt == lte->refcnt) { - /* Newly added stream that is only referenced in the modified - * images. Append it to the list of streams to write. */ - list_add(<e->staging_list, (struct list_head*)arg); - } else { - /* Not a newly added stream. But set out_refcnt to the full - * refcnt so that it's written correctly. */ - lte->out_refcnt = lte->refcnt; - } - return 0; + for (int i = 0; i < w->hdr.image_count; i++) + if (w->image_metadata[i].modified) + return true; + return false; } /* @@ -1749,12 +1772,12 @@ static int find_new_streams(struct lookup_table_entry *lte, void *arg) */ static int overwrite_wim_inplace(WIMStruct *w, int write_flags, unsigned num_threads, - wimlib_progress_func_t progress_func, - int modified_image_idx) + wimlib_progress_func_t progress_func) { int ret; struct list_head stream_list; off_t old_wim_end; + bool found_modified_image; DEBUG("Overwriting `%s' in-place", w->filename); @@ -1773,27 +1796,13 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags, return WIMLIB_ERR_RESOURCE_ORDER; } - DEBUG("Identifying newly added streams"); - for_lookup_table_entry(w->lookup_table, lte_overwrite_prepare, NULL); - INIT_LIST_HEAD(&stream_list); - for (int i = modified_image_idx; i < w->hdr.image_count; i++) { - DEBUG("Identifiying streams in image %d", i + 1); - w->private = &stream_list; - for_dentry_in_tree(w->image_metadata[i].root_dentry, - dentry_find_streams_to_write, w); - } if (w->hdr.integrity.offset) old_wim_end = w->hdr.integrity.offset + w->hdr.integrity.size; else old_wim_end = w->hdr.xml_res_entry.offset + w->hdr.xml_res_entry.size; - ret = for_lookup_table_entry(w->lookup_table, check_resource_offset, - &old_wim_end); - if (ret != 0) - return ret; - - if (modified_image_idx == w->hdr.image_count && !w->deletion_occurred) { + if (!w->deletion_occurred && !any_images_modified(w)) { /* If no images have been modified and no images have been * deleted, a new lookup table does not need to be written. */ old_wim_end = w->hdr.lookup_table_res_entry.offset + @@ -1801,17 +1810,17 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags, write_flags |= WIMLIB_WRITE_FLAG_NO_LOOKUP_TABLE | WIMLIB_WRITE_FLAG_CHECKPOINT_AFTER_XML; } - INIT_LIST_HEAD(&stream_list); - for_lookup_table_entry(w->lookup_table, find_new_streams, - &stream_list); + ret = wim_find_new_streams(w, old_wim_end, &stream_list); + if (ret != 0) + return ret; ret = open_wim_writable(w, w->filename, false, (write_flags & WIMLIB_WRITE_FLAG_CHECK_INTEGRITY) != 0); if (ret != 0) return ret; - ret = lock_wim(w->out_fp, w->filename); + ret = lock_wim(w, w->out_fp); if (ret != 0) { fclose(w->out_fp); w->out_fp = NULL; @@ -1822,6 +1831,7 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags, ERROR_WITH_ERRNO("Can't seek to end of WIM"); fclose(w->out_fp); w->out_fp = NULL; + w->wim_locked = 0; return WIMLIB_ERR_WRITE; } @@ -1838,11 +1848,16 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags, DEBUG("No new streams were added"); } - for (int i = modified_image_idx; i < w->hdr.image_count; i++) { - select_wim_image(w, i + 1); - ret = write_metadata_resource(w); - if (ret != 0) - goto out_ftruncate; + found_modified_image = false; + for (int i = 0; i < w->hdr.image_count; i++) { + if (!found_modified_image) + found_modified_image = w->image_metadata[i].modified; + if (found_modified_image) { + select_wim_image(w, i + 1); + ret = write_metadata_resource(w); + if (ret != 0) + goto out_ftruncate; + } } write_flags |= WIMLIB_WRITE_FLAG_REUSE_INTEGRITY_TABLE; ret = finish_write(w, WIMLIB_ALL_IMAGES, write_flags, @@ -1854,6 +1869,7 @@ out_ftruncate: w->filename, old_wim_end); truncate(w->filename, old_wim_end); } + w->wim_locked = 0; return ret; } @@ -1942,25 +1958,13 @@ WIMLIBAPI int wimlib_overwrite(WIMStruct *w, int write_flags, if ((!w->deletion_occurred || (write_flags & WIMLIB_WRITE_FLAG_SOFT_DELETE)) && !(write_flags & WIMLIB_WRITE_FLAG_REBUILD)) { - int i; - int modified_image_idx; int ret; - - for (i = 0; i < w->hdr.image_count && !w->image_metadata[i].modified; i++) - ; - modified_image_idx = i; - for (; i < w->hdr.image_count && w->image_metadata[i].modified && - !w->image_metadata[i].has_been_mounted_rw; i++) - ; - if (i == w->hdr.image_count) { - ret = overwrite_wim_inplace(w, write_flags, num_threads, - progress_func, - modified_image_idx); - if (ret == WIMLIB_ERR_RESOURCE_ORDER) - WARNING("Falling back to re-building entire WIM"); - else - return ret; - } + ret = overwrite_wim_inplace(w, write_flags, num_threads, + progress_func); + if (ret == WIMLIB_ERR_RESOURCE_ORDER) + WARNING("Falling back to re-building entire WIM"); + else + return ret; } return overwrite_wim_via_tmpfile(w, write_flags, num_threads, progress_func);