X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=src%2Fwin32.c;h=3925ca56a458d375d6ed11f55acae89f3e102954;hp=0c5c51cdb47594afcc5d7738f26b76bf418538ca;hb=32844c59e618cfaf1999e81e32b5e18fcb13a5b9;hpb=8d2bd90a2c9a151edc1619bf35be46b2fdda3e36 diff --git a/src/win32.c b/src/win32.c index 0c5c51cd..3925ca56 100644 --- a/src/win32.c +++ b/src/win32.c @@ -23,15 +23,13 @@ * along with wimlib; if not, see http://www.gnu.org/licenses/. */ -#ifndef __WIN32__ -# error "This file contains Windows code" -#endif +#ifdef __WIN32__ #include "config.h" #include #include #include -#include /* shlwapi.h for PathMatchSpecA() */ +#include /* shlwapi.h for PathMatchSpecW() */ #ifdef ERROR /* windows.h defines this */ # undef ERROR #endif @@ -44,7 +42,15 @@ #include +#define MAX_GET_SD_ACCESS_DENIED_WARNINGS 1 +#define MAX_GET_SACL_PRIV_NOTHELD_WARNINGS 1 +struct win32_capture_state { + unsigned long num_get_sd_access_denied; + unsigned long num_get_sacl_priv_notheld; +}; +#define MAX_SET_SD_ACCESS_DENIED_WARNINGS 1 +#define MAX_SET_SACL_PRIV_NOTHELD_WARNINGS 1 /* Pointers to functions that are not available on all targetted versions of * Windows (XP and later). NOTE: The WINAPI annotations seem to be important; I @@ -67,12 +73,10 @@ void win32_global_init() { DWORD err; - bool warned; - if (hKernel32 == NULL) { DEBUG("Loading Kernel32.dll"); - hKernel32 = LoadLibraryA("Kernel32.dll"); + hKernel32 = LoadLibraryW(L"Kernel32.dll"); if (hKernel32 == NULL) { err = GetLastError(); WARNING("Can't load Kernel32.dll"); @@ -108,26 +112,36 @@ win32_global_cleanup() } } -static const char *access_denied_msg = -" If you are not running this program as the administrator, you may\n" -" need to do so, so that all data and metadata can be backed up.\n" -" Otherwise, there may be no way to access the desired data or\n" -" metadata without taking ownership of the file or directory.\n"; +static const wchar_t *capture_access_denied_msg = +L" If you are not running this program as the administrator, you may\n" + " need to do so, so that all data and metadata can be backed up.\n" + " Otherwise, there may be no way to access the desired data or\n" + " metadata without taking ownership of the file or directory.\n" + ; + +static const wchar_t *apply_access_denied_msg = +L"If you are not running this program as the administrator, you may\n" + " need to do so, so that all data and metadata can be extracted\n" + " exactly as the origignal copy. However, if you do not care that\n" + " the security descriptors are extracted correctly, you could run\n" + " `wimlib-imagex apply' with the --no-acls flag instead.\n" + ; #ifdef ENABLE_ERROR_MESSAGES void win32_error(u32 err_code) { - char *buffer; + wchar_t *buffer; DWORD nchars; - nchars = FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER, + nchars = FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | + FORMAT_MESSAGE_ALLOCATE_BUFFER, NULL, err_code, 0, - (char*)&buffer, 0, NULL); + (wchar_t*)&buffer, 0, NULL); if (nchars == 0) { ERROR("Error printing error message! " "Computer will self-destruct in 3 seconds."); } else { - ERROR("Win32 error: %s", buffer); + ERROR("Win32 error: %ls", buffer); LocalFree(buffer); } } @@ -159,7 +173,7 @@ win32_open_file_data_only(const wchar_t *path) } int -win32_read_file(const utf16lechar *win32_filename, +win32_read_file(const wchar_t *filename, void *handle, u64 offset, size_t size, void *buf) { HANDLE h = handle; @@ -173,7 +187,7 @@ win32_read_file(const utf16lechar *win32_filename, if (ReadFile(h, buf, size, &bytesRead, NULL) && bytesRead == size) return 0; err = GetLastError(); - ERROR("Error reading \"%ls\"", win32_filename); + ERROR("Error reading \"%ls\"", filename); win32_error(err); return WIMLIB_ERR_READ; } @@ -191,14 +205,12 @@ FILETIME_to_u64(const FILETIME *ft) } static int -win32_get_short_name(struct wim_dentry *dentry, - const wchar_t *path_utf16) +win32_get_short_name(struct wim_dentry *dentry, const wchar_t *path) { WIN32_FIND_DATAW dat; - if (FindFirstFileW(path_utf16, &dat) && - dat.cAlternateFileName[0] != L'\0') - { - size_t short_name_nbytes = wcslen(dat.cAlternateFileName) * 2; + if (FindFirstFileW(path, &dat) && dat.cAlternateFileName[0] != L'\0') { + size_t short_name_nbytes = wcslen(dat.cAlternateFileName) * + sizeof(wchar_t); size_t n = short_name_nbytes + sizeof(wchar_t); dentry->short_name = MALLOC(n); if (!dentry->short_name) @@ -206,31 +218,39 @@ win32_get_short_name(struct wim_dentry *dentry, memcpy(dentry->short_name, dat.cAlternateFileName, n); dentry->short_name_nbytes = short_name_nbytes; } + /* If we can't read the short filename for some reason, we just ignore + * the error and assume the file has no short name. I don't think this + * should be an issue, since the short names are essentially obsolete + * anyway. */ return 0; } static int win32_get_security_descriptor(struct wim_dentry *dentry, struct sd_set *sd_set, - const wchar_t *path_utf16) + const wchar_t *path, + struct win32_capture_state *state, + int add_image_flags) { SECURITY_INFORMATION requestedInformation; DWORD lenNeeded = 0; BOOL status; DWORD err; + unsigned long n; requestedInformation = DACL_SECURITY_INFORMATION | SACL_SECURITY_INFORMATION | OWNER_SECURITY_INFORMATION | GROUP_SECURITY_INFORMATION; +again: /* Request length of security descriptor */ - status = GetFileSecurityW(path_utf16, requestedInformation, + status = GetFileSecurityW(path, requestedInformation, NULL, 0, &lenNeeded); err = GetLastError(); if (!status && err == ERROR_INSUFFICIENT_BUFFER) { DWORD len = lenNeeded; char buf[len]; - if (GetFileSecurityW(path_utf16, requestedInformation, + if (GetFileSecurityW(path, requestedInformation, (PSECURITY_DESCRIPTOR)buf, len, &lenNeeded)) { int security_id = sd_set_add_sd(sd_set, buf, len); @@ -245,57 +265,90 @@ win32_get_security_descriptor(struct wim_dentry *dentry, } } - if (err == ERROR_ACCESS_DENIED) { - WARNING("Failed to read security descriptor of \"%ls\": " - "Access denied!\n%s", path_utf16, access_denied_msg); + if (add_image_flags & WIMLIB_ADD_IMAGE_FLAG_STRICT_ACLS) + goto fail; + + switch (err) { + case ERROR_PRIVILEGE_NOT_HELD: + if (requestedInformation & SACL_SECURITY_INFORMATION) { + n = state->num_get_sacl_priv_notheld++; + requestedInformation &= ~SACL_SECURITY_INFORMATION; + if (n < MAX_GET_SACL_PRIV_NOTHELD_WARNINGS) { + WARNING( +"We don't have enough privileges to read the full security\n" +" descriptor of \"%ls\"!\n" +" Re-trying with SACL omitted.\n", path); + } else if (n == MAX_GET_SACL_PRIV_NOTHELD_WARNINGS) { + WARNING( +"Suppressing further privileges not held error messages when reading\n" +" security descriptors."); + } + goto again; + } + /* Fall through */ + case ERROR_ACCESS_DENIED: + n = state->num_get_sd_access_denied++; + if (n < MAX_GET_SD_ACCESS_DENIED_WARNINGS) { + WARNING("Failed to read security descriptor of \"%ls\": " + "Access denied!\n%ls", path, capture_access_denied_msg); + } else if (n == MAX_GET_SD_ACCESS_DENIED_WARNINGS) { + WARNING("Suppressing further access denied errors messages i" + "when reading security descriptors"); + } return 0; - } else { - ERROR("Win32 API: Failed to read security descriptor of \"%ls\"", - path_utf16); + default: +fail: + ERROR("Failed to read security descriptor of \"%ls\"", path); win32_error(err); return WIMLIB_ERR_READ; } } +static int +win32_build_dentry_tree_recursive(struct wim_dentry **root_ret, + wchar_t *path, + size_t path_num_chars, + struct wim_lookup_table *lookup_table, + struct sd_set *sd_set, + const struct capture_config *config, + int add_image_flags, + wimlib_progress_func_t progress_func, + struct win32_capture_state *state); + /* Reads the directory entries of directory using a Win32 API and recursively * calls win32_build_dentry_tree() on them. */ static int win32_recurse_directory(struct wim_dentry *root, - const mbchar *root_disk_path, + wchar_t *dir_path, + size_t dir_path_num_chars, struct wim_lookup_table *lookup_table, - struct wim_security_data *sd, + struct sd_set *sd_set, const struct capture_config *config, int add_image_flags, wimlib_progress_func_t progress_func, - struct sd_set *sd_set, - const wchar_t *path_utf16, - size_t path_utf16_nchars) + struct win32_capture_state *state) { WIN32_FIND_DATAW dat; HANDLE hFind; DWORD err; int ret; - { - /* Begin reading the directory by calling FindFirstFileW. - * Unlike UNIX opendir(), FindFirstFileW has file globbing built - * into it. But this isn't what we actually want, so just add a - * dummy glob to get all entries. */ - wchar_t pattern_buf[path_utf16_nchars + 3]; - memcpy(pattern_buf, path_utf16, - path_utf16_nchars * sizeof(wchar_t)); - pattern_buf[path_utf16_nchars] = L'/'; - pattern_buf[path_utf16_nchars + 1] = L'*'; - pattern_buf[path_utf16_nchars + 2] = L'\0'; - hFind = FindFirstFileW(pattern_buf, &dat); - } + /* Begin reading the directory by calling FindFirstFileW. Unlike UNIX + * opendir(), FindFirstFileW has file globbing built into it. But this + * isn't what we actually want, so just add a dummy glob to get all + * entries. */ + dir_path[dir_path_num_chars] = L'/'; + dir_path[dir_path_num_chars + 1] = L'*'; + dir_path[dir_path_num_chars + 2] = L'\0'; + hFind = FindFirstFileW(dir_path, &dat); + dir_path[dir_path_num_chars] = L'\0'; + if (hFind == INVALID_HANDLE_VALUE) { err = GetLastError(); if (err == ERROR_FILE_NOT_FOUND) { return 0; } else { - ERROR("Win32 API: Failed to read directory \"%s\"", - root_disk_path); + ERROR("Failed to read directory \"%ls\"", dir_path); win32_error(err); return WIMLIB_ERR_READ; } @@ -303,37 +356,38 @@ win32_recurse_directory(struct wim_dentry *root, ret = 0; do { /* Skip . and .. entries */ - if (!(dat.cFileName[0] == cpu_to_le16(L'.') && - (dat.cFileName[1] == cpu_to_le16(L'\0') || - (dat.cFileName[1] == cpu_to_le16(L'.') && - dat.cFileName[2] == cpu_to_le16(L'\0'))))) - { - struct wim_dentry *child; - - mbchar *mbs_name; - size_t mbs_name_nbytes; - ret = utf16le_to_mbs(dat.cFileName, - wcslen(dat.cFileName) * sizeof(wchar_t), - &mbs_name, - &mbs_name_nbytes); - if (ret) - goto out_find_close; - - mbchar name[strlen(root_disk_path) + 1 + mbs_name_nbytes + 1]; - sprintf(name, "%s/%s", root_disk_path, mbs_name); - FREE(mbs_name); - ret = win32_build_dentry_tree(&child, name, lookup_table, - sd, config, add_image_flags, - progress_func, sd_set); - if (ret) - goto out_find_close; - if (child) - dentry_add_child(root, child); - } + if (dat.cFileName[0] == L'.' && + (dat.cFileName[1] == L'\0' || + (dat.cFileName[1] == L'.' && + dat.cFileName[2] == L'\0'))) + continue; + size_t filename_len = wcslen(dat.cFileName); + + dir_path[dir_path_num_chars] = L'/'; + wmemcpy(dir_path + dir_path_num_chars + 1, + dat.cFileName, + filename_len + 1); + + struct wim_dentry *child; + size_t path_len = dir_path_num_chars + 1 + filename_len; + ret = win32_build_dentry_tree_recursive(&child, + dir_path, + path_len, + lookup_table, + sd_set, + config, + add_image_flags, + progress_func, + state); + dir_path[dir_path_num_chars] = L'\0'; + if (ret) + goto out_find_close; + if (child) + dentry_add_child(root, child); } while (FindNextFileW(hFind, &dat)); err = GetLastError(); if (err != ERROR_NO_MORE_FILES) { - ERROR("Win32 API: Failed to read directory \"%s\"", root_disk_path); + ERROR("Failed to read directory \"%ls\"", dir_path); win32_error(err); if (ret == 0) ret = WIMLIB_ERR_READ; @@ -361,7 +415,7 @@ static int win32_capture_reparse_point(HANDLE hFile, struct wim_inode *inode, struct wim_lookup_table *lookup_table, - const mbchar *path) + const wchar_t *path) { /* "Reparse point data, including the tag and optional GUID, * cannot exceed 16 kilobytes." - MSDN */ @@ -379,16 +433,16 @@ win32_capture_reparse_point(HANDLE hFile, NULL)) { DWORD err = GetLastError(); - ERROR("Win32 API: Failed to get reparse data of \"%s\"", path); + ERROR("Failed to get reparse data of \"%ls\"", path); win32_error(err); return WIMLIB_ERR_READ; } if (bytesReturned < 8) { - ERROR("Reparse data on \"%s\" is invalid", path); + ERROR("Reparse data on \"%ls\" is invalid", path); return WIMLIB_ERR_READ; } inode->i_reparse_tag = le32_to_cpu(*(u32*)reparse_point_buf); - return inode_add_ads_with_data(inode, "", + return inode_add_ads_with_data(inode, L"", reparse_point_buf + 8, bytesReturned - 8, lookup_table); } @@ -439,9 +493,9 @@ out_close_handle: * wim_lookup_table_entry' in memory for it, or uses an existing 'struct * wim_lookup_table_entry' for an identical stream. * - * @path_utf16: Path to the file (UTF-16LE). + * @path: Path to the file (UTF-16LE). * - * @path_utf16_nchars: Number of 2-byte characters in @path_utf16. + * @path_num_chars: Number of 2-byte characters in @path. * * @inode: WIM inode to save the stream into. * @@ -453,8 +507,8 @@ out_close_handle: * Returns 0 on success; nonzero on failure. */ static int -win32_capture_stream(const wchar_t *path_utf16, - size_t path_utf16_nchars, +win32_capture_stream(const wchar_t *path, + size_t path_num_chars, struct wim_inode *inode, struct wim_lookup_table *lookup_table, WIN32_FIND_STREAM_DATA *dat) @@ -496,7 +550,7 @@ win32_capture_stream(const wchar_t *path_utf16, if (is_named_stream) { /* Allocate an ADS entry for the named stream. */ ads_entry = inode_add_ads_utf16le(inode, stream_name, - stream_name_nchars * 2); + stream_name_nchars * sizeof(wchar_t)); if (!ads_entry) { ret = WIMLIB_ERR_NOMEM; goto out; @@ -512,15 +566,15 @@ win32_capture_stream(const wchar_t *path_utf16, * begin with an explicit "./" so that, for example, a file t:ads, where * :ads is the part we added, is not interpreted as a file on the t: * drive. */ - spath_nchars = path_utf16_nchars; + spath_nchars = path_num_chars; relpath_prefix = L""; colonchar = L""; if (is_named_stream) { spath_nchars += 1 + stream_name_nchars; colonchar = L":"; - if (path_utf16_nchars == 1 && - path_utf16[0] != cpu_to_le16('/') && - path_utf16[0] != cpu_to_le16('\\')) + if (path_num_chars == 1 && + path[0] != L'/' && + path[0] != L'\\') { spath_nchars += 2; relpath_prefix = L"./"; @@ -530,14 +584,13 @@ win32_capture_stream(const wchar_t *path_utf16, spath_buf_nbytes = (spath_nchars + 1) * sizeof(wchar_t); spath = MALLOC(spath_buf_nbytes); - swprintf(spath, spath_buf_nbytes, L"%ls%ls%ls%ls", - relpath_prefix, path_utf16, colonchar, stream_name); + swprintf(spath, L"%ls%ls%ls%ls", + relpath_prefix, path, colonchar, stream_name); ret = win32_sha1sum(spath, hash); if (ret) { err = GetLastError(); - ERROR("Win32 API: Failed to read \"%ls\" to calculate SHA1sum", - spath); + ERROR("Failed to read \"%ls\" to calculate SHA1sum", spath); win32_error(err); goto out_free_spath; } @@ -554,8 +607,8 @@ win32_capture_stream(const wchar_t *path_utf16, ret = WIMLIB_ERR_NOMEM; goto out_free_spath; } - lte->win32_file_on_disk = spath; - lte->file_on_disk_fp = INVALID_HANDLE_VALUE; + lte->file_on_disk = spath; + lte->win32_file_on_disk_fp = INVALID_HANDLE_VALUE; spath = NULL; lte->resource_location = RESOURCE_WIN32; lte->resource_entry.original_size = (uint64_t)dat->StreamSize.QuadPart; @@ -572,7 +625,7 @@ out_free_spath: out: return ret; out_invalid_stream_name: - ERROR("Invalid stream name: \"%ls:%ls\"", path_utf16, dat->cStreamName); + ERROR("Invalid stream name: \"%ls:%ls\"", path, dat->cStreamName); ret = WIMLIB_ERR_READ; goto out; } @@ -580,9 +633,9 @@ out_invalid_stream_name: /* Scans a Win32 file for unnamed and named data streams (not reparse point * streams). * - * @path_utf16: Path to the file (UTF-16LE). + * @path: Path to the file (UTF-16LE). * - * @path_utf16_nchars: Number of 2-byte characters in @path_utf16. + * @path_num_chars: Number of 2-byte characters in @path. * * @inode: WIM inode to save the stream into. * @@ -594,8 +647,8 @@ out_invalid_stream_name: * Returns 0 on success; nonzero on failure. */ static int -win32_capture_streams(const wchar_t *path_utf16, - size_t path_utf16_nchars, +win32_capture_streams(const wchar_t *path, + size_t path_num_chars, struct wim_inode *inode, struct wim_lookup_table *lookup_table, u64 file_size) @@ -608,7 +661,7 @@ win32_capture_streams(const wchar_t *path_utf16, if (win32func_FindFirstStreamW == NULL) goto unnamed_only; - hFind = win32func_FindFirstStreamW(path_utf16, FindStreamInfoStandard, &dat, 0); + hFind = win32func_FindFirstStreamW(path, FindStreamInfoStandard, &dat, 0); if (hFind == INVALID_HANDLE_VALUE) { err = GetLastError(); @@ -624,21 +677,22 @@ win32_capture_streams(const wchar_t *path_utf16, return 0; } else { if (err == ERROR_ACCESS_DENIED) { - WARNING("Failed to look up data streams of \"%ls\": " - "Access denied!\n%s", path_utf16, - access_denied_msg); + /* XXX This maybe should be an error. */ + WARNING("Failed to look up data streams " + "of \"%ls\": Access denied!\n%ls", + path, capture_access_denied_msg); return 0; } else { - ERROR("Win32 API: Failed to look up data streams of \"%ls\"", - path_utf16); + ERROR("Failed to look up data streams " + "of \"%ls\"", path); win32_error(err); return WIMLIB_ERR_READ; } } } do { - ret = win32_capture_stream(path_utf16, - path_utf16_nchars, + ret = win32_capture_stream(path, + path_num_chars, inode, lookup_table, &dat); if (ret) @@ -646,7 +700,7 @@ win32_capture_streams(const wchar_t *path_utf16, } while (win32func_FindNextStreamW(hFind, &dat)); err = GetLastError(); if (err != ERROR_HANDLE_EOF) { - ERROR("Win32 API: Error reading data streams from \"%ls\"", path_utf16); + ERROR("Win32 API: Error reading data streams from \"%ls\"", path); win32_error(err); ret = WIMLIB_ERR_READ; } @@ -654,44 +708,44 @@ out_find_close: FindClose(hFind); return ret; unnamed_only: + /* FindFirstStreamW() API is not available. Only capture the unnamed + * data stream. */ if (inode->i_attributes & (FILE_ATTRIBUTE_REPARSE_POINT | FILE_ATTRIBUTE_DIRECTORY)) { ret = 0; } else { + /* Just create our own WIN32_FIND_STREAM_DATA for an unnamed + * stream to reduce the code to a call to the + * already-implemented win32_capture_stream() */ wcscpy(dat.cStreamName, L"::$DATA"); dat.StreamSize.QuadPart = file_size; - ret = win32_capture_stream(path_utf16, - path_utf16_nchars, + ret = win32_capture_stream(path, + path_num_chars, inode, lookup_table, &dat); } return ret; } -/* Win32 version of capturing a directory tree */ -int -win32_build_dentry_tree(struct wim_dentry **root_ret, - const mbchar *root_disk_path, - struct wim_lookup_table *lookup_table, - struct wim_security_data *sd, - const struct capture_config *config, - int add_image_flags, - wimlib_progress_func_t progress_func, - void *extra_arg) +static int +win32_build_dentry_tree_recursive(struct wim_dentry **root_ret, + wchar_t *path, + size_t path_num_chars, + struct wim_lookup_table *lookup_table, + struct sd_set *sd_set, + const struct capture_config *config, + int add_image_flags, + wimlib_progress_func_t progress_func, + struct win32_capture_state *state) { struct wim_dentry *root = NULL; - int ret = 0; struct wim_inode *inode; - - wchar_t *path_utf16; - size_t path_utf16_nbytes; - size_t path_utf16_nchars; - struct sd_set *sd_set; DWORD err; u64 file_size; + int ret = 0; - if (exclude_path(root_disk_path, config, true)) { + if (exclude_path(path, config, true)) { if (add_image_flags & WIMLIB_ADD_IMAGE_FLAG_ROOT) { ERROR("Cannot exclude the root directory from capture"); ret = WIMLIB_ERR_INVALID_CAPTURE_CONFIG; @@ -701,7 +755,7 @@ win32_build_dentry_tree(struct wim_dentry **root_ret, && progress_func) { union wimlib_progress_info info; - info.scan.cur_path = root_disk_path; + info.scan.cur_path = path; info.scan.excluded = true; progress_func(WIMLIB_PROGRESS_MSG_SCAN_DENTRY, &info); } @@ -712,47 +766,34 @@ win32_build_dentry_tree(struct wim_dentry **root_ret, && progress_func) { union wimlib_progress_info info; - info.scan.cur_path = root_disk_path; + info.scan.cur_path = path; info.scan.excluded = false; progress_func(WIMLIB_PROGRESS_MSG_SCAN_DENTRY, &info); } - if (extra_arg == NULL) { - sd_set = alloca(sizeof(struct sd_set)); - sd_set->rb_root.rb_node = NULL, - sd_set->sd = sd; - } else { - sd_set = extra_arg; - } - - ret = mbs_to_utf16le(root_disk_path, strlen(root_disk_path), - &path_utf16, &path_utf16_nbytes); - if (ret) - goto out_destroy_sd_set; - path_utf16_nchars = path_utf16_nbytes / sizeof(wchar_t); - - HANDLE hFile = win32_open_existing_file(path_utf16, + HANDLE hFile = win32_open_existing_file(path, FILE_READ_DATA | FILE_READ_ATTRIBUTES); if (hFile == INVALID_HANDLE_VALUE) { err = GetLastError(); - ERROR("Win32 API: Failed to open \"%s\"", root_disk_path); + ERROR("Win32 API: Failed to open \"%ls\"", path); win32_error(err); ret = WIMLIB_ERR_OPEN; - goto out_free_path_utf16; + goto out; } BY_HANDLE_FILE_INFORMATION file_info; if (!GetFileInformationByHandle(hFile, &file_info)) { err = GetLastError(); - ERROR("Win32 API: Failed to get file information for \"%s\"", - root_disk_path); + ERROR("Win32 API: Failed to get file information for \"%ls\"", + path); win32_error(err); ret = WIMLIB_ERR_STAT; goto out_close_handle; } /* Create a WIM dentry */ - ret = new_dentry_with_timeless_inode(path_basename(root_disk_path), &root); + ret = new_dentry_with_timeless_inode(path_basename_with_len(path, path_num_chars), + &root); if (ret) goto out_close_handle; @@ -770,12 +811,13 @@ win32_build_dentry_tree(struct wim_dentry **root_ret, add_image_flags &= ~(WIMLIB_ADD_IMAGE_FLAG_ROOT | WIMLIB_ADD_IMAGE_FLAG_SOURCE); /* Get DOS name and security descriptor (if any). */ - ret = win32_get_short_name(root, path_utf16); + ret = win32_get_short_name(root, path); if (ret) goto out_close_handle; if (!(add_image_flags & WIMLIB_ADD_IMAGE_FLAG_NO_ACLS)) { - ret = win32_get_security_descriptor(root, sd_set, path_utf16); + ret = win32_get_security_descriptor(root, sd_set, path, state, + add_image_flags); if (ret) goto out_close_handle; } @@ -788,45 +830,41 @@ win32_build_dentry_tree(struct wim_dentry **root_ret, /* But first... directories may have alternate data streams that * need to be captured. */ - ret = win32_capture_streams(path_utf16, - path_utf16_nchars, + ret = win32_capture_streams(path, + path_num_chars, inode, lookup_table, file_size); if (ret) goto out_close_handle; ret = win32_recurse_directory(root, - root_disk_path, + path, + path_num_chars, lookup_table, - sd, + sd_set, config, add_image_flags, progress_func, - sd_set, - path_utf16, - path_utf16_nchars); + state); } else if (inode->i_attributes & FILE_ATTRIBUTE_REPARSE_POINT) { - /* Reparse point: save the reparse tag and data */ + /* Reparse point: save the reparse tag and data. Alternate data + * streams are not captured, if it's even possible for a reparse + * point to have alternate data streams... */ ret = win32_capture_reparse_point(hFile, inode, lookup_table, - root_disk_path); + path); } else { /* Not a directory, not a reparse point; capture the default * file contents and any alternate data streams. */ - ret = win32_capture_streams(path_utf16, - path_utf16_nchars, + ret = win32_capture_streams(path, + path_num_chars, inode, lookup_table, file_size); } out_close_handle: CloseHandle(hFile); -out_free_path_utf16: - FREE(path_utf16); -out_destroy_sd_set: - if (extra_arg == NULL) - destroy_sd_set(sd_set); out: if (ret == 0) *root_ret = root; @@ -835,14 +873,82 @@ out: return ret; } -/* Replacement for POSIX fnmatch() (partial functionality only) */ +static void +win32_do_capture_warnings(const struct win32_capture_state *state, + int add_image_flags) +{ + if (state->num_get_sacl_priv_notheld == 0 && + state->num_get_sd_access_denied == 0) + return; + + WARNING(""); + WARNING("Built dentry tree successfully, but with the following problem(s):"); + if (state->num_get_sacl_priv_notheld != 0) { + WARNING("Could not capture SACL (System Access Control List)\n" + " on %lu files or directories.", + state->num_get_sacl_priv_notheld); + } + if (state->num_get_sd_access_denied != 0) { + WARNING("Could not capture security descriptor at all\n" + " on %lu files or directories.", + state->num_get_sd_access_denied); + } + WARNING( + "Try running the program as the Administrator to make sure all the\n" +" desired metadata has been captured exactly. However, if you\n" +" do not care about capturing security descriptors correctly, then\n" +" nothing more needs to be done%ls\n", + (add_image_flags & WIMLIB_ADD_IMAGE_FLAG_NO_ACLS) ? L"." : + L", although you might consider\n" +" passing the --no-acls flag to `wimlib-imagex capture' or\n" +" `wimlib-imagex append' to explicitly capture no security\n" +" descriptors.\n"); +} + +/* Win32 version of capturing a directory tree */ int -fnmatch(const char *pattern, const char *string, int flags) +win32_build_dentry_tree(struct wim_dentry **root_ret, + const wchar_t *root_disk_path, + struct wim_lookup_table *lookup_table, + struct sd_set *sd_set, + const struct capture_config *config, + int add_image_flags, + wimlib_progress_func_t progress_func, + void *extra_arg) { - if (PathMatchSpecA(string, pattern)) - return 0; - else - return FNM_NOMATCH; + size_t path_nchars; + wchar_t *path; + int ret; + struct win32_capture_state state; + + path_nchars = wcslen(root_disk_path); + if (path_nchars > 32767) + return WIMLIB_ERR_INVALID_PARAM; + + /* There is no check for overflow later when this buffer is being used! + * But the max path length on NTFS is 32767 characters, and paths need + * to be written specially to even go past 260 characters, so we should + * be okay with 32770 characters. */ + path = MALLOC(32770 * sizeof(wchar_t)); + if (!path) + return WIMLIB_ERR_NOMEM; + + wmemcpy(path, root_disk_path, path_nchars + 1); + + memset(&state, 0, sizeof(state)); + ret = win32_build_dentry_tree_recursive(root_ret, + path, + path_nchars, + lookup_table, + sd_set, + config, + add_image_flags, + progress_func, + &state); + FREE(path); + if (ret == 0) + win32_do_capture_warnings(&state, add_image_flags); + return ret; } static int @@ -912,6 +1018,78 @@ win32_set_reparse_data(HANDLE h, return 0; } +/* + * Sets the security descriptor on an extracted file. + */ +static int +win32_set_security_data(const struct wim_inode *inode, + const wchar_t *path, + struct apply_args *args) +{ + PSECURITY_DESCRIPTOR descriptor; + unsigned long n; + DWORD err; + + descriptor = wim_const_security_data(args->w)->descriptors[inode->i_security_id]; + + SECURITY_INFORMATION securityInformation = DACL_SECURITY_INFORMATION | + SACL_SECURITY_INFORMATION | + OWNER_SECURITY_INFORMATION | + GROUP_SECURITY_INFORMATION; +again: + if (SetFileSecurityW(path, securityInformation, descriptor)) + return 0; + err = GetLastError(); + if (args->extract_flags & WIMLIB_EXTRACT_FLAG_STRICT_ACLS) + goto fail; + switch (err) { + case ERROR_PRIVILEGE_NOT_HELD: + if (securityInformation & SACL_SECURITY_INFORMATION) { + n = args->num_set_sacl_priv_notheld++; + securityInformation &= ~SACL_SECURITY_INFORMATION; + if (n < MAX_SET_SACL_PRIV_NOTHELD_WARNINGS) { + WARNING( +"We don't have enough privileges to set the full security\n" +" descriptor on \"%ls\"!\n", path); + if (args->num_set_sd_access_denied + + args->num_set_sacl_priv_notheld == 1) + { + WARNING("%ls", apply_access_denied_msg); + } + WARNING("Re-trying with SACL omitted.\n", path); + } else if (n == MAX_GET_SACL_PRIV_NOTHELD_WARNINGS) { + WARNING( +"Suppressing further 'privileges not held' error messages when setting\n" +" security descriptors."); + } + goto again; + } + /* Fall through */ + case ERROR_INVALID_OWNER: + case ERROR_ACCESS_DENIED: + n = args->num_set_sd_access_denied++; + if (n < MAX_SET_SD_ACCESS_DENIED_WARNINGS) { + WARNING("Failed to set security descriptor on \"%ls\": " + "Access denied!\n", path); + if (args->num_set_sd_access_denied + + args->num_set_sacl_priv_notheld == 1) + { + WARNING("%ls", apply_access_denied_msg); + } + } else if (n == MAX_SET_SD_ACCESS_DENIED_WARNINGS) { + WARNING( +"Suppressing further access denied error messages when setting\n" +" security descriptors"); + } + return 0; + default: +fail: + ERROR("Failed to set security descriptor on \"%ls\"", path); + win32_error(err); + return WIMLIB_ERR_WRITE; + } +} + static int win32_extract_chunk(const void *buf, size_t len, u64 offset, void *arg) @@ -939,12 +1117,28 @@ do_win32_extract_stream(HANDLE hStream, struct wim_lookup_table_entry *lte) win32_extract_chunk, hStream); } +static bool +path_is_root_of_drive(const wchar_t *path) +{ + if (!*path) + return false; + + if (*path != L'/' && *path != L'\\') { + if (*(path + 1) == L':') + path += 2; + else + return false; + } + while (*path == L'/' || *path == L'\\') + path++; + return (*path == L'\0'); +} + static int win32_extract_stream(const struct wim_inode *inode, const wchar_t *path, const wchar_t *stream_name_utf16, - struct wim_lookup_table_entry *lte, - const struct wim_security_data *security_data) + struct wim_lookup_table_entry *lte) { wchar_t *stream_path; HANDLE h; @@ -952,17 +1146,6 @@ win32_extract_stream(const struct wim_inode *inode, DWORD err; DWORD creationDisposition = CREATE_ALWAYS; - SECURITY_ATTRIBUTES *secattr; - - if (security_data && inode->i_security_id != -1) { - secattr = alloca(sizeof(*secattr)); - secattr->nLength = sizeof(*secattr); - secattr->lpSecurityDescriptor = security_data->descriptors[inode->i_security_id]; - secattr->bInheritHandle = FALSE; - } else { - secattr = NULL; - } - if (stream_name_utf16) { /* Named stream. Create a buffer that contains the UTF-16LE * string [.\]@path:@stream_name_utf16. This is needed to @@ -990,7 +1173,7 @@ win32_extract_stream(const struct wim_inode *inode, prefix = L""; } stream_path = alloca((stream_path_nchars + 1) * sizeof(wchar_t)); - swprintf(stream_path, stream_path_nchars + 1, L"%ls%ls:%ls", + swprintf(stream_path, L"%ls%ls:%ls", prefix, path, stream_name_utf16); } else { /* Unnamed stream; its path is just the path to the file itself. @@ -1001,9 +1184,16 @@ win32_extract_stream(const struct wim_inode *inode, * the call to CreateFileW() will merely open the directory that * was already created rather than creating a new file. */ if (inode->i_attributes & FILE_ATTRIBUTE_DIRECTORY) { - if (!CreateDirectoryW(stream_path, secattr)) { + if (!CreateDirectoryW(stream_path, NULL)) { err = GetLastError(); - if (err != ERROR_ALREADY_EXISTS) { + switch (err) { + case ERROR_ALREADY_EXISTS: + break; + case ERROR_ACCESS_DENIED: + if (path_is_root_of_drive(path)) + break; + /* Fall through */ + default: ERROR("Failed to create directory \"%ls\"", stream_path); win32_error(err); @@ -1024,7 +1214,7 @@ win32_extract_stream(const struct wim_inode *inode, h = CreateFileW(stream_path, GENERIC_WRITE, 0, - secattr, + NULL, creationDisposition, FILE_FLAG_OPEN_REPARSE_POINT | FILE_FLAG_BACKUP_SEMANTICS | @@ -1085,15 +1275,13 @@ out: */ static int win32_extract_streams(const struct wim_inode *inode, - const wchar_t *path, u64 *completed_bytes_p, - const struct wim_security_data *security_data) + const wchar_t *path, u64 *completed_bytes_p) { struct wim_lookup_table_entry *unnamed_lte; int ret; unnamed_lte = inode_unnamed_lte_resolved(inode); - ret = win32_extract_stream(inode, path, NULL, unnamed_lte, - security_data); + ret = win32_extract_stream(inode, path, NULL, unnamed_lte); if (ret) goto out; if (unnamed_lte) @@ -1111,8 +1299,7 @@ win32_extract_streams(const struct wim_inode *inode, ret = win32_extract_stream(inode, path, ads_entry->stream_name, - ads_entry->lte, - NULL); + ads_entry->lte); if (ret) break; if (ads_entry->lte) @@ -1125,92 +1312,72 @@ out: /* Extract a file, directory, reparse point, or hard link to an * already-extracted file using the Win32 API */ -int win32_do_apply_dentry(const mbchar *output_path, - size_t output_path_nbytes, - struct wim_dentry *dentry, - struct apply_args *args) +int +win32_do_apply_dentry(const wchar_t *output_path, + size_t output_path_num_chars, + struct wim_dentry *dentry, + struct apply_args *args) { - wchar_t *utf16le_path; - size_t utf16le_path_nbytes; - DWORD err; int ret; struct wim_inode *inode = dentry->d_inode; - - ret = mbs_to_utf16le(output_path, output_path_nbytes, - &utf16le_path, &utf16le_path_nbytes); - if (ret) - return ret; + DWORD err; if (inode->i_nlink > 1 && inode->i_extracted_file != NULL) { /* Linked file, with another name already extracted. Create a * hard link. */ DEBUG("Creating hard link \"%ls => %ls\"", - utf16le_path, inode->i_extracted_file); - if (!CreateHardLinkW(utf16le_path, inode->i_extracted_file, NULL)) - { + output_path, inode->i_extracted_file); + if (!CreateHardLinkW(output_path, inode->i_extracted_file, NULL)) { err = GetLastError(); ERROR("Can't create hard link \"%ls => %ls\"", - utf16le_path, inode->i_extracted_file); - ret = WIMLIB_ERR_LINK; + output_path, inode->i_extracted_file); win32_error(err); + return WIMLIB_ERR_LINK; } } else { /* Create the file, directory, or reparse point, and extract the * data streams. */ - const struct wim_security_data *security_data; - if (args->extract_flags & WIMLIB_EXTRACT_FLAG_NOACLS) - security_data = NULL; - else - security_data = wim_const_security_data(args->w); - - ret = win32_extract_streams(inode, utf16le_path, - &args->progress.extract.completed_bytes, - security_data); + ret = win32_extract_streams(inode, output_path, + &args->progress.extract.completed_bytes); if (ret) - goto out_free_utf16_path; + return ret; + if (inode->i_security_id >= 0 && + !(args->extract_flags & WIMLIB_EXTRACT_FLAG_NO_ACLS)) + { + ret = win32_set_security_data(inode, output_path, args); + if (ret) + return ret; + } if (inode->i_nlink > 1) { /* Save extracted path for a later call to * CreateHardLinkW() if this inode has multiple links. * */ - inode->i_extracted_file = utf16le_path; - goto out; + inode->i_extracted_file = WSTRDUP(output_path); + if (!inode->i_extracted_file) + ret = WIMLIB_ERR_NOMEM; } } -out_free_utf16_path: - FREE(utf16le_path); -out: - return ret; + return 0; } /* Set timestamps on an extracted file using the Win32 API */ int -win32_do_apply_dentry_timestamps(const mbchar *output_path, - size_t output_path_nbytes, +win32_do_apply_dentry_timestamps(const wchar_t *path, + size_t path_num_chars, const struct wim_dentry *dentry, const struct apply_args *args) { - /* Win32 */ - wchar_t *utf16le_path; - size_t utf16le_path_nbytes; DWORD err; HANDLE h; - int ret; const struct wim_inode *inode = dentry->d_inode; - ret = mbs_to_utf16le(output_path, output_path_nbytes, - &utf16le_path, &utf16le_path_nbytes); - if (ret) - return ret; - - DEBUG("Opening \"%s\" to set timestamps", output_path); - h = win32_open_existing_file(utf16le_path, FILE_WRITE_ATTRIBUTES); - - if (h == INVALID_HANDLE_VALUE) + DEBUG("Opening \"%ls\" to set timestamps", path); + h = win32_open_existing_file(path, FILE_WRITE_ATTRIBUTES); + if (h == INVALID_HANDLE_VALUE) { err = GetLastError(); - FREE(utf16le_path); - if (h == INVALID_HANDLE_VALUE) goto fail; + } FILETIME creationTime = {.dwLowDateTime = inode->i_creation_time & 0xffffffff, .dwHighDateTime = inode->i_creation_time >> 32}; @@ -1219,21 +1386,21 @@ win32_do_apply_dentry_timestamps(const mbchar *output_path, FILETIME lastWriteTime = {.dwLowDateTime = inode->i_last_write_time & 0xffffffff, .dwHighDateTime = inode->i_last_write_time >> 32}; - DEBUG("Calling SetFileTime() on \"%s\"", output_path); + DEBUG("Calling SetFileTime() on \"%ls\"", path); if (!SetFileTime(h, &creationTime, &lastAccessTime, &lastWriteTime)) { err = GetLastError(); CloseHandle(h); goto fail; } - DEBUG("Closing \"%s\"", output_path); + DEBUG("Closing \"%ls\"", path); if (!CloseHandle(h)) { err = GetLastError(); goto fail; } goto out; fail: - /* Only warn if setting timestamps failed. */ - WARNING("Can't set timestamps on \"%s\"", output_path); + /* Only warn if setting timestamps failed; still return 0. */ + WARNING("Can't set timestamps on \"%ls\"", path); win32_error(err); out: return 0; @@ -1243,16 +1410,21 @@ out: int fsync(int fd) { - HANDLE h = (HANDLE)_get_osfhandle(fd); + DWORD err; + HANDLE h; + + h = (HANDLE)_get_osfhandle(fd); if (h == INVALID_HANDLE_VALUE) { + err = GetLastError(); ERROR("Could not get Windows handle for file descriptor"); - win32_error(GetLastError()); + win32_error(err); errno = EBADF; return -1; } if (!FlushFileBuffers(h)) { + err = GetLastError(); ERROR("Could not flush file buffers to disk"); - win32_error(GetLastError()); + win32_error(err); errno = EIO; return -1; } @@ -1271,53 +1443,95 @@ win32_get_number_of_processors() /* Replacement for POSIX-2008 realpath(). Warning: partial functionality only * (resolved_path must be NULL). Also I highly doubt that GetFullPathName * really does the right thing under all circumstances. */ -mbchar * -realpath(const mbchar *path, mbchar *resolved_path) +wchar_t * +realpath(const wchar_t *path, wchar_t *resolved_path) { DWORD ret; wimlib_assert(resolved_path == NULL); + DWORD err; - ret = GetFullPathNameA(path, 0, NULL, NULL); - if (!ret) + ret = GetFullPathNameW(path, 0, NULL, NULL); + if (!ret) { + err = GetLastError(); goto fail_win32; + } - resolved_path = MALLOC(ret); + resolved_path = TMALLOC(ret); if (!resolved_path) - goto fail; - ret = GetFullPathNameA(path, ret, resolved_path, NULL); + goto out; + ret = GetFullPathNameW(path, ret, resolved_path, NULL); if (!ret) { + err = GetLastError(); free(resolved_path); + resolved_path = NULL; goto fail_win32; } - return resolved_path; + goto out; fail_win32: - win32_error(GetLastError()); -fail: - return NULL; -} - -char * -nl_langinfo(nl_item item) -{ - wimlib_assert(item == CODESET); - static char buf[64]; - strcpy(buf, "Unknown"); - return buf; + win32_error(err); + errno = -1; +out: + return resolved_path; } -/* rename() on Windows fails if the destination file exists. Fix it. */ +/* rename() on Windows fails if the destination file exists. And we need to + * make it work on wide characters. Fix it. */ int -rename_replacement(const char *oldpath, const char *newpath) +win32_rename_replacement(const wchar_t *oldpath, const wchar_t *newpath) { - if (MoveFileExA(oldpath, newpath, MOVEFILE_REPLACE_EXISTING)) { + if (MoveFileExW(oldpath, newpath, MOVEFILE_REPLACE_EXISTING)) { return 0; } else { /* As usual, the possible error values are not documented */ DWORD err = GetLastError(); - ERROR("MoveFileExA(): Can't rename \"%s\" to \"%s\"", + ERROR("MoveFileEx(): Can't rename \"%ls\" to \"%ls\"", oldpath, newpath); win32_error(err); - errno = 0; + errno = -1; return -1; } } + +/* Replacement for POSIX fnmatch() (partial functionality only) */ +int +fnmatch(const wchar_t *pattern, const wchar_t *string, int flags) +{ + if (PathMatchSpecW(string, pattern)) + return 0; + else + return FNM_NOMATCH; +} + +/* truncate() replacement */ +int +win32_truncate_replacement(const wchar_t *path, off_t size) +{ + DWORD err = NO_ERROR; + LARGE_INTEGER liOffset; + + HANDLE h = win32_open_existing_file(path, GENERIC_WRITE); + if (h == INVALID_HANDLE_VALUE) + goto fail; + + liOffset.QuadPart = size; + if (!SetFilePointerEx(h, liOffset, NULL, FILE_BEGIN)) + goto fail_close_handle; + + if (!SetEndOfFile(h)) + goto fail_close_handle; + CloseHandle(h); + return 0; + +fail_close_handle: + err = GetLastError(); + CloseHandle(h); +fail: + if (err == NO_ERROR) + err = GetLastError(); + ERROR("Can't truncate \"%ls\" to %"PRIu64" bytes", path, size); + win32_error(err); + errno = -1; + return -1; +} + +#endif /* __WIN32__ */