X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=src%2Fupdate_image.c;h=ac07b78ac8dbfe0c40eb338efafb97fb9e57f0d0;hp=b2eceecf760c72319b9fafcf916c531ed22e8101;hb=542225070ab6583b6f5915172425cac6e0326d77;hpb=3de1ec66f778edda19865482d685bc6f4e17faf7 diff --git a/src/update_image.c b/src/update_image.c index b2eceecf..ac07b78a 100644 --- a/src/update_image.c +++ b/src/update_image.c @@ -62,12 +62,9 @@ #include "wimlib/endianness.h" #include "wimlib/error.h" #include "wimlib/metadata.h" -#ifdef WITH_NTFS_3G -# include "wimlib/ntfs_3g.h" /* for do_ntfs_umount() */ -#endif #include "wimlib/paths.h" #include "wimlib/progress.h" -#include "wimlib/xml.h" +#include "wimlib/xml_windows.h" /* Saved specification of a "primitive" update operation that was performed. */ struct update_primitive { @@ -184,8 +181,8 @@ free_update_command_journal(struct update_command_journal *j) /* Free orphaned dentry trees */ while (!list_empty(&j->orphans)) { orphan = list_first_entry(&j->orphans, - struct wim_dentry, tmp_list); - list_del(&orphan->tmp_list); + struct wim_dentry, d_tmp_list); + list_del(&orphan->d_tmp_list); free_dentry_tree(orphan, j->blob_table); } @@ -269,8 +266,8 @@ rollback_link(struct wim_dentry *subject, struct wim_dentry *parent, do_unlink(subject, parent, root_p); /* @subject is now unlinked. Add it to orphans. */ - list_add(&subject->tmp_list, orphans); - subject->is_orphan = 1; + list_add(&subject->d_tmp_list, orphans); + subject->d_is_orphan = 1; } /* Undo an unlink operation. */ @@ -282,8 +279,8 @@ rollback_unlink(struct wim_dentry *subject, struct wim_dentry *parent, do_link(subject, parent, root_p); /* @subject is no longer unlinked. Delete it from orphans. */ - list_del(&subject->tmp_list); - subject->is_orphan = 0; + list_del(&subject->d_tmp_list); + subject->d_is_orphan = 0; } /* Rollback a name change operation. */ @@ -318,13 +315,13 @@ rollback_update_primitive(const struct update_primitive *prim, break; case CHANGE_FILE_NAME: rollback_name_change(prim->name.old_name, - &prim->name.subject->file_name, - &prim->name.subject->file_name_nbytes); + &prim->name.subject->d_name, + &prim->name.subject->d_name_nbytes); break; case CHANGE_SHORT_NAME: rollback_name_change(prim->name.old_name, - &prim->name.subject->short_name, - &prim->name.subject->short_name_nbytes); + &prim->name.subject->d_short_name, + &prim->name.subject->d_short_name_nbytes); break; } } @@ -365,9 +362,9 @@ journaled_link(struct update_command_journal *j, do_link(subject, parent, j->root_p); - if (subject->is_orphan) { - list_del(&subject->tmp_list); - subject->is_orphan = 0; + if (subject->d_is_orphan) { + list_del(&subject->d_tmp_list); + subject->d_is_orphan = 0; } return 0; } @@ -397,8 +394,8 @@ journaled_unlink(struct update_command_journal *j, struct wim_dentry *subject) do_unlink(subject, parent, j->root_p); - list_add(&subject->tmp_list, &j->orphans); - subject->is_orphan = 1; + list_add(&subject->d_tmp_list, &j->orphans); + subject->d_is_orphan = 1; return 0; } @@ -423,26 +420,26 @@ journaled_change_name(struct update_command_journal *j, prim.type = CHANGE_FILE_NAME; prim.name.subject = dentry; - prim.name.old_name = dentry->file_name; + prim.name.old_name = dentry->d_name; ret = record_update_primitive(j, prim); if (ret) { FREE(new_name); return ret; } - dentry->file_name = new_name; - dentry->file_name_nbytes = new_name_nbytes; + dentry->d_name = new_name; + dentry->d_name_nbytes = new_name_nbytes; /* Clear the short name. */ prim.type = CHANGE_SHORT_NAME; prim.name.subject = dentry; - prim.name.old_name = dentry->short_name; + prim.name.old_name = dentry->d_short_name; ret = record_update_primitive(j, prim); if (ret) return ret; - dentry->short_name = NULL; - dentry->short_name_nbytes = 0; + dentry->d_short_name = NULL; + dentry->d_short_name_nbytes = 0; return 0; } @@ -516,8 +513,8 @@ handle_conflict(struct wim_dentry *branch, struct wim_dentry *existing, existing_child = get_dentry_child_with_utf16le_name(existing, - new_child->file_name, - new_child->file_name_nbytes, + new_child->d_name, + new_child->d_name_nbytes, WIMLIB_CASE_PLATFORM_DEFAULT); unlink_dentry(new_child); if (existing_child) { @@ -553,7 +550,7 @@ handle_conflict(struct wim_dentry *branch, struct wim_dentry *existing, if (add_flags & WIMLIB_ADD_FLAG_VERBOSE) { union wimlib_progress_info info; - info.replace.path_in_wim = existing->_full_path; + info.replace.path_in_wim = existing->d_full_path; ret = call_progress(progfunc, WIMLIB_PROGRESS_MSG_REPLACE_FILE_IN_WIM, &info, progctx); @@ -692,7 +689,7 @@ attach_branch(struct wim_dentry *branch, const tchar *target_tstr, if (ret) goto out_free_branch; - BUILD_BUG_ON(WIM_PATH_SEPARATOR != OS_PREFERRED_PATH_SEPARATOR); + STATIC_ASSERT(WIM_PATH_SEPARATOR == OS_PREFERRED_PATH_SEPARATOR); ret = dentry_set_name(branch, path_basename(target_tstr)); if (ret) goto out_free_target; @@ -792,10 +789,6 @@ execute_add_command(struct update_command_journal *j, struct capture_params params; struct capture_config config; capture_tree_t capture_tree = platform_default_capture_tree; -#ifdef WITH_NTFS_3G - struct _ntfs_volume *ntfs_vol = NULL; -#endif - void *extra_arg = NULL; struct wim_dentry *branch; add_flags = add_cmd->add.add_flags; @@ -803,21 +796,11 @@ execute_add_command(struct update_command_journal *j, wim_target_path = add_cmd->add.wim_target_path; config_file = add_cmd->add.config_file; - DEBUG("fs_source_path=\"%"TS"\", wim_target_path=\"%"TS"\", add_flags=%#x", - fs_source_path, wim_target_path, add_flags); - memset(¶ms, 0, sizeof(params)); #ifdef WITH_NTFS_3G - if (add_flags & WIMLIB_ADD_FLAG_NTFS) { - capture_tree = build_dentry_tree_ntfs; - extra_arg = &ntfs_vol; - if (wim_get_current_image_metadata(wim)->ntfs_vol != NULL) { - ERROR("NTFS volume already set"); - ret = WIMLIB_ERR_INVALID_PARAM; - goto out; - } - } + if (add_flags & WIMLIB_ADD_FLAG_NTFS) + capture_tree = ntfs_3g_build_dentry_tree; #endif ret = get_capture_config(config_file, &config, @@ -831,7 +814,6 @@ execute_add_command(struct update_command_journal *j, params.sd_set = sd_set; params.config = &config; params.add_flags = add_flags; - params.extra_arg = extra_arg; params.progfunc = wim->progfunc; params.progctx = wim->progctx; @@ -852,7 +834,7 @@ execute_add_command(struct update_command_journal *j, ¶ms.progress, params.progctx); if (ret) { free_dentry_tree(branch, wim->blob_table); - goto out_cleanup_after_capture; + goto out_destroy_config; } if (WIMLIB_IS_WIM_ROOT_PATH(wim_target_path) && @@ -861,13 +843,13 @@ execute_add_command(struct update_command_journal *j, ERROR("\"%"TS"\" is not a directory!", fs_source_path); ret = WIMLIB_ERR_NOTDIR; free_dentry_tree(branch, wim->blob_table); - goto out_cleanup_after_capture; + goto out_destroy_config; } ret = attach_branch(branch, wim_target_path, j, add_flags, params.progfunc, params.progctx); if (ret) - goto out_cleanup_after_capture; + goto out_destroy_config; if (config_file && (add_flags & WIMLIB_ADD_FLAG_WIMBOOT) && WIMLIB_IS_WIM_ROOT_PATH(wim_target_path)) @@ -881,23 +863,22 @@ execute_add_command(struct update_command_journal *j, * /Windows/System32/WimBootCompress.ini in the WIM image. */ ret = platform_default_capture_tree(&branch, config_file, ¶ms); if (ret) - goto out_cleanup_after_capture; + goto out_destroy_config; ret = attach_branch(branch, wimboot_cfgfile, j, 0, NULL, NULL); if (ret) - goto out_cleanup_after_capture; + goto out_destroy_config; + } + + if (WIMLIB_IS_WIM_ROOT_PATH(wim_target_path) && + get_dentry(wim, T("Windows"), WIMLIB_CASE_INSENSITIVE)) + { + ret = set_windows_specific_info(wim); + if (ret) + goto out_destroy_config; } -#ifdef WITH_NTFS_3G - wim_get_current_image_metadata(wim)->ntfs_vol = ntfs_vol; -#endif ret = 0; - goto out_destroy_config; -out_cleanup_after_capture: -#ifdef WITH_NTFS_3G - if (ntfs_vol) - do_ntfs_umount(ntfs_vol); -#endif out_destroy_config: destroy_capture_config(&config); out: @@ -916,8 +897,6 @@ execute_delete_command(struct update_command_journal *j, flags = delete_cmd->delete_.delete_flags; wim_path = delete_cmd->delete_.wim_path; - DEBUG("Deleting WIM path \"%"TS"\" (flags=%#x)", wim_path, flags); - tree = get_dentry(wim, wim_path, WIMLIB_CASE_PLATFORM_DEFAULT); if (!tree) { /* Path to delete does not exist in the WIM. */ @@ -943,8 +922,8 @@ execute_delete_command(struct update_command_journal *j, static int free_dentry_full_path(struct wim_dentry *dentry, void *_ignore) { - FREE(dentry->_full_path); - dentry->_full_path = NULL; + FREE(dentry->d_full_path); + dentry->d_full_path = NULL; return 0; } @@ -1041,7 +1020,7 @@ rename_wim_path(WIMStruct *wim, const tchar *from, const tchar *to, unlink_dentry(src); dentry_add_child(parent_of_dst, src); } - if (src->_full_path) + if (src->d_full_path) for_dentry_in_tree(src, free_dentry_full_path, NULL); return 0; } @@ -1088,22 +1067,6 @@ execute_rename_command(struct update_command_journal *j, return ret; } -static inline const tchar * -update_op_to_str(int op) -{ - switch (op) { - case WIMLIB_UPDATE_OP_ADD: - return T("add"); - case WIMLIB_UPDATE_OP_DELETE: - return T("delete"); - case WIMLIB_UPDATE_OP_RENAME: - return T("rename"); - default: - wimlib_assert(0); - return NULL; - } -} - static bool have_command_type(const struct wimlib_update_command *cmds, size_t num_cmds, enum wimlib_update_op op) @@ -1162,8 +1125,6 @@ execute_update_commands(WIMStruct *wim, info.update.total_commands = num_cmds; ret = 0; for (size_t i = 0; i < num_cmds; i++) { - DEBUG("Executing update command %zu of %zu (op=%"TS")", - i + 1, num_cmds, update_op_to_str(cmds[i].op)); info.update.command = &cmds[i]; if (update_flags & WIMLIB_UPDATE_FLAG_SEND_PROGRESS) { ret = call_progress(wim->progfunc, @@ -1245,22 +1206,22 @@ check_add_command(struct wimlib_update_command *cmd, WIMLIB_ADD_FLAG_WINCONFIG | WIMLIB_ADD_FLAG_WIMBOOT | WIMLIB_ADD_FLAG_NO_REPLACE | - WIMLIB_ADD_FLAG_TEST_FILE_EXCLUSION)) + WIMLIB_ADD_FLAG_TEST_FILE_EXCLUSION | + WIMLIB_ADD_FLAG_SNAPSHOT)) return WIMLIB_ERR_INVALID_PARAM; bool is_entire_image = WIMLIB_IS_WIM_ROOT_PATH(cmd->add.wim_target_path); #ifndef WITH_NTFS_3G if (add_flags & WIMLIB_ADD_FLAG_NTFS) { - ERROR("wimlib was compiled without support for NTFS-3g, so\n" - " we cannot capture a WIM image directly " - "from an NTFS volume"); + ERROR("NTFS-3g capture mode is unsupported because wimlib " + "was compiled --without-ntfs-3g"); return WIMLIB_ERR_UNSUPPORTED; } #endif #ifdef __WIN32__ - /* Check for flags not supported on Windows */ + /* Check for flags not supported on Windows. */ if (add_flags & WIMLIB_ADD_FLAG_UNIX_DATA) { ERROR("Capturing UNIX-specific data is not supported on Windows"); return WIMLIB_ERR_UNSUPPORTED; @@ -1269,6 +1230,15 @@ check_add_command(struct wimlib_update_command *cmd, ERROR("Dereferencing symbolic links is not supported on Windows"); return WIMLIB_ERR_UNSUPPORTED; } +#else + /* Check for flags only supported on Windows. */ + + /* Currently, SNAPSHOT means Windows VSS. In the future, it perhaps + * could be implemented for other types of snapshots, such as btrfs. */ + if (add_flags & WIMLIB_ADD_FLAG_SNAPSHOT) { + ERROR("Snapshot mode is only supported on Windows (VSS)"); + return WIMLIB_ERR_UNSUPPORTED; + } #endif /* VERBOSE implies EXCLUDE_VERBOSE */ @@ -1299,12 +1269,6 @@ check_add_command(struct wimlib_update_command *cmd, } if (!is_entire_image) { - if (add_flags & WIMLIB_ADD_FLAG_NTFS) { - ERROR("Cannot add directly from an NTFS volume " - "when not capturing a full image!"); - return WIMLIB_ERR_INVALID_PARAM; - } - if (add_flags & WIMLIB_ADD_FLAG_RPFIX) { ERROR("Cannot do reparse point fixups when " "not capturing a full image!"); @@ -1450,19 +1414,23 @@ wimlib_update_image(WIMStruct *wim, int update_flags) { int ret; + struct wim_image_metadata *imd; struct wimlib_update_command *cmds_copy; if (update_flags & ~WIMLIB_UPDATE_FLAG_SEND_PROGRESS) return WIMLIB_ERR_INVALID_PARAM; - DEBUG("Updating image %d with %zu commands", image, num_cmds); - /* Load the metadata for the image to modify (if not loaded already) */ ret = select_wim_image(wim, image); if (ret) - goto out; + return ret; - DEBUG("Preparing %zu update commands", num_cmds); + imd = wim->image_metadata[image - 1]; + + /* Don't allow updating an image currently being shared by multiple + * WIMStructs (as a result of an export) */ + if (imd->refcnt > 1) + return WIMLIB_ERR_IMAGE_HAS_MULTIPLE_REFERENCES; /* Make a copy of the update commands, in the process doing certain * canonicalizations on paths (e.g. translating backslashes to forward @@ -1470,7 +1438,7 @@ wimlib_update_image(WIMStruct *wim, * commands. */ ret = copy_update_commands(cmds, num_cmds, &cmds_copy); if (ret) - goto out; + return ret; /* Perform additional checks on the update commands before we execute * them. */ @@ -1479,17 +1447,11 @@ wimlib_update_image(WIMStruct *wim, goto out_free_cmds_copy; /* Actually execute the update commands. */ - DEBUG("Executing %zu update commands", num_cmds); ret = execute_update_commands(wim, cmds_copy, num_cmds, update_flags); if (ret) goto out_free_cmds_copy; - wim->image_metadata[image - 1]->modified = 1; - - /* Statistics about the WIM image, such as the numbers of files and - * directories, may have changed. Call xml_update_image_info() to - * recalculate these statistics. */ - xml_update_image_info(wim, image); + mark_image_dirty(imd); for (size_t i = 0; i < num_cmds; i++) if (cmds_copy[i].op == WIMLIB_UPDATE_OP_ADD && @@ -1497,7 +1459,6 @@ wimlib_update_image(WIMStruct *wim, wim->hdr.flags |= WIM_HDR_FLAG_RP_FIX; out_free_cmds_copy: free_update_commands(cmds_copy, num_cmds); -out: return ret; }