X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=src%2Ftagged_items.c;h=723773f94be3e678afe6c0f88bae6a3355a961ce;hp=1ed3b4a914454b6938dd193bb31b2d400dd8eba3;hb=f9894b7e0e2a2a46fffdf7274d8671fb00f98089;hpb=0afbab754acf82c6afc4d2173055f2f4d157240b diff --git a/src/tagged_items.c b/src/tagged_items.c index 1ed3b4a9..723773f9 100644 --- a/src/tagged_items.c +++ b/src/tagged_items.c @@ -74,8 +74,14 @@ inode_get_tagged_item(const struct wim_inode *inode, u32 desired_tag, u32 min_data_len) { size_t minlen_with_hdr = sizeof(struct tagged_item_header) + min_data_len; - size_t len_remaining = inode->i_extra_size; - u8 *p = inode->i_extra; + size_t len_remaining; + u8 *p; + + if (!inode->i_extra) + return NULL; + + len_remaining = inode->i_extra->size; + p = inode->i_extra->data; /* Iterate through the tagged items. */ while (len_remaining >= minlen_with_hdr) { @@ -108,26 +114,28 @@ inode_add_tagged_item(struct wim_inode *inode, u32 tag, u32 len) { size_t itemsize; size_t newsize; - u8 *buf; + struct wim_inode_extra *extra; struct tagged_item_header *hdr; /* We prepend the item instead of appending it because it's easier. */ itemsize = sizeof(struct tagged_item_header) + ALIGN(len, 8); - newsize = itemsize + inode->i_extra_size; + newsize = itemsize; + if (inode->i_extra) + newsize += inode->i_extra->size; - buf = MALLOC(newsize); - if (!buf) + extra = MALLOC(sizeof(struct wim_inode_extra) + newsize); + if (!extra) return NULL; - - if (inode->i_extra_size) { - memcpy(buf + itemsize, inode->i_extra, inode->i_extra_size); + if (inode->i_extra) { + memcpy(&extra->data[itemsize], inode->i_extra->data, + inode->i_extra->size); FREE(inode->i_extra); } - inode->i_extra = buf; - inode->i_extra_size = newsize; + extra->size = newsize; + inode->i_extra = extra; - hdr = (struct tagged_item_header *)buf; + hdr = (struct tagged_item_header *)extra->data; hdr->tag = cpu_to_le32(tag); hdr->length = cpu_to_le32(len); return memset(hdr->data, 0, ALIGN(len, 8));