X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=src%2Fadd_image.c;h=1d826fb8c9a70a4b663c5c9f47237a6bd9708162;hp=d40dfa097487d6efb1108775d9a30847e50f6339;hb=ccdd5a74123ebf14353a9569bf014fb2e7774d1e;hpb=28d3d79a1894375e457237097bc80f0d92746018 diff --git a/src/add_image.c b/src/add_image.c index d40dfa09..1d826fb8 100644 --- a/src/add_image.c +++ b/src/add_image.c @@ -45,14 +45,14 @@ add_new_dentry_tree(WIMStruct *wim, struct wim_dentry *root_dentry, int ret; metadata_lte = new_lookup_table_entry(); - if (!metadata_lte) + if (metadata_lte == NULL) return WIMLIB_ERR_NOMEM; - metadata_lte->resource_entry.flags = WIM_RESHDR_FLAG_METADATA; + metadata_lte->flags = WIM_RESHDR_FLAG_METADATA; metadata_lte->unhashed = 1; new_imd = new_image_metadata(); - if (!new_imd) { + if (new_imd == NULL) { free_lookup_table_entry(metadata_lte); return WIMLIB_ERR_NOMEM; } @@ -68,7 +68,7 @@ add_new_dentry_tree(WIMStruct *wim, struct wim_dentry *root_dentry, return ret; } -/* Append an empty image to the WIMStruct. */ +/* API function documented in wimlib.h */ WIMLIBAPI int wimlib_add_empty_image(WIMStruct *wim, const tchar *name, int *new_idx_ret) { @@ -92,7 +92,7 @@ wimlib_add_empty_image(WIMStruct *wim, const tchar *name, int *new_idx_ret) } sd = new_wim_security_data(); - if (!sd) { + if (sd == NULL) { ret = WIMLIB_ERR_NOMEM; goto out; } @@ -139,7 +139,8 @@ capture_sources_to_add_cmds(const struct wimlib_capture_source *sources, sources[i].fs_source_path, sources[i].wim_target_path); add_cmds[i].op = WIMLIB_UPDATE_OP_ADD; - add_cmds[i].add.add_flags = add_flags; + add_cmds[i].add.add_flags = add_flags & ~(WIMLIB_ADD_FLAG_BOOT | + WIMLIB_ADD_FLAG_WIMBOOT); add_cmds[i].add.config = (struct wimlib_capture_config*)config; add_cmds[i].add.fs_source_path = sources[i].fs_source_path; add_cmds[i].add.wim_target_path = sources[i].wim_target_path; @@ -148,8 +149,7 @@ capture_sources_to_add_cmds(const struct wimlib_capture_source *sources, return add_cmds; } -/* Adds an image to the WIMStruct from multiple on-disk directory trees, or a - * NTFS volume. */ +/* API function documented in wimlib.h */ WIMLIBAPI int wimlib_add_image_multisource(WIMStruct *wim, const struct wimlib_capture_source *sources, @@ -165,6 +165,10 @@ wimlib_add_image_multisource(WIMStruct *wim, DEBUG("Adding image \"%"TS"\" from %zu sources (add_flags=%#x)", name, num_sources, add_flags); + for (size_t i = 0; i < num_sources; i++) + if (sources[i].reserved != 0) + return WIMLIB_ERR_INVALID_PARAM; + /* Add the new image (initially empty) */ ret = wimlib_add_empty_image(wim, name, NULL); if (ret) @@ -173,7 +177,7 @@ wimlib_add_image_multisource(WIMStruct *wim, /* Translate the "capture sources" into generic update commands. */ add_cmds = capture_sources_to_add_cmds(sources, num_sources, add_flags, config); - if (!add_cmds) { + if (add_cmds == NULL) { ret = WIMLIB_ERR_NOMEM; goto out_delete_image; } @@ -188,6 +192,8 @@ wimlib_add_image_multisource(WIMStruct *wim, /* Success; set boot index if requested. */ if (add_flags & WIMLIB_ADD_FLAG_BOOT) wim->hdr.boot_idx = wim->hdr.image_count; + if (add_flags & WIMLIB_ADD_FLAG_WIMBOOT) + wim_info_set_wimboot(wim->wim_info, wim->hdr.image_count, true); ret = 0; goto out; out_delete_image: @@ -200,7 +206,7 @@ out: return ret; } -/* Adds an image to the WIMStruct from an on-disk directory tree or NTFS volume. */ +/* API function documented in wimlib.h */ WIMLIBAPI int wimlib_add_image(WIMStruct *wim, const tchar *source,