X-Git-Url: https://wimlib.net/git/?p=wimlib;a=blobdiff_plain;f=programs%2Fimagex.c;h=854be037e42ac281dd25eba5685f017bee191d69;hp=42ba17fa8a7856cda80576464d094d7abbdbf9f5;hb=e9fa56fa6e181ae15282a2fcf0dbfa0b7c59cd81;hpb=a0ab870124b71d950072609cf97c3c0ef5eb4655;ds=sidebyside diff --git a/programs/imagex.c b/programs/imagex.c index 42ba17fa..854be037 100644 --- a/programs/imagex.c +++ b/programs/imagex.c @@ -22,7 +22,10 @@ * along with this program. If not, see . */ -#include "config.h" +#ifdef HAVE_CONFIG_H +# include "config.h" /* Need for PACKAGE_VERSION, etc. */ +#endif + #include "wimlib.h" #include "wimlib_tchar.h" @@ -40,7 +43,7 @@ #include #ifdef HAVE_ALLOCA_H -#include +# include #endif #ifdef __WIN32__ @@ -80,7 +83,7 @@ enum imagex_op_type { }; static void usage(int cmd_type); -static void usage_all(); +static void usage_all(void); static bool imagex_be_quiet = false; @@ -165,18 +168,13 @@ IMAGEX_PROGNAME" split WIMFILE SPLIT_WIMFILE PART_SIZE_MB [--check]\n" ), [UNMOUNT] = T( -IMAGEX_PROGNAME" unmount DIRECTORY [--commit] [--check] [--rebuild]\n" +IMAGEX_PROGNAME" unmount DIRECTORY [--commit] [--check] [--rebuild] [--lazy]\n" ), [UPDATE] = T( -IMAGEX_PROGNAME" update WIMFILE IMAGE [--check] [--rebuild]\n" -" [--threads=NUM_THREADS] [DEFAULT_ADD_OPTIONS]\n" -" [DEFAULT_DELETE_OPTIONS] [< CMDFILE]\n" -" ... where each CMD is:\n" -" add [--unix-data] [--no-acls] [--strict-acls] [--dereference]\n" -" [--verbose] FILE_OR_DIRECTORY DEST_WIM_PATH\n" -" delete [--force] [--recursive] WIM_PATH\n" -" rename SRC_PATH_IN_WIM DEST_PATH_IN_WIM\n" +IMAGEX_PROGNAME" update WIMFILE [IMAGE_NUM | IMAGE_NAME] [--check] [--rebuild]\n" +" [--threads=NUM_THREADS] [DEFAULT_ADD_OPTIONS]\n" +" [DEFAULT_DELETE_OPTIONS] < CMDFILE\n" ), }; @@ -184,14 +182,15 @@ IMAGEX_PROGNAME" update WIMFILE IMAGE [--check] [--rebuild]\n" static void recommend_man_page(const tchar *cmd_name) { + const tchar *format_str; #ifdef __WIN32__ - tprintf(T("\nSee "IMAGEX_PROGNAME"-%"TS".pdf in the " - "doc directory for more details.\n"), - cmd_name); + format_str = T("See "IMAGEX_PROGNAME"%"TS"%"TS".pdf in the " + "doc directory for more details.\n"); #else - tprintf(T("\nTry `man "IMAGEX_PROGNAME"-%"TS"' " - "for more details.\n"), cmd_name); + format_str = T("Try `man "IMAGEX_PROGNAME"%"TS"%"TS"' " + "for more details.\n"); #endif + tprintf(format_str, *cmd_name ? T("-") : T(""), cmd_name); } enum { @@ -209,6 +208,7 @@ enum { IMAGEX_FORCE_OPTION, IMAGEX_HARDLINK_OPTION, IMAGEX_HEADER_OPTION, + IMAGEX_LAZY_OPTION, IMAGEX_LOOKUP_TABLE_OPTION, IMAGEX_METADATA_OPTION, IMAGEX_NORPFIX_OPTION, @@ -336,6 +336,7 @@ static const struct option unmount_options[] = { {T("commit"), no_argument, NULL, IMAGEX_COMMIT_OPTION}, {T("check"), no_argument, NULL, IMAGEX_CHECK_OPTION}, {T("rebuild"), no_argument, NULL, IMAGEX_REBUILD_OPTION}, + {T("lazy"), no_argument, NULL, IMAGEX_LAZY_OPTION}, {NULL, 0, NULL, 0}, }; @@ -347,9 +348,16 @@ static const struct option update_options[] = { {T("threads"), required_argument, NULL, IMAGEX_THREADS_OPTION}, {T("check"), no_argument, NULL, IMAGEX_CHECK_OPTION}, {T("rebuild"), no_argument, NULL, IMAGEX_REBUILD_OPTION}, + + /* Default delete options */ {T("force"), no_argument, NULL, IMAGEX_FORCE_OPTION}, {T("recursive"), no_argument, NULL, IMAGEX_RECURSIVE_OPTION}, + + /* Global add option */ {T("config"), required_argument, NULL, IMAGEX_CONFIG_OPTION}, + + /* Default add options */ + {T("verbose"), no_argument, NULL, IMAGEX_VERBOSE_OPTION}, {T("dereference"), no_argument, NULL, IMAGEX_DEREFERENCE_OPTION}, {T("unix-data"), no_argument, NULL, IMAGEX_UNIX_DATA_OPTION}, {T("noacls"), no_argument, NULL, IMAGEX_NO_ACLS_OPTION}, @@ -1238,7 +1246,9 @@ update_command_add_option(int op, const tchar *option, bool recognized = true; switch (op) { case WIMLIB_UPDATE_OP_ADD: - if (!tstrcmp(option, T("--unix-data"))) + if (!tstrcmp(option, T("--verbose"))) + cmd->add.add_flags |= WIMLIB_ADD_IMAGE_FLAG_VERBOSE; + else if (!tstrcmp(option, T("--unix-data"))) cmd->add.add_flags |= WIMLIB_ADD_IMAGE_FLAG_UNIX_DATA; else if (!tstrcmp(option, T("--no-acls")) || !tstrcmp(option, T("--noacls"))) cmd->add.add_flags |= WIMLIB_ADD_IMAGE_FLAG_NO_ACLS; @@ -1257,7 +1267,7 @@ update_command_add_option(int op, const tchar *option, else recognized = false; break; - case WIMLIB_UPDATE_OP_RENAME: + default: recognized = false; break; } @@ -1352,8 +1362,8 @@ parse_update_command(tchar *line, size_t len, if (!update_command_add_option(op, next_string, command)) { imagex_error(T("Unrecognized option \"%"TS"\" to " - "update command on line %zu"), - next_string, line_number); + "update command \"%"TS"\" on line %zu"), + next_string, command_name, line_number); return false; } @@ -2120,18 +2130,19 @@ free_extract_commands(struct wimlib_extract_command *cmds, size_t num_cmds, } static struct wimlib_extract_command * -prepare_extract_commands(tchar **argv, int argc, int extract_flags, - tchar *dest_dir, size_t *num_cmds_ret) +prepare_extract_commands(tchar **paths, unsigned num_paths, + int extract_flags, tchar *dest_dir, + size_t *num_cmds_ret) { struct wimlib_extract_command *cmds; size_t num_cmds; tchar *emptystr = T(""); - if (argc == 0) { - argc = 1; - argv = &emptystr; + if (num_paths == 0) { + num_paths = 1; + paths = &emptystr; } - num_cmds = argc; + num_cmds = num_paths; cmds = calloc(num_cmds, sizeof(cmds[0])); if (!cmds) { imagex_error(T("Out of memory!")); @@ -2140,18 +2151,18 @@ prepare_extract_commands(tchar **argv, int argc, int extract_flags, for (size_t i = 0; i < num_cmds; i++) { cmds[i].extract_flags = extract_flags; - cmds[i].wim_source_path = argv[i]; - if (is_root_wim_path(argv[i])) { + cmds[i].wim_source_path = paths[i]; + if (is_root_wim_path(paths[i])) { cmds[i].fs_dest_path = dest_dir; } else { - size_t len = tstrlen(dest_dir) + 1 + tstrlen(argv[i]); + size_t len = tstrlen(dest_dir) + 1 + tstrlen(paths[i]); cmds[i].fs_dest_path = malloc((len + 1) * sizeof(tchar)); if (!cmds[i].fs_dest_path) { free_extract_commands(cmds, num_cmds, dest_dir); return NULL; } tsprintf(cmds[i].fs_dest_path, T("%"TS"/%"TS), dest_dir, - tbasename(argv[i])); + tbasename(paths[i])); } } *num_cmds_ret = num_cmds; @@ -2207,19 +2218,15 @@ imagex_extract(int argc, tchar **argv) imagex_be_quiet = true; break; default: - usage(EXTRACT); - ret = -1; - goto out; + goto out_usage; } } argc -= optind; argv += optind; - if (argc < 2) { - usage(EXTRACT); - ret = -1; - goto out; - } + if (argc < 2) + goto out_usage; + wimfile = argv[0]; image_num_or_name = argv[1]; @@ -2256,7 +2263,7 @@ imagex_extract(int argc, tchar **argv) win32_acquire_restore_privileges(); #endif - ret = wimlib_extract_files(wim, image, 0, cmds, num_cmds, + ret = wimlib_extract_files(wim, image, cmds, num_cmds, 0, additional_swms, num_additional_swms, imagex_progress_func); if (ret == 0) { @@ -2281,6 +2288,10 @@ out_free_cmds: free_extract_commands(cmds, num_cmds, dest_dir); out: return ret; +out_usage: + usage(EXTRACT); + ret = -1; + goto out; } /* Prints information about a WIM file; also can mark an image as bootable, @@ -2775,9 +2786,13 @@ imagex_optimize(int argc, tchar **argv) wimfile = argv[0]; + ret = file_writable(wimfile); + if (ret) + return ret; + ret = wimlib_open_wim(wimfile, open_flags, &w, imagex_progress_func); - if (ret != 0) + if (ret) return ret; old_size = file_get_size(argv[0]); @@ -2875,6 +2890,9 @@ imagex_unmount(int argc, tchar **argv) case IMAGEX_REBUILD_OPTION: unmount_flags |= WIMLIB_UNMOUNT_FLAG_REBUILD; break; + case IMAGEX_LAZY_OPTION: + unmount_flags |= WIMLIB_UNMOUNT_FLAG_LAZY; + break; default: usage(UNMOUNT); return -1; @@ -2906,7 +2924,7 @@ imagex_update(int argc, tchar **argv) WIMStruct *wim; int ret; int open_flags = 0; - int write_flags = WIMLIB_WRITE_FLAG_SOFT_DELETE; + int write_flags = 0; int update_flags = 0; int default_add_flags = WIMLIB_ADD_IMAGE_FLAG_EXCLUDE_VERBOSE; int default_delete_flags = 0; @@ -2923,6 +2941,7 @@ imagex_update(int argc, tchar **argv) for_opt(c, update_options) { switch (c) { + /* Generic or write options */ case IMAGEX_THREADS_OPTION: num_threads = parse_num_threads(optarg); if (num_threads == UINT_MAX) { @@ -2937,15 +2956,24 @@ imagex_update(int argc, tchar **argv) case IMAGEX_REBUILD_OPTION: write_flags |= WIMLIB_WRITE_FLAG_REBUILD; break; + + /* Default delete options */ case IMAGEX_FORCE_OPTION: default_delete_flags |= WIMLIB_DELETE_FLAG_FORCE; break; case IMAGEX_RECURSIVE_OPTION: default_delete_flags |= WIMLIB_DELETE_FLAG_RECURSIVE; break; + + /* Global add option */ case IMAGEX_CONFIG_OPTION: config_file = optarg; break; + + /* Default add options */ + case IMAGEX_VERBOSE_OPTION: + default_add_flags |= WIMLIB_ADD_IMAGE_FLAG_VERBOSE; + break; case IMAGEX_DEREFERENCE_OPTION: default_add_flags |= WIMLIB_ADD_IMAGE_FLAG_DEREFERENCE; break; @@ -2968,6 +2996,11 @@ imagex_update(int argc, tchar **argv) if (argc < 1 || argc > 2) goto out_usage; wimfile = argv[0]; + + ret = file_writable(wimfile); + if (ret) + goto out; + ret = wimlib_open_wim(wimfile, open_flags, &wim, imagex_progress_func); if (ret) goto out; @@ -3005,6 +3038,7 @@ imagex_update(int argc, tchar **argv) /* Read update commands from standard input */ if (isatty(STDIN_FILENO)) { tputs(T("Reading update commands from standard input...")); + recommend_man_page(T("update")); } cmd_file_contents = stdin_get_text_contents(&cmd_file_nchars); if (!cmd_file_contents) { @@ -3093,7 +3127,7 @@ static const struct imagex_command imagex_commands[] = { }; static void -version() +version(void) { static const tchar *s = T( @@ -3149,13 +3183,14 @@ usage(int cmd_type) tprintf(T("Usage:\n%"TS), usage_strings[cmd_type]); for_imagex_command(cmd) { if (cmd->cmd == cmd_type) { + tputc(T('\n'), stdout); recommend_man_page(cmd->name); } } } static void -usage_all() +usage_all(void) { tfputs(T("Usage:\n"), stdout); for (int i = 0; i < ARRAY_LEN(usage_strings); i++) @@ -3167,9 +3202,9 @@ usage_all() "\n" " The compression TYPE may be \"maximum\", \"fast\", or \"none\".\n" "\n" -" Try `man "IMAGEX_PROGNAME"' for more information.\n" ); tfputs(extra, stdout); + recommend_man_page(T("")); } /* Entry point for wimlib's ImageX implementation. On UNIX the command