xpress_decompress: allocate decode table on heap instead of stack

[wimlib] / src / xpress_decompress.c

diff --git a/src/xpress_decompress.c b/src/xpress_decompress.c
index 2951be1bc8280db3040a3bf04dc44cb38f8061d8..623ea187fef32ececc0669afdb247ca51e162726 100644 (file)
--- a/src/xpress_decompress.c
+++ b/src/xpress_decompress.c
@@ -6,7 +6,7 @@
 
 /*
  *
 
 /*
  *

- * Copyright (C) 2012, 2013 Eric Biggers
+ * Copyright (C) 2012-2016 Eric Biggers

  *
  * This file is free software; you can redistribute it and/or modify it under
  * the terms of the GNU Lesser General Public License as published by the Free
  *
  * This file is free software; you can redistribute it and/or modify it under
  * the terms of the GNU Lesser General Public License as published by the Free


@@ -70,108 +70,114 @@
 #include "wimlib/decompressor_ops.h"
 #include "wimlib/decompress_common.h"
 #include "wimlib/error.h"
 #include "wimlib/decompressor_ops.h"
 #include "wimlib/decompress_common.h"
 #include "wimlib/error.h"

+#include "wimlib/util.h"

 #include "wimlib/xpress_constants.h"
 
 /* This value is chosen for fast decompression.  */
 #include "wimlib/xpress_constants.h"
 
 /* This value is chosen for fast decompression.  */

-#define XPRESS_TABLEBITS 12
+#define XPRESS_TABLEBITS 11

 
 

-/* Decode the matches and literal bytes in a region of XPRESS-encoded data.  */
-static int
-xpress_decode_window(struct input_bitstream *istream, const u16 *decode_table,
-                    u8 *window, unsigned window_size)
-{
-       u8 *window_ptr = window;
-       u8 *window_end = &window[window_size];
-       unsigned sym;
-       unsigned match_len;
-       unsigned offset_high_bit;
-       unsigned match_offset;
-
-       while (window_ptr != window_end) {
-
-               sym = read_huffsym(istream, decode_table,
-                                  XPRESS_TABLEBITS, XPRESS_MAX_CODEWORD_LEN);
-               if (sym < XPRESS_NUM_CHARS) {
-                       /* Literal  */
-                       *window_ptr++ = sym;
-                       continue;
-               }
-
-               /* Match  */
-               match_len = sym & 0xf;
-               offset_high_bit = (sym >> 4) & 0xf;
-
-               bitstream_ensure_bits(istream, 16);
-
-               match_offset = (1 << offset_high_bit) |
-                               bitstream_pop_bits(istream, offset_high_bit);
-
-               if (match_len == 0xf) {
-                       match_len += bitstream_read_byte(istream);
-                       if (match_len == 0xf + 0xff)
-                               match_len = bitstream_read_u16(istream);
-               }
-               match_len += XPRESS_MIN_MATCH_LEN;
-
-               if (unlikely(match_offset > window_ptr - window))
-                       return -1;
-
-               if (unlikely(match_len > window_end - window_ptr))
-                       return -1;
-
-               lz_copy(window_ptr, match_len, match_offset, window_end,
-                       XPRESS_MIN_MATCH_LEN);
-
-               window_ptr += match_len;
-       }
-       return 0;
-}
+struct xpress_decompressor {
+       union {
+               DECODE_TABLE(decode_table, XPRESS_NUM_SYMBOLS,
+                            XPRESS_TABLEBITS, XPRESS_MAX_CODEWORD_LEN);
+               u8 lens[XPRESS_NUM_SYMBOLS];
+       };
+} _aligned_attribute(DECODE_TABLE_ALIGNMENT);

 
 static int
 
 static int

-xpress_decompress(const void *compressed_data, size_t compressed_size,
-                 void *uncompressed_data, size_t uncompressed_size, void *_ctx)
+xpress_decompress(const void *restrict compressed_data, size_t compressed_size,
+                 void *restrict uncompressed_data, size_t uncompressed_size,
+                 void *restrict _d)

 {
 {

-       const u8 *cdata = compressed_data;
-       u8 lens[XPRESS_NUM_SYMBOLS];
-       u8 *lens_p;
-       u16 decode_table[(1 << XPRESS_TABLEBITS) + 2 * XPRESS_NUM_SYMBOLS]
-                       _aligned_attribute(DECODE_TABLE_ALIGNMENT);
-       struct input_bitstream istream;
-
-       /* XPRESS uses only one Huffman code.  It contains 512 symbols, and the
-        * code lengths of these symbols are given literally as 4-bit integers
-        * in the first 256 bytes of the compressed data.  */
+       struct xpress_decompressor *d  = _d;
+       const u8 * const in_begin = compressed_data;
+       u8 * const out_begin = uncompressed_data;
+       u8 *out_next = out_begin;
+       u8 * const out_end = out_begin + uncompressed_size;
+       struct input_bitstream is;
+
+       /* Read the Huffman codeword lengths.  */

        if (compressed_size < XPRESS_NUM_SYMBOLS / 2)
                return -1;
        if (compressed_size < XPRESS_NUM_SYMBOLS / 2)
                return -1;

-
-       lens_p = lens;
-       for (unsigned i = 0; i < XPRESS_NUM_SYMBOLS / 2; i++) {
-               *lens_p++ = cdata[i] & 0xf;
-               *lens_p++ = cdata[i] >> 4;
+       for (int i = 0; i < XPRESS_NUM_SYMBOLS / 2; i++) {
+               d->lens[2 * i + 0] = in_begin[i] & 0xf;
+               d->lens[2 * i + 1] = in_begin[i] >> 4;

        }
 
        }
 

-       if (make_huffman_decode_table(decode_table, XPRESS_NUM_SYMBOLS,
-                                     XPRESS_TABLEBITS, lens,
+       /* Build a decoding table for the Huffman code.  */
+       if (make_huffman_decode_table(d->decode_table, XPRESS_NUM_SYMBOLS,
+                                     XPRESS_TABLEBITS, d->lens,

                                      XPRESS_MAX_CODEWORD_LEN))
                return -1;
 
                                      XPRESS_MAX_CODEWORD_LEN))
                return -1;
 

-       init_input_bitstream(&istream, cdata + XPRESS_NUM_SYMBOLS / 2,
+       /* Decode the matches and literals.  */
+
+       init_input_bitstream(&is, in_begin + XPRESS_NUM_SYMBOLS / 2,

                             compressed_size - XPRESS_NUM_SYMBOLS / 2);
 
                             compressed_size - XPRESS_NUM_SYMBOLS / 2);
 

-       return xpress_decode_window(&istream, decode_table,
-                                   uncompressed_data, uncompressed_size);
+       while (out_next != out_end) {
+               unsigned sym;
+               unsigned log2_offset;
+               u32 length;
+               u32 offset;
+
+               sym = read_huffsym(&is, d->decode_table,
+                                  XPRESS_TABLEBITS, XPRESS_MAX_CODEWORD_LEN);
+               if (sym < XPRESS_NUM_CHARS) {
+                       /* Literal  */
+                       *out_next++ = sym;
+               } else {
+                       /* Match  */
+                       length = sym & 0xf;
+                       log2_offset = (sym >> 4) & 0xf;
+
+                       bitstream_ensure_bits(&is, 16);
+
+                       offset = ((u32)1 << log2_offset) |
+                                bitstream_pop_bits(&is, log2_offset);
+
+                       if (length == 0xf) {
+                               length += bitstream_read_byte(&is);
+                               if (length == 0xf + 0xff)
+                                       length = bitstream_read_u16(&is);
+                       }
+                       length += XPRESS_MIN_MATCH_LEN;
+
+                       if (unlikely(lz_copy(length, offset,
+                                            out_begin, out_next, out_end,
+                                            XPRESS_MIN_MATCH_LEN)))
+                               return -1;
+
+                       out_next += length;
+               }
+       }
+       return 0;

 }
 
 static int
 }
 
 static int

-xpress_create_decompressor(size_t max_block_size, void **dec_ret)
+xpress_create_decompressor(size_t max_block_size, void **d_ret)

 {
 {

+       struct xpress_decompressor *d;
+

        if (max_block_size > XPRESS_MAX_OFFSET + 1)
                return WIMLIB_ERR_INVALID_PARAM;
 
        if (max_block_size > XPRESS_MAX_OFFSET + 1)
                return WIMLIB_ERR_INVALID_PARAM;
 

+       d = ALIGNED_MALLOC(sizeof(*d), DECODE_TABLE_ALIGNMENT);
+       if (!d)
+               return WIMLIB_ERR_NOMEM;
+
+       *d_ret = d;

        return 0;
 }
 
        return 0;
 }
 

+static void
+xpress_free_decompressor(void *_d)
+{
+       ALIGNED_FREE(_d);
+}
+

 const struct decompressor_ops xpress_decompressor_ops = {
        .create_decompressor = xpress_create_decompressor,
        .decompress          = xpress_decompress,
 const struct decompressor_ops xpress_decompressor_ops = {
        .create_decompressor = xpress_create_decompressor,
        .decompress          = xpress_decompress,

+       .free_decompressor   = xpress_free_decompressor,

 };
 };