]> wimlib.net Git - wimlib/blobdiff - src/write.c
Fix can_raw_copy()
[wimlib] / src / write.c
index 8554d1ab573fc23af05533c2f9f1cde750e0914e..e7107ab1d392bb0a740d304737677117e7f6a8a2 100644 (file)
@@ -74,9 +74,21 @@ static bool
 can_raw_copy(const struct wim_lookup_table_entry *lte,
             int write_resource_flags, int out_ctype, u32 out_chunk_size)
 {
-       return (out_ctype == wim_resource_compression_type(lte)
-               && out_chunk_size == wim_resource_chunk_size(lte)
-               && out_ctype != WIMLIB_COMPRESSION_TYPE_NONE);
+       if (write_resource_flags & WIMLIB_WRITE_RESOURCE_FLAG_RECOMPRESS)
+               return false;
+       if (lte->resource_location != RESOURCE_IN_WIM)
+               return false;
+       if (out_ctype == WIMLIB_COMPRESSION_TYPE_NONE)
+               return false;
+       if (lte->rspec->flags & WIM_RESHDR_FLAG_PACKED_STREAMS)
+               return false;
+       if (!(lte->rspec->flags & WIM_RESHDR_FLAG_COMPRESSED))
+               return false;
+       if (lte->rspec->wim->compression_type != out_ctype)
+               return false;
+       if (lte->rspec->wim->chunk_size != out_chunk_size)
+               return false;
+       return true;
 }
 
 
@@ -109,6 +121,11 @@ compress_chunk(const void * uncompressed_data,
                                            uncompressed_len,
                                            compressed_data,
                                            comp_ctx);
+       case WIMLIB_COMPRESSION_TYPE_LZMS:
+               /* TODO */
+               WARNING("LZMS compression not yet implemented!");
+               return 0;
+
        default:
                wimlib_assert(0);
                return 0;
@@ -150,7 +167,7 @@ begin_wim_resource_chunk_tab(const struct wim_lookup_table_entry *lte,
        struct chunk_table *chunk_tab;
        int ret;
 
-       size = wim_resource_size(lte);
+       size = lte->size;
        num_chunks = DIV_ROUND_UP(size, out_chunk_size);
        bytes_per_chunk_entry = (size > (1ULL << 32)) ? 8 : 4;
        alloc_size = sizeof(struct chunk_table) + num_chunks * sizeof(u64);
@@ -222,16 +239,14 @@ finish_wim_resource_chunk_tab(struct chunk_table *chunk_tab,
                                         chunk_tab->bytes_per_chunk_entry,
                                 chunk_tab->table_disk_size);
        } else {
-               ret  = full_pwrite(out_fd,
-                                  chunk_tab->offsets +
-                                          chunk_tab->bytes_per_chunk_entry,
-                                  chunk_tab->table_disk_size,
-                                  res_start_offset);
-       }
-       if (ret) {
-               ERROR_WITH_ERRNO("Failed to write chunk table in compressed "
-                                "file resource");
+               ret = full_pwrite(out_fd,
+                                 chunk_tab->offsets +
+                                         chunk_tab->bytes_per_chunk_entry,
+                                 chunk_tab->table_disk_size,
+                                 res_start_offset);
        }
+       if (ret)
+               ERROR_WITH_ERRNO("Write error");
        return ret;
 }
 
@@ -247,7 +262,7 @@ write_pwm_stream_header(const struct wim_lookup_table_entry *lte,
        int ret;
 
        stream_hdr.magic = PWM_STREAM_MAGIC;
-       stream_hdr.uncompressed_size = cpu_to_le64(lte->resource_entry.original_size);
+       stream_hdr.uncompressed_size = cpu_to_le64(lte->size);
        if (additional_reshdr_flags & PWM_RESHDR_FLAG_UNHASHED) {
                zero_out_hash(stream_hdr.hash);
        } else {
@@ -255,7 +270,7 @@ write_pwm_stream_header(const struct wim_lookup_table_entry *lte,
                copy_hash(stream_hdr.hash, lte->hash);
        }
 
-       reshdr_flags = lte->resource_entry.flags & ~WIM_RESHDR_FLAG_COMPRESSED;
+       reshdr_flags = lte->flags & ~(WIM_RESHDR_FLAG_COMPRESSED | WIM_RESHDR_FLAG_PACKED_STREAMS);
        reshdr_flags |= additional_reshdr_flags;
        stream_hdr.flags = cpu_to_le32(reshdr_flags);
        ret = full_write(out_fd, &stream_hdr, sizeof(stream_hdr));
@@ -317,7 +332,6 @@ write_resource_cb(const void *chunk, size_t chunk_size, void *_ctx)
        void *compressed_chunk = NULL;
        unsigned compressed_size;
        bool compressed_chunk_malloced = false;
-       size_t stack_max = 32768;
 
        if (ctx->doing_sha)
                sha1_update(&ctx->sha_ctx, chunk, chunk_size);
@@ -327,7 +341,7 @@ write_resource_cb(const void *chunk, size_t chunk_size, void *_ctx)
        if (ctx->out_ctype != WIMLIB_COMPRESSION_TYPE_NONE) {
 
                /* Compress the chunk.  */
-               if (chunk_size <= stack_max) {
+               if (chunk_size <= STACK_MAX) {
                        compressed_chunk = alloca(chunk_size);
                } else {
                        compressed_chunk = MALLOC(chunk_size);
@@ -397,7 +411,10 @@ error:
  *     One of the WIMLIB_COMPRESSION_TYPE_* constants to indicate which
  *     compression algorithm to use.
  *
- * @out_res_entry:
+ * @out_chunk_size:
+ *     Compressed chunk size to use.
+ *
+ * @out_reshdr:
  *     On success, this is filled in with the offset, flags, compressed size,
  *     and uncompressed size of the resource in the output WIM.
  *
@@ -415,19 +432,18 @@ error:
  * calculated (except when doing a raw copy --- see below).  If the @unhashed
  * flag is set on the lookup table entry, this message digest is simply copied
  * to it; otherwise, the message digest is compared with the existing one, and
- * the function will fail if they do not match.
+ * this function will fail if they do not match.
  */
-int
+static int
 write_wim_resource(struct wim_lookup_table_entry *lte,
                   struct filedes *out_fd, int out_ctype,
                   u32 out_chunk_size,
-                  struct resource_entry *out_res_entry,
+                  struct wim_reshdr *out_reshdr,
                   int resource_flags,
                   struct wimlib_lzx_context **comp_ctx)
 {
        struct write_resource_ctx write_ctx;
        off_t res_start_offset;
-       u32 in_chunk_size;
        u64 read_size;
        int ret;
 
@@ -439,49 +455,53 @@ write_wim_resource(struct wim_lookup_table_entry *lte,
        res_start_offset = out_fd->offset;
 
        /* If we are not forcing the data to be recompressed, and the input
-        * resource is located in a WIM with the same compression type as that
-        * desired other than no compression, we can simply copy the compressed
-        * data without recompressing it.  This also means we must skip
-        * calculating the SHA1, as we never will see the uncompressed data.  */
+        * resource is located in a WIM with a compression mode compatible with
+        * the output, we can simply copy the compressed data without
+        * recompressing it.  This also means we must skip calculating the SHA1,
+        * as we never will see the uncompressed data.  */
        if (can_raw_copy(lte, resource_flags, out_ctype, out_chunk_size)) {
-               /* Normally we can request a RAW_FULL read, but if we're reading
-                * from a pipable resource and writing a non-pipable resource or
-                * vice versa, then a RAW_CHUNKS read needs to be requested so
-                * that the written resource can be appropriately formatted.
-                * However, in neither case is any actual decompression needed.
-                */
-               if (lte->is_pipable == !!(resource_flags &
-                                         WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE))
+               /* Normally, for raw copies we can request a RAW_FULL read, but
+                * if we're reading from a pipable resource and writing a
+                * non-pipable resource or vice versa, then a RAW_CHUNKS read
+                * needs to be requested so that the written resource can be
+                * appropriately formatted.  However, in neither case is any
+                * actual decompression needed.  */
+               if (lte->rspec->is_pipable == !!(resource_flags &
+                                                WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE))
+               {
                        resource_flags |= WIMLIB_READ_RESOURCE_FLAG_RAW_FULL;
-               else
+                       read_size = lte->rspec->size_in_wim;
+               } else {
                        resource_flags |= WIMLIB_READ_RESOURCE_FLAG_RAW_CHUNKS;
-               read_size = lte->resource_entry.size;
+                       read_size = lte->size;
+               }
                write_ctx.doing_sha = false;
        } else {
                write_ctx.doing_sha = true;
                sha1_init(&write_ctx.sha_ctx);
-               read_size = lte->resource_entry.original_size;
+               read_size = lte->size;
        }
 
-       /* If the output resource is to be compressed, initialize the chunk
-        * table and set the function to use for chunk compression.  Exceptions:
-        * no compression function is needed if doing a raw copy; also, no chunk
-        * table is needed if doing a *full* (not per-chunk) raw copy.  */
+       /* Set the output compression mode and initialize chunk table if needed.
+        */
        write_ctx.out_ctype = WIMLIB_COMPRESSION_TYPE_NONE;
        write_ctx.out_chunk_size = out_chunk_size;
        write_ctx.chunk_tab = NULL;
        if (out_ctype != WIMLIB_COMPRESSION_TYPE_NONE) {
                wimlib_assert(out_chunk_size > 0);
                if (!(resource_flags & WIMLIB_READ_RESOURCE_FLAG_RAW)) {
+                       /* Compression needed.  */
                        write_ctx.out_ctype = out_ctype;
                        if (out_ctype == WIMLIB_COMPRESSION_TYPE_LZX) {
-                               ret = wimlib_lzx_alloc_context(NULL, comp_ctx);
+                               ret = wimlib_lzx_alloc_context(out_chunk_size,
+                                                              NULL, comp_ctx);
                                if (ret)
                                        goto out;
                        }
                        write_ctx.comp_ctx = *comp_ctx;
                }
                if (!(resource_flags & WIMLIB_READ_RESOURCE_FLAG_RAW_FULL)) {
+                       /* Chunk table needed.  */
                        ret = begin_wim_resource_chunk_tab(lte, out_fd,
                                                           out_chunk_size,
                                                           &write_ctx.chunk_tab,
@@ -504,17 +524,12 @@ write_wim_resource(struct wim_lookup_table_entry *lte,
        }
 
        /* Write the entire resource by reading the entire resource and feeding
-        * the data through the write_resource_cb function. */
+        * the data through write_resource_cb().  */
        write_ctx.out_fd = out_fd;
        write_ctx.resource_flags = resource_flags;
 try_write_again:
-       if (write_ctx.out_ctype == WIMLIB_COMPRESSION_TYPE_NONE)
-               in_chunk_size = wim_resource_chunk_size(lte);
-       else
-               in_chunk_size = out_chunk_size;
-       ret = read_resource_prefix(lte, read_size,
-                                  write_resource_cb,
-                                  in_chunk_size, &write_ctx, resource_flags);
+       ret = read_stream_prefix(lte, read_size, write_resource_cb,
+                                &write_ctx, resource_flags);
        if (ret)
                goto out_free_chunk_tab;
 
@@ -536,27 +551,27 @@ try_write_again:
                        goto out_free_chunk_tab;
        }
 
-       /* Fill in out_res_entry with information about the newly written
+       /* Fill in out_reshdr with information about the newly written
         * resource.  */
-       out_res_entry->size          = out_fd->offset - res_start_offset;
-       out_res_entry->flags         = lte->resource_entry.flags;
+       out_reshdr->size_in_wim   = out_fd->offset - res_start_offset;
+       out_reshdr->flags         = lte->flags & ~WIM_RESHDR_FLAG_PACKED_STREAMS;
        if (out_ctype == WIMLIB_COMPRESSION_TYPE_NONE)
-               out_res_entry->flags &= ~WIM_RESHDR_FLAG_COMPRESSED;
+               out_reshdr->flags &= ~WIM_RESHDR_FLAG_COMPRESSED;
        else
-               out_res_entry->flags |= WIM_RESHDR_FLAG_COMPRESSED;
-       out_res_entry->offset        = res_start_offset;
-       out_res_entry->original_size = wim_resource_size(lte);
+               out_reshdr->flags |= WIM_RESHDR_FLAG_COMPRESSED;
+       out_reshdr->offset_in_wim  = res_start_offset;
+       out_reshdr->uncompressed_size = lte->size;
 
        /* Check for resources compressed to greater than their original size
         * and write them uncompressed instead.  (But never do this if writing
         * to a pipe, and don't bother if we did a raw copy.)  */
-       if (out_res_entry->size > out_res_entry->original_size &&
+       if (out_reshdr->size_in_wim > out_reshdr->uncompressed_size &&
            !(resource_flags & (WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE |
                                WIMLIB_READ_RESOURCE_FLAG_RAW)))
        {
                DEBUG("Compressed %"PRIu64" => %"PRIu64" bytes; "
                      "writing uncompressed instead",
-                     out_res_entry->original_size, out_res_entry->size);
+                     out_reshdr->uncompressed_size, out_reshdr->size_in_wim);
                ret = seek_and_truncate(out_fd, res_start_offset);
                if (ret)
                        goto out_free_chunk_tab;
@@ -567,21 +582,21 @@ try_write_again:
                write_ctx.doing_sha = false;
                goto try_write_again;
        }
-       if (resource_flags & (WIMLIB_READ_RESOURCE_FLAG_RAW)) {
+       if (resource_flags & WIMLIB_READ_RESOURCE_FLAG_RAW) {
                DEBUG("Copied raw compressed data "
                      "(%"PRIu64" => %"PRIu64" bytes @ +%"PRIu64", flags=0x%02x)",
-                     out_res_entry->original_size, out_res_entry->size,
-                     out_res_entry->offset, out_res_entry->flags);
+                     out_reshdr->uncompressed_size, out_reshdr->size_in_wim,
+                     out_reshdr->offset_in_wim, out_reshdr->flags);
        } else if (out_ctype != WIMLIB_COMPRESSION_TYPE_NONE) {
                DEBUG("Wrote compressed resource "
                      "(%"PRIu64" => %"PRIu64" bytes @ +%"PRIu64", flags=0x%02x)",
-                     out_res_entry->original_size, out_res_entry->size,
-                     out_res_entry->offset, out_res_entry->flags);
+                     out_reshdr->uncompressed_size, out_reshdr->size_in_wim,
+                     out_reshdr->offset_in_wim, out_reshdr->flags);
        } else {
                DEBUG("Wrote uncompressed resource "
                      "(%"PRIu64" bytes @ +%"PRIu64", flags=0x%02x)",
-                     out_res_entry->original_size,
-                     out_res_entry->offset, out_res_entry->flags);
+                     out_reshdr->uncompressed_size,
+                     out_reshdr->offset_in_wim, out_reshdr->flags);
        }
        ret = 0;
 out_free_chunk_tab:
@@ -591,42 +606,50 @@ out:
 }
 
 /* Like write_wim_resource(), but the resource is specified by a buffer of
- * uncompressed data rather a lookup table entry; also writes the SHA1 hash of
- * the buffer to @hash_ret.  */
+ * uncompressed data rather a lookup table entry.  Also writes the SHA1 message
+ * digest of the buffer to @hash_ret if it is non-NULL.  */
 int
 write_wim_resource_from_buffer(const void *buf, size_t buf_size,
                               int reshdr_flags, struct filedes *out_fd,
                               int out_ctype,
                               u32 out_chunk_size,
-                              struct resource_entry *out_res_entry,
+                              struct wim_reshdr *out_reshdr,
                               u8 *hash_ret, int write_resource_flags,
                               struct wimlib_lzx_context **comp_ctx)
 {
-       /* Set up a temporary lookup table entry to provide to
-        * write_wim_resource(). */
-       struct wim_lookup_table_entry lte;
        int ret;
+       struct wim_lookup_table_entry *lte;
 
-       lte.resource_location            = RESOURCE_IN_ATTACHED_BUFFER;
-       lte.attached_buffer              = (void*)buf;
-       lte.resource_entry.original_size = buf_size;
-       lte.resource_entry.flags         = reshdr_flags;
-       lte.compression_type             = WIMLIB_COMPRESSION_TYPE_NONE;
+       /* Set up a temporary lookup table entry to provide to
+        * write_wim_resource().  */
+
+       lte = new_lookup_table_entry();
+       if (lte == NULL)
+               return WIMLIB_ERR_NOMEM;
+
+       lte->resource_location  = RESOURCE_IN_ATTACHED_BUFFER;
+       lte->attached_buffer    = (void*)buf;
+       lte->size               = buf_size;
+       lte->flags              = reshdr_flags;
 
        if (write_resource_flags & WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE) {
-               sha1_buffer(buf, buf_size, lte.hash);
-               lte.unhashed = 0;
+               sha1_buffer(buf, buf_size, lte->hash);
+               lte->unhashed = 0;
        } else {
-               lte.unhashed = 1;
+               lte->unhashed = 1;
        }
 
-       ret = write_wim_resource(&lte, out_fd, out_ctype, out_chunk_size,
-                                out_res_entry, write_resource_flags, comp_ctx);
+       ret = write_wim_resource(lte, out_fd, out_ctype, out_chunk_size,
+                                out_reshdr, write_resource_flags, comp_ctx);
        if (ret)
-               return ret;
+               goto out_free_lte;
        if (hash_ret)
-               copy_hash(hash_ret, lte.hash);
-       return 0;
+               copy_hash(hash_ret, lte->hash);
+       ret = 0;
+out_free_lte:
+       lte->resource_location = RESOURCE_NONEXISTENT;
+       free_lookup_table_entry(lte);
+       return ret;
 }
 
 
@@ -809,24 +832,24 @@ do_write_streams_progress(struct write_streams_progress_data *progress_data,
        bool new_wim_part;
 
        if (stream_discarded) {
-               progress->write_streams.total_bytes -= wim_resource_size(lte);
+               progress->write_streams.total_bytes -= lte->size;
                if (progress_data->next_progress != ~(uint64_t)0 &&
                    progress_data->next_progress > progress->write_streams.total_bytes)
                {
                        progress_data->next_progress = progress->write_streams.total_bytes;
                }
        } else {
-               progress->write_streams.completed_bytes += wim_resource_size(lte);
+               progress->write_streams.completed_bytes += lte->size;
        }
        new_wim_part = false;
        if (lte->resource_location == RESOURCE_IN_WIM &&
-           lte->wim != progress_data->prev_wim_part)
+           lte->rspec->wim != progress_data->prev_wim_part)
        {
                if (progress_data->prev_wim_part) {
                        new_wim_part = true;
                        progress->write_streams.completed_parts++;
                }
-               progress_data->prev_wim_part = lte->wim;
+               progress_data->prev_wim_part = lte->rspec->wim;
        }
        progress->write_streams.completed_streams++;
        if (progress_data->progress_func
@@ -861,7 +884,7 @@ serial_write_stream(struct wim_lookup_table_entry *lte, void *_ctx)
        return write_wim_resource(lte, ctx->out_fd,
                                  ctx->out_ctype,
                                  ctx->out_chunk_size,
-                                 &lte->output_resource_entry,
+                                 &lte->out_reshdr,
                                  ctx->write_resource_flags,
                                  ctx->comp_ctx);
 }
@@ -917,7 +940,7 @@ do_write_stream_list(struct list_head *stream_list,
                                    lte->filtered) {
                                        DEBUG("Discarding duplicate stream of "
                                              "length %"PRIu64,
-                                             wim_resource_size(lte));
+                                             lte->size);
                                        lte->no_progress = 0;
                                        stream_discarded = true;
                                        goto skip_to_progress;
@@ -939,7 +962,7 @@ do_write_stream_list(struct list_head *stream_list,
                if (ret)
                        break;
                /* In parallel mode, some streams are deferred for later,
-                * serialized processing; ignore them here. */
+                * serialized processing; ignore them here.  */
                if (lte->deferred)
                        continue;
                if (lte->unhashed) {
@@ -1055,7 +1078,7 @@ write_wim_chunks(struct message *msg, struct filedes *out_fd,
        }
        ret = full_writev(out_fd, vecs, nvecs);
        if (ret)
-               ERROR_WITH_ERRNO("Failed to write WIM chunks");
+               ERROR_WITH_ERRNO("Write error");
        return ret;
 }
 
@@ -1127,7 +1150,7 @@ allocate_messages(size_t num_messages, u32 out_chunk_size)
        struct message *msgs;
 
        msgs = CALLOC(num_messages, sizeof(struct message));
-       if (!msgs)
+       if (msgs == NULL)
                return NULL;
        for (size_t i = 0; i < num_messages; i++) {
                if (init_message(&msgs[i], out_chunk_size)) {
@@ -1153,7 +1176,7 @@ main_writer_thread_init_ctx(struct main_writer_thread_ctx *ctx)
        /* Pre-allocate all the buffers that will be needed to do the chunk
         * compression. */
        ctx->msgs = allocate_messages(ctx->num_messages, ctx->out_chunk_size);
-       if (!ctx->msgs)
+       if (ctx->msgs == NULL)
                return WIMLIB_ERR_NOMEM;
 
        /* Initially, all the messages are available to use. */
@@ -1173,12 +1196,14 @@ main_writer_thread_init_ctx(struct main_writer_thread_ctx *ctx)
        INIT_LIST_HEAD(&ctx->outstanding_streams);
        ctx->num_outstanding_messages = 0;
 
+       /* Message currently being prepared.  */
        ctx->next_msg = NULL;
 
        /* Resources that don't need any chunks compressed are added to this
-        * list and written directly by the main thread. */
+        * list and written directly by the main thread.  */
        INIT_LIST_HEAD(&ctx->serial_streams);
 
+       /* Pointer to chunk table for stream currently being written.  */
        ctx->cur_chunk_tab = NULL;
 
        return 0;
@@ -1200,17 +1225,17 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
 
        /* Get the next message from the queue and process it.
         * The message will contain 1 or more data chunks that have been
-        * compressed. */
+        * compressed.  */
        msg = shared_queue_get(ctx->compressed_res_queue);
        msg->complete = true;
        --ctx->num_outstanding_messages;
 
-       /* Is this the next chunk in the current resource?  If it's not
-        * (i.e., an earlier chunk in a same or different resource
-        * hasn't been compressed yet), do nothing, and keep this
-        * message around until all earlier chunks are received.
+       /* Is this the next chunk in the current resource?  If it's not (i.e.,
+        * an earlier chunk in a same or different resource hasn't been
+        * compressed yet), do nothing, and keep this message around until all
+        * earlier chunks are received.
         *
-        * Otherwise, write all the chunks we can. */
+        * Otherwise, write all the chunks we can.  */
        while (cur_lte != NULL &&
               !list_empty(&cur_lte->msg_list)
               && (msg = container_of(cur_lte->msg_list.next,
@@ -1243,17 +1268,16 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
                                                           ctx->write_resource_flags);
                        if (ret)
                                return ret;
-
                }
 
-               /* Write the compressed chunks from the message. */
+               /* Write the compressed chunks from the message.  */
                ret = write_wim_chunks(msg, ctx->out_fd, ctx->cur_chunk_tab,
                                       ctx->write_resource_flags);
                if (ret)
                        return ret;
 
-               /* Was this the last chunk of the stream?  If so, finish
-                * it. */
+               /* Was this the last chunk of the stream?  If so, finish the
+                * stream by writing the chunk table.  */
                if (list_empty(&cur_lte->msg_list) &&
                    msg->begin_chunk + msg->num_chunks == ctx->cur_chunk_tab->num_chunks)
                {
@@ -1277,12 +1301,12 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
                         * equal to their original size and write them
                         * uncompressed instead.  (But never do this if writing
                         * to a pipe.)  */
-                       if (res_csize >= wim_resource_size(cur_lte) &&
+                       if (res_csize >= cur_lte->size &&
                            !(ctx->write_resource_flags & WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE))
                        {
                                DEBUG("Compressed %"PRIu64" => %"PRIu64" bytes; "
                                      "writing uncompressed instead",
-                                     wim_resource_size(cur_lte), res_csize);
+                                     cur_lte->size, res_csize);
                                ret = seek_and_truncate(ctx->out_fd, ctx->res_start_offset);
                                if (ret)
                                        return ret;
@@ -1290,31 +1314,31 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
                                                         ctx->out_fd,
                                                         WIMLIB_COMPRESSION_TYPE_NONE,
                                                         0,
-                                                        &cur_lte->output_resource_entry,
+                                                        &cur_lte->out_reshdr,
                                                         ctx->write_resource_flags,
                                                         ctx->comp_ctx);
                                if (ret)
                                        return ret;
                        } else {
-                               cur_lte->output_resource_entry.size =
+                               cur_lte->out_reshdr.size_in_wim =
                                        res_csize;
 
-                               cur_lte->output_resource_entry.original_size =
-                                       cur_lte->resource_entry.original_size;
+                               cur_lte->out_reshdr.uncompressed_size =
+                                       cur_lte->size;
 
-                               cur_lte->output_resource_entry.offset =
+                               cur_lte->out_reshdr.offset_in_wim =
                                        ctx->res_start_offset;
 
-                               cur_lte->output_resource_entry.flags =
-                                       cur_lte->resource_entry.flags |
+                               cur_lte->out_reshdr.flags =
+                                       cur_lte->flags |
                                                WIM_RESHDR_FLAG_COMPRESSED;
 
                                DEBUG("Wrote compressed resource "
                                      "(%"PRIu64" => %"PRIu64" bytes @ +%"PRIu64", flags=0x%02x)",
-                                     cur_lte->output_resource_entry.original_size,
-                                     cur_lte->output_resource_entry.size,
-                                     cur_lte->output_resource_entry.offset,
-                                     cur_lte->output_resource_entry.flags);
+                                     cur_lte->out_reshdr.uncompressed_size,
+                                     cur_lte->out_reshdr.size_in_wim,
+                                     cur_lte->out_reshdr.offset_in_wim,
+                                     cur_lte->out_reshdr.flags);
                        }
 
                        do_write_streams_progress(ctx->progress_data,
@@ -1325,7 +1349,7 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
                         * list for direct writing by the main thread (e.g.
                         * resources that don't need to be compressed because
                         * the desired compression type is the same as the
-                        * previous compression type). */
+                        * previous compression type).  */
                        if (!list_empty(&ctx->serial_streams)) {
                                ret = do_write_stream_list_serial(&ctx->serial_streams,
                                                                  ctx->lookup_table,
@@ -1339,7 +1363,7 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
                                        return ret;
                        }
 
-                       /* Advance to the next stream to write. */
+                       /* Advance to the next stream to write.  */
                        if (list_empty(&ctx->outstanding_streams)) {
                                cur_lte = NULL;
                        } else {
@@ -1352,7 +1376,7 @@ receive_compressed_chunks(struct main_writer_thread_ctx *ctx)
        return 0;
 }
 
-/* Called when the main thread has read a new chunk of data. */
+/* Called when the main thread has read a new chunk of data.  */
 static int
 main_writer_thread_cb(const void *chunk, size_t chunk_size, void *_ctx)
 {
@@ -1446,17 +1470,14 @@ submit_stream_for_compression(struct wim_lookup_table_entry *lte,
        /* Read the entire stream @lte, feeding its data chunks to the
         * compressor threads.  Also SHA1-sum the stream; this is required in
         * the case that @lte is unhashed, and a nice additional verification
-        * when @lte is already hashed. */
+        * when @lte is already hashed.  */
        sha1_init(&ctx->next_sha_ctx);
        ctx->next_chunk = 0;
-       ctx->next_num_chunks = DIV_ROUND_UP(wim_resource_size(lte),
-                                           ctx->out_chunk_size);
+       ctx->next_num_chunks = DIV_ROUND_UP(lte->size, ctx->out_chunk_size);
        ctx->next_lte = lte;
        INIT_LIST_HEAD(&lte->msg_list);
        list_add_tail(&lte->being_compressed_list, &ctx->outstanding_streams);
-       ret = read_resource_prefix(lte, wim_resource_size(lte),
-                                  main_writer_thread_cb,
-                                  ctx->out_chunk_size, ctx, 0);
+       ret = read_stream_prefix(lte, lte->size, main_writer_thread_cb, ctx, 0);
        if (ret)
                return ret;
        wimlib_assert(ctx->next_chunk == ctx->next_num_chunks);
@@ -1469,14 +1490,14 @@ main_thread_process_next_stream(struct wim_lookup_table_entry *lte, void *_ctx)
        struct main_writer_thread_ctx *ctx = _ctx;
        int ret;
 
-       if (wim_resource_size(lte) < 1000 ||
+       if (lte->size < 1000 ||
            !must_compress_stream(lte, ctx->write_resource_flags,
                                  ctx->out_ctype, ctx->out_chunk_size))
        {
                /* Stream is too small or isn't being compressed.  Process it by
                 * the main thread when we have a chance.  We can't necessarily
                 * process it right here, as the main thread could be in the
-                * middle of writing a different stream. */
+                * middle of writing a different stream.  */
                list_add_tail(&lte->write_streams_list, &ctx->serial_streams);
                lte->deferred = 1;
                ret = 0;
@@ -1521,8 +1542,7 @@ get_default_num_threads(void)
  * At any given point in time, multiple streams may be having chunks compressed
  * concurrently.  The stream that the main thread is currently *reading* may be
  * later in the list that the stream that the main thread is currently
- * *writing*.
- */
+ * *writing*.  */
 static int
 write_stream_list_parallel(struct list_head *stream_list,
                           struct wim_lookup_table *lookup_table,
@@ -1539,12 +1559,14 @@ write_stream_list_parallel(struct list_head *stream_list,
        struct shared_queue compressed_res_queue;
        pthread_t *compressor_threads = NULL;
        union wimlib_progress_info *progress = &progress_data->progress;
+       unsigned num_started_threads;
+       bool can_retry = true;
 
        if (num_threads == 0) {
                long nthreads = get_default_num_threads();
                if (nthreads < 1 || nthreads > UINT_MAX) {
                        WARNING("Could not determine number of processors! Assuming 1");
-                       goto out_serial;
+                       goto out_serial_quiet;
                } else if (nthreads == 1) {
                        goto out_serial_quiet;
                } else {
@@ -1584,14 +1606,15 @@ write_stream_list_parallel(struct list_head *stream_list,
                params[i].compressed_res_queue = &compressed_res_queue;
                params[i].out_ctype = out_ctype;
                if (out_ctype == WIMLIB_COMPRESSION_TYPE_LZX) {
-                       ret = wimlib_lzx_alloc_context(NULL, &params[i].comp_ctx);
+                       ret = wimlib_lzx_alloc_context(out_chunk_size,
+                                                      NULL, &params[i].comp_ctx);
                        if (ret)
                                goto out_free_params;
                }
        }
 
        compressor_threads = MALLOC(num_threads * sizeof(pthread_t));
-       if (!compressor_threads) {
+       if (compressor_threads == NULL) {
                ret = WIMLIB_ERR_NOMEM;
                goto out_free_params;
        }
@@ -1600,15 +1623,17 @@ write_stream_list_parallel(struct list_head *stream_list,
                DEBUG("pthread_create thread %u of %u", i + 1, num_threads);
                ret = pthread_create(&compressor_threads[i], NULL,
                                     compressor_thread_proc, &params[i]);
-               if (ret != 0) {
+               if (ret) {
+                       errno = ret;
                        ret = -1;
                        ERROR_WITH_ERRNO("Failed to create compressor "
                                         "thread %u of %u",
                                         i + 1, num_threads);
-                       num_threads = i;
+                       num_started_threads = i;
                        goto out_join;
                }
        }
+       num_started_threads = num_threads;
 
        if (progress_data->progress_func) {
                progress_data->progress_func(WIMLIB_PROGRESS_MSG_WRITE_STREAMS,
@@ -1616,6 +1641,9 @@ write_stream_list_parallel(struct list_head *stream_list,
        }
 
        struct main_writer_thread_ctx ctx;
+
+       memset(&ctx, 0, sizeof(ctx));
+
        ctx.stream_list           = stream_list;
        ctx.lookup_table          = lookup_table;
        ctx.out_fd                = out_fd;
@@ -1630,6 +1658,8 @@ write_stream_list_parallel(struct list_head *stream_list,
        ret = main_writer_thread_init_ctx(&ctx);
        if (ret)
                goto out_join;
+
+       can_retry = false;
        ret = do_write_stream_list(stream_list, lookup_table,
                                   main_thread_process_next_stream,
                                   &ctx, progress_data);
@@ -1641,15 +1671,15 @@ write_stream_list_parallel(struct list_head *stream_list,
         * chunks to be compressed so that the remaining streams can actually be
         * written to the output file.  Furthermore, any remaining streams that
         * had processing deferred to the main thread need to be handled.  These
-        * tasks are done by the main_writer_thread_finish() function. */
+        * tasks are done by the main_writer_thread_finish() function.  */
        ret = main_writer_thread_finish(&ctx);
 out_destroy_ctx:
        main_writer_thread_destroy_ctx(&ctx);
 out_join:
-       for (unsigned i = 0; i < num_threads; i++)
+       for (unsigned i = 0; i < num_started_threads; i++)
                shared_queue_put(&res_to_compress_queue, NULL);
 
-       for (unsigned i = 0; i < num_threads; i++) {
+       for (unsigned i = 0; i < num_started_threads; i++) {
                if (pthread_join(compressor_threads[i], NULL)) {
                        WARNING_WITH_ERRNO("Failed to join compressor "
                                           "thread %u of %u",
@@ -1665,7 +1695,7 @@ out_destroy_compressed_res_queue:
        shared_queue_destroy(&compressed_res_queue);
 out_destroy_res_to_compress_queue:
        shared_queue_destroy(&res_to_compress_queue);
-       if (ret >= 0 && ret != WIMLIB_ERR_NOMEM)
+       if (!can_retry || (ret >= 0 && ret != WIMLIB_ERR_NOMEM))
                return ret;
 out_serial:
        WARNING("Falling back to single-threaded compression");
@@ -1682,10 +1712,9 @@ out_serial_quiet:
 }
 #endif
 
-/*
- * Write a list of streams to a WIM (@out_fd) using the compression type
- * @out_ctype and up to @num_threads compressor threads.
- */
+/* Write a list of streams to a WIM (@out_fd) using the compression type
+ * @out_ctype, chunk size @out_chunk_size, and up to @num_threads compressor
+ * threads.  */
 static int
 write_stream_list(struct list_head *stream_list,
                  struct wim_lookup_table *lookup_table,
@@ -1695,15 +1724,15 @@ write_stream_list(struct list_head *stream_list,
                  int write_flags,
                  unsigned num_threads, wimlib_progress_func_t progress_func)
 {
-       struct wim_lookup_table_entry *lte;
-       size_t num_streams = 0;
-       u64 total_bytes = 0;
-       u64 total_compression_bytes = 0;
-       struct write_streams_progress_data progress_data;
        int ret;
        int write_resource_flags;
-       unsigned total_parts = 0;
-       WIMStruct *prev_wim_part = NULL;
+       u64 total_bytes;
+       u64 total_compression_bytes;
+       unsigned total_parts;
+       WIMStruct *prev_wim_part;
+       size_t num_streams;
+       struct wim_lookup_table_entry *lte;
+       struct write_streams_progress_data progress_data;
 
        if (list_empty(stream_list)) {
                DEBUG("No streams to write.");
@@ -1715,23 +1744,31 @@ write_stream_list(struct list_head *stream_list,
        DEBUG("Writing stream list (offset = %"PRIu64", write_resource_flags=0x%08x)",
              out_fd->offset, write_resource_flags);
 
-       sort_stream_list_by_sequential_order(stream_list,
-                                            offsetof(struct wim_lookup_table_entry,
-                                                     write_streams_list));
+       /* Sort the stream list into a good order for reading.  */
+       ret = sort_stream_list_by_sequential_order(stream_list,
+                                                  offsetof(struct wim_lookup_table_entry,
+                                                           write_streams_list));
+       if (ret)
+               return ret;
 
        /* Calculate the total size of the streams to be written.  Note: this
         * will be the uncompressed size, as we may not know the compressed size
         * yet, and also this will assume that every unhashed stream will be
-        * written (which will not necessarily be the case). */
+        * written (which will not necessarily be the case).  */
+       total_bytes = 0;
+       total_compression_bytes = 0;
+       num_streams = 0;
+       total_parts = 0;
+       prev_wim_part = NULL;
        list_for_each_entry(lte, stream_list, write_streams_list) {
                num_streams++;
-               total_bytes += wim_resource_size(lte);
+               total_bytes += lte->size;
                if (must_compress_stream(lte, write_resource_flags,
                                         out_ctype, out_chunk_size))
-                       total_compression_bytes += wim_resource_size(lte);
+                       total_compression_bytes += lte->size;
                if (lte->resource_location == RESOURCE_IN_WIM) {
-                       if (prev_wim_part != lte->wim) {
-                               prev_wim_part = lte->wim;
+                       if (prev_wim_part != lte->rspec->wim) {
+                               prev_wim_part = lte->rspec->wim;
                                total_parts++;
                        }
                }
@@ -1776,7 +1813,7 @@ write_stream_list(struct list_head *stream_list,
        if (ret == 0)
                DEBUG("Successfully wrote stream list.");
        else
-               DEBUG("Failed to write stream list.");
+               DEBUG("Failed to write stream list (ret=%d).", ret);
        return ret;
 }
 
@@ -1811,10 +1848,10 @@ stream_size_table_insert(struct wim_lookup_table_entry *lte, void *_tab)
        struct wim_lookup_table_entry *same_size_lte;
        struct hlist_node *tmp;
 
-       pos = hash_u64(wim_resource_size(lte)) % tab->capacity;
+       pos = hash_u64(lte->size) % tab->capacity;
        lte->unique_size = 1;
        hlist_for_each_entry(same_size_lte, tmp, &tab->array[pos], hash_list_2) {
-               if (wim_resource_size(same_size_lte) == wim_resource_size(lte)) {
+               if (same_size_lte->size == lte->size) {
                        lte->unique_size = 0;
                        same_size_lte->unique_size = 0;
                        break;
@@ -1920,7 +1957,6 @@ prepare_logical_stream_list(WIMStruct *wim, int image, bool streams_ok,
                            struct find_streams_ctx *ctx)
 {
        int ret;
-       struct wim_lookup_table_entry *lte;
 
        if (streams_ok && (image == WIMLIB_ALL_IMAGES ||
                           (image == 1 && wim->hdr.image_count == 1)))
@@ -1948,8 +1984,6 @@ prepare_logical_stream_list(WIMStruct *wim, int image, bool streams_ok,
                        return ret;
        }
 
-       list_for_each_entry(lte, &ctx->stream_list, write_streams_list)
-               lte->part_number = wim->hdr.part_number;
        return 0;
 }
 
@@ -1961,10 +1995,10 @@ process_filtered_stream(struct wim_lookup_table_entry *lte, void *_ctx)
 
        /* Calculate and set lte->filtered.  */
        if (lte->resource_location == RESOURCE_IN_WIM) {
-               if (lte->wim == ctx->wim &&
+               if (lte->rspec->wim == ctx->wim &&
                    (ctx->write_flags & WIMLIB_WRITE_FLAG_OVERWRITE))
                        filtered |= FILTERED_SAME_WIM;
-               if (lte->wim != ctx->wim &&
+               if (lte->rspec->wim != ctx->wim &&
                    (ctx->write_flags & WIMLIB_WRITE_FLAG_SKIP_EXTERNAL_WIMS))
                        filtered |= FILTERED_EXTERNAL_WIM;
        }
@@ -2083,10 +2117,8 @@ write_wim_streams(WIMStruct *wim, int image, int write_flags,
                 * use stream list already explicitly provided.  Use existing
                 * reference counts.  */
                stream_list = stream_list_override;
-               list_for_each_entry(lte, stream_list, write_streams_list) {
+               list_for_each_entry(lte, stream_list, write_streams_list)
                        lte->out_refcnt = (lte->refcnt ? lte->refcnt : 1);
-                       lte->part_number = wim->hdr.part_number;
-               }
        }
 
        return write_stream_list(stream_list,
@@ -2145,8 +2177,8 @@ write_wim_metadata_resources(WIMStruct *wim, int image, int write_flags,
                } else if (write_flags & WIMLIB_WRITE_FLAG_OVERWRITE) {
                        DEBUG("Image %u was not modified; re-using existing "
                              "metadata resource.", i);
-                       copy_resource_entry(&imd->metadata_lte->output_resource_entry,
-                                           &imd->metadata_lte->resource_entry);
+                       wim_res_spec_to_hdr(imd->metadata_lte->rspec,
+                                           &imd->metadata_lte->out_reshdr);
                        ret = 0;
                } else {
                        DEBUG("Image %u was not modified; copying existing "
@@ -2155,7 +2187,7 @@ write_wim_metadata_resources(WIMStruct *wim, int image, int write_flags,
                                                 &wim->out_fd,
                                                 wim->out_compression_type,
                                                 wim->out_chunk_size,
-                                                &imd->metadata_lte->output_resource_entry,
+                                                &imd->metadata_lte->out_reshdr,
                                                 write_resource_flags,
                                                 &wim->lzx_context);
                }
@@ -2265,19 +2297,19 @@ finish_write(WIMStruct *wim, int image, int write_flags,
         * it should be a copy of the resource entry for the image that is
         * marked as bootable.  This is not well documented...  */
        if (wim->hdr.boot_idx == 0) {
-               zero_resource_entry(&wim->hdr.boot_metadata_res_entry);
+               zero_reshdr(&wim->hdr.boot_metadata_reshdr);
        } else {
-               copy_resource_entry(&wim->hdr.boot_metadata_res_entry,
+               copy_reshdr(&wim->hdr.boot_metadata_reshdr,
                            &wim->image_metadata[wim->hdr.boot_idx- 1
-                                       ]->metadata_lte->output_resource_entry);
+                                       ]->metadata_lte->out_reshdr);
        }
 
        /* Write lookup table.  (Save old position first.)  */
-       old_lookup_table_end = wim->hdr.lookup_table_res_entry.offset +
-                              wim->hdr.lookup_table_res_entry.size;
+       old_lookup_table_end = wim->hdr.lookup_table_reshdr.offset_in_wim +
+                              wim->hdr.lookup_table_reshdr.size_in_wim;
        if (!(write_flags & WIMLIB_WRITE_FLAG_NO_LOOKUP_TABLE)) {
                ret = write_wim_lookup_table(wim, image, write_flags,
-                                            &wim->hdr.lookup_table_res_entry,
+                                            &wim->hdr.lookup_table_reshdr,
                                             stream_list_override);
                if (ret)
                        return ret;
@@ -2288,7 +2320,7 @@ finish_write(WIMStruct *wim, int image, int write_flags,
        if (write_flags & WIMLIB_WRITE_FLAG_USE_EXISTING_TOTALBYTES)
                xml_totalbytes = WIM_TOTALBYTES_USE_EXISTING;
        ret = write_wim_xml_data(wim, image, xml_totalbytes,
-                                &wim->hdr.xml_res_entry,
+                                &wim->hdr.xml_data_reshdr,
                                 write_resource_flags);
        if (ret)
                return ret;
@@ -2298,7 +2330,7 @@ finish_write(WIMStruct *wim, int image, int write_flags,
                if (write_flags & WIMLIB_WRITE_FLAG_CHECKPOINT_AFTER_XML) {
                        struct wim_header checkpoint_hdr;
                        memcpy(&checkpoint_hdr, &wim->hdr, sizeof(struct wim_header));
-                       zero_resource_entry(&checkpoint_hdr.integrity);
+                       zero_reshdr(&checkpoint_hdr.integrity_table_reshdr);
                        checkpoint_hdr.flags |= WIM_HDR_FLAG_WRITE_IN_PROGRESS;
                        ret = write_wim_header_at_offset(&checkpoint_hdr,
                                                         &wim->out_fd, 0);
@@ -2309,8 +2341,8 @@ finish_write(WIMStruct *wim, int image, int write_flags,
                if (!(write_flags & WIMLIB_WRITE_FLAG_REUSE_INTEGRITY_TABLE))
                        old_lookup_table_end = 0;
 
-               new_lookup_table_end = wim->hdr.lookup_table_res_entry.offset +
-                                      wim->hdr.lookup_table_res_entry.size;
+               new_lookup_table_end = wim->hdr.lookup_table_reshdr.offset_in_wim +
+                                      wim->hdr.lookup_table_reshdr.size_in_wim;
 
                ret = write_integrity_table(wim,
                                            new_lookup_table_end,
@@ -2320,7 +2352,7 @@ finish_write(WIMStruct *wim, int image, int write_flags,
                        return ret;
        } else {
                /* No integrity table.  */
-               zero_resource_entry(&wim->hdr.integrity);
+               zero_reshdr(&wim->hdr.integrity_table_reshdr);
        }
 
        /* Now that all information in the WIM header has been determined, the
@@ -2468,7 +2500,7 @@ write_pipable_wim(WIMStruct *wim, int image, int write_flags,
                  struct list_head *stream_list_override)
 {
        int ret;
-       struct resource_entry xml_res_entry;
+       struct wim_reshdr xml_reshdr;
 
        WARNING("Creating a pipable WIM, which will "
                "be incompatible\n"
@@ -2491,7 +2523,7 @@ write_pipable_wim(WIMStruct *wim, int image, int write_flags,
 
        /* Write extra copy of the XML data.  */
        ret = write_wim_xml_data(wim, image, WIM_TOTALBYTES_OMIT,
-                                &xml_res_entry,
+                                &xml_reshdr,
                                 WIMLIB_WRITE_RESOURCE_FLAG_PIPABLE);
        if (ret)
                return ret;
@@ -2638,8 +2670,10 @@ write_wim_part(WIMStruct *wim,
        wim->hdr.total_parts = total_parts;
 
        /* Set compression type if different.  */
-       if (wim->compression_type != wim->out_compression_type)
-               wim->hdr.flags = get_wim_hdr_cflags(wim->out_compression_type);
+       if (wim->compression_type != wim->out_compression_type) {
+               ret = set_wim_hdr_cflags(wim->out_compression_type, &wim->hdr);
+               wimlib_assert(ret == 0);
+       }
 
        /* Set chunk size if different.  */
        wim->hdr.chunk_size = wim->out_chunk_size;
@@ -2651,10 +2685,10 @@ write_wim_part(WIMStruct *wim,
                randomize_byte_array(wim->hdr.guid, WIMLIB_GUID_LEN);
 
        /* Clear references to resources that have not been written yet.  */
-       zero_resource_entry(&wim->hdr.lookup_table_res_entry);
-       zero_resource_entry(&wim->hdr.xml_res_entry);
-       zero_resource_entry(&wim->hdr.boot_metadata_res_entry);
-       zero_resource_entry(&wim->hdr.integrity);
+       zero_reshdr(&wim->hdr.lookup_table_reshdr);
+       zero_reshdr(&wim->hdr.xml_data_reshdr);
+       zero_reshdr(&wim->hdr.boot_metadata_reshdr);
+       zero_reshdr(&wim->hdr.integrity_table_reshdr);
 
        /* Set image count and boot index correctly for single image writes.  */
        if (image != WIMLIB_ALL_IMAGES) {
@@ -2807,8 +2841,8 @@ check_resource_offset(struct wim_lookup_table_entry *lte, void *_wim)
        const WIMStruct *wim = _wim;
        off_t end_offset = *(const off_t*)wim->private;
 
-       if (lte->resource_location == RESOURCE_IN_WIM && lte->wim == wim &&
-           lte->resource_entry.offset + lte->resource_entry.size > end_offset)
+       if (lte->resource_location == RESOURCE_IN_WIM && lte->rspec->wim == wim &&
+           lte->rspec->offset_in_wim + lte->rspec->size_in_wim > end_offset)
                return WIMLIB_ERR_RESOURCE_ORDER;
        return 0;
 }
@@ -2919,11 +2953,12 @@ overwrite_wim_inplace(WIMStruct *wim, int write_flags,
         * data, and that there are no stream resources, metadata resources, or
         * lookup tables after the XML data.  Otherwise, these data would be
         * overwritten. */
-       old_xml_begin = wim->hdr.xml_res_entry.offset;
-       old_xml_end = old_xml_begin + wim->hdr.xml_res_entry.size;
-       old_lookup_table_end = wim->hdr.lookup_table_res_entry.offset +
-                              wim->hdr.lookup_table_res_entry.size;
-       if (wim->hdr.integrity.offset != 0 && wim->hdr.integrity.offset < old_xml_end) {
+       old_xml_begin = wim->hdr.xml_data_reshdr.offset_in_wim;
+       old_xml_end = old_xml_begin + wim->hdr.xml_data_reshdr.size_in_wim;
+       old_lookup_table_end = wim->hdr.lookup_table_reshdr.offset_in_wim +
+                              wim->hdr.lookup_table_reshdr.size_in_wim;
+       if (wim->hdr.integrity_table_reshdr.offset_in_wim != 0 &&
+           wim->hdr.integrity_table_reshdr.offset_in_wim < old_xml_end) {
                WARNING("Didn't expect the integrity table to be before the XML data");
                return WIMLIB_ERR_RESOURCE_ORDER;
        }
@@ -2948,10 +2983,11 @@ overwrite_wim_inplace(WIMStruct *wim, int write_flags,
                old_wim_end = old_lookup_table_end;
                write_flags |= WIMLIB_WRITE_FLAG_NO_LOOKUP_TABLE |
                               WIMLIB_WRITE_FLAG_CHECKPOINT_AFTER_XML;
-       } else if (wim->hdr.integrity.offset) {
+       } else if (wim->hdr.integrity_table_reshdr.offset_in_wim != 0) {
                /* Old WIM has an integrity table; begin writing new streams
                 * after it. */
-               old_wim_end = wim->hdr.integrity.offset + wim->hdr.integrity.size;
+               old_wim_end = wim->hdr.integrity_table_reshdr.offset_in_wim +
+                             wim->hdr.integrity_table_reshdr.size_in_wim;
        } else {
                /* No existing integrity table; begin writing new streams after
                 * the old XML data. */