]> wimlib.net Git - wimlib/blobdiff - src/write.c
Fix typo
[wimlib] / src / write.c
index 61a29962f6916521bc1ca255ccb7b39bc2162cb0..4d3ade0893b02da6eec64a460a693540c3b09f84 100644 (file)
  * along with wimlib; if not, see http://www.gnu.org/licenses/.
  */
 
+#include "config.h"
+
+#if defined(HAVE_SYS_FILE_H) && defined(HAVE_FLOCK)
+/* On BSD, this should be included before "list.h" so that "list.h" can
+ * overwrite the LIST_HEAD macro. */
+#include <sys/file.h>
+#endif
+
+#include "list.h"
 #include "wimlib_internal.h"
 #include "io.h"
 #include "dentry.h"
 #include "xml.h"
 #include "lzx.h"
 #include "xpress.h"
-#include <unistd.h>
 
 #ifdef ENABLE_MULTITHREADED_COMPRESSION
-#include <semaphore.h>
 #include <pthread.h>
-#include <errno.h>
 #endif
 
+#include <unistd.h>
+#include <errno.h>
+
 #ifdef WITH_NTFS_3G
 #include <time.h>
 #include <ntfs-3g/attrib.h>
 #include <ntfs-3g/dir.h>
 #endif
 
-
 #ifdef HAVE_ALLOCA_H
 #include <alloca.h>
 #else
 #include <stdlib.h>
 #endif
 
-static int do_fflush(FILE *fp)
+static int fflush_and_ftruncate(FILE *fp, off_t size)
 {
-       int ret = fflush(fp);
+       int ret;
+
+       ret = fflush(fp);
        if (ret != 0) {
                ERROR_WITH_ERRNO("Failed to flush data to output WIM file");
                return WIMLIB_ERR_WRITE;
        }
-       return 0;
-}
-
-static int fflush_and_ftruncate(FILE *fp, off_t size)
-{
-       int ret;
-
-       ret = do_fflush(fp);
-       if (ret != 0)
-               return ret;
        ret = ftruncate(fileno(fp), size);
        if (ret != 0) {
                ERROR_WITH_ERRNO("Failed to truncate output WIM file to "
@@ -158,7 +158,7 @@ typedef int (*compress_func_t)(const void *, unsigned, void *, unsigned *);
 
 compress_func_t get_compress_func(int out_ctype)
 {
-       if (out_ctype == WIM_COMPRESSION_TYPE_LZX)
+       if (out_ctype == WIMLIB_COMPRESSION_TYPE_LZX)
                return lzx_compress;
        else
                return xpress_compress;
@@ -209,7 +209,7 @@ static int write_wim_resource_chunk(const u8 chunk[], unsigned chunk_size,
 }
 
 /*
- * Finishes a WIM chunk tale and writes it to the output file at the correct
+ * Finishes a WIM chunk table and writes it to the output file at the correct
  * offset.
  *
  * The final size of the full compressed resource is returned in the
@@ -323,6 +323,27 @@ static void end_wim_resource_read(struct lookup_table_entry *lte
 #endif
 }
 
+static int
+write_uncompressed_resource_and_truncate(struct lookup_table_entry *lte,
+                                        FILE *out_fp,
+                                        off_t file_offset,
+                                        struct resource_entry *out_res_entry)
+{
+       int ret;
+       if (fseeko(out_fp, file_offset, SEEK_SET) != 0) {
+               ERROR_WITH_ERRNO("Failed to seek to byte %"PRIu64" of "
+                                "output WIM file", file_offset);
+               return WIMLIB_ERR_WRITE;
+       }
+       ret = write_wim_resource(lte, out_fp, WIMLIB_COMPRESSION_TYPE_NONE,
+                                out_res_entry, 0);
+       if (ret != 0)
+               return ret;
+
+       return fflush_and_ftruncate(out_fp,
+                                   file_offset + wim_resource_size(lte));
+}
+
 /*
  * Writes a WIM resource to a FILE * opened for writing.  The resource may be
  * written uncompressed or compressed depending on the @out_ctype parameter.
@@ -358,7 +379,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
        struct chunk_table *chunk_tab = NULL;
        bool raw;
        off_t file_offset;
-       compress_func_t compress;
+       compress_func_t compress = NULL;
 #ifdef WITH_NTFS_3G
        ntfs_inode *ni = NULL;
 #endif
@@ -382,7 +403,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
        /* Are the compression types the same?  If so, do a raw copy (copy
         * without decompressing and recompressing the data). */
        raw = (wim_resource_compression_type(lte) == out_ctype
-              && out_ctype != WIM_COMPRESSION_TYPE_NONE
+              && out_ctype != WIMLIB_COMPRESSION_TYPE_NONE
               && !(flags & WIMLIB_RESOURCE_FLAG_RECOMPRESS));
 
        if (raw) {
@@ -402,7 +423,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
 
        /* If we are writing a compressed resource and not doing a raw copy, we
         * need to initialize the chunk table */
-       if (out_ctype != WIM_COMPRESSION_TYPE_NONE && !raw) {
+       if (out_ctype != WIMLIB_COMPRESSION_TYPE_NONE && !raw) {
                ret = begin_wim_resource_chunk_tab(lte, out_fp, file_offset,
                                                   &chunk_tab);
                if (ret != 0)
@@ -452,7 +473,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
        /* Raw copy:  The new compressed size is the same as the old compressed
         * size
         *
-        * Using WIM_COMPRESSION_TYPE_NONE:  The new compressed size is the
+        * Using WIMLIB_COMPRESSION_TYPE_NONE:  The new compressed size is the
         * original size
         *
         * Using a different compression type:  Call
@@ -462,7 +483,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
        if (raw) {
                new_compressed_size = old_compressed_size;
        } else {
-               if (out_ctype == WIM_COMPRESSION_TYPE_NONE)
+               if (out_ctype == WIMLIB_COMPRESSION_TYPE_NONE)
                        new_compressed_size = original_size;
                else {
                        ret = finish_wim_resource_chunk_tab(chunk_tab, out_fp,
@@ -494,22 +515,14 @@ int write_wim_resource(struct lookup_table_entry *lte,
        }
 
        if (!raw && new_compressed_size >= original_size &&
-           out_ctype != WIM_COMPRESSION_TYPE_NONE)
+           out_ctype != WIMLIB_COMPRESSION_TYPE_NONE)
        {
                /* Oops!  We compressed the resource to larger than the original
                 * size.  Write the resource uncompressed instead. */
-               if (fseeko(out_fp, file_offset, SEEK_SET) != 0) {
-                       ERROR_WITH_ERRNO("Failed to seek to byte %"PRIu64" "
-                                        "of output WIM file", file_offset);
-                       ret = WIMLIB_ERR_WRITE;
-                       goto out_fclose;
-               }
-               ret = write_wim_resource(lte, out_fp, WIM_COMPRESSION_TYPE_NONE,
-                                        out_res_entry, flags);
-               if (ret != 0)
-                       goto out_fclose;
-
-               ret = fflush_and_ftruncate(out_fp, file_offset + out_res_entry->size);
+               ret = write_uncompressed_resource_and_truncate(lte,
+                                                              out_fp,
+                                                              file_offset,
+                                                              out_res_entry);
                if (ret != 0)
                        goto out_fclose;
        } else {
@@ -519,7 +532,7 @@ int write_wim_resource(struct lookup_table_entry *lte,
                        out_res_entry->offset        = file_offset;
                        out_res_entry->flags         = lte->resource_entry.flags
                                                        & ~WIM_RESHDR_FLAG_COMPRESSED;
-                       if (out_ctype != WIM_COMPRESSION_TYPE_NONE)
+                       if (out_ctype != WIMLIB_COMPRESSION_TYPE_NONE)
                                out_res_entry->flags |= WIM_RESHDR_FLAG_COMPRESSED;
                }
        }
@@ -537,13 +550,14 @@ out:
 
 #ifdef ENABLE_MULTITHREADED_COMPRESSION
 struct shared_queue {
-       sem_t filled_slots;
-       sem_t empty_slots;
-       pthread_mutex_t lock;
+       unsigned size;
        unsigned front;
        unsigned back;
+       unsigned filled_slots;
        void **array;
-       unsigned size;
+       pthread_mutex_t lock;
+       pthread_cond_t msg_avail_cond;
+       pthread_cond_t space_avail_cond;
 };
 
 static int shared_queue_init(struct shared_queue *q, unsigned size)
@@ -551,46 +565,52 @@ static int shared_queue_init(struct shared_queue *q, unsigned size)
        q->array = CALLOC(sizeof(q->array[0]), size);
        if (!q->array)
                return WIMLIB_ERR_NOMEM;
-
-       sem_init(&q->filled_slots, 0, 0);
-       sem_init(&q->empty_slots, 0, size);
-       pthread_mutex_init(&q->lock, NULL);
+       q->filled_slots = 0;
        q->front = 0;
        q->back = size - 1;
        q->size = size;
+       pthread_mutex_init(&q->lock, NULL);
+       pthread_cond_init(&q->msg_avail_cond, NULL);
+       pthread_cond_init(&q->space_avail_cond, NULL);
        return 0;
 }
 
 static void shared_queue_destroy(struct shared_queue *q)
 {
-       sem_destroy(&q->filled_slots);
-       sem_destroy(&q->empty_slots);
-       pthread_mutex_destroy(&q->lock);
        FREE(q->array);
+       pthread_mutex_destroy(&q->lock);
+       pthread_cond_destroy(&q->msg_avail_cond);
+       pthread_cond_destroy(&q->space_avail_cond);
 }
 
 static void shared_queue_put(struct shared_queue *q, void *obj)
 {
-       sem_wait(&q->empty_slots);
        pthread_mutex_lock(&q->lock);
+       while (q->filled_slots == q->size)
+               pthread_cond_wait(&q->space_avail_cond, &q->lock);
 
        q->back = (q->back + 1) % q->size;
        q->array[q->back] = obj;
+       q->filled_slots++;
 
-       sem_post(&q->filled_slots);
+       pthread_cond_broadcast(&q->msg_avail_cond);
        pthread_mutex_unlock(&q->lock);
 }
 
 static void *shared_queue_get(struct shared_queue *q)
 {
-       sem_wait(&q->filled_slots);
+       void *obj;
+
        pthread_mutex_lock(&q->lock);
+       while (q->filled_slots == 0)
+               pthread_cond_wait(&q->msg_avail_cond, &q->lock);
 
-       void *obj = q->array[q->front];
+       obj = q->array[q->front];
        q->array[q->front] = NULL;
        q->front = (q->front + 1) % q->size;
+       q->filled_slots--;
 
-       sem_post(&q->empty_slots);
+       pthread_cond_broadcast(&q->space_avail_cond);
        pthread_mutex_unlock(&q->lock);
        return obj;
 }
@@ -647,68 +667,61 @@ static void *compressor_thread_proc(void *arg)
                shared_queue_put(compressed_res_queue, msg);
        }
        DEBUG("Compressor thread terminating");
+       return NULL;
 }
 #endif
 
-void show_stream_op_progress(u64 *cur_size, u64 *next_size,
-                            u64 total_size, u64 one_percent,
-                            unsigned *cur_percent,
-                            const struct lookup_table_entry *cur_lte,
-                            const char *op)
-{
-       if (*cur_size >= *next_size) {
-               printf("\r%"PRIu64" MiB of %"PRIu64" MiB "
-                      "(uncompressed) %s (%u%% done)",
-                      *cur_size >> 20,
-                      total_size >> 20, op, *cur_percent);
-               fflush(stdout);
-               *next_size += one_percent;
-               (*cur_percent)++;
-       }
-       *cur_size += wim_resource_size(cur_lte);
-}
-
-void finish_stream_op_progress(u64 total_size, const char *op)
+static int do_write_stream_list(struct list_head *my_resources,
+                               FILE *out_fp,
+                               int out_ctype,
+                               wimlib_progress_func_t progress_func,
+                               union wimlib_progress_info *progress,
+                               int write_resource_flags)
 {
-       printf("\r%"PRIu64" MiB of %"PRIu64" MiB "
-              "(uncompressed) %s (100%% done)\n",
-              total_size >> 20, total_size >> 20, op);
-       fflush(stdout);
-}
-
-static int write_stream_list_serial(struct list_head *stream_list,
-                                   FILE *out_fp, int out_ctype,
-                                   int write_flags, u64 total_size)
-{
-       struct lookup_table_entry *lte;
        int ret;
+       struct lookup_table_entry *lte, *tmp;
 
-       u64 one_percent = total_size / 100;
-       u64 cur_size = 0;
-       u64 next_size = 0;
-       unsigned cur_percent = 0;
-       int write_resource_flags = 0;
-
-       if (write_flags & WIMLIB_WRITE_FLAG_RECOMPRESS)
-               write_resource_flags |= WIMLIB_RESOURCE_FLAG_RECOMPRESS;
-
-       list_for_each_entry(lte, stream_list, staging_list) {
-               if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-                       show_stream_op_progress(&cur_size, &next_size,
-                                               total_size, one_percent,
-                                               &cur_percent, lte, "written");
-               }
-               ret = write_wim_resource(lte, out_fp, out_ctype,
+       list_for_each_entry_safe(lte, tmp, my_resources, staging_list) {
+               ret = write_wim_resource(lte,
+                                        out_fp,
+                                        out_ctype,
                                         &lte->output_resource_entry,
                                         write_resource_flags);
                if (ret != 0)
                        return ret;
+               list_del(&lte->staging_list);
+               progress->write_streams.completed_bytes +=
+                       wim_resource_size(lte);
+               progress->write_streams.completed_streams++;
+               if (progress_func) {
+                       progress_func(WIMLIB_PROGRESS_MSG_WRITE_STREAMS,
+                                     progress);
+               }
        }
-       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS)
-               finish_stream_op_progress(total_size, "written");
        return 0;
 }
 
+static int write_stream_list_serial(struct list_head *stream_list,
+                                   FILE *out_fp,
+                                   int out_ctype,
+                                   int write_flags,
+                                   wimlib_progress_func_t progress_func,
+                                   union wimlib_progress_info *progress)
+{
+       int write_resource_flags;
+
+       if (write_flags & WIMLIB_WRITE_FLAG_RECOMPRESS)
+               write_resource_flags = WIMLIB_RESOURCE_FLAG_RECOMPRESS;
+       else
+               write_resource_flags = 0;
+       progress->write_streams.num_threads = 1;
+       if (progress_func)
+               progress_func(WIMLIB_PROGRESS_MSG_WRITE_STREAMS, progress);
+       return do_write_stream_list(stream_list, out_fp,
+                                   out_ctype, progress_func,
+                                   progress, write_resource_flags);
+}
+
 #ifdef ENABLE_MULTITHREADED_COMPRESSION
 static int write_wim_chunks(struct message *msg, FILE *out_fp,
                            struct chunk_table *chunk_tab)
@@ -751,7 +764,8 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                                   struct shared_queue *compressed_res_queue,
                                   size_t queue_size,
                                   int write_flags,
-                                  u64 total_size)
+                                  wimlib_progress_func_t progress_func,
+                                  union wimlib_progress_info *progress)
 {
        int ret;
 
@@ -780,46 +794,26 @@ static int main_writer_thread_proc(struct list_head *stream_list,
        //
        LIST_HEAD(outstanding_resources);
        struct list_head *next_resource = stream_list->next;
-       struct lookup_table_entry *next_lte = container_of(next_resource,
-                                                          struct lookup_table_entry,
-                                                          staging_list);
-       next_resource = next_resource->next;
+       struct lookup_table_entry *next_lte = NULL;
        u64 next_chunk = 0;
-       u64 next_num_chunks = wim_resource_chunks(next_lte);
-       INIT_LIST_HEAD(&next_lte->msg_list);
-       list_add_tail(&next_lte->staging_list, &outstanding_resources);
+       u64 next_num_chunks = 0;
 
        // As in write_wim_resource(), each resource we read is checksummed.
        SHA_CTX next_sha_ctx;
-       sha1_init(&next_sha_ctx);
        u8 next_hash[SHA1_HASH_SIZE];
 
        // Resources that don't need any chunks compressed are added to this
        // list and written directly by the main thread.
        LIST_HEAD(my_resources);
 
-       struct lookup_table_entry *cur_lte = next_lte;
+       struct lookup_table_entry *cur_lte = NULL;
        struct chunk_table *cur_chunk_tab = NULL;
-       struct lookup_table_entry *lte;
        struct message *msg;
 
-       u64 one_percent = total_size / 100;
-       u64 cur_size = 0;
-       u64 next_size = 0;
-       unsigned cur_percent = 0;
-
 #ifdef WITH_NTFS_3G
        ntfs_inode *ni = NULL;
 #endif
 
-#ifdef WITH_NTFS_3G
-       ret = prepare_resource_for_read(next_lte, &ni);
-#else
-       ret = prepare_resource_for_read(next_lte);
-#endif
-       if (ret != 0)
-               goto out;
-
        DEBUG("Initializing buffers for uncompressed "
              "and compressed data (%zu bytes needed)",
              queue_size * MAX_CHUNKS_PER_MSG * WIM_CHUNK_SIZE * 2);
@@ -829,7 +823,12 @@ static int main_writer_thread_proc(struct list_head *stream_list,
        for (size_t i = 0; i < ARRAY_LEN(msgs); i++) {
                for (size_t j = 0; j < MAX_CHUNKS_PER_MSG; j++) {
                        msgs[i].compressed_chunks[j] = MALLOC(WIM_CHUNK_SIZE);
-                       msgs[i].uncompressed_chunks[j] = MALLOC(WIM_CHUNK_SIZE);
+
+                       // The extra 8 bytes is because longest_match() in lz.c
+                       // may read a little bit off the end of the uncompressed
+                       // data.  It doesn't need to be initialized--- we really
+                       // just need to avoid accessing an unmapped page.
+                       msgs[i].uncompressed_chunks[j] = MALLOC(WIM_CHUNK_SIZE + 8);
                        if (msgs[i].compressed_chunks[j] == NULL ||
                            msgs[i].uncompressed_chunks[j] == NULL)
                        {
@@ -849,7 +848,88 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                // are no more messages available since they were all sent off,
                // or (b) there are no more resources that need to be
                // compressed.
-               while (!list_empty(&available_msgs) && next_lte != NULL) {
+               while (!list_empty(&available_msgs)) {
+                       if (next_chunk == next_num_chunks) {
+                               // If next_chunk == next_num_chunks, there are
+                               // no more chunks to write in the current
+                               // stream.  So, check the SHA1 message digest of
+                               // the stream that was just finished (unless
+                               // next_lte == NULL, which is the case the very
+                               // first time this loop is entered, and also
+                               // near the very end of the compression when
+                               // there are no more streams.)  Then, advance to
+                               // the next stream (if there is one).
+                               if (next_lte != NULL) {
+                               #ifdef WITH_NTFS_3G
+                                       end_wim_resource_read(next_lte, ni);
+                                       ni = NULL;
+                               #else
+                                       end_wim_resource_read(next_lte);
+                               #endif
+                                       DEBUG2("Finalize SHA1 md (next_num_chunks=%zu)",
+                                              next_num_chunks);
+                                       sha1_final(next_hash, &next_sha_ctx);
+                                       if (!hashes_equal(next_lte->hash, next_hash)) {
+                                               ERROR("WIM resource has incorrect hash!");
+                                               if (next_lte->resource_location ==
+                                                   RESOURCE_IN_FILE_ON_DISK)
+                                               {
+                                                       ERROR("We were reading it from `%s'; "
+                                                             "maybe it changed while we were "
+                                                             "reading it.",
+                                                             next_lte->file_on_disk);
+                                               }
+                                               ret = WIMLIB_ERR_INVALID_RESOURCE_HASH;
+                                               goto out;
+                                       }
+                               }
+
+                               // Advance to the next resource.
+                               //
+                               // If the next resource needs no compression, just write
+                               // it with this thread (not now though--- we could be in
+                               // the middle of writing another resource.)  Keep doing
+                               // this until we either get to the end of the resources
+                               // list, or we get to a resource that needs compression.
+                               while (1) {
+                                       if (next_resource == stream_list) {
+                                               next_lte = NULL;
+                                               break;
+                                       }
+                                       next_lte = container_of(next_resource,
+                                                               struct lookup_table_entry,
+                                                               staging_list);
+                                       next_resource = next_resource->next;
+                                       if ((!(write_flags & WIMLIB_WRITE_FLAG_RECOMPRESS)
+                                              && wim_resource_compression_type(next_lte) == out_ctype)
+                                           || wim_resource_size(next_lte) == 0)
+                                       {
+                                               list_add_tail(&next_lte->staging_list,
+                                                             &my_resources);
+                                       } else {
+                                               list_add_tail(&next_lte->staging_list,
+                                                             &outstanding_resources);
+                                               next_chunk = 0;
+                                               next_num_chunks = wim_resource_chunks(next_lte);
+                                               sha1_init(&next_sha_ctx);
+                                               INIT_LIST_HEAD(&next_lte->msg_list);
+                                       #ifdef WITH_NTFS_3G
+                                               ret = prepare_resource_for_read(next_lte, &ni);
+                                       #else
+                                               ret = prepare_resource_for_read(next_lte);
+                                       #endif
+
+                                               if (ret != 0)
+                                                       goto out;
+                                               if (cur_lte == NULL)
+                                                       cur_lte = next_lte;
+                                               break;
+                                       }
+                               }
+                       }
+
+                       if (next_lte == NULL)
+                               break;
 
                        // Get a message from the available messages
                        // list
@@ -904,81 +984,11 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                        list_add_tail(&msg->list, &next_lte->msg_list);
                        shared_queue_put(res_to_compress_queue, msg);
                        DEBUG2("Compression request sent");
-
-                       if (next_chunk != next_num_chunks)
-                               // More chunks to send for this resource
-                               continue;
-
-                       // Done sending compression requests for a resource!
-                       // Check the SHA1 message digest.
-                       DEBUG2("Finalize SHA1 md (next_num_chunks=%zu)", next_num_chunks);
-                       sha1_final(next_hash, &next_sha_ctx);
-                       if (!hashes_equal(next_lte->hash, next_hash)) {
-                               ERROR("WIM resource has incorrect hash!");
-                               if (next_lte->resource_location == RESOURCE_IN_FILE_ON_DISK) {
-                                       ERROR("We were reading it from `%s'; maybe it changed "
-                                             "while we were reading it.",
-                                             next_lte->file_on_disk);
-                               }
-                               ret = WIMLIB_ERR_INVALID_RESOURCE_HASH;
-                               goto out;
-                       }
-
-                       // Advance to the next resource.
-                       //
-                       // If the next resource needs no compression, just write
-                       // it with this thread (not now though--- we could be in
-                       // the middle of writing another resource.)  Keep doing
-                       // this until we either get to the end of the resources
-                       // list, or we get to a resource that needs compression.
-
-                       while (1) {
-                               if (next_resource == stream_list) {
-                                       next_lte = NULL;
-                                       break;
-                               }
-                       #ifdef WITH_NTFS_3G
-                               end_wim_resource_read(next_lte, ni);
-                               ni = NULL;
-                       #else
-                               end_wim_resource_read(next_lte);
-                       #endif
-
-                               next_lte = container_of(next_resource,
-                                                       struct lookup_table_entry,
-                                                       staging_list);
-                               next_resource = next_resource->next;
-                               if ((!(write_flags & WIMLIB_WRITE_FLAG_RECOMPRESS)
-                                     && next_lte->resource_location == RESOURCE_IN_WIM
-                                     && wimlib_get_compression_type(next_lte->wim) == out_ctype)
-                                   || wim_resource_size(next_lte) == 0)
-                               {
-                                       list_add_tail(&next_lte->staging_list,
-                                                     &my_resources);
-                               } else {
-                                       list_add_tail(&next_lte->staging_list,
-                                                     &outstanding_resources);
-                                       next_chunk = 0;
-                                       next_num_chunks = wim_resource_chunks(next_lte);
-                                       sha1_init(&next_sha_ctx);
-                                       INIT_LIST_HEAD(&next_lte->msg_list);
-                               #ifdef WITH_NTFS_3G
-                                       ret = prepare_resource_for_read(next_lte, &ni);
-                               #else
-                                       ret = prepare_resource_for_read(next_lte);
-                               #endif
-                                       if (ret != 0)
-                                               goto out;
-                                       DEBUG2("Updated next_lte");
-                                       break;
-                               }
-                       }
                }
 
                // If there are no outstanding resources, there are no more
                // resources that need to be written.
                if (list_empty(&outstanding_resources)) {
-                       DEBUG("No outstanding resources! Done");
                        ret = 0;
                        goto out;
                }
@@ -986,23 +996,16 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                // Get the next message from the queue and process it.
                // The message will contain 1 or more data chunks that have been
                // compressed.
-               DEBUG2("Waiting for message");
                msg = shared_queue_get(compressed_res_queue);
                msg->complete = true;
 
-               DEBUG2("Received msg (begin_chunk=%"PRIu64")", msg->begin_chunk);
-
-               list_for_each_entry(msg, &cur_lte->msg_list, list) {
-                       DEBUG2("complete=%d", msg->complete);
-               }
-
                // Is this the next chunk in the current resource?  If it's not
                // (i.e., an earlier chunk in a same or different resource
                // hasn't been compressed yet), do nothing, and keep this
                // message around until all earlier chunks are received.
                //
                // Otherwise, write all the chunks we can.
-               while (!list_empty(&cur_lte->msg_list)
+               while (cur_lte != NULL && !list_empty(&cur_lte->msg_list)
                        && (msg = container_of(cur_lte->msg_list.next,
                                               struct message,
                                               list))->complete)
@@ -1010,15 +1013,6 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                        DEBUG2("Complete msg (begin_chunk=%"PRIu64")", msg->begin_chunk);
                        if (msg->begin_chunk == 0) {
                                DEBUG2("Begin chunk tab");
-                               if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-                                       show_stream_op_progress(&cur_size,
-                                                               &next_size,
-                                                               total_size,
-                                                               one_percent,
-                                                               &cur_percent,
-                                                               cur_lte,
-                                                               "written");
-                               }
 
                                // This is the first set of chunks.  Leave space
                                // for the chunk table in the output file.
@@ -1059,19 +1053,40 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                                if (ret != 0)
                                        goto out;
 
+                               if (res_csize >= wim_resource_size(cur_lte)) {
+                                       /* Oops!  We compressed the resource to
+                                        * larger than the original size.  Write
+                                        * the resource uncompressed instead. */
+                                       ret = write_uncompressed_resource_and_truncate(
+                                                        cur_lte,
+                                                        out_fp,
+                                                        cur_chunk_tab->file_offset,
+                                                        &cur_lte->output_resource_entry);
+                                       if (ret != 0)
+                                               goto out;
+                               } else {
+                                       cur_lte->output_resource_entry.size =
+                                               res_csize;
+
+                                       cur_lte->output_resource_entry.original_size =
+                                               cur_lte->resource_entry.original_size;
 
-                               cur_lte->output_resource_entry.size =
-                                       res_csize;
+                                       cur_lte->output_resource_entry.offset =
+                                               cur_chunk_tab->file_offset;
 
-                               cur_lte->output_resource_entry.original_size =
-                                       cur_lte->resource_entry.original_size;
+                                       cur_lte->output_resource_entry.flags =
+                                               cur_lte->resource_entry.flags |
+                                                       WIM_RESHDR_FLAG_COMPRESSED;
+                               }
 
-                               cur_lte->output_resource_entry.offset =
-                                       cur_chunk_tab->file_offset;
+                               progress->write_streams.completed_bytes +=
+                                               wim_resource_size(cur_lte);
+                               progress->write_streams.completed_streams++;
 
-                               cur_lte->output_resource_entry.flags =
-                                       cur_lte->resource_entry.flags |
-                                               WIM_RESHDR_FLAG_COMPRESSED;
+                               if (progress_func) {
+                                       progress_func(WIMLIB_PROGRESS_MSG_WRITE_STREAMS,
+                                                     progress);
+                               }
 
                                FREE(cur_chunk_tab);
                                cur_chunk_tab = NULL;
@@ -1080,9 +1095,15 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                                list_del(&cur_lte->staging_list);
 
                                if (next == &outstanding_resources) {
-                                       DEBUG("No more outstanding resources");
-                                       ret = 0;
-                                       goto out;
+                                       if (next_lte == NULL) {
+                                               DEBUG("No more outstanding resources");
+                                               ret = 0;
+                                               goto out;
+                                       } else {
+                                               DEBUG("No more outstanding resources---"
+                                                     "but still more to compress!");
+                                               cur_lte = NULL;
+                                       }
                                } else {
                                        cur_lte = container_of(cur_lte->staging_list.next,
                                                               struct lookup_table_entry,
@@ -1096,61 +1117,31 @@ static int main_writer_thread_proc(struct list_head *stream_list,
                                // to be compressed because the desired
                                // compression type is the same as the previous
                                // compression type).
-                               struct lookup_table_entry *tmp;
-                               list_for_each_entry_safe(lte,
-                                                        tmp,
-                                                        &my_resources,
-                                                        staging_list)
-                               {
-                                       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-                                               show_stream_op_progress(&cur_size,
-                                                                       &next_size,
-                                                                       total_size,
-                                                                       one_percent,
-                                                                       &cur_percent,
-                                                                       lte,
-                                                                       "written");
-                                       }
-
-                                       ret = write_wim_resource(lte,
-                                                                out_fp,
-                                                                out_ctype,
-                                                                &lte->output_resource_entry,
-                                                                0);
-                                       list_del(&lte->staging_list);
-                                       if (ret != 0)
-                                               goto out;
-                               }
+                               ret = do_write_stream_list(&my_resources,
+                                                          out_fp,
+                                                          out_ctype,
+                                                          progress_func,
+                                                          progress,
+                                                          0);
+                               if (ret != 0)
+                                       goto out;
                        }
                }
        }
 
 out:
+       if (next_lte) {
 #ifdef WITH_NTFS_3G
-       end_wim_resource_read(cur_lte, ni);
+               end_wim_resource_read(next_lte, ni);
 #else
-       end_wim_resource_read(cur_lte);
+               end_wim_resource_read(next_lte);
 #endif
+       }
+
        if (ret == 0) {
-               list_for_each_entry(lte, &my_resources, staging_list) {
-                       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-                               show_stream_op_progress(&cur_size,
-                                                       &next_size,
-                                                       total_size,
-                                                       one_percent,
-                                                       &cur_percent,
-                                                       lte,
-                                                       "written");
-                       }
-                       ret = write_wim_resource(lte, out_fp,
-                                                out_ctype,
-                                                &lte->output_resource_entry,
-                                                0);
-                       if (ret != 0)
-                               break;
-               }
-               if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS)
-                       finish_stream_op_progress(total_size, "written");
+               ret = do_write_stream_list(&my_resources, out_fp,
+                                          out_ctype, progress_func,
+                                          progress, 0);
        } else {
                size_t num_available_msgs = 0;
                struct list_head *cur;
@@ -1165,8 +1156,6 @@ out:
                }
        }
 
-       DEBUG("Freeing messages");
-
        for (size_t i = 0; i < ARRAY_LEN(msgs); i++) {
                for (size_t j = 0; j < MAX_CHUNKS_PER_MSG; j++) {
                        FREE(msgs[i].compressed_chunks[j]);
@@ -1180,22 +1169,13 @@ out:
 }
 
 
-static const char *get_data_type(int ctype)
-{
-       switch (ctype) {
-       case WIM_COMPRESSION_TYPE_NONE:
-               return "uncompressed";
-       case WIM_COMPRESSION_TYPE_LZX:
-               return "LZX-compressed";
-       case WIM_COMPRESSION_TYPE_XPRESS:
-               return "XPRESS-compressed";
-       }
-}
-
 static int write_stream_list_parallel(struct list_head *stream_list,
-                                     FILE *out_fp, int out_ctype,
-                                     int write_flags, u64 total_size,
-                                     unsigned num_threads)
+                                     FILE *out_fp,
+                                     int out_ctype,
+                                     int write_flags,
+                                     unsigned num_threads,
+                                     wimlib_progress_func_t progress_func,
+                                     union wimlib_progress_info *progress)
 {
        int ret;
        struct shared_queue res_to_compress_queue;
@@ -1212,6 +1192,7 @@ static int write_stream_list_parallel(struct list_head *stream_list,
                }
        }
 
+       progress->write_streams.num_threads = num_threads;
        wimlib_assert(stream_list->next != stream_list);
 
        static const double MESSAGES_PER_THREAD = 2.0;
@@ -1247,10 +1228,8 @@ static int write_stream_list_parallel(struct list_head *stream_list,
                }
        }
 
-       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-               printf("Writing %s data using %u threads...\n",
-                      get_data_type(out_ctype), num_threads);
-       }
+       if (progress_func)
+               progress_func(WIMLIB_PROGRESS_MSG_WRITE_STREAMS, progress);
 
        ret = main_writer_thread_proc(stream_list,
                                      out_fp,
@@ -1259,8 +1238,8 @@ static int write_stream_list_parallel(struct list_head *stream_list,
                                      &compressed_res_queue,
                                      queue_size,
                                      write_flags,
-                                     total_size);
-
+                                     progress_func,
+                                     progress);
 out_join:
        for (unsigned i = 0; i < num_threads; i++)
                shared_queue_put(&res_to_compress_queue, NULL);
@@ -1279,8 +1258,13 @@ out_destroy_res_to_compress_queue:
                return ret;
 out_serial:
        WARNING("Falling back to single-threaded compression");
-       return write_stream_list_serial(stream_list, out_fp,
-                                       out_ctype, write_flags, total_size);
+       return write_stream_list_serial(stream_list,
+                                       out_fp,
+                                       out_ctype,
+                                       write_flags,
+                                       progress_func,
+                                       progress);
+
 }
 #endif
 
@@ -1290,61 +1274,61 @@ out_serial:
  */
 static int write_stream_list(struct list_head *stream_list, FILE *out_fp,
                             int out_ctype, int write_flags,
-                            unsigned num_threads)
+                            unsigned num_threads,
+                            wimlib_progress_func_t progress_func)
 {
        struct lookup_table_entry *lte;
        size_t num_streams = 0;
-       u64 total_size = 0;
+       u64 total_bytes = 0;
+       u64 total_compression_bytes = 0;
        bool compression_needed = false;
+       union wimlib_progress_info progress;
+       int ret;
 
        list_for_each_entry(lte, stream_list, staging_list) {
                num_streams++;
-               total_size += wim_resource_size(lte);
-               if (!compression_needed
-                   &&
-                   (out_ctype != WIM_COMPRESSION_TYPE_NONE
-                      && (lte->resource_location != RESOURCE_IN_WIM
-                          || wimlib_get_compression_type(lte->wim) != out_ctype
-                          || (write_flags & WIMLIB_WRITE_FLAG_REBUILD)))
-                   && wim_resource_size(lte) != 0)
-                       compression_needed = true;
+               total_bytes += wim_resource_size(lte);
+               if (out_ctype != WIMLIB_COMPRESSION_TYPE_NONE
+                      && (wim_resource_compression_type(lte) != out_ctype ||
+                          (write_flags & WIMLIB_WRITE_FLAG_RECOMPRESS)))
+               {
+                       total_compression_bytes += wim_resource_size(lte);
+               }
        }
+       progress.write_streams.total_bytes       = total_bytes;
+       progress.write_streams.total_streams     = num_streams;
+       progress.write_streams.completed_bytes   = 0;
+       progress.write_streams.completed_streams = 0;
+       progress.write_streams.num_threads       = num_threads;
+       progress.write_streams.compression_type  = out_ctype;
 
        if (num_streams == 0) {
-               if (write_flags & WIMLIB_WRITE_FLAG_VERBOSE)
-                       printf("No streams to write\n");
-               return 0;
-       }
-
-       if (write_flags & WIMLIB_WRITE_FLAG_VERBOSE) {
-               printf("Preparing to write %zu streams "
-                      "(%"PRIu64" total bytes uncompressed)\n",
-                      num_streams, total_size);
-               printf("Using compression type %s\n",
-                      wimlib_get_compression_type_string(out_ctype));
+               ret = 0;
+               goto out;
        }
 
 #ifdef ENABLE_MULTITHREADED_COMPRESSION
-       if (compression_needed && total_size >= 1000000 && num_threads != 1) {
-               return write_stream_list_parallel(stream_list, out_fp,
-                                                 out_ctype, write_flags,
-                                                 total_size, num_threads);
+       if (total_compression_bytes >= 1000000 && num_threads != 1) {
+               ret = write_stream_list_parallel(stream_list,
+                                                out_fp,
+                                                out_ctype,
+                                                write_flags,
+                                                num_threads,
+                                                progress_func,
+                                                &progress);
        }
        else
 #endif
        {
-               if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) {
-                       const char *reason = "";
-                       if (!compression_needed)
-                               reason = " (no compression needed)";
-                       printf("Writing %s data using 1 thread%s\n",
-                              get_data_type(out_ctype), reason);
-               }
-
-               return write_stream_list_serial(stream_list, out_fp,
-                                               out_ctype, write_flags,
-                                               total_size);
+               ret = write_stream_list_serial(stream_list,
+                                              out_fp,
+                                              out_ctype,
+                                              write_flags,
+                                              progress_func,
+                                              &progress);
        }
+out:
+       return ret;
 }
 
 
@@ -1369,7 +1353,8 @@ static int find_streams_to_write(WIMStruct *w)
 }
 
 static int write_wim_streams(WIMStruct *w, int image, int write_flags,
-                            unsigned num_threads)
+                            unsigned num_threads,
+                            wimlib_progress_func_t progress_func)
 {
 
        for_lookup_table_entry(w->lookup_table, lte_zero_out_refcnt, NULL);
@@ -1378,7 +1363,7 @@ static int write_wim_streams(WIMStruct *w, int image, int write_flags,
        for_image(w, image, find_streams_to_write);
        return write_stream_list(&stream_list, w->out_fp,
                                 wimlib_get_compression_type(w), write_flags,
-                                num_threads);
+                                num_threads, progress_func);
 }
 
 /*
@@ -1410,7 +1395,8 @@ static int write_wim_streams(WIMStruct *w, int image, int write_flags,
  *             fsync() the output file before closing it.
  *
  */
-int finish_write(WIMStruct *w, int image, int write_flags)
+int finish_write(WIMStruct *w, int image, int write_flags,
+                wimlib_progress_func_t progress_func)
 {
        int ret;
        struct wim_header hdr;
@@ -1462,7 +1448,6 @@ int finish_write(WIMStruct *w, int image, int write_flags)
 
                off_t old_lookup_table_end;
                off_t new_lookup_table_end;
-               bool show_progress;
                if (write_flags & WIMLIB_WRITE_FLAG_REUSE_INTEGRITY_TABLE) {
                        old_lookup_table_end = w->hdr.lookup_table_res_entry.offset +
                                               w->hdr.lookup_table_res_entry.size;
@@ -1471,13 +1456,12 @@ int finish_write(WIMStruct *w, int image, int write_flags)
                }
                new_lookup_table_end = hdr.lookup_table_res_entry.offset +
                                       hdr.lookup_table_res_entry.size;
-               show_progress = ((write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS) != 0);
 
                ret = write_integrity_table(out,
                                            &hdr.integrity,
                                            new_lookup_table_end,
                                            old_lookup_table_end,
-                                           show_progress);
+                                           progress_func);
                if (ret != 0)
                        goto out;
        } else {
@@ -1492,7 +1476,7 @@ int finish_write(WIMStruct *w, int image, int write_flags)
         * marked as bootable.  This is not well documented...
         */
        if (hdr.boot_idx == 0 || !w->image_metadata
-                       || (image != WIM_ALL_IMAGES && image != hdr.boot_idx)) {
+                       || (image != WIMLIB_ALL_IMAGES && image != hdr.boot_idx)) {
                memset(&hdr.boot_metadata_res_entry, 0,
                       sizeof(struct resource_entry));
        } else {
@@ -1503,7 +1487,7 @@ int finish_write(WIMStruct *w, int image, int write_flags)
        }
 
        /* Set image count and boot index correctly for single image writes */
-       if (image != WIM_ALL_IMAGES) {
+       if (image != WIMLIB_ALL_IMAGES) {
                hdr.image_count = 1;
                if (hdr.boot_idx == image)
                        hdr.boot_idx = 1;
@@ -1538,7 +1522,53 @@ out:
        return ret;
 }
 
-static void close_wim_writable(WIMStruct *w)
+#if defined(HAVE_SYS_FILE_H) && defined(HAVE_FLOCK)
+int lock_wim(FILE *fp, const char *path)
+{
+       int ret = 0;
+       if (fp) {
+               ret = flock(fileno(fp), LOCK_EX | LOCK_NB);
+               if (ret != 0) {
+                       if (errno == EWOULDBLOCK) {
+                               ERROR("`%s' is already being modified or has been "
+                                     "mounted read-write\n"
+                                     "        by another process!", path);
+                               ret = WIMLIB_ERR_ALREADY_LOCKED;
+                       } else {
+                               WARNING("Failed to lock `%s': %s",
+                                       path, strerror(errno));
+                               ret = 0;
+                       }
+               }
+       }
+       return ret;
+}
+#endif
+
+static int open_wim_writable(WIMStruct *w, const char *path,
+                            bool trunc, bool readable)
+{
+       const char *mode;
+       if (trunc)
+               if (readable)
+                       mode = "w+b";
+               else
+                       mode = "wb";
+       else
+               mode = "r+b";
+
+       wimlib_assert(w->out_fp == NULL);
+       w->out_fp = fopen(path, mode);
+       if (w->out_fp) {
+               return 0;
+       } else {
+               ERROR_WITH_ERRNO("Failed to open `%s' for writing", path);
+               return WIMLIB_ERR_OPEN;
+       }
+}
+
+
+void close_wim_writable(WIMStruct *w)
 {
        if (w->out_fp) {
                if (fclose(w->out_fp) != 0) {
@@ -1553,12 +1583,8 @@ static void close_wim_writable(WIMStruct *w)
 int begin_write(WIMStruct *w, const char *path, int write_flags)
 {
        int ret;
-       bool need_readable = false;
-       bool trunc = true;
-       if (write_flags & WIMLIB_WRITE_FLAG_CHECK_INTEGRITY)
-               need_readable = true;
-
-       ret = open_wim_writable(w, path, trunc, need_readable);
+       ret = open_wim_writable(w, path, true,
+                               (write_flags & WIMLIB_WRITE_FLAG_CHECK_INTEGRITY) != 0);
        if (ret != 0)
                return ret;
        /* Write dummy header. It will be overwritten later. */
@@ -1567,7 +1593,8 @@ int begin_write(WIMStruct *w, const char *path, int write_flags)
 
 /* Writes a stand-alone WIM to a file.  */
 WIMLIBAPI int wimlib_write(WIMStruct *w, const char *path,
-                          int image, int write_flags, unsigned num_threads)
+                          int image, int write_flags, unsigned num_threads,
+                          wimlib_progress_func_t progress_func)
 {
        int ret;
 
@@ -1576,7 +1603,7 @@ WIMLIBAPI int wimlib_write(WIMStruct *w, const char *path,
 
        write_flags &= WIMLIB_WRITE_MASK_PUBLIC;
 
-       if (image != WIM_ALL_IMAGES &&
+       if (image != WIMLIB_ALL_IMAGES &&
             (image < 1 || image > w->hdr.image_count))
                return WIMLIB_ERR_INVALID_IMAGE;
 
@@ -1585,29 +1612,26 @@ WIMLIBAPI int wimlib_write(WIMStruct *w, const char *path,
                return WIMLIB_ERR_SPLIT_UNSUPPORTED;
        }
 
-       if (image == WIM_ALL_IMAGES)
-               DEBUG("Writing all images to `%s'.", path);
-       else
-               DEBUG("Writing image %d to `%s'.", image, path);
-
        ret = begin_write(w, path, write_flags);
        if (ret != 0)
                goto out;
 
-       ret = write_wim_streams(w, image, write_flags, num_threads);
+       ret = write_wim_streams(w, image, write_flags, num_threads,
+                               progress_func);
        if (ret != 0)
                goto out;
 
-       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS)
-               printf("Writing image metadata...\n");
+       if (progress_func)
+               progress_func(WIMLIB_PROGRESS_MSG_WRITE_METADATA_BEGIN, NULL);
 
        ret = for_image(w, image, write_metadata_resource);
        if (ret != 0)
                goto out;
 
-       ret = finish_write(w, image, write_flags);
-       if (ret == 0 && (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS))
-               printf("Successfully wrote `%s'\n", path);
+       if (progress_func)
+               progress_func(WIMLIB_PROGRESS_MSG_WRITE_METADATA_END, NULL);
+
+       ret = finish_write(w, image, write_flags, progress_func);
 out:
        close_wim_writable(w);
        return ret;
@@ -1705,6 +1729,7 @@ static int find_new_streams(struct lookup_table_entry *lte, void *arg)
  */
 static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
                                 unsigned num_threads,
+                                wimlib_progress_func_t progress_func,
                                 int modified_image_idx)
 {
        int ret;
@@ -1733,10 +1758,6 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
        INIT_LIST_HEAD(&stream_list);
        for (int i = modified_image_idx; i < w->hdr.image_count; i++) {
                DEBUG("Identifiying streams in image %d", i + 1);
-               wimlib_assert(w->image_metadata[i].modified);
-               wimlib_assert(!w->image_metadata[i].has_been_mounted_rw);
-               wimlib_assert(w->image_metadata[i].root_dentry != NULL);
-               wimlib_assert(w->image_metadata[i].metadata_lte != NULL);
                w->private = &stream_list;
                for_dentry_in_tree(w->image_metadata[i].root_dentry,
                                   dentry_find_streams_to_write, w);
@@ -1755,7 +1776,6 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
        if (modified_image_idx == w->hdr.image_count && !w->deletion_occurred) {
                /* If no images have been modified and no images have been
                 * deleted, a new lookup table does not need to be written. */
-               wimlib_assert(list_empty(&stream_list));
                old_wim_end = w->hdr.lookup_table_res_entry.offset +
                              w->hdr.lookup_table_res_entry.size;
                write_flags |= WIMLIB_WRITE_FLAG_NO_LOOKUP_TABLE |
@@ -1771,9 +1791,17 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
        if (ret != 0)
                return ret;
 
+       ret = lock_wim(w->out_fp, w->filename);
+       if (ret != 0) {
+               fclose(w->out_fp);
+               w->out_fp = NULL;
+               return ret;
+       }
+
        if (fseeko(w->out_fp, old_wim_end, SEEK_SET) != 0) {
                ERROR_WITH_ERRNO("Can't seek to end of WIM");
-               return WIMLIB_ERR_WRITE;
+               ret = WIMLIB_ERR_WRITE;
+               goto out_ftruncate;
        }
 
        if (!list_empty(&stream_list)) {
@@ -1781,7 +1809,8 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
                      old_wim_end);
                ret = write_stream_list(&stream_list, w->out_fp,
                                        wimlib_get_compression_type(w),
-                                       write_flags, num_threads);
+                                       write_flags, num_threads,
+                                       progress_func);
                if (ret != 0)
                        goto out_ftruncate;
        } else {
@@ -1795,7 +1824,8 @@ static int overwrite_wim_inplace(WIMStruct *w, int write_flags,
                        goto out_ftruncate;
        }
        write_flags |= WIMLIB_WRITE_FLAG_REUSE_INTEGRITY_TABLE;
-       ret = finish_write(w, WIM_ALL_IMAGES, write_flags);
+       ret = finish_write(w, WIMLIB_ALL_IMAGES, write_flags,
+                          progress_func);
 out_ftruncate:
        close_wim_writable(w);
        if (ret != 0) {
@@ -1807,12 +1837,13 @@ out_ftruncate:
 }
 
 static int overwrite_wim_via_tmpfile(WIMStruct *w, int write_flags,
-                                    unsigned num_threads)
+                                    unsigned num_threads,
+                                    wimlib_progress_func_t progress_func)
 {
        size_t wim_name_len;
        int ret;
 
-       DEBUG("Overwrining `%s' via a temporary file", w->filename);
+       DEBUG("Overwriting `%s' via a temporary file", w->filename);
 
        /* Write the WIM to a temporary file in the same directory as the
         * original WIM. */
@@ -1822,20 +1853,14 @@ static int overwrite_wim_via_tmpfile(WIMStruct *w, int write_flags,
        randomize_char_array_with_alnum(tmpfile + wim_name_len, 9);
        tmpfile[wim_name_len + 9] = '\0';
 
-       ret = wimlib_write(w, tmpfile, WIM_ALL_IMAGES,
+       ret = wimlib_write(w, tmpfile, WIMLIB_ALL_IMAGES,
                           write_flags | WIMLIB_WRITE_FLAG_FSYNC,
-                          num_threads);
+                          num_threads, progress_func);
        if (ret != 0) {
                ERROR("Failed to write the WIM file `%s'", tmpfile);
                goto err;
        }
 
-       /* Close the original WIM file that was opened for reading. */
-       if (w->fp != NULL) {
-               fclose(w->fp);
-               w->fp = NULL;
-       }
-
        DEBUG("Renaming `%s' to `%s'", tmpfile, w->filename);
 
        /* Rename the new file to the old file .*/
@@ -1846,8 +1871,18 @@ static int overwrite_wim_via_tmpfile(WIMStruct *w, int write_flags,
                goto err;
        }
 
-       if (write_flags & WIMLIB_WRITE_FLAG_SHOW_PROGRESS)
-               printf("Successfully renamed `%s' to `%s'\n", tmpfile, w->filename);
+       if (progress_func) {
+               union wimlib_progress_info progress;
+               progress.rename.from = tmpfile;
+               progress.rename.to = w->filename;
+               progress_func(WIMLIB_PROGRESS_MSG_RENAME, &progress);
+       }
+
+       /* Close the original WIM file that was opened for reading. */
+       if (w->fp != NULL) {
+               fclose(w->fp);
+               w->fp = NULL;
+       }
 
        /* Re-open the WIM read-only. */
        w->fp = fopen(w->filename, "rb");
@@ -1855,6 +1890,8 @@ static int overwrite_wim_via_tmpfile(WIMStruct *w, int write_flags,
                ret = WIMLIB_ERR_REOPEN;
                WARNING("Failed to re-open `%s' read-only: %s",
                        w->filename, strerror(errno));
+               FREE(w->filename);
+               w->filename = NULL;
        }
        return ret;
 err:
@@ -1868,7 +1905,8 @@ err:
  * Writes a WIM file to the original file that it was read from, overwriting it.
  */
 WIMLIBAPI int wimlib_overwrite(WIMStruct *w, int write_flags,
-                              unsigned num_threads)
+                              unsigned num_threads,
+                              wimlib_progress_func_t progress_func)
 {
        if (!w)
                return WIMLIB_ERR_INVALID_PARAM;
@@ -1895,14 +1933,10 @@ WIMLIBAPI int wimlib_overwrite(WIMStruct *w, int write_flags,
                        ;
                if (i == w->hdr.image_count) {
                        return overwrite_wim_inplace(w, write_flags, num_threads,
+                                                    progress_func,
                                                     modified_image_idx);
                }
        }
-       return overwrite_wim_via_tmpfile(w, write_flags, num_threads);
-}
-
-/* Deprecated */
-WIMLIBAPI int wimlib_overwrite_xml_and_header(WIMStruct *wim, int write_flags)
-{
-       return wimlib_overwrite(wim, write_flags, 1);
+       return overwrite_wim_via_tmpfile(w, write_flags, num_threads,
+                                        progress_func);
 }