/*
* verify.c
*
- * Some functions to verify that stuff in the WIM is valid. Of course, not
- * *all* the verifications of the input data are in this file.
+ * Verify stream reference counts.
*/
/*
#include "wimlib/security.h"
static int
-verify_inode(struct wim_inode *inode, const WIMStruct *w)
+lte_fix_refcnt(struct wim_lookup_table_entry *lte, void *ctr)
{
- const struct wim_lookup_table *table = w->lookup_table;
- const struct wim_security_data *sd = wim_const_security_data(w);
- struct wim_dentry *first_dentry = inode_first_dentry(inode);
- struct wim_dentry *dentry;
-
- /* Check the security ID. -1 is valid and means "no security
- * descriptor". Anything else has to be a valid index into the WIM
- * image's security descriptors table. */
- if (inode->i_security_id < -1) {
- ERROR("Dentry `%"TS"' has an invalid security ID (%d)",
- dentry_full_path(first_dentry), inode->i_security_id);
- return WIMLIB_ERR_INVALID_DENTRY;
- }
-
- if (inode->i_security_id >= 0 &&
- inode->i_security_id >= sd->num_entries)
- {
- ERROR("Dentry `%"TS"' has an invalid security ID (%d) "
- "(there are only %u entries in the security table)",
- dentry_full_path(first_dentry), inode->i_security_id,
- sd->num_entries);
- return WIMLIB_ERR_INVALID_DENTRY;
- }
-
- /* Check that lookup table entries for all the inode's stream exist,
- * except if the SHA1 message digest is all 0's, which indicates an
- * empty stream.
- *
- * This check is skipped on split WIMs. */
- if (w->hdr.total_parts == 1) {
- for (unsigned i = 0; i <= inode->i_num_ads; i++) {
- struct wim_lookup_table_entry *lte;
- const u8 *hash;
- hash = inode_stream_hash_unresolved(inode, i);
- lte = __lookup_resource(table, hash);
- if (!lte && !is_zero_hash(hash)) {
- ERROR("Could not find lookup table entry for stream "
- "%u of dentry `%"TS"'",
- i, dentry_full_path(first_dentry));
- return WIMLIB_ERR_INVALID_DENTRY;
- }
- if (lte)
- lte->real_refcnt += inode->i_nlink;
- }
- }
-
- /* Make sure there is only one unnamed data stream. */
- unsigned num_unnamed_streams = 0;
- for (unsigned i = 0; i <= inode->i_num_ads; i++) {
- const u8 *hash;
- hash = inode_stream_hash_unresolved(inode, i);
- if (inode_stream_name_nbytes(inode, i) == 0 && !is_zero_hash(hash))
- num_unnamed_streams++;
- }
- if (num_unnamed_streams > 1) {
- ERROR("Dentry `%"TS"' has multiple (%u) un-named streams",
- dentry_full_path(first_dentry), num_unnamed_streams);
- return WIMLIB_ERR_INVALID_DENTRY;
- }
-
- /* Files cannot have multiple DOS names, even if they have multiple
- * names in multiple directories (i.e. hard links).
- * Source: NTFS-3g authors. */
- struct wim_dentry *dentry_with_dos_name = NULL;
- inode_for_each_dentry(dentry, inode) {
- if (dentry_has_short_name(dentry)) {
- if (dentry_with_dos_name) {
- /* This was previously an error, but if we
- * capture a WIM from UDF on Windows, hard links
- * are supported but DOS names are automatically
- * generated for all names for an inode. */
- #if 0
- ERROR("Hard-linked file has a DOS name at "
- "both `%"TS"' and `%"TS"'",
- dentry_full_path(dentry_with_dos_name),
- dentry_full_path(dentry));
- return WIMLIB_ERR_INVALID_DENTRY;
- #else
- dentry->dos_name_invalid = 1;
- #endif
- }
- dentry_with_dos_name = dentry;
+ if (lte->refcnt != lte->real_refcnt) {
+ if (wimlib_print_errors) {
+ WARNING("The following lookup table entry has a reference "
+ "count of %u, but", lte->refcnt);
+ WARNING("We found %u references to it",
+ lte->real_refcnt);
+ print_lookup_table_entry(lte, stderr);
}
+ lte->refcnt = lte->real_refcnt;
+ ++*(unsigned long *)ctr;
}
-
- /* Directories with multiple links have not been tested. XXX */
- if (inode->i_nlink > 1 && inode->i_attributes & FILE_ATTRIBUTE_DIRECTORY) {
- ERROR("Hard-linked directory `%"TS"' is unsupported",
- dentry_full_path(first_dentry));
- return WIMLIB_ERR_INVALID_DENTRY;
- }
-
- inode->i_verified = 1;
return 0;
}
-/* Run some miscellaneous verifications on a WIM dentry */
-int
-verify_dentry(struct wim_dentry *dentry, void *wim)
+static void
+tally_inode_refcnts(const struct wim_inode *inode,
+ const struct wim_lookup_table *lookup_table)
{
- int ret;
- WIMStruct *w = wim;
-
- /* Verify the associated inode, but only one time no matter how many
- * dentries it has (unless we are doing a full verification of the WIM,
- * in which case we need to force the inode to be verified again.) */
- if (!dentry->d_inode->i_verified) {
- ret = verify_inode(dentry->d_inode, w);
- if (ret)
- return ret;
- }
-
- /* Make sure root dentry is unnamed, while every other dentry has at
- * least a long name.
- *
- * I am assuming that dentries having only a DOS name is illegal; i.e.,
- * Windows will always combine the Win32 name and DOS name for a file
- * into a single WIM dentry, even if they are stored separately on NTFS.
- * (This seems to be the case...) */
- if (dentry_is_root(dentry)) {
- if (dentry_has_long_name(dentry) || dentry_has_short_name(dentry)) {
- ERROR("The root dentry has a nonempty name!");
- return WIMLIB_ERR_INVALID_DENTRY;
- }
- } else {
- if (!dentry_has_long_name(dentry)) {
- ERROR("Dentry `%"TS"' has no long name!",
- dentry_full_path(dentry));
- return WIMLIB_ERR_INVALID_DENTRY;
- }
- }
-
-#if 0
- /* Check timestamps */
- if (inode->i_last_access_time < inode->i_creation_time ||
- inode->i_last_write_time < inode->i_creation_time) {
- WARNING("Dentry `%"TS"' was created after it was last accessed or "
- "written to", dentry->full_path);
+ for (unsigned i = 0; i <= inode->i_num_ads; i++) {
+ struct wim_lookup_table_entry *lte;
+ lte = inode_stream_lte(inode, i, lookup_table);
+ if (lte)
+ lte->real_refcnt += inode->i_nlink;
}
-#endif
-
- return 0;
}
+
static int
-image_run_full_verifications(WIMStruct *w)
+tally_image_refcnts(WIMStruct *wim)
{
- struct wim_image_metadata *imd;
- struct wim_inode *inode;
+ const struct wim_image_metadata *imd;
+ const struct wim_inode *inode;
- imd = wim_get_current_image_metadata(w);
+ imd = wim_get_current_image_metadata(wim);
image_for_each_inode(inode, imd)
- inode->i_verified = 0;
- return for_dentry_in_tree(imd->root_dentry, verify_dentry, w);
-}
-
-static int
-lte_fix_refcnt(struct wim_lookup_table_entry *lte, void *ctr)
-{
- if (lte->refcnt != lte->real_refcnt) {
- #ifdef ENABLE_ERROR_MESSAGES
- WARNING("The following lookup table entry has a reference "
- "count of %u, but", lte->refcnt);
- WARNING("We found %u references to it",
- lte->real_refcnt);
- print_lookup_table_entry(lte, stderr);
- #endif
- lte->refcnt = lte->real_refcnt;
- ++*(unsigned long *)ctr;
- }
+ tally_inode_refcnts(inode, wim->lookup_table);
return 0;
}
+
/* Ideally this would be unnecessary... however, the WIMs for Windows 8 are
* screwed up because some lookup table entries are referenced more times than
* their stated reference counts. So theoretically, if we delete all the
* EVERY lookup table entry. This only absolutely has to be done before an image
* is deleted or before an image is mounted read-write. */
int
-wim_run_full_verifications(WIMStruct *w)
+wim_recalculate_refcnts(WIMStruct *wim)
{
+ unsigned long num_ltes_with_bogus_refcnt = 0;
int ret;
- for_lookup_table_entry(w->lookup_table, lte_zero_real_refcnt, NULL);
-
- w->all_images_verified = 1; /* Set *before* image_run_full_verifications,
- because of check in read_metadata_resource() */
- ret = for_image(w, WIMLIB_ALL_IMAGES, image_run_full_verifications);
- if (ret == 0) {
- unsigned long num_ltes_with_bogus_refcnt = 0;
- for_lookup_table_entry(w->lookup_table, lte_fix_refcnt,
- &num_ltes_with_bogus_refcnt);
- if (num_ltes_with_bogus_refcnt != 0) {
- WARNING("A total of %lu entries in the WIM's stream "
- "lookup table had to have\n"
- " their reference counts fixed.",
- num_ltes_with_bogus_refcnt);
- }
- } else {
- w->all_images_verified = 0;
+ for_lookup_table_entry(wim->lookup_table, lte_zero_real_refcnt, NULL);
+ ret = for_image(wim, WIMLIB_ALL_IMAGES, tally_image_refcnts);
+ if (ret)
+ return ret;
+ num_ltes_with_bogus_refcnt = 0;
+ for_lookup_table_entry(wim->lookup_table, lte_fix_refcnt,
+ &num_ltes_with_bogus_refcnt);
+ if (num_ltes_with_bogus_refcnt != 0) {
+ WARNING("A total of %lu entries in the WIM's stream "
+ "lookup table had to have\n"
+ " their reference counts fixed.",
+ num_ltes_with_bogus_refcnt);
}
- return ret;
+ wim->refcnts_ok = 1;
+ return 0;
}
git://wimlib.net / wimlib / blobdiff