]> wimlib.net Git - wimlib/blobdiff - src/ntfs-capture.c
Cleanup
[wimlib] / src / ntfs-capture.c
index d23776b889d39cc4c990ebcd4cb130439fefef75..dcff1fe4e720f31bf4590e13c7cf604a5afbac9d 100644 (file)
 
 #include "config.h"
 
-#ifdef WITH_NTFS_3G
 #include <ntfs-3g/endians.h>
 #include <ntfs-3g/types.h>
-#endif
 
 #include "wimlib_internal.h"
 
 
-#ifdef WITH_NTFS_3G
 #include "dentry.h"
 #include "lookup_table.h"
-#include "io.h"
+#include "buffer_io.h"
 #include <ntfs-3g/layout.h>
 #include <ntfs-3g/acls.h>
 #include <ntfs-3g/attrib.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <errno.h>
+#include "rbtree.h"
 
-/* Structure that allows searching the security descriptors by SHA1 message
- * digest. */
+/* Red-black tree that maps SHA1 message digests of security descriptors to
+ * security IDs, which are themselves indices into the table of security
+ * descriptors in the 'struct wim_security_data'. */
 struct sd_set {
        struct wim_security_data *sd;
-       struct sd_node *root;
+       struct rb_root rb_root;
 };
 
-/* Binary tree node of security descriptors, indexed by the @hash field. */
 struct sd_node {
        int security_id;
        u8 hash[SHA1_HASH_SIZE];
-       struct sd_node *left;
-       struct sd_node *right;
+       struct rb_node rb_node;
 };
 
-static void free_sd_tree(struct sd_node *root)
+static void free_sd_tree(struct rb_node *node)
 {
-       if (root) {
-               free_sd_tree(root->left);
-               free_sd_tree(root->right);
-               FREE(root);
+       if (node) {
+               free_sd_tree(node->rb_left);
+               free_sd_tree(node->rb_right);
+               FREE(container_of(node, struct sd_node, rb_node));
        }
 }
 /* Frees a security descriptor index set. */
 static void destroy_sd_set(struct sd_set *sd_set)
 {
-       free_sd_tree(sd_set->root);
+       free_sd_tree(sd_set->rb_root.rb_node);
 }
 
 /* Inserts a a new node into the security descriptor index tree. */
-static void insert_sd_node(struct sd_node *new, struct sd_node *root)
+static void insert_sd_node(struct sd_set *set, struct sd_node *new)
 {
-       int cmp = hashes_cmp(new->hash, root->hash);
-       if (cmp < 0) {
-               if (root->left)
-                       insert_sd_node(new, root->left);
-               else
-                       root->left = new;
-       } else if (cmp > 0) {
-               if (root->right)
-                       insert_sd_node(new, root->right);
+       struct rb_root *root = &set->rb_root;
+       struct rb_node **p = &(root->rb_node);
+       struct rb_node *rb_parent = NULL;
+
+       while (*p) {
+               struct sd_node *this = container_of(*p, struct sd_node, rb_node);
+               int cmp = hashes_cmp(new->hash, this->hash);
+
+               rb_parent = *p;
+               if (cmp < 0)
+                       p = &((*p)->rb_left);
+               else if (cmp > 0)
+                       p = &((*p)->rb_right);
                else
-                       root->right = new;
-       } else {
-               wimlib_assert(0);
+                       wimlib_assert(0); /* Duplicate SHA1 message digest */
        }
+       rb_link_node(&new->rb_node, rb_parent, p);
+       rb_insert_color(&new->rb_node, root);
 }
 
-/* Returns the security ID of the security data having a SHA1 message digest of
- * @hash in the security descriptor index tree rooted at @root.
- *
- * If not found, return -1. */
-static int lookup_sd(const u8 hash[SHA1_HASH_SIZE], struct sd_node *root)
+/* Returns the index of the security descriptor having a SHA1 message digest of
+ * @hash.  If not found, return -1. */
+static int lookup_sd(struct sd_set *set, const u8 hash[SHA1_HASH_SIZE])
 {
-       int cmp;
-       if (!root)
-               return -1;
-       cmp = hashes_cmp(hash, root->hash);
-       if (cmp < 0)
-               return lookup_sd(hash, root->left);
-       else if (cmp > 0)
-               return lookup_sd(hash, root->right);
-       else
-               return root->security_id;
+       struct rb_node *node = set->rb_root.rb_node;
+
+       while (node) {
+               struct sd_node *sd_node = container_of(node, struct sd_node, rb_node);
+               int cmp = hashes_cmp(hash, sd_node->hash);
+               if (cmp < 0)
+                       node = node->rb_left;
+               else if (cmp > 0)
+                       node = node->rb_right;
+               else
+                       return sd_node->security_id;
+       }
+       return -1;
 }
 
 /*
@@ -137,10 +139,11 @@ static int sd_set_add_sd(struct sd_set *sd_set, const char descriptor[],
 
        sha1_buffer((const u8*)descriptor, size, hash);
 
-       security_id = lookup_sd(hash, sd_set->root);
-       if (security_id >= 0)
+       security_id = lookup_sd(sd_set, hash);
+       if (security_id >= 0) /* Identical descriptor already exists */
                return security_id;
 
+       /* Need to add a new security descriptor */
        new = MALLOC(sizeof(*new));
        if (!new)
                goto out;
@@ -152,11 +155,8 @@ static int sd_set_add_sd(struct sd_set *sd_set, const char descriptor[],
 
        memcpy(descr_copy, descriptor, size);
        new->security_id = sd->num_entries;
-       new->left = NULL;
-       new->right = NULL;
        copy_hash(new->hash, hash);
 
-
        descriptors = REALLOC(sd->descriptors,
                              (sd->num_entries + 1) * sizeof(sd->descriptors[0]));
        if (!descriptors)
@@ -172,11 +172,7 @@ static int sd_set_add_sd(struct sd_set *sd_set, const char descriptor[],
        sd->num_entries++;
        DEBUG("There are now %d security descriptors", sd->num_entries);
        sd->total_length += size + sizeof(sd->sizes[0]);
-
-       if (sd_set->root)
-               insert_sd_node(new, sd_set->root);
-       else
-               sd_set->root = new;
+       insert_sd_node(sd_set, new);
        return new->security_id;
 out_free_descr:
        FREE(descr_copy);
@@ -209,7 +205,7 @@ static int ntfs_attr_sha1sum(ntfs_inode *ni, ATTR_RECORD *ar,
 {
        s64 pos = 0;
        s64 bytes_remaining;
-       char buf[4096];
+       char buf[BUFFER_SIZE];
        ntfs_attr *na;
        SHA_CTX ctx;
 
@@ -249,9 +245,9 @@ out_error:
 
 /* Load the streams from a file or reparse point in the NTFS volume into the WIM
  * lookup table */
-static int capture_ntfs_streams(struct dentry *dentry, ntfs_inode *ni,
+static int capture_ntfs_streams(struct wim_dentry *dentry, ntfs_inode *ni,
                                char path[], size_t path_len,
-                               struct lookup_table *lookup_table,
+                               struct wim_lookup_table *lookup_table,
                                ntfs_volume **ntfs_vol_p,
                                ATTR_TYPES type)
 {
@@ -259,7 +255,7 @@ static int capture_ntfs_streams(struct dentry *dentry, ntfs_inode *ni,
        u8 attr_hash[SHA1_HASH_SIZE];
        struct ntfs_location *ntfs_loc = NULL;
        int ret = 0;
-       struct lookup_table_entry *lte;
+       struct wim_lookup_table_entry *lte;
 
        DEBUG2("Capturing NTFS data streams from `%s'", path);
 
@@ -333,7 +329,7 @@ static int capture_ntfs_streams(struct dentry *dentry, ntfs_inode *ni,
                                lte->ntfs_loc = ntfs_loc;
                                lte->resource_location = RESOURCE_IN_NTFS_VOLUME;
                                if (type == AT_REPARSE_POINT) {
-                                       dentry->d_inode->reparse_tag = reparse_tag;
+                                       dentry->d_inode->i_reparse_tag = reparse_tag;
                                        ntfs_loc->is_reparse_point = true;
                                        lte->resource_entry.original_size = data_size - 8;
                                        lte->resource_entry.size = data_size - 8;
@@ -343,7 +339,7 @@ static int capture_ntfs_streams(struct dentry *dentry, ntfs_inode *ni,
                                        lte->resource_entry.size = data_size;
                                }
                                ntfs_loc = NULL;
-                               DEBUG("Add resource for `%s' (size = %zu)",
+                               DEBUG("Add resource for `%s' (size = %"PRIu64")",
                                      dentry->file_name_utf8,
                                      lte->resource_entry.original_size);
                                copy_hash(lte->hash, attr_hash);
@@ -353,22 +349,24 @@ static int capture_ntfs_streams(struct dentry *dentry, ntfs_inode *ni,
                if (name_length == 0) {
                        /* Unnamed data stream.  Put the reference to it in the
                         * dentry's inode. */
-                       if (dentry->d_inode->lte) {
+                       if (dentry->d_inode->i_lte) {
                                ERROR("Found two un-named data streams for "
                                      "`%s'", path);
                                ret = WIMLIB_ERR_NTFS_3G;
                                goto out_free_lte;
                        }
-                       dentry->d_inode->lte = lte;
+                       dentry->d_inode->i_lte = lte;
                } else {
                        /* Named data stream.  Put the reference to it in the
                         * alternate data stream entries */
-                       struct ads_entry *new_ads_entry;
+                       struct wim_ads_entry *new_ads_entry;
                        size_t stream_name_utf8_len;
-                       stream_name_utf8 = utf16_to_utf8((const char*)attr_record_name(actx->attr),
-                                                        name_length * 2,
-                                                        &stream_name_utf8_len);
-                       if (!stream_name_utf8)
+
+                       ret = utf16_to_utf8((const char*)attr_record_name(actx->attr),
+                                           name_length * 2,
+                                           &stream_name_utf8,
+                                           &stream_name_utf8_len);
+                       if (ret != 0)
                                goto out_free_lte;
                        new_ads_entry = inode_add_ads(dentry->d_inode, stream_name_utf8);
                        FREE(stream_name_utf8);
@@ -399,27 +397,152 @@ out_put_actx:
        return ret;
 }
 
+/* Red-black tree that maps NTFS inode numbers to DOS names */
+struct dos_name_map {
+       struct rb_root rb_root;
+};
+
+struct dos_name_node {
+       struct rb_node rb_node;
+       char dos_name[24];
+       int name_len_bytes;
+       u64 ntfs_ino;
+};
+
+/* Inserts a new DOS name into the map */
+static int insert_dos_name(struct dos_name_map *map,
+                          const ntfschar *dos_name, int name_len,
+                          u64 ntfs_ino)
+{
+       struct dos_name_node *new_node;
+       struct rb_node **p;
+       struct rb_root *root;
+       struct rb_node *rb_parent;
+
+       DEBUG("DOS name_len = %d", name_len);
+       new_node = MALLOC(sizeof(struct dos_name_node));
+       if (!new_node)
+               return -1;
+
+       /* DOS names are supposed to be 12 characters max (that's 24 bytes,
+        * assuming 2-byte ntfs characters) */
+       wimlib_assert(name_len * sizeof(ntfschar) <= sizeof(new_node->dos_name));
+
+       /* Initialize the DOS name, DOS name length, and NTFS inode number of
+        * the red-black tree node */
+       memcpy(new_node->dos_name, dos_name, name_len * sizeof(ntfschar));
+       new_node->name_len_bytes = name_len * sizeof(ntfschar);
+       new_node->ntfs_ino = ntfs_ino;
+
+       /* Insert the red-black tree node */
+       root = &map->rb_root;
+       p = &root->rb_node;
+       rb_parent = NULL;
+       while (*p) {
+               struct dos_name_node *this;
+
+               this = container_of(*p, struct dos_name_node, rb_node);
+               rb_parent = *p;
+               if (new_node->ntfs_ino < this->ntfs_ino)
+                       p = &((*p)->rb_left);
+               else if (new_node->ntfs_ino > this->ntfs_ino)
+                       p = &((*p)->rb_right);
+               else {
+                       /* This should be impossible since a NTFS inode cannot
+                        * have multiple DOS names, and we only should get each
+                        * DOS name entry once from the ntfs_readdir() calls. */
+                       ERROR("NTFS inode %"PRIu64" has multiple DOS names",
+                             ntfs_ino);
+                       return -1;
+               }
+       }
+       rb_link_node(&new_node->rb_node, rb_parent, p);
+       rb_insert_color(&new_node->rb_node, root);
+       DEBUG("Inserted DOS name for inode %"PRIu64, ntfs_ino);
+       return 0;
+}
+
+/* Returns a structure that contains the DOS name and its length for a NTFS
+ * inode, or NULL if the inode has no DOS name. */
+static struct dos_name_node *
+lookup_dos_name(const struct dos_name_map *map, u64 ntfs_ino)
+{
+       struct rb_node *node = map->rb_root.rb_node;
+       while (node) {
+               struct dos_name_node *this;
+               this = container_of(node, struct dos_name_node, rb_node);
+               if (ntfs_ino < this->ntfs_ino)
+                       node = node->rb_left;
+               else if (ntfs_ino > this->ntfs_ino)
+                       node = node->rb_right;
+               else
+                       return this;
+       }
+       return NULL;
+}
+
+static int set_dentry_dos_name(struct wim_dentry *dentry, void *arg)
+{
+       const struct dos_name_map *map = arg;
+       const struct dos_name_node *node;
+
+       if (dentry->is_win32_name) {
+               node = lookup_dos_name(map, dentry->d_inode->i_ino);
+               if (node) {
+                       dentry->short_name = MALLOC(node->name_len_bytes);
+                       if (!dentry->short_name)
+                               return WIMLIB_ERR_NOMEM;
+                       memcpy(dentry->short_name, node->dos_name,
+                              node->name_len_bytes);
+                       dentry->short_name_len = node->name_len_bytes;
+                       DEBUG("Assigned DOS name to ino %"PRIu64,
+                             dentry->d_inode->i_ino);
+               } else {
+                       WARNING("NTFS inode %"PRIu64" has Win32 name with no "
+                               "corresponding DOS name",
+                               dentry->d_inode->i_ino);
+               }
+       }
+       return 0;
+}
+
+static void free_dos_name_tree(struct rb_node *node) {
+       if (node) {
+               free_dos_name_tree(node->rb_left);
+               free_dos_name_tree(node->rb_right);
+               FREE(container_of(node, struct dos_name_node, rb_node));
+       }
+}
+
+static void destroy_dos_name_map(struct dos_name_map *map)
+{
+       free_dos_name_tree(map->rb_root.rb_node);
+}
+
 struct readdir_ctx {
-       struct dentry       *parent;
-       ntfs_inode          *dir_ni;
-       char                *path;
-       size_t               path_len;
-       struct lookup_table *lookup_table;
-       struct sd_set       *sd_set;
+       struct wim_dentry *parent;
+       ntfs_inode *dir_ni;
+       char *path;
+       size_t path_len;
+       struct wim_lookup_table *lookup_table;
+       struct sd_set *sd_set;
+       struct dos_name_map *dos_name_map;
        const struct capture_config *config;
-       ntfs_volume        **ntfs_vol_p;
-       int                  flags;
+       ntfs_volume **ntfs_vol_p;
+       int add_image_flags;
+       wimlib_progress_func_t progress_func;
 };
 
 static int
-build_dentry_tree_ntfs_recursive(struct dentry **root_p, ntfs_inode *dir_ni,
+build_dentry_tree_ntfs_recursive(struct wim_dentry **root_p, ntfs_inode *dir_ni,
                                 ntfs_inode *ni, char path[], size_t path_len,
                                 int name_type,
-                                struct lookup_table *lookup_table,
+                                struct wim_lookup_table *lookup_table,
                                 struct sd_set *sd_set,
                                 const struct capture_config *config,
                                 ntfs_volume **ntfs_vol_p,
-                                int flags);
+                                int add_image_flags,
+                                wimlib_progress_func_t progress_func);
 
 static int wim_ntfs_capture_filldir(void *dirent, const ntfschar *name,
                                    const int name_len, const int name_type,
@@ -429,29 +552,39 @@ static int wim_ntfs_capture_filldir(void *dirent, const ntfschar *name,
        struct readdir_ctx *ctx;
        size_t utf8_name_len;
        char *utf8_name;
-       struct dentry *child = NULL;
+       struct wim_dentry *child;
        int ret;
        size_t path_len;
 
-       if (name_type == FILE_NAME_DOS)
-               return 0;
-
-       ret = -1;
-
-       utf8_name = utf16_to_utf8((const char*)name, name_len * 2,
-                                 &utf8_name_len);
-       if (!utf8_name)
-               goto out;
+       ctx = dirent;
+       if (name_type & FILE_NAME_DOS) {
+               /* If this is the entry for a DOS name, store it for later. */
+               ret = insert_dos_name(ctx->dos_name_map, name,
+                                     name_len, mref & MFT_REF_MASK_CPU);
+
+               /* Return now if an error occurred or if this is just a DOS name
+                * and not a Win32+DOS name. */
+               if (ret != 0 || name_type == FILE_NAME_DOS)
+                       return ret;
+       }
+       ret = utf16_to_utf8((const char*)name, name_len * 2,
+                           &utf8_name, &utf8_name_len);
+       if (ret != 0)
+               return -1;
 
        if (utf8_name[0] == '.' &&
             (utf8_name[1] == '\0' ||
              (utf8_name[1] == '.' && utf8_name[2] == '\0'))) {
+               /* . or .. entries
+                *
+                * note: name_type is POSIX for these, so DOS names will not
+                * have been inserted for them.  */
                ret = 0;
                goto out_free_utf8_name;
        }
 
-       ctx = dirent;
-
+       /* Open the inode for this directory entry and recursively capture the
+        * directory tree rooted at it */
        ntfs_inode *ni = ntfs_inode_open(ctx->dir_ni->vol, mref);
        if (!ni) {
                ERROR_WITH_ERRNO("Failed to open NTFS inode");
@@ -462,62 +595,58 @@ static int wim_ntfs_capture_filldir(void *dirent, const ntfschar *name,
                ctx->path[path_len++] = '/';
        memcpy(ctx->path + path_len, utf8_name, utf8_name_len + 1);
        path_len += utf8_name_len;
+       child = NULL;
        ret = build_dentry_tree_ntfs_recursive(&child, ctx->dir_ni,
                                               ni, ctx->path, path_len, name_type,
                                               ctx->lookup_table, ctx->sd_set,
                                               ctx->config, ctx->ntfs_vol_p,
-                                              ctx->flags);
-
+                                              ctx->add_image_flags,
+                                              ctx->progress_func);
        if (child)
                dentry_add_child(ctx->parent, child);
-
        ntfs_inode_close(ni);
 out_free_utf8_name:
        FREE(utf8_name);
-out:
        return ret;
 }
 
-static int change_dentry_short_name(struct dentry *dentry,
-                                   const char short_name_utf8[],
-                                   int short_name_utf8_len)
-{
-       size_t short_name_utf16_len;
-       char *short_name_utf16;
-       short_name_utf16 = utf8_to_utf16(short_name_utf8, short_name_utf8_len,
-                                        &short_name_utf16_len);
-       if (!short_name_utf16) {
-               ERROR_WITH_ERRNO("Failed to convert short name to UTF-16");
-               return WIMLIB_ERR_NOMEM;
-       }
-       dentry->short_name = short_name_utf16;
-       dentry->short_name_len = short_name_utf16_len;
-       return 0;
-}
-
 /* Recursively build a WIM dentry tree corresponding to a NTFS volume.
  * At the same time, update the WIM lookup table with lookup table entries for
  * the NTFS streams, and build an array of security descriptors.
  */
-static int build_dentry_tree_ntfs_recursive(struct dentry **root_p,
+static int build_dentry_tree_ntfs_recursive(struct wim_dentry **root_p,
                                            ntfs_inode *dir_ni,
                                            ntfs_inode *ni,
                                            char path[],
                                            size_t path_len,
                                            int name_type,
-                                           struct lookup_table *lookup_table,
+                                           struct wim_lookup_table *lookup_table,
                                            struct sd_set *sd_set,
                                            const struct capture_config *config,
                                            ntfs_volume **ntfs_vol_p,
-                                           int flags)
+                                           int add_image_flags,
+                                           wimlib_progress_func_t progress_func)
 {
        u32 attributes;
-       int mrec_flags;
        int ret;
-       char dos_name_utf8[64];
-       struct dentry *root;
+       struct wim_dentry *root;
 
-       mrec_flags = ni->mrec->flags;
+       if (exclude_path(path, config, false)) {
+               /* Exclude a file or directory tree based on the capture
+                * configuration file */
+               if ((add_image_flags & WIMLIB_ADD_IMAGE_FLAG_VERBOSE)
+                   && progress_func)
+               {
+                       union wimlib_progress_info info;
+                       info.scan.cur_path = path;
+                       info.scan.excluded = true;
+                       progress_func(WIMLIB_PROGRESS_MSG_SCAN_DENTRY, &info);
+               }
+               *root_p = NULL;
+               return 0;
+       }
+
+       /* Get file attributes */
        struct SECURITY_CONTEXT ctx;
        memset(&ctx, 0, sizeof(ctx));
        ctx.vol = ni->vol;
@@ -530,82 +659,68 @@ static int build_dentry_tree_ntfs_recursive(struct dentry **root_p,
                return WIMLIB_ERR_NTFS_3G;
        }
 
-       if (exclude_path(path, config, false)) {
-               if (flags & WIMLIB_ADD_IMAGE_FLAG_VERBOSE) {
-                       const char *file_type;
-                       if (attributes & MFT_RECORD_IS_DIRECTORY)
-                               file_type = "directory";
-                       else
-                               file_type = "file";
-                       printf("Excluding %s `%s' from capture\n",
-                              file_type, path);
-               }
-               *root_p = NULL;
-               return 0;
+       if ((add_image_flags & WIMLIB_ADD_IMAGE_FLAG_VERBOSE)
+           && progress_func)
+       {
+               union wimlib_progress_info info;
+               info.scan.cur_path = path;
+               info.scan.excluded = false;
+               progress_func(WIMLIB_PROGRESS_MSG_SCAN_DENTRY, &info);
        }
 
-       if (flags & WIMLIB_ADD_IMAGE_FLAG_VERBOSE)
-               printf("Scanning `%s'\n", path);
-
+       /* Create the new WIM dentry */
        root = new_dentry_with_timeless_inode(path_basename(path));
-       if (!root)
-               return WIMLIB_ERR_NOMEM;
-       *root_p = root;
-
-       if (dir_ni && (name_type == FILE_NAME_WIN32_AND_DOS
-                      || name_type == FILE_NAME_WIN32))
-       {
-               ret = ntfs_get_ntfs_dos_name(ni, dir_ni, dos_name_utf8,
-                                            sizeof(dos_name_utf8));
-               if (ret > 0) {
-                       DEBUG("Changing short name of `%s'", path);
-                       ret = change_dentry_short_name(root, dos_name_utf8,
-                                                      ret);
-                       if (ret != 0)
-                               return ret;
-               } else {
-               #ifdef ENODATA
-                       if (errno != ENODATA) {
-                               ERROR_WITH_ERRNO("Error getting DOS name "
-                                                "of `%s'", path);
-                               return WIMLIB_ERR_NTFS_3G;
-                       }
-               #endif
-               }
+       if (!root) {
+               if (errno == EILSEQ)
+                       return WIMLIB_ERR_INVALID_UTF8_STRING;
+               else if (errno == ENOMEM)
+                       return WIMLIB_ERR_NOMEM;
+               else
+                       return WIMLIB_ERR_ICONV_NOT_AVAILABLE;
        }
+       *root_p = root;
 
-       root->d_inode->creation_time    = le64_to_cpu(ni->creation_time);
-       root->d_inode->last_write_time  = le64_to_cpu(ni->last_data_change_time);
-       root->d_inode->last_access_time = le64_to_cpu(ni->last_access_time);
-       root->d_inode->attributes       = le32_to_cpu(attributes);
-       root->d_inode->ino              = ni->mft_no;
-       root->d_inode->resolved         = true;
+       if (name_type & FILE_NAME_WIN32) /* Win32 or Win32+DOS name */
+               root->is_win32_name = 1;
+       root->d_inode->i_creation_time    = le64_to_cpu(ni->creation_time);
+       root->d_inode->i_last_write_time  = le64_to_cpu(ni->last_data_change_time);
+       root->d_inode->i_last_access_time = le64_to_cpu(ni->last_access_time);
+       root->d_inode->i_attributes       = le32_to_cpu(attributes);
+       root->d_inode->i_ino              = ni->mft_no;
+       root->d_inode->i_resolved         = 1;
 
        if (attributes & FILE_ATTR_REPARSE_POINT) {
                /* Junction point, symbolic link, or other reparse point */
                ret = capture_ntfs_streams(root, ni, path, path_len,
                                           lookup_table, ntfs_vol_p,
                                           AT_REPARSE_POINT);
-       } else if (mrec_flags & MFT_RECORD_IS_DIRECTORY) {
+       } else if (ni->mrec->flags & MFT_RECORD_IS_DIRECTORY) {
 
                /* Normal directory */
                s64 pos = 0;
+               struct dos_name_map dos_name_map = { .rb_root = {.rb_node = NULL} };
                struct readdir_ctx ctx = {
-                       .parent       = root,
-                       .dir_ni       = ni,
-                       .path         = path,
-                       .path_len     = path_len,
-                       .lookup_table = lookup_table,
-                       .sd_set       = sd_set,
-                       .config       = config,
-                       .ntfs_vol_p   = ntfs_vol_p,
-                       .flags        = flags,
+                       .parent          = root,
+                       .dir_ni          = ni,
+                       .path            = path,
+                       .path_len        = path_len,
+                       .lookup_table    = lookup_table,
+                       .sd_set          = sd_set,
+                       .dos_name_map    = &dos_name_map,
+                       .config          = config,
+                       .ntfs_vol_p      = ntfs_vol_p,
+                       .add_image_flags = add_image_flags,
+                       .progress_func   = progress_func,
                };
                ret = ntfs_readdir(ni, &pos, &ctx, wim_ntfs_capture_filldir);
-               if (ret != 0) {
+               if (ret) {
                        ERROR_WITH_ERRNO("ntfs_readdir()");
                        ret = WIMLIB_ERR_NTFS_3G;
+               } else {
+                       ret = for_dentry_child(root, set_dentry_dos_name,
+                                              &dos_name_map);
                }
+               destroy_dos_name_map(&dos_name_map);
        } else {
                /* Normal file */
                ret = capture_ntfs_streams(root, ni, path, path_len,
@@ -615,6 +730,7 @@ static int build_dentry_tree_ntfs_recursive(struct dentry **root_p,
        if (ret != 0)
                return ret;
 
+       /* Get security descriptor */
        char _sd[1];
        char *sd = _sd;
        errno = 0;
@@ -627,45 +743,52 @@ static int build_dentry_tree_ntfs_recursive(struct dentry **root_p,
                                                 ni, dir_ni, sd, ret);
        }
        if (ret > 0) {
-               root->d_inode->security_id = sd_set_add_sd(sd_set, sd, ret);
-               if (root->d_inode->security_id == -1) {
+               root->d_inode->i_security_id = sd_set_add_sd(sd_set, sd, ret);
+               if (root->d_inode->i_security_id == -1) {
                        ERROR("Out of memory");
                        return WIMLIB_ERR_NOMEM;
                }
                DEBUG("Added security ID = %u for `%s'",
-                     root->d_inode->security_id, path);
+                     root->d_inode->i_security_id, path);
                ret = 0;
        } else if (ret < 0) {
                ERROR_WITH_ERRNO("Failed to get security information from "
                                 "`%s'", path);
                ret = WIMLIB_ERR_NTFS_3G;
        } else {
-               root->d_inode->security_id = -1;
+               root->d_inode->i_security_id = -1;
                DEBUG("No security ID for `%s'", path);
        }
        return ret;
 }
 
-static int build_dentry_tree_ntfs(struct dentry **root_p,
-                                 const char *device,
-                                 struct lookup_table *lookup_table,
-                                 struct wim_security_data *sd,
-                                 const struct capture_config *config,
-                                 int flags,
-                                 void *extra_arg)
+int build_dentry_tree_ntfs(struct wim_dentry **root_p,
+                          const char *device,
+                          struct wim_lookup_table *lookup_table,
+                          struct wim_security_data *sd,
+                          const struct capture_config *config,
+                          int add_image_flags,
+                          wimlib_progress_func_t progress_func,
+                          void *extra_arg)
 {
        ntfs_volume *vol;
        ntfs_inode *root_ni;
-       int ret = 0;
+       int ret;
        struct sd_set sd_set = {
                .sd = sd,
-               .root = NULL,
+               .rb_root = {NULL},
        };
        ntfs_volume **ntfs_vol_p = extra_arg;
 
        DEBUG("Mounting NTFS volume `%s' read-only", device);
 
+#ifdef HAVE_NTFS_MNT_RDONLY
+       /* NTFS-3g 2013 */
+       vol = ntfs_mount(device, NTFS_MNT_RDONLY);
+#else
+       /* NTFS-3g 2011, 2012 */
        vol = ntfs_mount(device, MS_RDONLY);
+#endif
        if (!vol) {
                ERROR_WITH_ERRNO("Failed to mount NTFS volume `%s' read-only",
                                 device);
@@ -692,6 +815,7 @@ static int build_dentry_tree_ntfs(struct dentry **root_p,
        char *path = MALLOC(32768);
        if (!path) {
                ERROR("Could not allocate memory for NTFS pathname");
+               ret = WIMLIB_ERR_NOMEM;
                goto out_cleanup;
        }
 
@@ -699,14 +823,19 @@ static int build_dentry_tree_ntfs(struct dentry **root_p,
        path[1] = '\0';
        ret = build_dentry_tree_ntfs_recursive(root_p, NULL, root_ni, path, 1,
                                               FILE_NAME_POSIX, lookup_table,
-                                              &sd_set, config, ntfs_vol_p,
-                                              flags);
+                                              &sd_set,
+                                              config, ntfs_vol_p,
+                                              add_image_flags,
+                                              progress_func);
 out_cleanup:
        FREE(path);
        ntfs_inode_close(root_ni);
        destroy_sd_set(&sd_set);
-
 out:
+       ntfs_index_ctx_put(vol->secure_xsii);
+       ntfs_index_ctx_put(vol->secure_xsdh);
+       ntfs_inode_close(vol->secure_ni);
+
        if (ret) {
                if (ntfs_umount(vol, FALSE) != 0) {
                        ERROR_WITH_ERRNO("Failed to unmount NTFS volume `%s'",
@@ -721,34 +850,3 @@ out:
        }
        return ret;
 }
-
-
-
-WIMLIBAPI int wimlib_add_image_from_ntfs_volume(WIMStruct *w,
-                                               const char *device,
-                                               const char *name,
-                                               const char *config_str,
-                                               size_t config_len,
-                                               int flags)
-{
-       if (flags & (WIMLIB_ADD_IMAGE_FLAG_DEREFERENCE)) {
-               ERROR("Cannot dereference files when capturing directly from NTFS");
-               return WIMLIB_ERR_INVALID_PARAM;
-       }
-       return do_add_image(w, device, name, config_str, config_len, flags,
-                           build_dentry_tree_ntfs, &w->ntfs_vol);
-}
-
-#else /* WITH_NTFS_3G */
-WIMLIBAPI int wimlib_add_image_from_ntfs_volume(WIMStruct *w,
-                                               const char *device,
-                                               const char *name,
-                                               const char *config_str,
-                                               size_t config_len,
-                                               int flags)
-{
-       ERROR("wimlib was compiled without support for NTFS-3g, so");
-       ERROR("we cannot capture a WIM image directly from a NTFS volume");
-       return WIMLIB_ERR_UNSUPPORTED;
-}
-#endif /* WITH_NTFS_3G */