]> wimlib.net Git - wimlib/blobdiff - src/ntfs-apply.c
Misc fixes
[wimlib] / src / ntfs-apply.c
index 3ac622919c683c674859777d0a20c0bff0fcd96f..4118a30af74dac5fc5e3f626c39d03aa86ae5a69 100644 (file)
@@ -49,9 +49,9 @@ struct ntfs_apply_args {
        WIMStruct *w;
 };
 
-extern int _ntfs_set_file_security(ntfs_inode *ni, u32 selection,
+extern int ntfs_inode_set_security(ntfs_inode *ni, u32 selection,
                                   const char *attr);
-extern int _ntfs_set_file_attributes(ntfs_inode *ni, s32 attrib);
+extern int ntfs_inode_set_attributes(ntfs_inode *ni, s32 attrib);
 
 /* 
  * Extracts a WIM resource to a NTFS attribute.
@@ -85,7 +85,7 @@ extract_wim_resource_to_ntfs_attr(const struct lookup_table_entry *lte,
        sha1_final(hash, &ctx);
        if (!hashes_equal(hash, lte->hash)) {
                ERROR("Invalid checksum on a WIM resource "
-                     "(detected when extracting to NTFS stream file)");
+                     "(detected when extracting to NTFS stream)");
                ERROR("The following WIM resource is invalid:");
                print_lookup_table_entry(lte);
                return WIMLIB_ERR_INVALID_RESOURCE_HASH;
@@ -141,6 +141,15 @@ static int write_ntfs_data_streams(ntfs_inode *ni, const struct dentry *dentry,
        return ret;
 }
 
+static bool in_same_dir(const char *path1, const char *path2)
+{
+       const char *p1 = strrchr(path1, '/');
+       const char *p2 = strrchr(path2, '/');
+       if (p1 - path1 != p2 - path2)
+               return false;
+       return memcmp(path1, path2,  p1 - path1) == 0;
+}
+
 /*
  * Makes a NTFS hard link
  *
@@ -156,21 +165,52 @@ static int wim_apply_hardlink_ntfs(const struct dentry *from_dentry,
                                   ntfs_inode **to_ni_ret)
 {
        int ret;
+       char *p;
+       char orig;
+       const char *dir_name;
+
        ntfs_inode *to_ni;
+       ntfs_volume *vol;
 
        wimlib_assert(dentry_is_regular_file(from_dentry)
                        && dentry_is_regular_file(to_dentry));
 
+       if (ntfs_inode_close(dir_ni) != 0) {
+               ERROR_WITH_ERRNO("Error closing directory");
+               return WIMLIB_ERR_NTFS_3G;
+       }
+
+       vol = dir_ni->vol;
+
        DEBUG("Extracting NTFS hard link `%s' => `%s'",
              from_dentry->full_path_utf8, to_dentry->extracted_file);
 
-       to_ni = ntfs_pathname_to_inode(dir_ni->vol, NULL,
+       to_ni = ntfs_pathname_to_inode(vol, NULL,
                                       to_dentry->extracted_file);
        if (!to_ni) {
                ERROR_WITH_ERRNO("Could not find NTFS inode for `%s'",
                                 to_dentry->extracted_file);
                return WIMLIB_ERR_NTFS_3G;
        }
+       p = from_dentry->full_path_utf8 + from_dentry->full_path_utf8_len;
+       do {
+               p--;
+       } while (*p != '/');
+
+       orig = *p;
+       *p = '\0';
+       dir_name = from_dentry->full_path_utf8;
+
+       dir_ni = ntfs_pathname_to_inode(vol, NULL,
+                                       from_dentry->full_path_utf8);
+       if (!dir_ni) {
+               ERROR_WITH_ERRNO("Could not find NTFS inode for `%s'",
+                                from_dentry->full_path_utf8);
+               *p = orig;
+               return WIMLIB_ERR_NTFS_3G;
+       }
+       *p = orig;
+
        ret = ntfs_link(to_ni, dir_ni,
                        (ntfschar*)from_dentry->file_name,
                        from_dentry->file_name_len / 2);
@@ -191,7 +231,7 @@ apply_file_attributes_and_security_data(ntfs_inode *ni,
 {
        DEBUG("Setting NTFS file attributes on `%s' to %#"PRIx32,
              dentry->full_path_utf8, dentry->attributes);
-       if (!_ntfs_set_file_attributes(ni, dentry->attributes)) {
+       if (!ntfs_inode_set_attributes(ni, dentry->attributes)) {
                ERROR("Failed to set NTFS file attributes on `%s'",
                       dentry->full_path_utf8);
                return WIMLIB_ERR_NTFS_3G;
@@ -209,7 +249,7 @@ apply_file_attributes_and_security_data(ntfs_inode *ni,
                                DACL_SECURITY_INFORMATION  |
                                SACL_SECURITY_INFORMATION;
                                
-               if (!_ntfs_set_file_security(ni, selection,
+               if (!ntfs_inode_set_security(ni, selection,
                                             sd->descriptors[dentry->security_id]))
                {
                        ERROR_WITH_ERRNO("Failed to set security data on `%s'",
@@ -230,6 +270,8 @@ static int apply_reparse_data(ntfs_inode *ni, const struct dentry *dentry,
 
        lte = dentry_first_lte(dentry, w->lookup_table);
 
+       DEBUG("Applying reparse data to `%s'", dentry->full_path_utf8);
+
        if (!lte) {
                ERROR("Could not find reparse data for `%s'",
                      dentry->full_path_utf8);
@@ -305,7 +347,8 @@ static int preapply_dentry_with_dos_name(struct dentry *dentry,
                char orig;
                ntfs_volume *vol = (*dir_ni_p)->vol;
 
-               DEBUG("pre-applying DOS name `%s'", dentry_with_dos_name);
+               DEBUG("pre-applying DOS name `%s'",
+                     dentry_with_dos_name->full_path_utf8);
                ret = do_wim_apply_dentry_ntfs(dentry_with_dos_name,
                                               *dir_ni_p, w);
                if (ret != 0)
@@ -353,6 +396,8 @@ static int do_wim_apply_dentry_ntfs(struct dentry *dentry, ntfs_inode *dir_ni,
        } else {
                struct dentry *other;
 
+               /* Apply hard-linked directory in same directory with DOS name
+                * (if there is one) before this dentry */
                ret = preapply_dentry_with_dos_name(dentry, &dir_ni, w);
                if (ret != 0)
                        return ret;
@@ -362,13 +407,19 @@ static int do_wim_apply_dentry_ntfs(struct dentry *dentry, ntfs_inode *dir_ni,
                list_for_each_entry(other, &dentry->link_group_list,
                                    link_group_list) {
                        if (other->extracted_file) {
+                               /* Already extracted another dentry in the hard
+                                * link group.  We can make a hard link instead
+                                * of extracting the file data. */
                                ret = wim_apply_hardlink_ntfs(dentry, other,
                                                              dir_ni, &ni);
+                               is_hardlink = true;
                                if (ret != 0)
-                                       return ret;
+                                       goto out_close_dir_ni;
+                               else
+                                       goto out_set_dos_name;
                        }
                }
-               /* Can't make a hard link */
+               /* Can't make a hard link; extract the file itself */
                FREE(dentry->extracted_file);
                dentry->extracted_file = STRDUP(dentry->full_path_utf8);
                if (!dentry->extracted_file) {
@@ -617,6 +668,7 @@ static int do_wim_apply_image_ntfs(WIMStruct *w, const char *device, int extract
        ntfs_volume *vol;
        int ret;
        
+       DEBUG("Mounting NTFS volume `%s'", device);
        vol = ntfs_mount(device, 0);
        if (!vol) {
                ERROR_WITH_ERRNO("Failed to mount NTFS volume `%s'", device);
@@ -637,6 +689,7 @@ static int do_wim_apply_image_ntfs(WIMStruct *w, const char *device, int extract
                                       wim_apply_dentry_timestamps,
                                       &args);
 out:
+       DEBUG("Unmounting NTFS volume `%s'", device);
        if (ntfs_umount(vol, FALSE) != 0) {
                ERROR_WITH_ERRNO("Failed to unmount NTFS volume `%s'", device);
                if (ret == 0)
@@ -674,16 +727,6 @@ WIMLIBAPI int wimlib_apply_image_to_ntfs_volume(WIMStruct *w, int image,
        if (ret != 0)
                return ret;
 
-#if 0
-       if (getuid() != 0) {
-               ERROR("We are not root, but NTFS-3g requires root privileges to set arbitrary");
-               ERROR("security data on the NTFS filesystem.  Please run this program as root");
-               ERROR("if you want to extract a WIM image while preserving NTFS-specific");
-               ERROR("information.");
-
-               return WIMLIB_ERR_NOT_ROOT;
-       }
-#endif
        return do_wim_apply_image_ntfs(w, device, flags);
 }