]> wimlib.net Git - wimlib/blobdiff - src/ntfs-3g_capture.c
ntfs-3g_capture.c: Fix erroneous replacement
[wimlib] / src / ntfs-3g_capture.c
index 8d5d4c63b31aa8a863924f23c7c0bf93e1a29be8..92f3b7e1eb72b240921d81ac7ccde8d5dce86f4f 100644 (file)
@@ -75,12 +75,8 @@ open_ntfs_attr(ntfs_inode *ni, struct ntfs_location *loc)
 }
 
 int
-read_ntfs_file_prefix(const struct wim_lookup_table_entry *lte,
-                     u64 size,
-                     consume_data_callback_t cb,
-                     u32 in_chunk_size,
-                     void *ctx_or_buf,
-                     int _ignored_flags)
+read_ntfs_file_prefix(const struct wim_lookup_table_entry *lte, u64 size,
+                     consume_data_callback_t cb, void *cb_ctx)
 {
        struct ntfs_location *loc = lte->ntfs_loc;
        ntfs_volume *vol = loc->ntfs_vol;
@@ -88,12 +84,10 @@ read_ntfs_file_prefix(const struct wim_lookup_table_entry *lte,
        ntfs_attr *na;
        s64 pos;
        s64 bytes_remaining;
-       void *out_buf;
-       bool out_buf_malloced;
        int ret;
-       size_t stack_max = 32768;
+       u8 buf[BUFFER_SIZE];
 
-       ni = ntfs_pathname_to_inode(vol, NULL, loc->path);
+       ni = ntfs_pathname_to_inode(vol, NULL, loc->path);
        if (!ni) {
                ERROR_WITH_ERRNO("Can't find NTFS inode for \"%"TS"\"", loc->path);
                ret = WIMLIB_ERR_NTFS_3G;
@@ -106,44 +100,22 @@ read_ntfs_file_prefix(const struct wim_lookup_table_entry *lte,
                goto out_close_ntfs_inode;
        }
 
-       out_buf_malloced = false;
-       if (cb) {
-               if (in_chunk_size <= stack_max) {
-                       out_buf = alloca(in_chunk_size);
-               } else {
-                       out_buf = MALLOC(in_chunk_size);
-                       if (out_buf == NULL) {
-                               ret = WIMLIB_ERR_NOMEM;
-                               goto out_close_ntfs_attr;
-                       }
-                       out_buf_malloced = true;
-               }
-       } else {
-               out_buf = ctx_or_buf;
-       }
        pos = (loc->is_reparse_point) ? 8 : 0;
        bytes_remaining = size;
        while (bytes_remaining) {
-               s64 to_read = min(bytes_remaining, in_chunk_size);
-               if (ntfs_attr_pread(na, pos, to_read, out_buf) != to_read) {
+               s64 to_read = min(bytes_remaining, sizeof(buf));
+               if (ntfs_attr_pread(na, pos, to_read, buf) != to_read) {
                        ERROR_WITH_ERRNO("Error reading \"%"TS"\"", loc->path);
                        ret = WIMLIB_ERR_NTFS_3G;
-                       goto out_free_memory;
+                       goto out_close_ntfs_attr;
                }
                pos += to_read;
                bytes_remaining -= to_read;
-               if (cb) {
-                       ret = cb(out_buf, to_read, ctx_or_buf);
-                       if (ret)
-                               goto out_free_memory;
-               } else {
-                       out_buf += to_read;
-               }
+               ret = cb(buf, to_read, cb_ctx);
+               if (ret)
+                       goto out_close_ntfs_attr;
        }
        ret = 0;
-out_free_memory:
-       if (out_buf_malloced)
-               FREE(out_buf);
 out_close_ntfs_attr:
        ntfs_attr_close(na);
 out_close_ntfs_inode:
@@ -199,7 +171,7 @@ capture_ntfs_streams(struct wim_inode *inode,
        int ret;
        struct wim_lookup_table_entry *lte;
 
-       DEBUG2("Capturing NTFS data streams from `%s'", path);
+       DEBUG("Capturing NTFS data streams from `%s'", path);
 
        /* Get context to search the streams of the NTFS file. */
        actx = ntfs_attr_get_search_ctx(ni, NULL);
@@ -259,14 +231,14 @@ capture_ntfs_streams(struct wim_inode *inode,
                                        goto out_free_lte;
                                }
                                lte->ntfs_loc->is_reparse_point = true;
-                               lte->resource_entry.original_size = data_size - 8;
+                               lte->size = data_size - 8;
                                ret = read_reparse_tag(ni, lte->ntfs_loc,
                                                       &inode->i_reparse_tag);
                                if (ret)
                                        goto out_free_lte;
                        } else {
                                lte->ntfs_loc->is_reparse_point = false;
-                               lte->resource_entry.original_size = data_size;
+                               lte->size = data_size;
                        }
                }
                if (name_length == 0) {
@@ -276,8 +248,8 @@ capture_ntfs_streams(struct wim_inode *inode,
                                if (lte) {
                                        ERROR("Found two un-named data streams for \"%s\" "
                                              "(sizes = %"PRIu64", %"PRIu64")",
-                                             path, wim_resource_size(inode->i_lte),
-                                             wim_resource_size(lte));
+                                             path, inode->i_lte->size,
+                                             lte->size);
                                        ret = WIMLIB_ERR_NTFS_3G;
                                        goto out_free_lte;
                                }
@@ -324,7 +296,7 @@ out_free_ntfs_loc:
 out_put_actx:
        ntfs_attr_put_search_ctx(actx);
        if (ret == 0)
-               DEBUG2("Successfully captured NTFS streams from \"%s\"", path);
+               DEBUG("Successfully captured NTFS streams from \"%s\"", path);
        else
                ERROR("Failed to capture NTFS streams from \"%s\"", path);
        return ret;
@@ -563,17 +535,14 @@ build_dentry_tree_ntfs_recursive(struct wim_dentry **root_ret,
        le32 attributes;
        int ret;
        struct wim_dentry *root = NULL;
-       struct wim_inode *inode;
+       struct wim_inode *inode = NULL;
        ATTR_TYPES stream_type;
 
-       params->progress.scan.cur_path = path;
-
        if (exclude_path(path, path_len, params->config, false)) {
                /* Exclude a file or directory tree based on the capture
-                * configuration file */
-               do_capture_progress(params, WIMLIB_SCAN_DENTRY_EXCLUDED);
+                * configuration file.  */
                ret = 0;
-               goto out;
+               goto out_progress;
        }
 
        /* Get file attributes */
@@ -593,13 +562,12 @@ build_dentry_tree_ntfs_recursive(struct wim_dentry **root_ret,
                        ret = WIMLIB_ERR_UNSUPPORTED_FILE;
                        goto out;
                }
-               do_capture_progress(params, WIMLIB_SCAN_DENTRY_UNSUPPORTED);
+               params->progress.scan.cur_path = path;
+               do_capture_progress(params, WIMLIB_SCAN_DENTRY_UNSUPPORTED, NULL);
                ret = 0;
                goto out;
        }
 
-       do_capture_progress(params, WIMLIB_SCAN_DENTRY_OK);
-
        /* Create a WIM dentry with an associated inode, which may be shared */
        ret = inode_table_new_dentry(&params->inode_table,
                                     path_basename_with_len(path, path_len),
@@ -615,7 +583,7 @@ build_dentry_tree_ntfs_recursive(struct wim_dentry **root_ret,
        if (inode->i_nlink > 1) {
                /* Shared inode; nothing more to do */
                ret = 0;
-               goto out;
+               goto out_progress;
        }
 
        inode->i_creation_time    = le64_to_cpu(ni->creation_time);
@@ -666,6 +634,7 @@ build_dentry_tree_ntfs_recursive(struct wim_dentry **root_ret,
                if (ret)
                        goto out;
        }
+       path[path_len] = '\0';
 
        /* Reparse-point fixups are a no-op because in NTFS-3g capture mode we
         * only allow capturing an entire volume. */
@@ -709,6 +678,15 @@ build_dentry_tree_ntfs_recursive(struct wim_dentry **root_ret,
                        DEBUG("No security ID for `%s'", path);
                }
        }
+       if (ret)
+               goto out;
+
+out_progress:
+       params->progress.scan.cur_path = path;
+       if (root == NULL)
+               do_capture_progress(params, WIMLIB_SCAN_DENTRY_EXCLUDED, NULL);
+       else
+               do_capture_progress(params, WIMLIB_SCAN_DENTRY_OK, inode);
 out:
        if (ret == 0)
                *root_ret = root;