# include "config.h"
#endif
+#include <errno.h>
#include <locale.h>
#include <string.h>
* moving the empty SACL earlier in the security descriptor or by removing the
* SACL entirely. The latter work-around is valid because an empty SACL is
* equivalent to a "null", or non-existent, SACL.
- * - Versions up to and including 2013.1.13 reject security descriptors ending
- * with an empty DACL (Discretionary Access Control List). This is very
- * similar to the SACL bug and should be fixed in the next release after
- * 2013.1.13. However, removing the DACL is not a valid workaround because
- * this changes the meaning of the security descriptor--- an empty DACL allows
- * no access, whereas a "null" DACL allows all access.
+ * - Versions before 2014.2.15 reject security descriptors ending with an empty
+ * DACL (Discretionary Access Control List). This is very similar to the SACL
+ * bug. However, removing the DACL is not a valid workaround because this
+ * changes the meaning of the security descriptor--- an empty DACL allows no
+ * access, whereas a "null" DACL allows all access.
*
* If the security descriptor was fixed, this function returns an allocated
* buffer containing the fixed security descriptor, and its size is updated.
- * Otherwise (or if no memory is available) the original descriptor is returned.
+ * Otherwise (or if no memory is available) NULL is returned.
*/
-static u8 *
-sd_fixup(const u8 *_desc, size_t *size_p)
+static void *
+sd_fixup(const void *_desc, size_t *size_p)
{
- u32 owner_offset, group_offset, dacl_offset;
-#if !defined(HAVE_NTFS_MNT_RDONLY)
- u32 sacl_offset;
-#endif
+ u32 owner_offset, group_offset, dacl_offset, sacl_offset;
bool owner_valid, group_valid;
size_t size = *size_p;
- const wimlib_SECURITY_DESCRIPTOR_RELATIVE *desc =
- (const wimlib_SECURITY_DESCRIPTOR_RELATIVE*)_desc;
+ const wimlib_SECURITY_DESCRIPTOR_RELATIVE *desc = _desc;
wimlib_SECURITY_DESCRIPTOR_RELATIVE *desc_new;
const wimlib_SID *owner, *group, *sid;
/* Don't attempt to fix clearly invalid security descriptors. */
if (size < sizeof(wimlib_SECURITY_DESCRIPTOR_RELATIVE))
- return (u8*)_desc;
+ return NULL;
if (le16_to_cpu(desc->control) & wimlib_SE_DACL_PRESENT)
dacl_offset = le32_to_cpu(desc->dacl_offset);
else
dacl_offset = 0;
-#if !defined(HAVE_NTFS_MNT_RDONLY)
if (le16_to_cpu(desc->control) & wimlib_SE_SACL_PRESENT)
sacl_offset = le32_to_cpu(desc->sacl_offset);
else
sacl_offset = 0;
-#endif
/* Check if the security descriptor will be affected by one of the bugs.
- * If not, do nothing and return.
- *
- * Note: HAVE_NTFS_MNT_RDONLY is defined if libntfs-3g is
- * version 2013.1.13 or later. */
- if (!(
- #if !defined(HAVE_NTFS_MNT_RDONLY)
- (sacl_offset != 0 && sacl_offset == size - sizeof(wimlib_ACL)) ||
- #endif
- (dacl_offset != 0 && dacl_offset == size - sizeof(wimlib_ACL))))
- return (u8*)_desc;
+ * If not, do nothing and return. */
+ if (!((sacl_offset != 0 && sacl_offset == size - sizeof(wimlib_ACL)) ||
+ (dacl_offset != 0 && dacl_offset == size - sizeof(wimlib_ACL))))
+ return NULL;
owner_offset = le32_to_cpu(desc->owner_offset);
group_offset = le32_to_cpu(desc->group_offset);
} else if (group_valid) {
sid = group;
} else {
- return (u8*)_desc;
+ return NULL;
}
desc_new = MALLOC(size + sid_size(sid));
if (!desc_new)
- return (u8*)_desc;
+ return NULL;
memcpy(desc_new, desc, size);
if (owner_valid)
desc_new->group_offset = cpu_to_le32(size);
memcpy((u8*)desc_new + size, sid, sid_size(sid));
*size_p = size + sid_size(sid);
- return (u8*)desc_new;
+ return desc_new;
}
/* Set the security descriptor @desc of size @desc_size on the NTFS inode @ni.
ntfs_3g_set_security_descriptor(ntfs_inode *ni, const void *desc, size_t desc_size)
{
struct SECURITY_CONTEXT sec_ctx;
- u8 *desc_fixed;
+ void *desc_fixed = NULL;
int ret = 0;
memset(&sec_ctx, 0, sizeof(sec_ctx));
sec_ctx.vol = ni->vol;
- desc_fixed = sd_fixup(desc, &desc_size);
-
- if (ntfs_set_ntfs_acl(&sec_ctx, ni, desc_fixed, desc_size, 0))
+retry:
+ if (ntfs_set_ntfs_acl(&sec_ctx, ni, desc, desc_size, 0)) {
+ if (desc_fixed == NULL) {
+ desc_fixed = sd_fixup(desc, &desc_size);
+ if (desc_fixed != NULL) {
+ desc = desc_fixed;
+ goto retry;
+ }
+ }
ret = WIMLIB_ERR_SET_SECURITY;
+ }
- if (desc_fixed != desc)
- FREE(desc_fixed);
-
+ FREE(desc_fixed);
return ret;
}
desc_size = sd->sizes[inode->i_security_id];
ret = ntfs_3g_set_security_descriptor(ni, desc, desc_size);
- if (ret) {
- if (wimlib_print_errors) {
- ERROR_WITH_ERRNO("Failed to set security descriptor "
- "on \"%s\" in NTFS volume",
- dentry_full_path(one_dentry));
+
+ if (unlikely(ret)) {
+ int err = errno;
+ ERROR_WITH_ERRNO("Failed to set security descriptor on "
+ "\"%s\" in NTFS volume",
+ dentry_full_path(one_dentry));
+ if (err == EINVAL && wimlib_print_errors) {
fprintf(wimlib_error_file,
"The security descriptor is: ");
print_byte_field(desc, desc_size, wimlib_error_file);
fprintf(wimlib_error_file, "\n");
+ fprintf(wimlib_error_file,
+ "\nThis error occurred because libntfs-3g thinks "
+ "the security descriptor is invalid. If you "
+ "are extracting a Windows 10 image, this may be "
+ "caused by a known bug in libntfs-3g. See: "
+ "http://wimlib.net/forums/viewtopic.php?f=1&t=4 "
+ "for more information.\n\n");
}
return ret;
}
struct ntfs_3g_apply_ctx *ctx)
{
struct wim_dentry *one_dentry = inode_first_extraction_dentry(inode);
+ ntfschar *stream_name;
size_t stream_name_nchars;
ntfs_attr *attr;
/* It's a data stream (may be unnamed or named). */
wimlib_assert(strm->stream_type == STREAM_TYPE_DATA);
- stream_name_nchars = utf16le_len_chars(strm->stream_name);
+ if (unlikely(stream_is_named(strm))) {
+ stream_name = strm->stream_name;
+ stream_name_nchars = utf16le_len_chars(stream_name);
- if (stream_name_nchars &&
- (ntfs_attr_add(ni, AT_DATA, strm->stream_name,
- stream_name_nchars, NULL, 0)))
- {
- ERROR_WITH_ERRNO("Failed to create named data stream of \"%s\"",
- dentry_full_path(one_dentry));
- return WIMLIB_ERR_NTFS_3G;
+ if (ntfs_attr_add(ni, AT_DATA, stream_name,
+ stream_name_nchars, NULL, 0))
+ {
+ ERROR_WITH_ERRNO("Failed to create named data stream of \"%s\"",
+ dentry_full_path(one_dentry));
+ return WIMLIB_ERR_NTFS_3G;
+ }
+ } else {
+ /* Don't pass an empty string other than AT_UNNAMED to
+ * ntfs_attr_open() --- it violates assumptions made by
+ * libntfs-3g. */
+ stream_name = AT_UNNAMED;
+ stream_name_nchars = 0;
}
/* This should be ensured by extract_blob_list() */
wimlib_assert(ctx->num_open_attrs < MAX_OPEN_FILES);
- attr = ntfs_attr_open(ni, AT_DATA, strm->stream_name,
- stream_name_nchars);
+ attr = ntfs_attr_open(ni, AT_DATA, stream_name, stream_name_nchars);
if (!attr) {
ERROR_WITH_ERRNO("Failed to open data stream of \"%s\"",
dentry_full_path(one_dentry));
git://wimlib.net / wimlib / blobdiff