]> wimlib.net Git - wimlib/blobdiff - src/lookup_table.c
Merge branch 'new_extract'
[wimlib] / src / lookup_table.c
index 47f6195a41fd0138ea7e6e28d6f3d35ebb09b13d..1950ab21a89bbbefb75fc56473ce64936d12753c 100644 (file)
@@ -6,7 +6,7 @@
  */
 
 /*
- * Copyright (C) 2012, 2013 Eric Biggers
+ * Copyright (C) 2012, 2013, 2014 Eric Biggers
  *
  * This file is part of wimlib, a library for working with WIM files.
  *
@@ -94,17 +94,11 @@ do_free_lookup_table_entry(struct wim_lookup_table_entry *entry, void *ignore)
 void
 free_lookup_table(struct wim_lookup_table *table)
 {
-       DEBUG("Freeing lookup table.");
-       if (table == NULL)
-               return;
-
-       if (table->array) {
-               for_lookup_table_entry(table,
-                                      do_free_lookup_table_entry,
-                                      NULL);
+       if (table) {
+               for_lookup_table_entry(table, do_free_lookup_table_entry, NULL);
                FREE(table->array);
+               FREE(table);
        }
-       FREE(table);
 }
 
 struct wim_lookup_table_entry *
@@ -133,7 +127,6 @@ clone_lookup_table_entry(const struct wim_lookup_table_entry *old)
        if (new == NULL)
                return NULL;
 
-       new->extracted_file = NULL;
        switch (new->resource_location) {
        case RESOURCE_IN_WIM:
                list_add(&new->rspec_node, &new->rspec->stream_list);
@@ -141,6 +134,7 @@ clone_lookup_table_entry(const struct wim_lookup_table_entry *old)
 
        case RESOURCE_IN_FILE_ON_DISK:
 #ifdef __WIN32__
+       case RESOURCE_IN_WINNT_FILE_ON_DISK:
        case RESOURCE_WIN32_ENCRYPTED:
 #endif
 #ifdef WITH_FUSE
@@ -200,6 +194,7 @@ lte_put_resource(struct wim_lookup_table_entry *lte)
                break;
        case RESOURCE_IN_FILE_ON_DISK:
 #ifdef __WIN32__
+       case RESOURCE_IN_WINNT_FILE_ON_DISK:
        case RESOURCE_WIN32_ENCRYPTED:
 #endif
 #ifdef WITH_FUSE
@@ -429,7 +424,7 @@ cmp_streams_by_sequential_order(const void *p1, const void *p2)
 
                /* Different (possibly split) WIMs?  */
                if (wim1 != wim2) {
-                       v = memcmp(wim1->hdr.guid, wim2->hdr.guid, WIM_GID_LEN);
+                       v = memcmp(wim1->hdr.guid, wim2->hdr.guid, WIM_GUID_LEN);
                        if (v)
                                return v;
                }
@@ -450,6 +445,7 @@ cmp_streams_by_sequential_order(const void *p1, const void *p2)
        case RESOURCE_IN_STAGING_FILE:
 #endif
 #ifdef __WIN32__
+       case RESOURCE_IN_WINNT_FILE_ON_DISK:
        case RESOURCE_WIN32_ENCRYPTED:
 #endif
                /* Compare files by path: just a heuristic that will place files
@@ -578,6 +574,182 @@ struct wim_lookup_table_entry_disk {
 
 #define WIM_LOOKUP_TABLE_ENTRY_DISK_SIZE 50
 
+/* Given a nonempty run of consecutive lookup table entries with the
+ * PACKED_STREAMS flag set, count how many specify resources (as opposed to
+ * streams within those resources).
+ *
+ * Returns the resulting count.  */
+static size_t
+count_subpacks(const struct wim_lookup_table_entry_disk *entries, size_t max)
+{
+       size_t count = 0;
+       do {
+               struct wim_reshdr reshdr;
+
+               get_wim_reshdr(&(entries++)->reshdr, &reshdr);
+
+               if (!(reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS)) {
+                       /* Run was terminated by a stand-alone stream entry.  */
+                       break;
+               }
+
+               if (reshdr.uncompressed_size == WIM_PACK_MAGIC_NUMBER) {
+                       /* This is a resource entry.  */
+                       count++;
+               }
+       } while (--max);
+       return count;
+}
+
+/* Given a run of consecutive lookup table entries with the PACKED_STREAMS flag
+ * set and having @num_subpacks resource entries, load resource information from
+ * them into the resource specifications in the @subpacks array.
+ *
+ * Returns 0 on success, or a nonzero error code on failure.  */
+static int
+do_load_subpack_info(WIMStruct *wim, struct wim_resource_spec **subpacks,
+                    size_t num_subpacks,
+                    const struct wim_lookup_table_entry_disk *entries)
+{
+       for (size_t i = 0; i < num_subpacks; i++) {
+               struct wim_reshdr reshdr;
+               struct alt_chunk_table_header_disk hdr;
+               struct wim_resource_spec *rspec;
+               int ret;
+
+               /* Advance to next resource entry.  */
+
+               do {
+                       get_wim_reshdr(&(entries++)->reshdr, &reshdr);
+               } while (reshdr.uncompressed_size != WIM_PACK_MAGIC_NUMBER);
+
+               rspec = subpacks[i];
+
+               wim_res_hdr_to_spec(&reshdr, wim, rspec);
+
+               /* For packed resources, the uncompressed size, compression
+                * type, and chunk size are stored in the resource itself, not
+                * in the lookup table.  */
+
+               ret = full_pread(&wim->in_fd, &hdr,
+                                sizeof(hdr), reshdr.offset_in_wim);
+               if (ret) {
+                       ERROR("Failed to read header of packed resource "
+                             "(offset_in_wim=%"PRIu64")",
+                             reshdr.offset_in_wim);
+                       return ret;
+               }
+
+               rspec->uncompressed_size = le64_to_cpu(hdr.res_usize);
+
+               /* Compression format numbers must be the same as in
+                * WIMGAPI to be compatible here.  */
+               BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_NONE != 0);
+               BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_XPRESS != 1);
+               BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_LZX != 2);
+               BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_LZMS != 3);
+               rspec->compression_type = le32_to_cpu(hdr.compression_format);
+
+               rspec->chunk_size = le32_to_cpu(hdr.chunk_size);
+
+               DEBUG("Subpack %zu/%zu: %"PRIu64" => %"PRIu64" "
+                     "(%"TS"/%"PRIu32") @ +%"PRIu64"",
+                     i + 1, num_subpacks,
+                     rspec->uncompressed_size,
+                     rspec->size_in_wim,
+                     wimlib_get_compression_type_string(rspec->compression_type),
+                     rspec->chunk_size,
+                     rspec->offset_in_wim);
+
+       }
+       return 0;
+}
+
+/* Given a nonempty run of consecutive lookup table entries with the
+ * PACKED_STREAMS flag set, allocate a 'struct wim_resource_spec' for each
+ * resource within that run.
+ *
+ * Returns 0 on success, or a nonzero error code on failure.
+ * Returns the pointers and count in *subpacks_ret and *num_subpacks_ret.
+ */
+static int
+load_subpack_info(WIMStruct *wim,
+                 const struct wim_lookup_table_entry_disk *entries,
+                 size_t num_remaining_entries,
+                 struct wim_resource_spec ***subpacks_ret,
+                 size_t *num_subpacks_ret)
+{
+       size_t num_subpacks;
+       struct wim_resource_spec **subpacks;
+       size_t i;
+       int ret;
+
+       num_subpacks = count_subpacks(entries, num_remaining_entries);
+       subpacks = CALLOC(num_subpacks, sizeof(subpacks[0]));
+       if (!subpacks)
+               return WIMLIB_ERR_NOMEM;
+
+       for (i = 0; i < num_subpacks; i++) {
+               subpacks[i] = MALLOC(sizeof(struct wim_resource_spec));
+               if (!subpacks[i]) {
+                       ret = WIMLIB_ERR_NOMEM;
+                       goto out_free_subpacks;
+               }
+       }
+
+       ret = do_load_subpack_info(wim, subpacks, num_subpacks, entries);
+       if (ret)
+               goto out_free_subpacks;
+
+       *subpacks_ret = subpacks;
+       *num_subpacks_ret = num_subpacks;
+       return 0;
+
+out_free_subpacks:
+       for (i = 0; i < num_subpacks; i++)
+               FREE(subpacks[i]);
+       FREE(subpacks);
+       return ret;
+}
+
+/* Given a 'struct wim_lookup_table_entry' allocated for a stream entry with
+ * PACKED_STREAMS set, try to bind it to a subpack of the current PACKED_STREAMS
+ * run.  */
+static int
+bind_stream_to_subpack(const struct wim_reshdr *reshdr,
+                      struct wim_lookup_table_entry *stream,
+                      struct wim_resource_spec **subpacks,
+                      size_t num_subpacks)
+{
+       u64 offset = reshdr->offset_in_wim;
+
+       /* XXX: This linear search will be slow in the degenerate case where the
+        * number of subpacks is huge.  */
+       stream->size = reshdr->size_in_wim;
+       stream->flags = reshdr->flags;
+       for (size_t i = 0; i < num_subpacks; i++) {
+               if (offset + stream->size <= subpacks[i]->uncompressed_size) {
+                       stream->offset_in_res = offset;
+                       lte_bind_wim_resource_spec(stream, subpacks[i]);
+                       return 0;
+               }
+               offset -= subpacks[i]->uncompressed_size;
+       }
+       ERROR("Packed stream could not be assigned to any resource");
+       return WIMLIB_ERR_INVALID_LOOKUP_TABLE_ENTRY;
+}
+
+static void
+free_subpack_info(struct wim_resource_spec **subpacks, size_t num_subpacks)
+{
+       if (subpacks) {
+               for (size_t i = 0; i < num_subpacks; i++)
+                       if (list_empty(&subpacks[i]->stream_list))
+                               FREE(subpacks[i]);
+               FREE(subpacks);
+       }
+}
+
 static int
 cmp_streams_by_offset_in_res(const void *p1, const void *p2)
 {
@@ -648,34 +820,47 @@ invalid_due_to_overlap:
        return WIMLIB_ERR_INVALID_LOOKUP_TABLE_ENTRY;
 }
 
-/* Validate the resource, or free it if unused.  */
 static int
-finish_resource(struct wim_resource_spec *rspec)
+finish_subpacks(struct wim_resource_spec **subpacks, size_t num_subpacks)
 {
-       if (!list_empty(&rspec->stream_list)) {
-               /* This resource contains at least one stream.  */
-               return validate_resource(rspec);
-       } else {
-               /* No streams are in this resource.  Get rid of it.  */
-               FREE(rspec);
-               return 0;
+       int ret = 0;
+       for (size_t i = 0; i < num_subpacks; i++) {
+               ret = validate_resource(subpacks[i]);
+               if (ret)
+                       break;
        }
+       free_subpack_info(subpacks, num_subpacks);
+       return ret;
 }
 
 /*
- * Reads the lookup table from a WIM file.  Each entry specifies a stream that
- * the WIM file contains, along with its location and SHA1 message digest.
+ * Reads the lookup table from a WIM file.  Usually, each entry specifies a
+ * stream that the WIM file contains, along with its location and SHA1 message
+ * digest.
  *
- * Saves lookup table entries for non-metadata streams in a hash table, and
- * saves the metadata entry for each image in a special per-image location (the
- * image_metadata array).
+ * Saves lookup table entries for non-metadata streams in a hash table (set to
+ * wim->lookup_table), and saves the metadata entry for each image in a special
+ * per-image location (the wim->image_metadata array).
  *
- * Return values:
+ * This works for both version WIM_VERSION_DEFAULT (68864) and version
+ * WIM_VERSION_PACKED_STREAMS (3584) WIMs.  In the latter, a consecutive run of
+ * lookup table entries that all have flag WIM_RESHDR_FLAG_PACKED_STREAMS (0x10)
+ * set is a "packed run".  A packed run logically contains zero or more
+ * resources, each of which logically contains zero or more streams.
+ * Physically, in such a run, a "lookup table entry" with uncompressed size
+ * WIM_PACK_MAGIC_NUMBER (0x100000000) specifies a resource, whereas any other
+ * entry specifies a stream.  Within such a run, stream entries and resource
+ * entries need not be in any particular order, except that the order of the
+ * resource entries is important, as it affects how streams are assigned to
+ * resources.  See the code for details.
+ *
+ * Possible return values:
  *     WIMLIB_ERR_SUCCESS (0)
  *     WIMLIB_ERR_INVALID_LOOKUP_TABLE_ENTRY
- *     WIMLIB_ERR_RESOURCE_NOT_FOUND
+ *     WIMLIB_ERR_NOMEM
  *
- *     Or an error code caused by failure to read the lookup table into memory.
+ *     Or an error code caused by failure to read the lookup table from the WIM
+ *     file.
  */
 int
 read_wim_lookup_table(WIMStruct *wim)
@@ -685,10 +870,11 @@ read_wim_lookup_table(WIMStruct *wim)
        void *buf = NULL;
        struct wim_lookup_table *table = NULL;
        struct wim_lookup_table_entry *cur_entry = NULL;
-       struct wim_resource_spec *cur_rspec = NULL;
        size_t num_duplicate_entries = 0;
        size_t num_wrong_part_entries = 0;
        u32 image_index = 0;
+       struct wim_resource_spec **cur_subpacks = NULL;
+       size_t cur_num_subpacks = 0;
 
        DEBUG("Reading lookup table.");
 
@@ -722,7 +908,6 @@ read_wim_lookup_table(WIMStruct *wim)
                        &((const struct wim_lookup_table_entry_disk*)buf)[i];
                struct wim_reshdr reshdr;
                u16 part_number;
-               struct wim_lookup_table_entry *duplicate_entry;
 
                /* Get the resource header  */
                get_wim_reshdr(&disk_entry->reshdr, &reshdr);
@@ -730,16 +915,16 @@ read_wim_lookup_table(WIMStruct *wim)
                DEBUG("reshdr: size_in_wim=%"PRIu64", "
                      "uncompressed_size=%"PRIu64", "
                      "offset_in_wim=%"PRIu64", "
-                     "flags=0x%02x\n",
+                     "flags=0x%02x",
                      reshdr.size_in_wim, reshdr.uncompressed_size,
                      reshdr.offset_in_wim, reshdr.flags);
 
                /* Ignore PACKED_STREAMS flag if it isn't supposed to be used in
-                * this WIM version  */
+                * this WIM version.  */
                if (wim->hdr.wim_version == WIM_VERSION_DEFAULT)
                        reshdr.flags &= ~WIM_RESHDR_FLAG_PACKED_STREAMS;
 
-               /* Allocate a 'struct wim_lookup_table_entry'  */
+               /* Allocate a new 'struct wim_lookup_table_entry'.  */
                cur_entry = new_lookup_table_entry();
                if (!cur_entry)
                        goto oom;
@@ -749,158 +934,115 @@ read_wim_lookup_table(WIMStruct *wim)
                cur_entry->refcnt = le32_to_cpu(disk_entry->refcnt);
                copy_hash(cur_entry->hash, disk_entry->hash);
 
-               /* Verify that the part number matches that of the underlying
-                * WIM file.  */
-               if (part_number != wim->hdr.part_number) {
-                       num_wrong_part_entries++;
-                       goto free_cur_entry_and_continue;
-               }
+               if (reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) {
 
-               /* If resource is uncompressed, check for (unexpected) size
-                * mismatch.  */
-               if (!(reshdr.flags & (WIM_RESHDR_FLAG_PACKED_STREAMS |
-                                     WIM_RESHDR_FLAG_COMPRESSED))) {
-                       if (reshdr.uncompressed_size != reshdr.size_in_wim) {
-                               /* So ... This is an uncompressed resource, but
-                                * its uncompressed size is NOT the same as its
-                                * "compressed" size (size_in_wim).  What to do
-                                * with it?
-                                *
-                                * Based on a simple test, WIMGAPI seems to
-                                * handle this as follows:
-                                *
-                                * if (size_in_wim > uncompressed_size) {
-                                *      Ignore uncompressed_size; use
-                                *      size_in_wim instead.
-                                * } else {
-                                *      Honor uncompressed_size, but treat the
-                                *      part of the file data above size_in_wim
-                                *      as all zeros.
-                                * }
-                                *
-                                * So we will do the same.
-                                */
-                               if (reshdr.size_in_wim > reshdr.uncompressed_size)
-                                       reshdr.uncompressed_size = reshdr.size_in_wim;
-                       }
-               }
+                       /* PACKED_STREAMS entry  */
 
-               /*
-                * Possibly start a new resource.
-                *
-                * We need to start a new resource if:
-                *
-                * - There is no previous resource (cur_rspec).
-                *
-                *   OR
-                *
-                * - The resource header did not have PACKED_STREAMS set, so it
-                *   specifies a new, single-stream resource.
-                *
-                *   OR
-                *
-                * - The resource header had PACKED_STREAMS set, and it's a
-                *   special entry that specifies the resource itself as opposed
-                *   to a stream, and we already encountered one such entry in
-                *   the current resource.  We will interpret this as the
-                *   beginning of a new packed resource.  (However, note that
-                *   wimlib does not currently allow create WIMs with multiple
-                *   packed resources, as to remain compatible with WIMGAPI.)
-                */
-               if (likely(!cur_rspec) ||
-                   !(reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) ||
-                     (reshdr.uncompressed_size == WIM_PACK_MAGIC_NUMBER &&
-                      cur_rspec->size_in_wim != 0))
-               {
-                       /* Finish previous resource (if existent)  */
-                       if (cur_rspec) {
-                               ret = finish_resource(cur_rspec);
-                               cur_rspec = NULL;
+                       if (!cur_subpacks) {
+                               /* Starting new run  */
+                               ret = load_subpack_info(wim, disk_entry,
+                                                       num_entries - i,
+                                                       &cur_subpacks,
+                                                       &cur_num_subpacks);
                                if (ret)
                                        goto out;
                        }
 
-                       /* Allocate the resource specification and initialize it
-                        * with values from the current stream entry.  */
-                       cur_rspec = MALLOC(sizeof(*cur_rspec));
-                       if (!cur_rspec)
-                               goto oom;
+                       if (reshdr.uncompressed_size == WIM_PACK_MAGIC_NUMBER) {
+                               /* Resource entry, not stream entry  */
+                               goto free_cur_entry_and_continue;
+                       }
+
+                       /* Stream entry  */
 
-                       wim_res_hdr_to_spec(&reshdr, wim, cur_rspec);
+                       ret = bind_stream_to_subpack(&reshdr,
+                                                    cur_entry,
+                                                    cur_subpacks,
+                                                    cur_num_subpacks);
+                       if (ret)
+                               goto out;
+
+               } else {
+                       /* Normal stream/resource entry; PACKED_STREAMS not set.
+                        */
 
-                       /* If this is a packed run, the current stream entry may
-                        * specify a stream within the resource, and not the
-                        * resource itself.  Zero possibly irrelevant data until
-                        * it is read for certain.  */
-                       if (reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) {
-                               cur_rspec->size_in_wim = 0;
-                               cur_rspec->uncompressed_size = 0;
-                               cur_rspec->offset_in_wim = 0;
+                       struct wim_resource_spec *rspec;
+
+                       if (unlikely(cur_subpacks)) {
+                               /* This entry terminated a packed run.  */
+                               ret = finish_subpacks(cur_subpacks,
+                                                     cur_num_subpacks);
+                               cur_subpacks = NULL;
+                               if (ret)
+                                       goto out;
                        }
-               }
 
-               /* Now cur_rspec != NULL.  */
+                       /* How to handle an uncompressed resource with its
+                        * uncompressed size different from its compressed size?
+                        *
+                        * Based on a simple test, WIMGAPI seems to handle this
+                        * as follows:
+                        *
+                        * if (size_in_wim > uncompressed_size) {
+                        *      Ignore uncompressed_size; use size_in_wim
+                        *      instead.
+                        * } else {
+                        *      Honor uncompressed_size, but treat the part of
+                        *      the file data above size_in_wim as all zeros.
+                        * }
+                        *
+                        * So we will do the same.  */
+                       if (unlikely(!(reshdr.flags &
+                                      WIM_RESHDR_FLAG_COMPRESSED) &&
+                                    (reshdr.size_in_wim >
+                                     reshdr.uncompressed_size)))
+                       {
+                               reshdr.uncompressed_size = reshdr.size_in_wim;
+                       }
 
-               /* Checked for packed resource specification.  */
-               if (unlikely((reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) &&
-                            reshdr.uncompressed_size == WIM_PACK_MAGIC_NUMBER))
-               {
-                       /* Found the specification for the packed resource.
-                        * Transfer the values to the `struct
-                        * wim_resource_spec', and discard the current stream
-                        * since this lookup table entry did not, in fact,
-                        * correspond to a "stream".
-                        */
+                       /* Set up a resource specification for this stream.  */
 
-                       /* Uncompressed size of the resource pack is actually
-                        * stored in the header of the resource itself.  Read
-                        * it, and also grab the chunk size and compression type
-                        * (which are not necessarily the defaults from the WIM
-                        * header).  */
-                       struct alt_chunk_table_header_disk hdr;
+                       rspec = MALLOC(sizeof(struct wim_resource_spec));
+                       if (!rspec)
+                               goto oom;
 
-                       ret = full_pread(&wim->in_fd, &hdr,
-                                        sizeof(hdr), reshdr.offset_in_wim);
-                       if (ret)
-                               goto out;
+                       wim_res_hdr_to_spec(&reshdr, wim, rspec);
 
-                       cur_rspec->uncompressed_size = le64_to_cpu(hdr.res_usize);
-                       cur_rspec->offset_in_wim = reshdr.offset_in_wim;
-                       cur_rspec->size_in_wim = reshdr.size_in_wim;
-                       cur_rspec->flags = reshdr.flags;
-
-                       /* Compression format numbers must be the same as in
-                        * WIMGAPI to be compatible here.  */
-                       BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_NONE != 0);
-                       BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_XPRESS != 1);
-                       BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_LZX != 2);
-                       BUILD_BUG_ON(WIMLIB_COMPRESSION_TYPE_LZMS != 3);
-                       cur_rspec->compression_type = le32_to_cpu(hdr.compression_format);
-
-                       cur_rspec->chunk_size = le32_to_cpu(hdr.chunk_size);
-
-                       DEBUG("Full pack is %"PRIu64" compressed bytes "
-                             "at file offset %"PRIu64" (flags 0x%02x)",
-                             cur_rspec->size_in_wim,
-                             cur_rspec->offset_in_wim,
-                             cur_rspec->flags);
-                       goto free_cur_entry_and_continue;
+                       cur_entry->offset_in_res = 0;
+                       cur_entry->size = reshdr.uncompressed_size;
+                       cur_entry->flags = reshdr.flags;
+
+                       lte_bind_wim_resource_spec(cur_entry, rspec);
                }
 
-               /* Ignore streams with zero hash.  */
+               /* cur_entry is now a stream bound to a resource.  */
+
+               /* Ignore entries with all zeroes in the hash field.  */
                if (is_zero_hash(cur_entry->hash))
                        goto free_cur_entry_and_continue;
 
+               /* Verify that the part number matches that of the underlying
+                * WIM file.  */
+               if (part_number != wim->hdr.part_number) {
+                       num_wrong_part_entries++;
+                       goto free_cur_entry_and_continue;
+               }
+
                if (reshdr.flags & WIM_RESHDR_FLAG_METADATA) {
+
                        /* Lookup table entry for a metadata resource.  */
 
-                       /* Metadata entries with no references must be ignored;
-                        * see, for example, the WinPE WIMs from the WAIK v2.1.
+                       /* Metadata entries with no references must be ignored.
+                        * See, for example, the WinPE WIMs from the WAIK v2.1.
                         */
                        if (cur_entry->refcnt == 0)
                                goto free_cur_entry_and_continue;
 
                        if (cur_entry->refcnt != 1) {
+                               /* We don't currently support this case due to
+                                * the complications of multiple images sharing
+                                * the same metadata resource or a metadata
+                                * resource also being referenced by files.  */
                                ERROR("Found metadata resource with refcnt != 1");
                                ret = WIMLIB_ERR_INVALID_LOOKUP_TABLE_ENTRY;
                                goto out;
@@ -911,18 +1053,22 @@ read_wim_lookup_table(WIMStruct *wim)
                                        "non-first part of the split WIM");
                                goto free_cur_entry_and_continue;
                        }
+
+                       /* The number of entries in the lookup table with
+                        * WIM_RESHDR_FLAG_METADATA set should be the same as
+                        * the image_count field in the WIM header.  */
                        if (image_index == wim->hdr.image_count) {
                                WARNING("Found more metadata resources than images");
                                goto free_cur_entry_and_continue;
                        }
 
                        /* Notice very carefully:  We are assigning the metadata
-                        * resources in the exact order mirrored by their lookup
-                        * table entries on disk, which is the behavior of
-                        * Microsoft's software.  In particular, this overrides
-                        * the actual locations of the metadata resources
-                        * themselves in the WIM file as well as any information
-                        * written in the XML data.  */
+                        * resources to images in the same order in which their
+                        * lookup table entries occur on disk.  (This is also
+                        * the behavior of Microsoft's software.)  In
+                        * particular, this overrides the actual locations of
+                        * the metadata resources themselves in the WIM file as
+                        * well as any information written in the XML data.  */
                        DEBUG("Found metadata resource for image %"PRIu32" at "
                              "offset %"PRIu64".",
                              image_index + 1,
@@ -930,52 +1076,33 @@ read_wim_lookup_table(WIMStruct *wim)
 
                        wim->image_metadata[image_index++]->metadata_lte = cur_entry;
                } else {
-                       /* Lookup table entry for a stream that is not a metadata
-                        * resource.  */
+                       /* Lookup table entry for a non-metadata stream.  */
 
                        /* Ignore this stream if it's a duplicate.  */
-                       duplicate_entry = lookup_stream(table, cur_entry->hash);
-                       if (duplicate_entry) {
+                       if (lookup_stream(table, cur_entry->hash)) {
                                num_duplicate_entries++;
                                goto free_cur_entry_and_continue;
                        }
 
-                       /* Insert the stream into the lookup table (keyed by its
-                        * SHA1 message digest).  */
+                       /* Insert the stream into the in-memory lookup table,
+                        * keyed by its SHA1 message digest.  */
                        lookup_table_insert(table, cur_entry);
                }
 
-               /* Add the stream to the current resource specification.  */
-               lte_bind_wim_resource_spec(cur_entry, cur_rspec);
-               if (reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) {
-                       /* In packed runs, the offset field is used for
-                        * in-resource offset, not the in-WIM offset, and the
-                        * size field is used for the uncompressed size, not the
-                        * compressed size.  */
-                       cur_entry->offset_in_res = reshdr.offset_in_wim;
-                       cur_entry->size = reshdr.size_in_wim;
-                       cur_entry->flags = reshdr.flags;
-                       /* cur_rspec stays the same  */
-
-               } else {
-                       /* Normal case: The stream corresponds one-to-one with
-                        * the resource entry.  */
-                       cur_entry->offset_in_res = 0;
-                       cur_entry->size = reshdr.uncompressed_size;
-                       cur_entry->flags = reshdr.flags;
-                       cur_rspec = NULL;
-               }
                continue;
 
        free_cur_entry_and_continue:
+               if (cur_subpacks &&
+                   cur_entry->resource_location == RESOURCE_IN_WIM)
+                       lte_unbind_wim_resource_spec(cur_entry);
                free_lookup_table_entry(cur_entry);
        }
        cur_entry = NULL;
 
-       /* Validate the last resource.  */
-       if (cur_rspec) {
-               ret = finish_resource(cur_rspec);
-               cur_rspec = NULL;
+       if (cur_subpacks) {
+               /* End of lookup table terminated a packed run.  */
+               ret = finish_subpacks(cur_subpacks, cur_num_subpacks);
+               cur_subpacks = NULL;
                if (ret)
                        goto out;
        }
@@ -999,17 +1126,17 @@ read_wim_lookup_table(WIMStruct *wim)
 
        DEBUG("Done reading lookup table.");
        wim->lookup_table = table;
-       table = NULL;
        ret = 0;
-       goto out;
+       goto out_free_buf;
+
 oom:
        ERROR("Not enough memory to read lookup table!");
        ret = WIMLIB_ERR_NOMEM;
 out:
-       if (cur_rspec && list_empty(&cur_rspec->stream_list))
-               FREE(cur_rspec);
+       free_subpack_info(cur_subpacks, cur_num_subpacks);
        free_lookup_table_entry(cur_entry);
        free_lookup_table(table);
+out_free_buf:
        FREE(buf);
        return ret;
 }
@@ -1025,6 +1152,10 @@ put_wim_lookup_table_entry(struct wim_lookup_table_entry_disk *disk_entry,
        copy_hash(disk_entry->hash, hash);
 }
 
+/* Note: the list of stream entries must be sorted so that all entries for the
+ * same packed resource are consecutive.  In addition, entries with
+ * WIM_RESHDR_FLAG_METADATA set must be in the same order as the indices of the
+ * underlying images.  */
 int
 write_wim_lookup_table_from_stream_list(struct list_head *stream_list,
                                        struct filedes *out_fd,
@@ -1038,6 +1169,8 @@ write_wim_lookup_table_from_stream_list(struct list_head *stream_list,
        struct wim_lookup_table_entry_disk *table_buf_ptr;
        int ret;
        u64 prev_res_offset_in_wim = ~0ULL;
+       u64 prev_uncompressed_size;
+       u64 logical_offset;
 
        table_size = 0;
        list_for_each_entry(lte, stream_list, lookup_table_list) {
@@ -1063,38 +1196,46 @@ write_wim_lookup_table_from_stream_list(struct list_head *stream_list,
        table_buf_ptr = table_buf;
 
        prev_res_offset_in_wim = ~0ULL;
+       prev_uncompressed_size = 0;
+       logical_offset = 0;
        list_for_each_entry(lte, stream_list, lookup_table_list) {
+               if (lte->out_reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS) {
+                       struct wim_reshdr tmp_reshdr;
 
-               put_wim_lookup_table_entry(table_buf_ptr++,
-                                          &lte->out_reshdr,
-                                          part_number,
-                                          lte->out_refcnt,
-                                          lte->hash);
-               if (lte->out_reshdr.flags & WIM_RESHDR_FLAG_PACKED_STREAMS &&
-                   lte->out_res_offset_in_wim != prev_res_offset_in_wim)
-               {
-                       /* Put the main resource entry for the pack.  */
+                       /* Eww.  When WIMGAPI sees multiple resource packs, it
+                        * expects the offsets to be adjusted as if there were
+                        * really only one pack.  */
 
-                       struct wim_reshdr reshdr;
+                       if (lte->out_res_offset_in_wim != prev_res_offset_in_wim) {
+                               /* Put the resource entry for pack  */
+                               tmp_reshdr.offset_in_wim = lte->out_res_offset_in_wim;
+                               tmp_reshdr.size_in_wim = lte->out_res_size_in_wim;
+                               tmp_reshdr.uncompressed_size = WIM_PACK_MAGIC_NUMBER;
+                               tmp_reshdr.flags = WIM_RESHDR_FLAG_PACKED_STREAMS;
 
-                       reshdr.offset_in_wim = lte->out_res_offset_in_wim;
-                       reshdr.size_in_wim = lte->out_res_size_in_wim;
-                       reshdr.uncompressed_size = WIM_PACK_MAGIC_NUMBER;
-                       reshdr.flags = WIM_RESHDR_FLAG_PACKED_STREAMS;
+                               put_wim_lookup_table_entry(table_buf_ptr++,
+                                                          &tmp_reshdr,
+                                                          part_number,
+                                                          1, zero_hash);
 
-                       DEBUG("Putting main entry for pack: "
-                             "size_in_wim=%"PRIu64", "
-                             "offset_in_wim=%"PRIu64", "
-                             "uncompressed_size=%"PRIu64,
-                             reshdr.size_in_wim,
-                             reshdr.offset_in_wim,
-                             reshdr.uncompressed_size);
+                               logical_offset += prev_uncompressed_size;
 
+                               prev_res_offset_in_wim = lte->out_res_offset_in_wim;
+                               prev_uncompressed_size = lte->out_res_uncompressed_size;
+                       }
+                       tmp_reshdr = lte->out_reshdr;
+                       tmp_reshdr.offset_in_wim += logical_offset;
                        put_wim_lookup_table_entry(table_buf_ptr++,
-                                                  &reshdr,
+                                                  &tmp_reshdr,
                                                   part_number,
-                                                  1, zero_hash);
-                       prev_res_offset_in_wim = lte->out_res_offset_in_wim;
+                                                  lte->out_refcnt,
+                                                  lte->hash);
+               } else {
+                       put_wim_lookup_table_entry(table_buf_ptr++,
+                                                  &lte->out_reshdr,
+                                                  part_number,
+                                                  lte->out_refcnt,
+                                                  lte->hash);
                }
 
        }
@@ -1130,16 +1271,6 @@ lte_zero_out_refcnt(struct wim_lookup_table_entry *lte, void *_ignore)
        return 0;
 }
 
-int
-lte_free_extracted_file(struct wim_lookup_table_entry *lte, void *_ignore)
-{
-       if (lte->extracted_file != NULL) {
-               FREE(lte->extracted_file);
-               lte->extracted_file = NULL;
-       }
-       return 0;
-}
-
 /* Allocate a stream entry for the contents of the buffer, or re-use an existing
  * entry in @lookup_table for the same stream.  */
 struct wim_lookup_table_entry *
@@ -1289,7 +1420,7 @@ wimlib_iterate_lookup_table(WIMStruct *wim, int flags,
                .cb = cb,
                .user_ctx = user_ctx,
        };
-       if (wim->hdr.part_number == 1) {
+       if (wim_has_metadata(wim)) {
                int ret;
                for (int i = 0; i < wim->hdr.image_count; i++) {
                        ret = do_iterate_lte(wim->image_metadata[i]->metadata_lte,