win32_capture_streams(): Only warn on stream lookup fail

[wimlib] / src / join.c

diff --git a/src/join.c b/src/join.c
index 2902a61cae68c86acc5fb134f327a982b2cb3403..b5c7c37bb576c202ae108227f80441640fa4599a 100644 (file)
--- a/src/join.c
+++ b/src/join.c
@@ -40,7 +40,9 @@ static int
 lookup_table_join(struct wim_lookup_table *table,
                  struct wim_lookup_table *new)
 {
-       return for_lookup_table_entry(new, move_lte_to_table, table);
+       for_lookup_table_entry(new, move_lte_to_table, table);
+       new->num_entries = 0;
+       return 0;
 }
 
 /*
@@ -107,16 +109,14 @@ join_wims(WIMStruct **swms, unsigned num_swms,
        }
 
        if (progress_func) {
-               progress.join.total_bytes        = total_bytes;
-               progress.join.total_parts        = swms[0]->hdr.total_parts;
-               progress.join.completed_bytes    = 0;
-               progress.join.completed_parts    = 0;
+               progress.join.total_bytes     = total_bytes;
+               progress.join.total_parts     = swms[0]->hdr.total_parts;
+               progress.join.completed_bytes = 0;
+               progress.join.completed_parts = 0;
                progress_func(WIMLIB_PROGRESS_MSG_JOIN_STREAMS, &progress);
        }
 
-       /* Write the resources (streams and metadata resources) from each SWM
-        * part */
-       swms[0]->write_metadata = true;
+       /* Write the non-metadata resources from each SWM part */
        for (i = 0; i < num_swms; i++) {
                swms[i]->fp = tfopen(swms[i]->filename, T("rb"));
                if (!swms[i]->fp) {
@@ -126,13 +126,18 @@ join_wims(WIMStruct **swms, unsigned num_swms,
                }
                swms[i]->out_fp = joined_wim->out_fp;
                swms[i]->hdr.part_number = 1;
-               ret = for_lookup_table_entry(swms[i]->lookup_table,
-                                            copy_resource, swms[i]);
+
+               ret = for_lookup_table_entry_pos_sorted(swms[i]->lookup_table,
+                                                       copy_resource,
+                                                       swms[i]);
                swms[i]->out_fp = NULL;
-               fclose(swms[i]->fp);
-               swms[i]->fp = NULL;
 
-               if (ret != 0)
+               if (i != 0) {
+                       fclose(swms[i]->fp);
+                       swms[i]->fp = NULL;
+               }
+
+               if (ret)
                        return ret;
 
                if (progress_func) {
@@ -142,14 +147,25 @@ join_wims(WIMStruct **swms, unsigned num_swms,
                }
        }
 
+       /* Copy the metadata resources from the first SWM part */
        joined_wim->hdr.image_count = swms[0]->hdr.image_count;
+       for (i = 0; i < joined_wim->hdr.image_count; i++) {
+               ret = copy_resource(swms[0]->image_metadata[i]->metadata_lte,
+                                   joined_wim);
+               if (ret)
+                       return ret;
+       }
+
+       /* Write lookup table, XML data, and optional integrity table */
        for (i = 0; i < num_swms; i++)
                lookup_table_join(joined_wim->lookup_table, swms[i]->lookup_table);
 
        free_wim_info(joined_wim->wim_info);
        joined_wim->wim_info = swms[0]->wim_info;
+       joined_wim->image_metadata = swms[0]->image_metadata;
        ret = finish_write(joined_wim, WIMLIB_ALL_IMAGES, write_flags, progress_func);
        joined_wim->wim_info = NULL;
+       joined_wim->image_metadata = NULL;
        return ret;
 }
 
@@ -188,8 +204,8 @@ wimlib_join(const tchar * const *swm_names,
        for (i = 0; i < num_swms; i++) {
                ret = wimlib_open_wim(swm_names[i], swm_open_flags, &swms[i],
                                      progress_func);
-               if (ret != 0)
-                       goto out;
+               if (ret)
+                       goto out_free_wims;
 
                /* Don't open all the parts at the same time, in case there are
                 * a lot of them */
@@ -200,20 +216,20 @@ wimlib_join(const tchar * const *swm_names,
        qsort(swms, num_swms, sizeof(swms[0]), cmp_swms_by_part_number);
 
        ret = verify_swm_set(swms[0], &swms[1], num_swms - 1);
-       if (ret != 0)
-               goto out;
+       if (ret)
+               goto out_free_wims;
 
        ret = wimlib_create_new_wim(wimlib_get_compression_type(swms[0]),
                                    &joined_wim);
-       if (ret != 0)
-               goto out;
+       if (ret)
+               goto out_free_wims;
 
        ret = begin_write(joined_wim, output_path, wim_write_flags);
-       if (ret != 0)
-               goto out;
+       if (ret)
+               goto out_free_wims;
        ret = join_wims(swms, num_swms, joined_wim, wim_write_flags,
                        progress_func);
-out:
+out_free_wims:
        for (i = 0; i < num_swms; i++)
                wimlib_free(swms[i]);
        wimlib_free(joined_wim);