]> wimlib.net Git - wimlib/blobdiff - src/extract_image.c
Fixes, comments
[wimlib] / src / extract_image.c
index 17b12809f010a38fff6245371232f978a9c10c84..dff7dd4f12c0596045eb555d392306cd80e4c166 100644 (file)
 #  include <alloca.h>
 #endif
 
-#if TCHAR_IS_UTF16LE
-#  include <wchar.h>
-#endif
-
 #ifndef __WIN32__
+
+/* Returns the number of components of @path.  */
+static unsigned
+get_num_path_components(const char *path)
+{
+       unsigned num_components = 0;
+       while (*path) {
+               while (*path == '/')
+                       path++;
+               if (*path)
+                       num_components++;
+               while (*path && *path != '/')
+                       path++;
+       }
+       return num_components;
+}
+
+static const char *
+path_next_part(const char *path)
+{
+       while (*path && *path != '/')
+               path++;
+       while (*path && *path == '/')
+               path++;
+       return path;
+}
+
 static int
 extract_regular_file_linked(struct wim_dentry *dentry,
                            const char *output_path,
@@ -89,7 +112,7 @@ extract_regular_file_linked(struct wim_dentry *dentry,
                size_t i;
 
                num_path_components =
-                       get_num_path_components(dentry->full_path) - 1;
+                       get_num_path_components(dentry_full_path(dentry)) - 1;
                num_output_dir_path_components =
                        get_num_path_components(args->target);
 
@@ -110,8 +133,10 @@ extract_regular_file_linked(struct wim_dentry *dentry,
                p2 = lte->extracted_file;
                while (*p2 == '/')
                        p2++;
-               while (num_output_dir_path_components--)
-                       p2 = path_next_part(p2, NULL);
+               while (num_output_dir_path_components > 0) {
+                       p2 = path_next_part(p2);
+                       num_output_dir_path_components--;
+               }
                strcpy(p, p2);
                if (symlink(buf, output_path) != 0) {
                        ERROR_WITH_ERRNO("Failed to symlink `%s' to `%s'",
@@ -123,7 +148,7 @@ extract_regular_file_linked(struct wim_dentry *dentry,
 }
 
 static int
-symlink_apply_unix_data(const mbchar *link,
+symlink_apply_unix_data(const char *link,
                        const struct wimlib_unix_data *unix_data)
 {
        if (lchown(link, unix_data->uid, unix_data->gid)) {
@@ -243,7 +268,7 @@ extract_regular_file_unlinked(struct wim_dentry *dentry,
        }
 
        ret = extract_wim_resource_to_fd(lte, out_fd, wim_resource_size(lte));
-       if (ret != 0) {
+       if (ret) {
                ERROR("Failed to extract resource to `%s'", output_path);
                goto out;
        }
@@ -303,12 +328,12 @@ extract_symlink(struct wim_dentry *dentry,
 {
        char target[4096];
        ssize_t ret = inode_readlink(dentry->d_inode, target,
-                                    sizeof(target), args->w, 0);
+                                    sizeof(target), args->w, false);
        struct wim_lookup_table_entry *lte;
 
        if (ret <= 0) {
                ERROR("Could not read the symbolic link from dentry `%s'",
-                     dentry->full_path);
+                     dentry_full_path(dentry));
                return WIMLIB_ERR_INVALID_DENTRY;
        }
        ret = symlink(target, output_path);
@@ -474,10 +499,12 @@ apply_dentry_normal(struct wim_dentry *dentry, void *arg)
        if (dentry_is_root(dentry)) {
                output_path = (tchar*)args->target;
        } else {
+               if (!dentry_full_path(dentry))
+                       return WIMLIB_ERR_NOMEM;
                output_path = alloca(len * sizeof(tchar) + dentry->full_path_nbytes +
                                     sizeof(tchar));
                memcpy(output_path, args->target, len * sizeof(tchar));
-               memcpy(output_path + len, dentry->full_path, dentry->full_path_nbytes);
+               memcpy(output_path + len, dentry->_full_path, dentry->full_path_nbytes);
                len += dentry->full_path_nbytes / sizeof(tchar);
                output_path[len] = T('\0');
        }
@@ -501,10 +528,12 @@ apply_dentry_timestamps_normal(struct wim_dentry *dentry, void *arg)
        if (dentry_is_root(dentry)) {
                output_path = (tchar*)args->target;
        } else {
+               if (!dentry_full_path(dentry))
+                       return WIMLIB_ERR_NOMEM;
                output_path = alloca(len * sizeof(tchar) + dentry->full_path_nbytes +
                                     sizeof(tchar));
                memcpy(output_path, args->target, len * sizeof(tchar));
-               memcpy(output_path + len, dentry->full_path, dentry->full_path_nbytes);
+               memcpy(output_path + len, dentry->_full_path, dentry->full_path_nbytes);
                len += dentry->full_path_nbytes / sizeof(tchar);
                output_path[len] = T('\0');
        }
@@ -528,13 +557,16 @@ maybe_apply_dentry(struct wim_dentry *dentry, void *arg)
        if (dentry->is_extracted)
                return 0;
 
+       if (!dentry_full_path(dentry))
+               return WIMLIB_ERR_NOMEM;
+
        if (args->extract_flags & WIMLIB_EXTRACT_FLAG_NO_STREAMS)
                if (inode_unnamed_lte_resolved(dentry->d_inode))
                        return 0;
 
        if ((args->extract_flags & WIMLIB_EXTRACT_FLAG_VERBOSE) &&
             args->progress_func) {
-               args->progress.extract.cur_path = dentry->full_path;
+               args->progress.extract.cur_path = dentry_full_path(dentry);
                args->progress_func(WIMLIB_PROGRESS_MSG_EXTRACT_DENTRY,
                                    &args->progress);
        }
@@ -544,54 +576,6 @@ maybe_apply_dentry(struct wim_dentry *dentry, void *arg)
        return ret;
 }
 
-static int
-cmp_streams_by_wim_position(const void *p1, const void *p2)
-{
-       const struct wim_lookup_table_entry *lte1, *lte2;
-       lte1 = *(const struct wim_lookup_table_entry**)p1;
-       lte2 = *(const struct wim_lookup_table_entry**)p2;
-       if (lte1->resource_entry.offset < lte2->resource_entry.offset)
-               return -1;
-       else if (lte1->resource_entry.offset > lte2->resource_entry.offset)
-               return 1;
-       else
-               return 0;
-}
-
-static int
-sort_stream_list_by_wim_position(struct list_head *stream_list)
-{
-       struct list_head *cur;
-       size_t num_streams;
-       struct wim_lookup_table_entry **array;
-       size_t i;
-       size_t array_size;
-
-       num_streams = 0;
-       list_for_each(cur, stream_list)
-               num_streams++;
-       array_size = num_streams * sizeof(array[0]);
-       array = MALLOC(array_size);
-       if (!array) {
-               ERROR("Failed to allocate %zu bytes to sort stream entries",
-                     array_size);
-               return WIMLIB_ERR_NOMEM;
-       }
-       cur = stream_list->next;
-       for (i = 0; i < num_streams; i++) {
-               array[i] = container_of(cur, struct wim_lookup_table_entry, staging_list);
-               cur = cur->next;
-       }
-
-       qsort(array, num_streams, sizeof(array[0]), cmp_streams_by_wim_position);
-
-       INIT_LIST_HEAD(stream_list);
-       for (i = 0; i < num_streams; i++)
-               list_add_tail(&array[i]->staging_list, stream_list);
-       FREE(array);
-       return 0;
-}
-
 static void
 calculate_bytes_to_extract(struct list_head *stream_list,
                           int extract_flags,
@@ -602,7 +586,7 @@ calculate_bytes_to_extract(struct list_head *stream_list,
        u64 num_streams = 0;
 
        /* For each stream to be extracted... */
-       list_for_each_entry(lte, stream_list, staging_list) {
+       list_for_each_entry(lte, stream_list, extraction_list) {
                if (extract_flags &
                    (WIMLIB_EXTRACT_FLAG_SYMLINK | WIMLIB_EXTRACT_FLAG_HARDLINK))
                {
@@ -630,7 +614,7 @@ maybe_add_stream_for_extraction(struct wim_lookup_table_entry *lte,
 {
        if (++lte->out_refcnt == 1) {
                INIT_LIST_HEAD(&lte->inode_list);
-               list_add_tail(&lte->staging_list, stream_list);
+               list_add_tail(&lte->extraction_list, stream_list);
        }
 }
 
@@ -669,18 +653,17 @@ inode_find_streams_for_extraction(struct wim_inode *inode,
 }
 
 static void
-find_streams_for_extraction(struct hlist_head *inode_list,
+find_streams_for_extraction(struct wim_image_metadata *imd,
                            struct list_head *stream_list,
                            struct wim_lookup_table *lookup_table,
                            int extract_flags)
 {
        struct wim_inode *inode;
-       struct hlist_node *cur;
        struct wim_dentry *dentry;
 
        for_lookup_table_entry(lookup_table, lte_zero_out_refcnt, NULL);
        INIT_LIST_HEAD(stream_list);
-       hlist_for_each_entry(inode, cur, inode_list, i_hlist) {
+       image_for_each_inode(inode, imd) {
                if (!inode->i_resolved)
                        inode_resolve_ltes(inode, lookup_table);
                inode_for_each_dentry(dentry, inode)
@@ -729,7 +712,7 @@ apply_stream_list(struct list_head *stream_list,
         * sequential reading of the WIM can be implemented. */
 
        /* For each distinct stream to be extracted */
-       list_for_each_entry(lte, stream_list, staging_list) {
+       list_for_each_entry(lte, stream_list, extraction_list) {
                /* For each inode that contains the stream */
                list_for_each_entry(inode, &lte->inode_list, i_lte_inode_list) {
                        /* For each dentry that points to the inode */
@@ -761,6 +744,41 @@ apply_stream_list(struct list_head *stream_list,
        return 0;
 }
 
+static int
+sort_stream_list_by_wim_position(struct list_head *stream_list)
+{
+       struct list_head *cur;
+       size_t num_streams;
+       struct wim_lookup_table_entry **array;
+       size_t i;
+       size_t array_size;
+
+       num_streams = 0;
+       list_for_each(cur, stream_list)
+               num_streams++;
+       array_size = num_streams * sizeof(array[0]);
+       array = MALLOC(array_size);
+       if (!array) {
+               ERROR("Failed to allocate %zu bytes to sort stream entries",
+                     array_size);
+               return WIMLIB_ERR_NOMEM;
+       }
+       cur = stream_list->next;
+       for (i = 0; i < num_streams; i++) {
+               array[i] = container_of(cur, struct wim_lookup_table_entry, extraction_list);
+               cur = cur->next;
+       }
+
+       qsort(array, num_streams, sizeof(array[0]), cmp_streams_by_wim_position);
+
+       INIT_LIST_HEAD(stream_list);
+       for (i = 0; i < num_streams; i++)
+               list_add_tail(&array[i]->extraction_list, stream_list);
+       FREE(array);
+       return 0;
+}
+
+
 /* Extracts the image @image from the WIM @w to the directory or NTFS volume
  * @target. */
 static int
@@ -770,16 +788,15 @@ extract_single_image(WIMStruct *w, int image,
 {
        int ret;
        struct list_head stream_list;
-       struct hlist_head *inode_list;
 
        struct apply_args args;
        const struct apply_operations *ops;
 
+       memset(&args, 0, sizeof(args));
+
        args.w                  = w;
        args.target             = target;
        args.extract_flags      = extract_flags;
-       args.num_utime_warnings = 0;
-       args.stream_list        = &stream_list;
        args.progress_func      = progress_func;
 
        if (progress_func) {
@@ -805,13 +822,12 @@ extract_single_image(WIMStruct *w, int image,
                ops = &normal_apply_operations;
 
        ret = select_wim_image(w, image);
-       if (ret != 0)
+       if (ret)
                goto out;
 
-       inode_list = &w->image_metadata[image - 1].inode_list;
-
        /* Build a list of the streams that need to be extracted */
-       find_streams_for_extraction(inode_list, &stream_list,
+       find_streams_for_extraction(wim_get_current_image_metadata(w),
+                                   &stream_list,
                                    w->lookup_table, extract_flags);
 
        /* Calculate the number of bytes of data that will be extracted */
@@ -887,19 +903,22 @@ out:
        return ret;
 }
 
+static const tchar *filename_forbidden_chars =
+T(
+#ifdef __WIN32__
+"<>:\"/\\|?*"
+#else
+"/"
+#endif
+);
 
+/* This function checks if it is okay to use a WIM image's name as a directory
+ * name.  */
 static bool
 image_name_ok_as_dir(const tchar *image_name)
 {
-       if (image_name == NULL)
-               return false;
-       if (image_name[0] == T('\0'))
-               return false;
-       if (tstrchr(image_name, T('/')))
-               return false;
-       if (tstrchr(image_name, T('\\')))
-               return false;
-       return true;
+       return image_name && *image_name &&
+               !tstrpbrk(image_name, filename_forbidden_chars);
 }
 
 /* Extracts all images from the WIM to the directory @target, with the images
@@ -921,16 +940,15 @@ extract_all_images(WIMStruct *w,
        if (ret)
                return ret;
 
-       wmemcpy(buf, target, output_path_len);
+       tmemcpy(buf, target, output_path_len);
        buf[output_path_len] = T('/');
        for (image = 1; image <= w->hdr.image_count; image++) {
                image_name = wimlib_get_image_name(w, image);
                if (image_name_ok_as_dir(image_name)) {
                        tstrcpy(buf + output_path_len + 1, image_name);
                } else {
-                       /* Image name is empty, or may not be representable in
-                        * the current locale, or contains path separators.  Use
-                        * the image number instead. */
+                       /* Image name is empty, or contains forbidden
+                        * characters. */
                        tsprintf(buf + output_path_len + 1, T("%d"), image);
                }
                ret = extract_single_image(w, image, buf, extract_flags,