]> wimlib.net Git - wimlib/blobdiff - src/dentry.c
ADS entry reading: minor changes
[wimlib] / src / dentry.c
index 68f9c57afa9df926b1856ccb79b825b1ccd36f21..471552e6acf8d1b2c2455bc29786930c30e36052 100644 (file)
  * along with wimlib; if not, see http://www.gnu.org/licenses/.
  */
 
-#include "wimlib_internal.h"
+#include <errno.h>
+#include <sys/stat.h>
+#include <time.h>
+#include <unistd.h>
+
 #include "dentry.h"
 #include "io.h"
-#include "timestamp.h"
 #include "lookup_table.h"
 #include "sha1.h"
-#include <unistd.h>
-#include <sys/stat.h>
+#include "timestamp.h"
+#include "wimlib_internal.h"
 
 /*
  * Returns true if @dentry has the UTF-8 file name @name that has length
@@ -56,8 +59,8 @@ static bool dentry_has_name(const struct dentry *dentry, const char *name,
 u64 dentry_total_length(const struct dentry *dentry)
 {
        u64 length = (dentry->length + 7) & ~7;
-       for (u16 i = 0 ; i < dentry->num_ads; i++)
-               length += ads_entry_length(&dentry->ads_entries[i]);
+       for (u16 i = 0; i < dentry->num_ads; i++)
+               length += ads_entry_total_length(&dentry->ads_entries[i]);
        return length;
 }
 
@@ -77,92 +80,115 @@ void stbuf_to_dentry(const struct stat *stbuf, struct dentry *dentry)
        else
                dentry->hard_link = (u64)stbuf->st_ino |
                                   ((u64)stbuf->st_dev << (sizeof(ino_t) * 8));
+       /* Set timestamps */
+       dentry->creation_time = timespec_to_wim_timestamp(&stbuf->st_mtim);
+       dentry->last_write_time = timespec_to_wim_timestamp(&stbuf->st_mtim);
+       dentry->last_access_time = timespec_to_wim_timestamp(&stbuf->st_atim);
 }
 
-/* Transfers file attributes from a struct dentry to a `stat' buffer. */
-void dentry_to_stbuf(const struct dentry *dentry, struct stat *stbuf, 
-                    const struct lookup_table *table)
-{
-       struct lookup_table_entry *lte;
-
-       if (dentry_is_symlink(dentry))
-               stbuf->st_mode = S_IFLNK | 0777;
-       else if (dentry_is_directory(dentry))
-               stbuf->st_mode = S_IFDIR | 0755;
-       else
-               stbuf->st_mode = S_IFREG | 0644;
-
-       /* Use the size of the unnamed (default) file stream. */
-       if (table && (lte = __lookup_resource(table, dentry_hash(dentry))))
-               stbuf->st_size = lte->resource_entry.original_size;
-       else
-               stbuf->st_size = 0;
-
-       stbuf->st_nlink   = dentry_link_group_size(dentry);
-       stbuf->st_ino     = dentry->hard_link;
-       stbuf->st_uid     = getuid();
-       stbuf->st_gid     = getgid();
-       stbuf->st_atime   = ms_timestamp_to_unix(dentry->last_access_time);
-       stbuf->st_mtime   = ms_timestamp_to_unix(dentry->last_write_time);
-       stbuf->st_ctime   = ms_timestamp_to_unix(dentry->creation_time);
-       stbuf->st_blocks  = (stbuf->st_size + 511) / 512;
-}
 
-/* Makes all timestamp fields for the dentry be the current time. */
+/* Sets all the timestamp fields of the dentry to the current time. */
 void dentry_update_all_timestamps(struct dentry *dentry)
 {
-       u64 now = get_timestamp();
+       u64 now = get_wim_timestamp();
        dentry->creation_time    = now;
        dentry->last_access_time = now;
        dentry->last_write_time  = now;
 }
 
+/* Returns the alternate data stream entry belonging to @dentry that has the
+ * stream name @stream_name. */
 struct ads_entry *dentry_get_ads_entry(struct dentry *dentry,
                                       const char *stream_name)
 {
-       size_t stream_name_len = strlen(stream_name);
+       size_t stream_name_len;
        if (!stream_name)
                return NULL;
-       for (u16 i = 0; i < dentry->num_ads; i++)
-               if (ads_entry_has_name(&dentry->ads_entries[i],
-                                      stream_name, stream_name_len))
-                       return &dentry->ads_entries[i];
+       if (dentry->num_ads) {
+               u16 i = 0;
+               stream_name_len = strlen(stream_name);
+               do {
+                       if (ads_entry_has_name(&dentry->ads_entries[i],
+                                              stream_name, stream_name_len))
+                               return &dentry->ads_entries[i];
+               } while (++i != dentry->num_ads);
+       }
        return NULL;
 }
 
-/* Add an alternate stream entry to a dentry and return a pointer to it, or NULL
- * on failure. */
+static void ads_entry_init(struct ads_entry *ads_entry)
+{
+       memset(ads_entry, 0, sizeof(struct ads_entry));
+       INIT_LIST_HEAD(&ads_entry->lte_group_list.list);
+       ads_entry->lte_group_list.type = STREAM_TYPE_ADS;
+}
+
+/* 
+ * Add an alternate stream entry to a dentry and return a pointer to it, or NULL
+ * if memory could not be allocated.
+ */
 struct ads_entry *dentry_add_ads(struct dentry *dentry, const char *stream_name)
 {
-       u16 num_ads = dentry->num_ads + 1;
+       u16 num_ads;
        struct ads_entry *ads_entries;
        struct ads_entry *new_entry;
-       if (num_ads == 0xffff)
+
+       DEBUG("Add alternate data stream %s:%s",
+              dentry->file_name_utf8, stream_name);
+
+       if (dentry->num_ads == 0xffff)
                return NULL;
-       ads_entries = MALLOC(num_ads * sizeof(struct ads_entry));
+       num_ads = dentry->num_ads + 1;
+       ads_entries = REALLOC(dentry->ads_entries,
+                             num_ads * sizeof(struct ads_entry));
        if (!ads_entries)
                return NULL;
+       if (ads_entries != dentry->ads_entries) {
+               /* We moved the ADS entries.  Adjust the stream lists. */
+               for (u16 i = 0; i < dentry->num_ads; i++) {
+                       struct list_head *cur = &ads_entries[i].lte_group_list.list;
+                       cur->prev->next = cur;
+                       cur->next->prev = cur;
+               }
+       }
 
        new_entry = &ads_entries[num_ads - 1];
-       if (change_ads_name(new_entry, stream_name) != 0) {
-               FREE(ads_entries);
+       ads_entry_init(new_entry);
+       if (change_ads_name(new_entry, stream_name) != 0)
                return NULL;
-       }
-
-       memcpy(ads_entries, dentry->ads_entries,
-              (num_ads - 1) * sizeof(struct ads_entry));
-       FREE(dentry->ads_entries);
        dentry->ads_entries = ads_entries;
        dentry->num_ads = num_ads;
-       return memset(new_entry, 0, sizeof(struct ads_entry));
+       return new_entry;
 }
 
-void dentry_remove_ads(struct dentry *dentry, struct ads_entry *sentry)
+/* Remove an alternate data stream from a dentry.
+ *
+ * The corresponding lookup table entry for the stream is NOT changed.
+ *
+ * @dentry:    The dentry
+ * @ads_entry: The alternate data stream entry (it MUST be one of the
+ *                ads_entry's in the array dentry->ads_entries).
+ */
+void dentry_remove_ads(struct dentry *dentry, struct ads_entry *ads_entry)
 {
-       destroy_ads_entry(sentry);
-       memcpy(sentry, sentry + 1,
-              (dentry->num_ads - (sentry - dentry->ads_entries))
-                * sizeof(struct ads_entry));
+       u16 idx;
+       u16 following;
+
+       wimlib_assert(dentry->num_ads);
+       idx = ads_entry - dentry->ads_entries;
+       wimlib_assert(idx < dentry->num_ads);
+       following = dentry->num_ads - idx - 1;
+
+       destroy_ads_entry(ads_entry);
+       memcpy(ads_entry, ads_entry + 1, following * sizeof(struct ads_entry));
+
+       /* We moved the ADS entries.  Adjust the stream lists. */
+       for (u16 i = 0; i < following; i++) {
+               struct list_head *cur = &ads_entry[i].lte_group_list.list;
+               cur->prev->next = cur;
+               cur->next->prev = cur;
+       }
+
        dentry->num_ads--;
 }
 
@@ -282,8 +308,8 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
 
        child = dentry->children;
        dentry->subdir_offset = *subdir_offset_p;
-       if (child) {
 
+       if (child) {
                /* Advance the subdir offset by the amount of space the children
                 * of this dentry take up. */
                do {
@@ -303,7 +329,7 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
        } else {
                /* On disk, childless directories have a valid subdir_offset
                 * that points to an 8-byte end-of-directory dentry.  Regular
-                * files have a subdir_offset of 0. */
+                * files or reparse points have a subdir_offset of 0. */
                if (dentry_is_directory(dentry))
                        *subdir_offset_p += 8;
                else
@@ -315,7 +341,7 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
 /* Returns the child of @dentry that has the file name @name.  
  * Returns NULL if no child has the name. */
 struct dentry *get_dentry_child_with_name(const struct dentry *dentry, 
-                                                       const char *name)
+                                         const char *name)
 {
        struct dentry *child;
        size_t name_len;
@@ -334,7 +360,8 @@ struct dentry *get_dentry_child_with_name(const struct dentry *dentry,
 
 /* Retrieves the dentry that has the UTF-8 @path relative to the dentry
  * @cur_dir.  Returns NULL if no dentry having the path is found. */
-static struct dentry *get_dentry_relative_path(struct dentry *cur_dir, const char *path)
+static struct dentry *get_dentry_relative_path(struct dentry *cur_dir,
+                                              const char *path)
 {
        struct dentry *child;
        size_t base_len;
@@ -365,7 +392,8 @@ struct dentry *get_dentry(WIMStruct *w, const char *path)
        return get_dentry_relative_path(root, path);
 }
 
-/* Returns the parent directory for the @path. */
+/* Returns the dentry that corresponds to the parent directory of @path, or NULL
+ * if the dentry is not found. */
 struct dentry *get_parent_dentry(WIMStruct *w, const char *path)
 {
        size_t path_len = strlen(path);
@@ -386,52 +414,65 @@ int print_dentry_full_path(struct dentry *dentry, void *ignore)
        return 0;
 }
 
+/* We want to be able to show the names of the file attribute flags that are
+ * set. */
 struct file_attr_flag {
        u32 flag;
        const char *name;
 };
 struct file_attr_flag file_attr_flags[] = {
-       {FILE_ATTRIBUTE_READONLY,               "READONLY"},
-       {FILE_ATTRIBUTE_HIDDEN,         "HIDDEN"},
-       {FILE_ATTRIBUTE_SYSTEM,         "SYSTEM"},
-       {FILE_ATTRIBUTE_DIRECTORY,              "DIRECTORY"},
-       {FILE_ATTRIBUTE_ARCHIVE,                "ARCHIVE"},
-       {FILE_ATTRIBUTE_DEVICE,         "DEVICE"},
-       {FILE_ATTRIBUTE_NORMAL,         "NORMAL"},
-       {FILE_ATTRIBUTE_TEMPORARY,              "TEMPORARY"},
-       {FILE_ATTRIBUTE_SPARSE_FILE,    "SPARSE_FILE"},
-       {FILE_ATTRIBUTE_REPARSE_POINT,  "REPARSE_POINT"},
-       {FILE_ATTRIBUTE_COMPRESSED,             "COMPRESSED"},
-       {FILE_ATTRIBUTE_OFFLINE,                "OFFLINE"},
+       {FILE_ATTRIBUTE_READONLY,           "READONLY"},
+       {FILE_ATTRIBUTE_HIDDEN,             "HIDDEN"},
+       {FILE_ATTRIBUTE_SYSTEM,             "SYSTEM"},
+       {FILE_ATTRIBUTE_DIRECTORY,          "DIRECTORY"},
+       {FILE_ATTRIBUTE_ARCHIVE,            "ARCHIVE"},
+       {FILE_ATTRIBUTE_DEVICE,             "DEVICE"},
+       {FILE_ATTRIBUTE_NORMAL,             "NORMAL"},
+       {FILE_ATTRIBUTE_TEMPORARY,          "TEMPORARY"},
+       {FILE_ATTRIBUTE_SPARSE_FILE,        "SPARSE_FILE"},
+       {FILE_ATTRIBUTE_REPARSE_POINT,      "REPARSE_POINT"},
+       {FILE_ATTRIBUTE_COMPRESSED,         "COMPRESSED"},
+       {FILE_ATTRIBUTE_OFFLINE,            "OFFLINE"},
        {FILE_ATTRIBUTE_NOT_CONTENT_INDEXED,"NOT_CONTENT_INDEXED"},
-       {FILE_ATTRIBUTE_ENCRYPTED,              "ENCRYPTED"},
-       {FILE_ATTRIBUTE_VIRTUAL,                "VIRTUAL"},
+       {FILE_ATTRIBUTE_ENCRYPTED,          "ENCRYPTED"},
+       {FILE_ATTRIBUTE_VIRTUAL,            "VIRTUAL"},
 };
 
-/* Prints a directory entry.  @lookup_table is a pointer to the lookup table, or
- * NULL if the resource entry for the dentry is not to be printed. */
+/* Prints a directory entry.  @lookup_table is a pointer to the lookup table, if
+ * available.  If the dentry is unresolved and the lookup table is NULL, the
+ * lookup table entries will not be printed.  Otherwise, they will be. */
 int print_dentry(struct dentry *dentry, void *lookup_table)
 {
+       const u8 *hash;
        struct lookup_table_entry *lte;
-       unsigned i;
 
        printf("[DENTRY]\n");
        printf("Length            = %"PRIu64"\n", dentry->length);
        printf("Attributes        = 0x%x\n", dentry->attributes);
-       for (i = 0; i < ARRAY_LEN(file_attr_flags); i++)
+       for (unsigned i = 0; i < ARRAY_LEN(file_attr_flags); i++)
                if (file_attr_flags[i].flag & dentry->attributes)
                        printf("    FILE_ATTRIBUTE_%s is set\n",
                                file_attr_flags[i].name);
        printf("Security ID       = %d\n", dentry->security_id);
        printf("Subdir offset     = %"PRIu64"\n", dentry->subdir_offset);
-       /*printf("Unused1           = 0x%"PRIu64"\n", dentry->unused1);*/
-       /*printf("Unused2           = %"PRIu64"\n", dentry->unused2);*/
-       printf("Creation Time     = 0x%"PRIx64"\n", dentry->creation_time);
-       printf("Last Access Time  = 0x%"PRIx64"\n", dentry->last_access_time);
-       printf("Last Write Time   = 0x%"PRIx64"\n", dentry->last_write_time);
-       printf("Hash              = 0x"); 
-       print_hash(dentry->hash); 
-       putchar('\n');
+#if 0
+       printf("Unused1           = 0x%"PRIu64"\n", dentry->unused1);
+       printf("Unused2           = %"PRIu64"\n", dentry->unused2);
+#endif
+#if 0
+       printf("Creation Time     = 0x%"PRIx64"\n");
+       printf("Last Access Time  = 0x%"PRIx64"\n");
+       printf("Last Write Time   = 0x%"PRIx64"\n");
+#endif
+
+       /* Translate the timestamps into something readable */
+       time_t creat_time = wim_timestamp_to_unix(dentry->creation_time);
+       time_t access_time = wim_timestamp_to_unix(dentry->last_access_time);
+       time_t mod_time = wim_timestamp_to_unix(dentry->last_write_time);
+       printf("Creation Time     = %s", asctime(gmtime(&creat_time)));
+       printf("Last Access Time  = %s", asctime(gmtime(&access_time)));
+       printf("Last Write Time   = %s", asctime(gmtime(&mod_time)));
+
        printf("Reparse Tag       = 0x%"PRIx32"\n", dentry->reparse_tag);
        printf("Hard Link Group   = 0x%"PRIx64"\n", dentry->hard_link);
        printf("Number of Alternate Data Streams = %hu\n", dentry->num_ads);
@@ -446,41 +487,51 @@ int print_dentry(struct dentry *dentry, void *lookup_table)
        puts("\"");
        printf("Short Name Length = %hu\n", dentry->short_name_len);
        printf("Full Path (UTF-8) = \"%s\"\n", dentry->full_path_utf8);
-       if (lookup_table && (lte = __lookup_resource(lookup_table, dentry->hash)))
-               print_lookup_table_entry(lte, NULL);
-       else
-               putchar('\n');
+       lte = dentry_stream_lte(dentry, 0, lookup_table);
+       if (lte) {
+               print_lookup_table_entry(lte);
+       } else {
+               hash = dentry_stream_hash(dentry, 0);
+               if (hash) {
+                       printf("Hash              = 0x"); 
+                       print_hash(hash);
+                       putchar('\n');
+                       putchar('\n');
+               }
+       }
        for (u16 i = 0; i < dentry->num_ads; i++) {
                printf("[Alternate Stream Entry %u]\n", i);
                printf("Name = \"%s\"\n", dentry->ads_entries[i].stream_name_utf8);
                printf("Name Length (UTF-16) = %u\n",
                                dentry->ads_entries[i].stream_name_len);
-               printf("Hash              = 0x"); 
-               print_hash(dentry->ads_entries[i].hash); 
-               if (lookup_table &&
-                    (lte = __lookup_resource(lookup_table,
-                                             dentry->ads_entries[i].hash)))
-               {
-                       print_lookup_table_entry(lte, NULL);
-               } else {
+               hash = dentry_stream_hash(dentry, i + 1);
+               if (hash) {
+                       printf("Hash              = 0x"); 
+                       print_hash(hash);
                        putchar('\n');
                }
+               print_lookup_table_entry(dentry_stream_lte(dentry, i + 1,
+                                                          lookup_table));
        }
        return 0;
 }
 
-static inline void dentry_common_init(struct dentry *dentry)
+/* Initializations done on every `struct dentry'. */
+static void dentry_common_init(struct dentry *dentry)
 {
        memset(dentry, 0, sizeof(struct dentry));
        dentry->refcnt = 1;
        dentry->security_id = -1;
+       dentry->ads_entries_status = ADS_ENTRIES_DEFAULT;
+       dentry->lte_group_list.type = STREAM_TYPE_NORMAL;
 }
 
 /* 
  * Creates an unlinked directory entry.
  *
- * @name:    The base name of the new dentry.
- * @return:  A pointer to the new dentry, or NULL if out of memory.
+ * @name:  The UTF-8 filename of the new dentry.
+ *
+ * Returns a pointer to the new dentry, or NULL if out of memory.
  */
 struct dentry *new_dentry(const char *name)
 {
@@ -498,6 +549,7 @@ struct dentry *new_dentry(const char *name)
        dentry->next   = dentry;
        dentry->prev   = dentry;
        dentry->parent = dentry;
+       INIT_LIST_HEAD(&dentry->link_group_list);
        return dentry;
 err:
        FREE(dentry);
@@ -514,23 +566,56 @@ void dentry_free_ads_entries(struct dentry *dentry)
        dentry->num_ads = 0;
 }
 
-
-void free_dentry(struct dentry *dentry)
+static void __destroy_dentry(struct dentry *dentry)
 {
        FREE(dentry->file_name);
        FREE(dentry->file_name_utf8);
        FREE(dentry->short_name);
        FREE(dentry->full_path_utf8);
-       dentry_free_ads_entries(dentry);
+       FREE(dentry->extracted_file);
+}
+
+/* Frees a WIM dentry. */
+void free_dentry(struct dentry *dentry)
+{
+       wimlib_assert(dentry);
+       __destroy_dentry(dentry);
+       /* Don't destroy the ADS entries if they "belong" to a different dentry
+        * */
+       if (dentry->ads_entries_status != ADS_ENTRIES_USER)
+               dentry_free_ads_entries(dentry);
        FREE(dentry);
 }
 
-/* clones a dentry.
+/* Like free_dentry(), but assigns a new ADS entries owner if this dentry was
+ * the previous owner, and also deletes the dentry from its link_group_list */
+void put_dentry(struct dentry *dentry)
+{
+       if (dentry->ads_entries_status == ADS_ENTRIES_OWNER) {
+               struct dentry *new_owner;
+               list_for_each_entry(new_owner, &dentry->link_group_list,
+                                   link_group_list)
+               {
+                       if (new_owner->ads_entries_status == ADS_ENTRIES_USER) {
+                               new_owner->ads_entries_status = ADS_ENTRIES_OWNER;
+                               break;
+                       }
+               }
+               dentry->ads_entries_status = ADS_ENTRIES_USER;
+       }
+       struct list_head *next;
+       list_del(&dentry->link_group_list);
+       free_dentry(dentry);
+}
+
+
+/* Partically clones a dentry.
  *
  * Beware:
- *     - memory for file names is not cloned
+ *     - memory for file names is not cloned (the pointers are all set to NULL
+ *       and the lengths are set to zero)
  *     - next, prev, and children pointers and not touched
- *     - stream entries are not cloned.
+ *     - stream entries are not cloned (pointer left untouched).
  */
 struct dentry *clone_dentry(struct dentry *old)
 {
@@ -547,26 +632,24 @@ struct dentry *clone_dentry(struct dentry *old)
        return new;
 }
 
-/* Arguments for do_free_dentry(). */
-struct free_dentry_args {
-       struct lookup_table *lookup_table;
-       bool lt_decrement_refcnt;
-};
-
 /* 
  * This function is passed as an argument to for_dentry_in_tree_depth() in order
  * to free a directory tree.  __args is a pointer to a `struct free_dentry_args'.
  */
-static int do_free_dentry(struct dentry *dentry, void *__args)
+static int do_free_dentry(struct dentry *dentry, void *__lookup_table)
 {
-       struct free_dentry_args *args = (struct free_dentry_args*)__args;
+       struct lookup_table *lookup_table = __lookup_table;
+       struct lookup_table_entry *lte;
+       unsigned i;
 
-       if (args->lt_decrement_refcnt && !dentry_is_directory(dentry)) {
-               lookup_table_decrement_refcnt(args->lookup_table, 
-                                             dentry->hash);
+       if (lookup_table) {
+               for (i = 0; i <= dentry->num_ads; i++) {
+                       lte = dentry_stream_lte(dentry, i, lookup_table);
+                       lte_decrement_refcnt(lte, lookup_table);
+               }
        }
 
-       wimlib_assert(dentry->refcnt >= 1);
+       wimlib_assert(dentry->refcnt != 0);
        if (--dentry->refcnt == 0)
                free_dentry(dentry);
        return 0;
@@ -576,20 +659,16 @@ static int do_free_dentry(struct dentry *dentry, void *__args)
  * Unlinks and frees a dentry tree.
  *
  * @root:              The root of the tree.
- * @lookup_table:      The lookup table for dentries.
- * @decrement_refcnt:          True if the dentries in the tree are to have their 
- *                     reference counts in the lookup table decremented.
+ * @lookup_table:      The lookup table for dentries.  If non-NULL, the
+ *                     reference counts in the lookup table for the lookup
+ *                     table entries corresponding to the dentries will be
+ *                     decremented.
  */
-void free_dentry_tree(struct dentry *root, struct lookup_table *lookup_table, 
-                     bool lt_decrement_refcnt)
+void free_dentry_tree(struct dentry *root, struct lookup_table *lookup_table)
 {
        if (!root || !root->parent)
                return;
-
-       struct free_dentry_args args;
-       args.lookup_table        = lookup_table;
-       args.lt_decrement_refcnt = lt_decrement_refcnt;
-       for_dentry_in_tree_depth(root, do_free_dentry, &args);
+       for_dentry_in_tree_depth(root, do_free_dentry, lookup_table);
 }
 
 int increment_dentry_refcnt(struct dentry *dentry, void *ignore)
@@ -606,6 +685,7 @@ int increment_dentry_refcnt(struct dentry *dentry, void *ignore)
  */
 void link_dentry(struct dentry *dentry, struct dentry *parent)
 {
+       wimlib_assert(dentry_is_directory(parent));
        dentry->parent = parent;
        if (parent->children) {
                /* Not an only child; link to siblings. */
@@ -621,7 +701,13 @@ void link_dentry(struct dentry *dentry, struct dentry *parent)
        }
 }
 
-/* Unlink a dentry from the directory tree. */
+
+/* Unlink a dentry from the directory tree. 
+ *
+ * Note: This merely removes it from the in-memory tree structure.  See
+ * remove_dentry() in mount.c for a function implemented on top of this one that
+ * frees the dentry and implements reference counting for the lookup table
+ * entries. */
 void unlink_dentry(struct dentry *dentry)
 {
        if (dentry_is_root(dentry))
@@ -647,36 +733,35 @@ static inline void recalculate_dentry_size(struct dentry *dentry)
        dentry->length = (dentry->length + 7) & ~7;
 }
 
-static int do_name_change(char **file_name_ret,
-                         char **file_name_utf8_ret,
-                         u16 *file_name_len_ret,
-                         u16 *file_name_utf8_len_ret,
-                         const char *new_name)
+/* Duplicates a UTF-8 name into UTF-8 and UTF-16 strings and returns the strings
+ * and their lengths in the pointer arguments */
+int get_names(char **name_utf16_ret, char **name_utf8_ret,
+             u16 *name_utf16_len_ret, u16 *name_utf8_len_ret,
+             const char *name)
 {
        size_t utf8_len;
        size_t utf16_len;
-       char *file_name, *file_name_utf8;
+       char *name_utf16, *name_utf8;
 
-       utf8_len = strlen(new_name);
+       utf8_len = strlen(name);
 
-       file_name = utf8_to_utf16(new_name, utf8_len, &utf16_len);
+       name_utf16 = utf8_to_utf16(name, utf8_len, &utf16_len);
 
-       if (!file_name)
+       if (!name_utf16)
                return WIMLIB_ERR_NOMEM;
 
-       file_name_utf8 = MALLOC(utf8_len + 1);
-       if (!file_name_utf8) {
-               FREE(file_name);
+       name_utf8 = MALLOC(utf8_len + 1);
+       if (!name_utf8) {
+               FREE(name_utf8);
                return WIMLIB_ERR_NOMEM;
        }
-       memcpy(file_name_utf8, new_name, utf8_len + 1);
-
-       FREE(*file_name_ret);
-       FREE(*file_name_utf8_ret);
-       *file_name_ret          = file_name;
-       *file_name_utf8_ret     = file_name_utf8;
-       *file_name_len_ret      = utf16_len;
-       *file_name_utf8_len_ret = utf8_len;
+       memcpy(name_utf8, name, utf8_len + 1);
+       FREE(*name_utf8_ret);
+       FREE(*name_utf16_ret);
+       *name_utf8_ret      = name_utf8;
+       *name_utf16_ret     = name_utf16;
+       *name_utf8_len_ret  = utf8_len;
+       *name_utf16_len_ret = utf16_len;
        return 0;
 }
 
@@ -687,20 +772,22 @@ int change_dentry_name(struct dentry *dentry, const char *new_name)
 {
        int ret;
 
-       ret = do_name_change(&dentry->file_name, &dentry->file_name_utf8,
-                            &dentry->file_name_len, &dentry->file_name_utf8_len,
-                            new_name);
+       ret = get_names(&dentry->file_name, &dentry->file_name_utf8,
+                       &dentry->file_name_len, &dentry->file_name_utf8_len,
+                        new_name);
        if (ret == 0)
                recalculate_dentry_size(dentry);
        return ret;
 }
 
+/*
+ * Changes the name of an alternate data stream */
 int change_ads_name(struct ads_entry *entry, const char *new_name)
 {
-       return do_name_change(&entry->stream_name, &entry->stream_name_utf8,
-                             &entry->stream_name_len,
-                             &entry->stream_name_utf8_len,
-                             new_name);
+       return get_names(&entry->stream_name, &entry->stream_name_utf8,
+                        &entry->stream_name_len,
+                        &entry->stream_name_utf8_len,
+                        new_name);
 }
 
 /* Parameters for calculate_dentry_statistics(). */
@@ -716,7 +803,6 @@ static int calculate_dentry_statistics(struct dentry *dentry, void *arg)
 {
        struct image_statistics *stats;
        struct lookup_table_entry *lte; 
-       u16 i;
        
        stats = arg;
 
@@ -725,25 +811,18 @@ static int calculate_dentry_statistics(struct dentry *dentry, void *arg)
        else
                ++*stats->file_count;
 
-       lte = __lookup_resource(stats->lookup_table, dentry->hash);
-       i = 0;
-       while (1) {
+       for (unsigned i = 0; i <= dentry->num_ads; i++) {
+               lte = dentry_stream_lte(dentry, i, stats->lookup_table);
                if (lte) {
-                       u64 size = lte->resource_entry.original_size;
-                       *stats->total_bytes += size;
+                       *stats->total_bytes += wim_resource_size(lte);
                        if (++lte->out_refcnt == 1)
-                               *stats->hard_link_bytes += size;
+                               *stats->hard_link_bytes += wim_resource_size(lte);
                }
-               if (i == dentry->num_ads)
-                       break;
-               lte = __lookup_resource(stats->lookup_table,
-                                       dentry->ads_entries[i].hash);
-               i++;
        }
-
        return 0;
 }
 
+/* Calculates some statistics about a dentry tree. */
 void calculate_dir_tree_statistics(struct dentry *root, struct lookup_table *table, 
                                   u64 *dir_count_ret, u64 *file_count_ret, 
                                   u64 *total_bytes_ret, 
@@ -763,25 +842,64 @@ void calculate_dir_tree_statistics(struct dentry *root, struct lookup_table *tab
        for_dentry_in_tree(root, calculate_dentry_statistics, &stats);
 }
 
+
+/* 
+ * Reads the alternate data stream entries for a dentry.
+ *
+ * @p: Pointer to buffer that starts with the first alternate stream entry.
+ *
+ * @dentry:    Dentry to load the alternate data streams into.
+ *                     @dentry->num_ads must have been set to the number of
+ *                     alternate data streams that are expected.
+ *
+ * @remaining_size:    Number of bytes of data remaining in the buffer pointed
+ *                             to by @p.
+ *
+ * The format of the on-disk alternate stream entries is as follows:
+ *
+ * struct ads_entry_on_disk {
+ *     u64  length;          // Length of the entry, in bytes.  This includes
+ *                                 all fields (including the stream name, the
+ *                                 null terminator, AND the padding!).
+ *     u64  reserved;        // Seems to be unused
+ *     u8   hash[20];        // SHA1 message digest of the uncompressed stream
+ *     u16  stream_name_len; // Length of the stream name, in bytes
+ *     char stream_name[];   // Stream name in UTF-16LE, @stream_name_len bytes long,
+ *                                  not including null terminator
+ *     u16  zero;            // UTF-16 null terminator for the stream name, NOT
+ *                                 included in @stream_name_len
+ *     char padding[];       // Padding to make the size a multiple of 8 bytes.
+ * };
+ *
+ * In addition, the entries are 8-byte aligned.
+ *
+ * Return 0 on success or nonzero on failure.  On success, dentry->ads_entries
+ * is set to an array of `struct ads_entry's of length dentry->num_ads.  On
+ * failure, @dentry is not modified.
+ */
 static int read_ads_entries(const u8 *p, struct dentry *dentry,
                            u64 remaining_size)
 {
-       u16 num_ads = dentry->num_ads;
-       struct ads_entry *ads_entries = CALLOC(num_ads, sizeof(struct ads_entry));
+       u16 num_ads;
+       struct ads_entry *ads_entries;
        int ret;
+
+       num_ads = dentry->num_ads;
+       ads_entries = CALLOC(num_ads, sizeof(struct ads_entry));
        if (!ads_entries) {
                ERROR("Could not allocate memory for %"PRIu16" "
                      "alternate data stream entries", num_ads);
                return WIMLIB_ERR_NOMEM;
        }
-       DEBUG2("Reading %"PRIu16" alternate data streams "
-              "(remaining size = %"PRIu64")", num_ads, remaining_size);
 
        for (u16 i = 0; i < num_ads; i++) {
                struct ads_entry *cur_entry = &ads_entries[i];
                u64 length;
+               u64 length_no_padding;
+               u64 total_length;
                size_t utf8_len;
                const char *p_save = p;
+
                /* Read the base stream entry, excluding the stream name. */
                if (remaining_size < WIM_ADS_ENTRY_DISK_SIZE) {
                        ERROR("Stream entries go past end of metadata resource");
@@ -789,30 +907,47 @@ static int read_ads_entries(const u8 *p, struct dentry *dentry,
                        ret = WIMLIB_ERR_INVALID_DENTRY;
                        goto out_free_ads_entries;
                }
-               remaining_size -= WIM_ADS_ENTRY_DISK_SIZE;
 
-               p = get_u64(p, &length); /* ADS entry length */
-
-               DEBUG2("ADS length = %"PRIu64, length);
-
-               p += 8; /* Unused */
-               p = get_bytes(p, WIM_HASH_SIZE, (u8*)cur_entry->hash);
+               p = get_u64(p, &length);
+               p += 8;
+               p = get_bytes(p, SHA1_HASH_SIZE, (u8*)cur_entry->hash);
                p = get_u16(p, &cur_entry->stream_name_len);
 
-               DEBUG2("Stream name length = %u", cur_entry->stream_name_len);
-
                cur_entry->stream_name = NULL;
                cur_entry->stream_name_utf8 = NULL;
 
-               if (remaining_size < cur_entry->stream_name_len + 2) {
+               /* Length including neither the null terminator nor the padding
+                * */
+               length_no_padding = WIM_ADS_ENTRY_DISK_SIZE +
+                                   cur_entry->stream_name_len;
+               total_length = ((length_no_padding + 2) + 7) & ~7;
+
+               wimlib_assert(total_length == ads_entry_total_length(cur_entry));
+
+               if (remaining_size < length_no_padding) {
                        ERROR("Stream entries go past end of metadata resource");
-                       ERROR("(remaining_size = %"PRIu64" bytes, stream_name_len "
-                             "= %"PRIu16" bytes", remaining_size,
-                             cur_entry->stream_name_len);
+                       ERROR("(remaining_size = %"PRIu64" bytes, "
+                             "length_no_padding = %"PRIu16" bytes",
+                             remaining_size, length_no_padding);
+                       ret = WIMLIB_ERR_INVALID_DENTRY;
+                       goto out_free_ads_entries;
+               }
+
+               /* The @length field in the on-disk ADS entry is expected to be
+                * equal to @total_length, which includes all of the entry and
+                * the padding that follows it to align the next ADS entry to an
+                * 8-byte boundary.  However, to be safe, we'll accept the
+                * length field as long as it's not less than the un-padded
+                * total length and not more than the padded total length. */
+               if (length < length_no_padding || length > total_length) {
+                       ERROR("Stream entry has unexpected length "
+                             "field (length field = %"PRIu64", "
+                             "unpadded total length = %"PRIu64", "
+                             "padded total length = %"PRIu64")",
+                             length, length_no_padding, total_length);
                        ret = WIMLIB_ERR_INVALID_DENTRY;
                        goto out_free_ads_entries;
                }
-               remaining_size -= cur_entry->stream_name_len + 2;
 
                cur_entry->stream_name = MALLOC(cur_entry->stream_name_len);
                if (!cur_entry->stream_name) {
@@ -830,7 +965,19 @@ static int read_ads_entries(const u8 *p, struct dentry *dentry,
                        ret = WIMLIB_ERR_NOMEM;
                        goto out_free_ads_entries;
                }
-               p = p_save + ads_entry_length(cur_entry);
+               /* It's expected that the size of every ADS entry is a multiple
+                * of 8.  However, to be safe, I'm allowing the possibility of
+                * an ADS entry at the very end of the metadata resource ending
+                * un-aligned.  So although we still need to increment the input
+                * pointer by @total_length to reach the next ADS entry, it's
+                * possible that less than @total_length is actually remaining
+                * in the metadata resource. We should set the remaining size to
+                * 0 bytes if this happens. */
+               p = p_save + total_length;
+               if (remaining_size < total_length)
+                       remaining_size = 0;
+               else
+                       remaining_size -= total_length;
        }
        dentry->ads_entries = ads_entries;
        return 0;
@@ -844,7 +991,19 @@ out_free_ads_entries:
 }
 
 /* 
- * Reads a directory entry from the metadata resource.
+ * Reads a directory entry, including all alternate data stream entries that
+ * follow it, from the WIM image's metadata resource.
+ *
+ * @metadata_resource: Buffer containing the uncompressed metadata resource.
+ * @metadata_resource_len:   Length of the metadata resource.
+ * @offset:    Offset of this directory entry in the metadata resource.
+ * @dentry:    A `struct dentry' that will be filled in by this function.
+ *
+ * Return 0 on success or nonzero on failure.  On failure, @dentry have been
+ * modified, bu it will be left with no pointers to any allocated buffers.
+ * On success, the dentry->length field must be examined.  If zero, this was a
+ * special "end of directory" dentry and not a real dentry.  If nonzero, this
+ * was a real dentry.
  */
 int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len, 
                u64 offset, struct dentry *dentry)
@@ -869,8 +1028,8 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
                return WIMLIB_ERR_INVALID_DENTRY;
        }
 
-       /* Before reading the whole entry, we need to read just the length.
-        * This is because aentry of length 8 (that is, just the length field)
+       /* Before reading the whole dentry, we need to read just the length.
+        * This is because a dentry of length 8 (that is, just the length field)
         * terminates the list of sibling directory entries. */
 
        p = get_u64(&metadata_resource[offset], &dentry->length);
@@ -878,10 +1037,14 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
        /* A zero length field (really a length of 8, since that's how big the
         * directory entry is...) indicates that this is the end of directory
         * dentry.  We do not read it into memory as an actual dentry, so just
-        * return true in that case. */
+        * return successfully in that case. */
        if (dentry->length == 0)
                return 0;
 
+       /* If the dentry does not overflow the metadata resource buffer and is
+        * not too short, read the rest of it (excluding the alternate data
+        * streams, but including the file name and short name variable-length
+        * fields) into memory. */
        if (offset + dentry->length >= metadata_resource_len) {
                ERROR("Directory entry at offset %"PRIu64" and with size "
                      "%"PRIu64" ends past the end of the metadata resource "
@@ -890,9 +1053,6 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
                return WIMLIB_ERR_INVALID_DENTRY;
        }
 
-       /* If it is a recognized length, read the rest of the directory entry.
-        * Note: The root directory entry has no name, and its length does not
-        * include the short name length field.  */
        if (dentry->length < WIM_DENTRY_DISK_SIZE) {
                ERROR("Directory entry has invalid length of %"PRIu64" bytes",
                      dentry->length);
@@ -912,7 +1072,7 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
        p = get_u64(p, &dentry->last_access_time);
        p = get_u64(p, &dentry->last_write_time);
 
-       p = get_bytes(p, WIM_HASH_SIZE, dentry->hash);
+       p = get_bytes(p, SHA1_HASH_SIZE, dentry->hash);
        
        /*
         * I don't know what's going on here.  It seems like M$ screwed up the
@@ -932,13 +1092,15 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
 
        /* By the way, the reparse_reserved field does not actually exist (at
         * least when the file is not a reparse point) */
-
        
        p = get_u16(p, &dentry->num_ads);
 
        p = get_u16(p, &short_name_len);
        p = get_u16(p, &file_name_len);
 
+       /* We now know the length of the file name and short name.  These should
+        * be included in the dentry length, but make sure the numbers are
+        * consistent. */
        calculated_size = WIM_DENTRY_DISK_SIZE + file_name_len + 2 +
                          short_name_len;
 
@@ -986,24 +1148,21 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
 
        p = get_bytes(p, short_name_len, short_name);
 
-       /* Some directory entries inexplicibly have a little over 70 bytes of
+       /* Some directory entries inexplicably have a little over 70 bytes of
         * extra data.  The exact amount of data seems to be 72 bytes, but it is
-        * aligned on the next 8-byte boundary.  Here's an example of the
-        * aligned data:
+        * aligned on the next 8-byte boundary.  It does NOT seem to be
+        * alternate data stream entries.  Here's an example of the aligned
+        * data:
         *
-        * 01000000400000006c786bbac58ede11b0bb00261870892ab6adb76fe63a3
-        * e468fca86530d2effa16c786bbac58ede11b0bb00261870892a0000000000
-        * 0000000000000000000000
+        * 01000000 40000000 6c786bba c58ede11 b0bb0026 1870892a b6adb76f
+        * e63a3e46 8fca8653 0d2effa1 6c786bba c58ede11 b0bb0026 1870892a
+        * 00000000 00000000 00000000 00000000
         *
         * Here's one interpretation of how the data is laid out.
         *
         * struct unknown {
         *      u32 field1; (always 0x00000001)
         *      u32 field2; (always 0x40000000)
-        *      u16 field3;
-        *      u32 field4;
-        *      u32 field5;
-        *      u32 field6;
         *      u8  data[48]; (???)
         *      u64 reserved1; (always 0)
         *      u64 reserved2; (always 0)
@@ -1019,6 +1178,15 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
        }
 #endif
 
+       /* 
+        * Read the alternate data streams, if present.  dentry->num_ads tells
+        * us how many they are, and they will directly follow the dentry
+        * on-disk.
+        *
+        * Note that each alternate data stream entry begins on an 8-byte
+        * aligned boundary, and the alternate data stream entries are NOT
+        * included in the dentry->length field for some reason.
+        */
        if (dentry->num_ads != 0) {
                calculated_size = (calculated_size + 7) & ~7;
                if (calculated_size > metadata_resource_len - offset) {
@@ -1034,6 +1202,8 @@ int read_dentry(const u8 metadata_resource[], u64 metadata_resource_len,
                        goto out_free_short_name;
        }
 
+       /* We've read all the data for this dentry.  Set the names and their
+        * lengths, and we've done. */
        dentry->file_name          = file_name;
        dentry->file_name_utf8     = file_name_utf8;
        dentry->short_name         = short_name;
@@ -1051,7 +1221,7 @@ out_free_file_name:
 }
 
 /* 
- * Writes a dentry to an output buffer.
+ * Writes a WIM dentry to an output buffer.
  *
  * @dentry:  The dentry structure.
  * @p:       The memory location to write the data to.
@@ -1062,6 +1232,7 @@ static u8 *write_dentry(const struct dentry *dentry, u8 *p)
 {
        u8 *orig_p = p;
        unsigned padding;
+       const u8 *hash;
 
        p = put_u64(p, dentry->length);
        p = put_u32(p, dentry->attributes);
@@ -1072,14 +1243,23 @@ static u8 *write_dentry(const struct dentry *dentry, u8 *p)
        p = put_u64(p, dentry->creation_time);
        p = put_u64(p, dentry->last_access_time);
        p = put_u64(p, dentry->last_write_time);
-       p = put_bytes(p, WIM_HASH_SIZE, dentry->hash);
+       if (dentry->resolved && dentry->lte)
+               hash = dentry->lte->hash;
+       else
+               hash = dentry->hash;
+       p = put_bytes(p, SHA1_HASH_SIZE, hash);
        if (dentry->attributes & FILE_ATTRIBUTE_REPARSE_POINT) {
                p = put_zeroes(p, 4);
                p = put_u32(p, dentry->reparse_tag);
                p = put_zeroes(p, 4);
        } else {
-               p = put_u32(p, dentry->reparse_tag);
-               p = put_u64(p, dentry->hard_link);
+               u64 hard_link;
+               p = put_u32(p, 0);
+               if (dentry->link_group_list.next == &dentry->link_group_list)
+                       hard_link = 0;
+               else
+                       hard_link = dentry->hard_link;
+               p = put_u64(p, hard_link);
        }
        p = put_u16(p, dentry->num_ads);
        p = put_u16(p, dentry->short_name_len);
@@ -1092,45 +1272,51 @@ static u8 *write_dentry(const struct dentry *dentry, u8 *p)
        if (p - orig_p < dentry->length)
                p = put_zeroes(p, dentry->length - (p - orig_p));
 
-       p = put_zeroes(p, (8 - (p - orig_p) % 8) % 8);
+       /* Align to 8-byte boundary */
+       p = put_zeroes(p, (8 - dentry->length % 8) % 8);
 
+       /* Write the alternate data streams, if there are any.  Please see
+        * read_ads_entries() for comments about the format of the on-disk
+        * alternate data stream entries. */
        for (u16 i = 0; i < dentry->num_ads; i++) {
-               p = put_u64(p, ads_entry_length(&dentry->ads_entries[i]));
+               p = put_u64(p, ads_entry_total_length(&dentry->ads_entries[i]));
                p = put_u64(p, 0); /* Unused */
-               p = put_bytes(p, WIM_HASH_SIZE, dentry->ads_entries[i].hash);
+               if (dentry->resolved && dentry->ads_entries[i].lte)
+                       hash = dentry->ads_entries[i].lte->hash;
+               else
+                       hash = dentry->ads_entries[i].hash;
+               p = put_bytes(p, SHA1_HASH_SIZE, hash);
                p = put_u16(p, dentry->ads_entries[i].stream_name_len);
                p = put_bytes(p, dentry->ads_entries[i].stream_name_len,
                                 (u8*)dentry->ads_entries[i].stream_name);
+               p = put_u16(p, 0);
                p = put_zeroes(p, (8 - (p - orig_p) % 8) % 8);
        }
        return p;
 }
 
-/* Recursive function that writes a dentry tree rooted at @tree, not including
- * @tree itself, which has already been written, except in the case of the root
- * dentry, which is written right away, along with an end-of-directory entry. */
-u8 *write_dentry_tree(const struct dentry *tree, u8 *p)
+/* Recursive function that writes a dentry tree rooted at @parent, not including
+ * @parent itself, which has already been written. */
+static u8 *write_dentry_tree_recursive(const struct dentry *parent, u8 *p)
 {
        const struct dentry *child;
 
-       if (dentry_is_root(tree)) {
-               p = write_dentry(tree, p);
+       /* Nothing to do if this dentry has no children. */
+       if (parent->subdir_offset == 0)
+               return p;
 
-               /* write end of directory entry */
-               p = put_u64(p, 0);
-       } else {
-               /* Nothing to do for non-directories */
-               if (!dentry_is_directory(tree))
-                       return p;
-       }
-
-       /* Write child dentries and end-of-directory entry. */
-       child = tree->children;
+       /* Write child dentries and end-of-directory entry. 
+        *
+        * Note: we need to write all of this dentry's children before
+        * recursively writing the directory trees rooted at each of the child
+        * dentries, since the on-disk dentries for a dentry's children are
+        * always located at consecutive positions in the metadata resource! */
+       child = parent->children;
        if (child) {
                do {
                        p = write_dentry(child, p);
                        child = child->next;
-               } while (child != tree->children);
+               } while (child != parent->children);
        }
 
        /* write end of directory entry */
@@ -1139,20 +1325,46 @@ u8 *write_dentry_tree(const struct dentry *tree, u8 *p)
        /* Recurse on children. */
        if (child) {
                do {
-                       p = write_dentry_tree(child, p);
+                       p = write_dentry_tree_recursive(child, p);
                        child = child->next;
-               } while (child != tree->children);
+               } while (child != parent->children);
        }
        return p;
 }
 
+/* Writes a directory tree to the metadata resource.
+ *
+ * @root:      Root of the dentry tree.
+ * @p:         Pointer to a buffer with enough space for the dentry tree.
+ *
+ * Returns pointer to the byte after the last byte we wrote.
+ */
+u8 *write_dentry_tree(const struct dentry *root, u8 *p)
+{
+       wimlib_assert(dentry_is_root(root));
+
+       /* If we're the root dentry, we have no parent that already
+        * wrote us, so we need to write ourselves. */
+       p = write_dentry(root, p);
+
+       /* Write end of directory entry after the root dentry just to be safe;
+        * however the root dentry obviously cannot have any siblings. */
+       p = put_u64(p, 0);
+
+       /* Recursively write the rest of the dentry tree. */
+       return write_dentry_tree_recursive(root, p);
+}
+
 /* Reads the children of a dentry, and all their children, ..., etc. from the
  * metadata resource and into the dentry tree.
  *
  * @metadata_resource: An array that contains the uncompressed metadata
  *                     resource for the WIM file.
- * @metadata_resource_len:     The length of @metadata_resource.
- * @dentry:    A pointer to a struct dentry that is the root of the directory
+ *
+ * @metadata_resource_len:  The length of the uncompressed metadata resource, in
+ *                         bytes.
+ *
+ * @dentry:    A pointer to a `struct dentry' that is the root of the directory
  *             tree and has already been read from the metadata resource.  It
  *             does not need to be the real root because this procedure is
  *             called recursively.
@@ -1169,8 +1381,12 @@ int read_dentry_tree(const u8 metadata_resource[], u64 metadata_resource_len,
        struct dentry cur_child;
        int ret;
 
-       /* If @dentry is a regular file, nothing more needs to be done for this
-        * branch. */
+       /* 
+        * If @dentry has no child dentries, nothing more needs to be done for
+        * this branch.  This is the case for regular files, symbolic links, and
+        * *possibly* empty directories (although an empty directory may also
+        * have one child dentry that is the special end-of-directory dentry)
+        */
        if (cur_offset == 0)
                return 0;
 
@@ -1184,10 +1400,8 @@ int read_dentry_tree(const u8 metadata_resource[], u64 metadata_resource_len,
                        break;
 
                /* Check for end of directory. */
-               if (cur_child.length == 0) {
-                       ret = 0;
+               if (cur_child.length == 0)
                        break;
-               }
 
                /* Not end of directory.  Allocate this child permanently and
                 * link it to the parent and previous child. */
@@ -1223,8 +1437,8 @@ int read_dentry_tree(const u8 metadata_resource[], u64 metadata_resource_len,
                cur_offset += dentry_total_length(child);
        }
 
-       /* Link last child to first one, and set parent's
-        * children pointer to the first child.  */
+       /* Link last child to first one, and set parent's children pointer to
+        * the first child.  */
        if (prev_child) {
                prev_child->next = first_child;
                first_child->prev = prev_child;