]> wimlib.net Git - wimlib/blobdiff - programs/imagex.c
imagex.c: Remove unused swap() macro
[wimlib] / programs / imagex.c
index 78eebaaad48136c9da71b91c2d9454174ec257d4..8e9e95218794e2481827406bcbf15781e6e30957 100644 (file)
@@ -35,9 +35,6 @@
 
 #define ARRAY_LEN(array) (sizeof(array) / sizeof(array[0]))
 
-#define swap(a, b) ({ typeof(a) __a = (a); typeof(b) __b = (b); \
-                               a = __b; b = __a; })
-
 #define for_opt(c, opts) while ((c = getopt_long_only(argc, (char**)argv, "", \
                                opts, NULL)) != -1)
 
@@ -61,44 +58,44 @@ static void usage(int cmd_type);
 static void usage_all();
 
 static const char *usage_strings[] = {
-[APPEND] = 
+[APPEND] =
 "    imagex append (DIRECTORY | NTFS_VOLUME) WIMFILE [IMAGE_NAME]\n"
 "                  [DESCRIPTION] [--boot] [--check] [--flags EDITION_ID]\n"
 "                  [--verbose] [--dereference] [--config=FILE]\n",
-[APPLY] = 
+[APPLY] =
 "    imagex apply WIMFILE [IMAGE_NUM | IMAGE_NAME | all]\n"
 "                 (DIRECTORY | NTFS_VOLUME) [--check] [--hardlink]\n"
 "                 [--symlink] [--verbose] [--ref=\"GLOB\"]\n",
-[CAPTURE] = 
+[CAPTURE] =
 "    imagex capture (DIRECTORY | NTFS_VOLUME) WIMFILE [IMAGE_NAME]\n"
 "                   [DESCRIPTION] [--boot] [--check] [--compress=TYPE]\n"
 "                   [--flags EDITION_ID] [--verbose] [--dereference]\n"
 "                   [--config=FILE]\n",
-[DELETE] = 
+[DELETE] =
 "    imagex delete WIMFILE (IMAGE_NUM | IMAGE_NAME | all) [--check]\n",
-[DIR] = 
+[DIR] =
 "    imagex dir WIMFILE (IMAGE_NUM | IMAGE_NAME | all)\n",
-[EXPORT] = 
+[EXPORT] =
 "    imagex export SRC_WIMFILE (SRC_IMAGE_NUM | SRC_IMAGE_NAME | all ) \n"
 "                  DEST_WIMFILE [DEST_IMAGE_NAME]\n"
 "                  [DEST_IMAGE_DESCRIPTION] [--boot] [--check]\n"
 "                  [--compress=TYPE] [--ref=\"GLOB\"]\n",
-[INFO] = 
+[INFO] =
 "    imagex info WIMFILE [IMAGE_NUM | IMAGE_NAME] [NEW_NAME]\n"
 "                [NEW_DESC] [--boot] [--check] [--header] [--lookup-table]\n"
 "                [--xml] [--extract-xml FILE] [--metadata]\n",
-[JOIN] = 
+[JOIN] =
 "    imagex join [--check] WIMFILE SPLIT_WIM...\n",
-[MOUNT] = 
+[MOUNT] =
 "    imagex mount WIMFILE (IMAGE_NUM | IMAGE_NAME) DIRECTORY\n"
 "                 [--check] [--debug] [--streams-interface=INTERFACE]\n"
 "                 [--ref=\"GLOB\"]\n",
-[MOUNTRW] = 
+[MOUNTRW] =
 "    imagex mountrw WIMFILE [IMAGE_NUM | IMAGE_NAME] DIRECTORY\n"
 "                   [--check] [--debug] [--streams-interface=INTERFACE]\n",
-[SPLIT] = 
+[SPLIT] =
 "    imagex split WIMFILE SPLIT_WIMFILE PART_SIZE_MB [--check]\n",
-[UNMOUNT] = 
+[UNMOUNT] =
 "    imagex unmount DIRECTORY [--commit] [--check]\n",
 };
 
@@ -108,15 +105,6 @@ static const struct option common_options[] = {
        {NULL, 0, NULL, 0},
 };
 
-static const struct option append_options[] = {
-       {"boot",        no_argument,       NULL, 'b'},
-       {"check",       no_argument,       NULL, 'c'},
-       {"config",      required_argument, NULL, 'C'},
-       {"dereference", no_argument,       NULL, 'L'},
-       {"flags",       required_argument, NULL, 'f'},
-       {"verbose",     no_argument,       NULL, 'v'},
-       {NULL, 0, NULL, 0},
-};
 static const struct option apply_options[] = {
        {"check",    no_argument,       NULL, 'c'},
        {"hardlink", no_argument,       NULL, 'h'},
@@ -125,7 +113,7 @@ static const struct option apply_options[] = {
        {"ref",      required_argument, NULL, 'r'},
        {NULL, 0, NULL, 0},
 };
-static const struct option capture_options[] = {
+static const struct option capture_or_append_options[] = {
        {"boot",        no_argument,       NULL, 'b'},
        {"check",       no_argument,       NULL, 'c'},
        {"compress",    required_argument, NULL, 'x'},
@@ -208,24 +196,6 @@ static void imagex_error_with_errno(const char *format, ...)
        va_end(va);
 }
 
-static const char *path_basename(const char *path)
-{
-       const char *p = path;
-       while (*p)
-               p++;
-       p--;
-
-       /* Trailing slashes. */
-       while ((p != path - 1) && *p == '/')
-               p--;
-
-       while ((p != path - 1) && *p != '/')
-               p--;
-
-       return p + 1;
-}
-
-
 static int verify_image_exists(int image)
 {
        if (image == WIM_NO_IMAGE) {
@@ -268,7 +238,7 @@ static int get_compression_type(const char *optarg)
        }
 }
 
-static const char *file_get_contents(const char *filename, size_t *len_ret)
+static char *file_get_contents(const char *filename, size_t *len_ret)
 {
        struct stat stbuf;
        char *buf;
@@ -337,8 +307,8 @@ static int open_swms_from_glob(const char *swm_glob,
                ret = -1;
                goto out_globfree;
        }
-       size_t offset = 0;
-       for (size_t i = 0; i < num_additional_swms; i++) {
+       unsigned offset = 0;
+       for (unsigned i = 0; i < num_additional_swms; i++) {
                if (strcmp(globbuf.gl_pathv[i], first_part) == 0) {
                        offset++;
                        continue;
@@ -363,120 +333,6 @@ out:
        return ret;
 }
 
-static int imagex_append(int argc, const char **argv)
-{
-       int c;
-       const char *flags_element = NULL;
-       int open_flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS;
-       int add_image_flags = 0;
-       int write_flags = WIMLIB_WRITE_FLAG_SHOW_PROGRESS;
-       const char *dir;
-       const char *wimfile;
-       const char *name;
-       const char *desc;
-       const char *config_file = NULL;
-       const char *config_str = NULL;
-       size_t config_len = 0;
-       WIMStruct *w;
-       int ret;
-       int cur_image;
-       char *default_name;
-
-       for_opt(c, append_options) {
-               switch (c) {
-               case 'b':
-                       add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_BOOT;
-                       break;
-               case 'c':
-                       open_flags |= WIMLIB_OPEN_FLAG_CHECK_INTEGRITY;
-                       write_flags |= WIMLIB_WRITE_FLAG_CHECK_INTEGRITY;
-                       break;
-               case 'C':
-                       config_file = optarg;
-                       break;
-               case 'f':
-                       flags_element = optarg;
-                       break;
-               case 'L':
-                       add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_DEREFERENCE;
-                       break;
-               case 'v':
-                       add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_VERBOSE;
-                       break;
-               default:
-                       usage(APPEND);
-                       return -1;
-               }
-       }
-       argc -= optind;
-       argv += optind;
-       if (argc < 2 || argc > 4) {
-               usage(APPEND);
-               return -1;
-       }
-       dir     = argv[0];
-       wimfile = argv[1];
-
-       char dir_copy[strlen(dir) + 1];
-       memcpy(dir_copy, dir, strlen(dir) + 1);
-       default_name = basename(dir_copy);
-
-       name    = (argc >= 3) ? argv[2] : default_name;
-       desc    = (argc >= 4) ? argv[3] : NULL;
-
-       if (config_file) {
-               config_str = file_get_contents(config_file, &config_len);
-               if (!config_str)
-                       return -1;
-       }
-
-       ret = wimlib_open_wim(wimfile, open_flags, &w);
-       if (ret != 0)
-               return ret;
-
-#ifdef WITH_NTFS_3G
-       struct stat stbuf;
-
-       ret = stat(dir, &stbuf);
-       if (ret == 0) {
-               if (S_ISBLK(stbuf.st_mode) || S_ISREG(stbuf.st_mode)) {
-                       const char *ntfs_device = dir;
-                       printf("Capturing WIM image NTFS filesystem on `%s'\n",
-                              ntfs_device);
-                       ret = wimlib_add_image_from_ntfs_volume(w, ntfs_device,
-                                                               name,
-                                                               config_str,
-                                                               config_len,
-                                                               add_image_flags);
-                       goto out_write;
-               }
-       } else {
-               if (errno != ENOENT)
-                       imagex_error_with_errno("Failed to stat `%s'", dir);
-       }
-#endif
-       ret = wimlib_add_image(w, dir, name, config_str, config_len,
-                              add_image_flags);
-
-out_write:
-       if (ret != 0)
-               goto out;
-       cur_image = wimlib_get_num_images(w);
-       if (desc) {
-               ret = wimlib_set_image_descripton(w, cur_image, desc);
-               if (ret != 0)
-                       goto out;
-       }
-       if (flags_element) {
-               ret = wimlib_set_image_flags(w, cur_image, flags_element);
-               if (ret != 0)
-                       goto out;
-       }
-       ret = wimlib_overwrite(w, write_flags);
-out:
-       wimlib_free(w);
-       return ret;
-}
 
 /* Extract one image, or all images, from a WIM file into a directory. */
 static int imagex_apply(int argc, const char **argv)
@@ -528,7 +384,7 @@ static int imagex_apply(int argc, const char **argv)
 
        wimfile = argv[0];
        if (argc == 2) {
-               image_num_or_name =  "1";
+               image_num_or_name = "1";
                dir = argv[1];
        } else {
                image_num_or_name = argv[1];
@@ -578,8 +434,11 @@ static int imagex_apply(int argc, const char **argv)
                        goto out;
                }
        } else {
-               if (errno != ENOENT)
+               if (errno != ENOENT) {
                        imagex_error_with_errno("Failed to stat `%s'", dir);
+                       ret = -1;
+                       goto out;
+               }
        }
 #endif
 
@@ -587,39 +446,42 @@ static int imagex_apply(int argc, const char **argv)
                                   additional_swms, num_additional_swms);
 out:
        wimlib_free(w);
-       if (additional_swms)
-               for (size_t i = 0; i < num_additional_swms; i++)
+       if (additional_swms) {
+               for (unsigned i = 0; i < num_additional_swms; i++)
                        wimlib_free(additional_swms[i]);
+               free(additional_swms);
+       }
        return ret;
 }
 
-
-/* Create a WIM file from a directory. */
-static int imagex_capture(int argc, const char **argv)
+static int imagex_capture_or_append(int argc, const char **argv)
 {
        int c;
+       int open_flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS;
        int add_image_flags = 0;
        int write_flags = WIMLIB_WRITE_FLAG_SHOW_PROGRESS;
        int compression_type = WIM_COMPRESSION_TYPE_XPRESS;
-       const char *flags_element = NULL;
        const char *dir;
        const char *wimfile;
        const char *name;
        const char *desc;
+       const char *flags_element = NULL;
        const char *config_file = NULL;
-       const char *config_str = NULL;
+       char *config_str = NULL;
        size_t config_len = 0;
-       WIMStruct *w;
+       WIMStruct *w = NULL;
+       int ret;
        int cur_image;
        char *default_name;
-       int ret;
+       int cmd = strcmp(argv[0], "append") ? CAPTURE : APPEND;
 
-       for_opt(c, capture_options) {
+       for_opt(c, capture_or_append_options) {
                switch (c) {
                case 'b':
                        add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_BOOT;
                        break;
                case 'c':
+                       open_flags |= WIMLIB_OPEN_FLAG_CHECK_INTEGRITY;
                        write_flags |= WIMLIB_WRITE_FLAG_CHECK_INTEGRITY;
                        break;
                case 'C':
@@ -633,34 +495,33 @@ static int imagex_capture(int argc, const char **argv)
                case 'f':
                        flags_element = optarg;
                        break;
+               case 'L':
+                       add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_DEREFERENCE;
+                       break;
                case 'v':
                        add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_VERBOSE;
                        write_flags |= WIMLIB_WRITE_FLAG_VERBOSE;
                        break;
-               case 'L':
-                       add_image_flags |= WIMLIB_ADD_IMAGE_FLAG_DEREFERENCE;
-                       break;
                default:
-                       usage(CAPTURE);
+                       usage(cmd);
                        return -1;
                }
        }
-
        argc -= optind;
        argv += optind;
        if (argc < 2 || argc > 4) {
-               usage(CAPTURE);
+               usage(cmd);
                return -1;
        }
-       dir     = argv[0];
+       dir = argv[0];
        wimfile = argv[1];
 
        char dir_copy[strlen(dir) + 1];
        memcpy(dir_copy, dir, strlen(dir) + 1);
        default_name = basename(dir_copy);
 
-       name    = (argc >= 3) ? argv[2] : default_name;
-       desc    = (argc >= 4) ? argv[3] : NULL;
+       name = (argc >= 3) ? argv[2] : default_name;
+       desc = (argc >= 4) ? argv[3] : NULL;
 
        if (config_file) {
                config_str = file_get_contents(config_file, &config_len);
@@ -668,9 +529,12 @@ static int imagex_capture(int argc, const char **argv)
                        return -1;
        }
 
-       ret = wimlib_create_new_wim(compression_type, &w);
+       if (cmd == APPEND)
+               ret = wimlib_open_wim(wimfile, open_flags, &w);
+       else
+               ret = wimlib_create_new_wim(compression_type, &w);
        if (ret != 0)
-               return ret;
+               goto out;
 
 #ifdef WITH_NTFS_3G
        struct stat stbuf;
@@ -689,18 +553,19 @@ static int imagex_capture(int argc, const char **argv)
                        goto out_write;
                }
        } else {
-               if (errno != ENOENT)
+               if (errno != ENOENT) {
                        imagex_error_with_errno("Failed to stat `%s'", dir);
+                       ret = -1;
+                       goto out;
+               }
        }
 #endif
-       ret = wimlib_add_image(w, dir, name, config_str,
-                              config_len, add_image_flags);
+       ret = wimlib_add_image(w, dir, name, config_str, config_len,
+                              add_image_flags);
 
 out_write:
-       if (ret != 0) {
-               imagex_error("Failed to add the image `%s'", dir);
+       if (ret != 0)
                goto out;
-       }
        cur_image = wimlib_get_num_images(w);
        if (desc) {
                ret = wimlib_set_image_descripton(w, cur_image, desc);
@@ -712,12 +577,15 @@ out_write:
                if (ret != 0)
                        goto out;
        }
-
-       ret = wimlib_write(w, wimfile, WIM_ALL_IMAGES, write_flags);
+       if (cmd == APPEND)
+               ret = wimlib_overwrite(w, write_flags);
+       else
+               ret = wimlib_write(w, wimfile, WIM_ALL_IMAGES, write_flags);
        if (ret != 0)
                imagex_error("Failed to write the WIM file `%s'", wimfile);
 out:
        wimlib_free(w);
+       free(config_str);
        return ret;
 }
 
@@ -766,12 +634,12 @@ static int imagex_delete(int argc, const char **argv)
 
        ret = verify_image_exists(image);
        if (ret != 0)
-               goto done;
+               goto out;
 
        ret = wimlib_delete_image(w, image);
        if (ret != 0) {
                imagex_error("Failed to delete image from `%s'", wimfile);
-               goto done;
+               goto out;
        }
 
        ret = wimlib_overwrite(w, write_flags);
@@ -779,7 +647,7 @@ static int imagex_delete(int argc, const char **argv)
                imagex_error("Failed to write the file `%s' with image "
                             "deleted", wimfile);
        }
-done:
+out:
        wimlib_free(w);
        return ret;
 }
@@ -792,7 +660,6 @@ static int imagex_dir(int argc, const char **argv)
        int image;
        int ret;
        int num_images;
-       int part_number;
 
        if (argc < 2) {
                imagex_error("Must specify a WIM file");
@@ -810,20 +677,11 @@ static int imagex_dir(int argc, const char **argv)
        if (ret != 0)
                return ret;
 
-       part_number = wimlib_get_part_number(w, NULL);
-       if (part_number != 1) {
-               imagex_error("`%s' is part %d of a split WIM!  Specify the "
-                            "first part to see the files",
-                            wimfile, part_number);
-               ret = WIMLIB_ERR_SPLIT_UNSUPPORTED;
-               goto done;
-       }
-
        if (argc == 3) {
                image = wimlib_resolve_image(w, argv[2]);
                ret = verify_image_exists(image);
                if (ret != 0)
-                       goto done;
+                       goto out;
        } else {
                /* Image was not specified.  If the WIM only contains one image,
                 * choose that one; otherwise, print an error. */
@@ -833,13 +691,13 @@ static int imagex_dir(int argc, const char **argv)
                                     "select one.", wimfile, num_images);
                        usage(DIR);
                        ret = -1;
-                       goto done;
+                       goto out;
                }
                image = 1;
        }
 
        ret = wimlib_print_files(w, image);
-done:
+out:
        wimlib_free(w);
        return ret;
 }
@@ -852,7 +710,7 @@ static int imagex_export(int argc, const char **argv)
        int open_flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS;
        int export_flags = 0;
        int write_flags = WIMLIB_WRITE_FLAG_SHOW_PROGRESS;
-       int compression_type = WIM_COMPRESSION_TYPE_XPRESS;
+       int compression_type;
        bool compression_type_specified = false;
        const char *src_wimfile;
        const char *src_image_num_or_name;
@@ -908,33 +766,40 @@ static int imagex_export(int argc, const char **argv)
        if (ret != 0)
                return ret;
 
-       /* Determine if the destination is an existing file or not.  
+       /* Determine if the destination is an existing file or not.
         * If so, we try to append the exported image(s) to it; otherwise, we
         * create a new WIM containing the exported image(s). */
        if (stat(dest_wimfile, &stbuf) == 0) {
+               int dest_ctype;
+
                wim_is_new = false;
                /* Destination file exists. */
                if (!S_ISREG(stbuf.st_mode) && !S_ISLNK(stbuf.st_mode)) {
                        imagex_error("`%s' is not a regular file",
                                        dest_wimfile);
+                       ret = -1;
                        goto out;
                }
                ret = wimlib_open_wim(dest_wimfile, open_flags, &dest_w);
                if (ret != 0)
                        goto out;
 
-               if (compression_type_specified && compression_type != 
-                               wimlib_get_compression_type(dest_w)) {
+               dest_ctype = wimlib_get_compression_type(dest_w);
+               if (compression_type_specified
+                   && compression_type != dest_ctype)
+               {
                        imagex_error("Cannot specify a compression type that is "
                                     "not the same as that used in the "
                                     "destination WIM");
                        ret = -1;
                        goto out;
                }
-               compression_type = wimlib_get_compression_type(dest_w);
+               compression_type = dest_ctype;
        } else {
                wim_is_new = true;
                /* dest_wimfile is not an existing file, so create a new WIM. */
+               if (!compression_type_specified)
+                       compression_type = wimlib_get_compression_type(src_w);
                if (errno == ENOENT) {
                        ret = wimlib_create_new_wim(compression_type, &dest_w);
                        if (ret != 0)
@@ -942,6 +807,7 @@ static int imagex_export(int argc, const char **argv)
                } else {
                        imagex_error_with_errno("Cannot stat file `%s'",
                                                dest_wimfile);
+                       ret = -1;
                        goto out;
                }
        }
@@ -959,7 +825,7 @@ static int imagex_export(int argc, const char **argv)
                        goto out;
        }
 
-       ret = wimlib_export_image(src_w, image, dest_w, dest_name, dest_desc, 
+       ret = wimlib_export_image(src_w, image, dest_w, dest_name, dest_desc,
                                  export_flags, additional_swms,
                                  num_additional_swms);
        if (ret != 0)
@@ -967,16 +833,18 @@ static int imagex_export(int argc, const char **argv)
 
 
        if (wim_is_new)
-               ret = wimlib_write(dest_w, dest_wimfile, WIM_ALL_IMAGES, 
+               ret = wimlib_write(dest_w, dest_wimfile, WIM_ALL_IMAGES,
                                   write_flags);
        else
                ret = wimlib_overwrite(dest_w, write_flags);
 out:
        wimlib_free(src_w);
        wimlib_free(dest_w);
-       if (additional_swms)
+       if (additional_swms) {
                for (unsigned i = 0; i < num_additional_swms; i++)
                        wimlib_free(additional_swms[i]);
+               free(additional_swms);
+       }
        return ret;
 }
 
@@ -1001,7 +869,7 @@ static int imagex_info(int argc, const char **argv)
        FILE *fp;
        int image;
        int ret;
-       int open_flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS | 
+       int open_flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS |
                         WIMLIB_OPEN_FLAG_SPLIT_OK;
        int part_number;
        int total_parts;
@@ -1053,7 +921,7 @@ static int imagex_info(int argc, const char **argv)
                        new_name = argv[2];
                        if (argc > 3) {
                                new_desc = argv[3];
-                       } 
+                       }
                }
        }
 
@@ -1066,23 +934,16 @@ static int imagex_info(int argc, const char **argv)
 
        part_number = wimlib_get_part_number(w, &total_parts);
 
-       /*if (total_parts > 1 && part_number > 1) {*/
-               /*printf("Warning: this is part %d of a %d-part split WIM.\n"*/
-                      /*"         Select the first part if you want to see information\n"*/
-                      /*"         about images in the WIM.\n", */
-                      /*part_number, total_parts);*/
-       /*}*/
-
        image = wimlib_resolve_image(w, image_num_or_name);
        if (image == WIM_NO_IMAGE && strcmp(image_num_or_name, "0") != 0) {
-               imagex_error("The image `%s' does not exist", 
+               imagex_error("The image `%s' does not exist",
                                                image_num_or_name);
                if (boot)
                        imagex_error("If you would like to set the boot "
                                     "index to 0, specify image \"0\" with "
                                     "the --boot flag.");
                ret = WIMLIB_ERR_INVALID_IMAGE;
-               goto done;
+               goto out;
        }
 
        if (image == WIM_ALL_IMAGES && wimlib_get_num_images(w) > 1) {
@@ -1091,14 +952,14 @@ static int imagex_info(int argc, const char **argv)
                                     "without specifying a specific "
                                     "image in a multi-image WIM");
                        ret = WIMLIB_ERR_INVALID_IMAGE;
-                       goto done;
+                       goto out;
                }
                if (new_name) {
                        imagex_error("Cannot specify the NEW_NAME "
                                     "without specifying a specific "
                                     "image in a multi-image WIM");
                        ret = WIMLIB_ERR_INVALID_IMAGE;
-                       goto done;
+                       goto out;
                }
        }
 
@@ -1106,11 +967,13 @@ static int imagex_info(int argc, const char **argv)
         * recreate the WIM file. */
        if (!new_name && !boot) {
 
+               /* Read-only operations */
+
                if (image == WIM_NO_IMAGE) {
                        imagex_error("`%s' is not a valid image",
                                     image_num_or_name);
                        ret = WIMLIB_ERR_INVALID_IMAGE;
-                       goto done;
+                       goto out;
                }
 
                if (image == WIM_ALL_IMAGES && short_header)
@@ -1131,7 +994,7 @@ static int imagex_info(int argc, const char **argv)
                if (xml) {
                        ret = wimlib_extract_xml_data(w, stdout);
                        if (ret != 0)
-                               goto done;
+                               goto out;
                }
 
                if (xml_out_file) {
@@ -1141,34 +1004,31 @@ static int imagex_info(int argc, const char **argv)
                                                        "file `%s' for "
                                                        "writing ",
                                                        xml_out_file);
-                               goto done;
+                               goto out;
                        }
                        ret = wimlib_extract_xml_data(w, fp);
                        if (fclose(fp) != 0) {
                                imagex_error("Failed to close the file `%s'",
                                             xml_out_file);
-                               goto done;
+                               goto out;
                        }
 
                        if (ret != 0)
-                               goto done;
+                               goto out;
                }
 
                if (short_header)
                        wimlib_print_available_images(w, image);
 
                if (metadata) {
-                       if (total_parts != 1 && part_number != 1) {
-                               imagex_error("Select part 1 of this %d-part WIM "
-                                            "to see the image metadata",
-                                            total_parts);
-                               return WIMLIB_ERR_SPLIT_UNSUPPORTED;
-                       }
                        ret = wimlib_print_metadata(w, image);
                        if (ret != 0)
-                               goto done;
+                               goto out;
                }
        } else {
+
+               /* Modification operations */
+
                if (total_parts != 1) {
                        imagex_error("Modifying a split WIM is not supported.");
                        return -1;
@@ -1194,7 +1054,7 @@ static int imagex_info(int argc, const char **argv)
                        }
                }
                if (new_name) {
-                       if (strcmp(wimlib_get_image_name(w, image), 
+                       if (strcmp(wimlib_get_image_name(w, image),
                                                new_name) == 0) {
                                printf("Image %d is already named \"%s\".\n",
                                       image, new_name);
@@ -1204,7 +1064,7 @@ static int imagex_info(int argc, const char **argv)
                                       "\"%s\".\n", image, new_name);
                                ret = wimlib_set_image_name(w, image, new_name);
                                if (ret != 0)
-                                       goto done;
+                                       goto out;
                        }
                }
                if (new_desc) {
@@ -1217,20 +1077,20 @@ static int imagex_info(int argc, const char **argv)
                        } else {
                                printf("Changing the description of image %d "
                                       "to \"%s\".\n", image, new_desc);
-                               ret = wimlib_set_image_descripton(w, image, 
+                               ret = wimlib_set_image_descripton(w, image,
                                                                  new_desc);
                                if (ret != 0)
-                                       goto done;
+                                       goto out;
                        }
                }
 
                /* Only call wimlib_overwrite_xml_and_header() if something
                 * actually needs to be changed. */
-               if (boot || new_name || new_desc || 
+               if (boot || new_name || new_desc ||
                                check != wimlib_has_integrity_table(w)) {
 
-                       ret = wimlib_overwrite_xml_and_header(w, check ? 
-                                       WIMLIB_WRITE_FLAG_CHECK_INTEGRITY | 
+                       ret = wimlib_overwrite_xml_and_header(w, check ?
+                                       WIMLIB_WRITE_FLAG_CHECK_INTEGRITY |
                                        WIMLIB_WRITE_FLAG_SHOW_PROGRESS : 0);
                } else {
                        printf("The file `%s' was not modified because nothing "
@@ -1238,9 +1098,8 @@ static int imagex_info(int argc, const char **argv)
                        ret = 0;
                }
        }
-
-done:
-       wimlib_free(w);
+out:
+       /*wimlib_free(w);*/
        return ret;
 }
 
@@ -1294,6 +1153,7 @@ static int imagex_mount_rw_or_ro(int argc, const char **argv)
 
        if (strcmp(argv[0], "mountrw") == 0)
                mount_flags |= WIMLIB_MOUNT_FLAG_READWRITE;
+
        for_opt(c, mount_options) {
                switch (c) {
                case 'c':
@@ -1346,7 +1206,7 @@ static int imagex_mount_rw_or_ro(int argc, const char **argv)
                if (num_images != 1) {
                        imagex_error("The file `%s' contains %d images; Please "
                                     "select one", wimfile, num_images);
-                       usage((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE)  
+                       usage((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE)
                                        ? MOUNTRW : MOUNT);
                        ret = WIMLIB_ERR_INVALID_IMAGE;
                        goto out;
@@ -1375,7 +1235,7 @@ out:
                        wimlib_free(additional_swms[i]);
        return ret;
 mount_usage:
-       usage((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE)  
+       usage((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE)
                        ? MOUNTRW : MOUNT);
        return -1;
 }
@@ -1386,6 +1246,7 @@ static int imagex_split(int argc, const char **argv)
        int c;
        int flags = WIMLIB_OPEN_FLAG_SHOW_PROGRESS;
        unsigned long part_size;
+       char *tmp;
 
        for_opt(c, split_options) {
                switch (c) {
@@ -1404,7 +1265,12 @@ static int imagex_split(int argc, const char **argv)
                usage(SPLIT);
                return -1;
        }
-       part_size = strtoul(argv[2], NULL, 10) * (1 << 20);
+       part_size = strtod(argv[2], &tmp) * (1 << 20);
+       if (tmp == argv[2] || *tmp) {
+               imagex_error("Invalid part size \"%s\"", argv[2]);
+               imagex_error("The part size must be an integer or floating-point number of megabytes.");
+               return -1;
+       }
        return wimlib_split(argv[0], argv[1], part_size, flags);
 }
 
@@ -1451,24 +1317,24 @@ struct imagex_command {
 #define for_imagex_command(p) for (p = &imagex_commands[0]; \
                p != &imagex_commands[ARRAY_LEN(imagex_commands)]; p++)
 
-static struct imagex_command imagex_commands[] = {
-       {"append",  imagex_append,         APPEND},
-       {"apply",   imagex_apply,          APPLY},
-       {"capture", imagex_capture,        CAPTURE},
-       {"delete",  imagex_delete,         DELETE},
-       {"dir",     imagex_dir,            DIR},
-       {"export",  imagex_export,         EXPORT},
-       {"info",    imagex_info,           INFO},
-       {"join",    imagex_join,           JOIN},
-       {"mount",   imagex_mount_rw_or_ro, MOUNT},
-       {"mountrw", imagex_mount_rw_or_ro, MOUNTRW},
-       {"split",   imagex_split,          SPLIT},
-       {"unmount", imagex_unmount,        UNMOUNT},
+static const struct imagex_command imagex_commands[] = {
+       {"append",  imagex_capture_or_append, APPEND},
+       {"apply",   imagex_apply,             APPLY},
+       {"capture", imagex_capture_or_append, CAPTURE},
+       {"delete",  imagex_delete,            DELETE},
+       {"dir",     imagex_dir,               DIR},
+       {"export",  imagex_export,            EXPORT},
+       {"info",    imagex_info,              INFO},
+       {"join",    imagex_join,              JOIN},
+       {"mount",   imagex_mount_rw_or_ro,    MOUNT},
+       {"mountrw", imagex_mount_rw_or_ro,    MOUNTRW},
+       {"split",   imagex_split,             SPLIT},
+       {"unmount", imagex_unmount,           UNMOUNT},
 };
 
 static void version()
 {
-       static const char *s = 
+       static const char *s =
        "imagex (" PACKAGE ") " PACKAGE_VERSION "\n"
        "Copyright (C) 2012 Eric Biggers\n"
        "License GPLv3+; GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n"
@@ -1484,7 +1350,7 @@ static void help_or_version(int argc, const char **argv)
 {
        int i;
        const char *p;
-       struct imagex_command *cmd;
+       const struct imagex_command *cmd;
 
        for (i = 1; i < argc; i++) {
                p = argv[i];
@@ -1494,7 +1360,7 @@ static void help_or_version(int argc, const char **argv)
                        continue;
                if (*p == '-')
                        p++;
-               if (strcmp(p, "help") == 0 || (*p == '?' && *(p + 1) == '\0')) {
+               if (strcmp(p, "help") == 0) {
                        for_imagex_command(cmd) {
                                if (strcmp(cmd->name, argv[1]) == 0) {
                                        usage(cmd->cmd);
@@ -1514,7 +1380,7 @@ static void help_or_version(int argc, const char **argv)
 
 static void usage(int cmd_type)
 {
-       struct imagex_command *cmd;
+       const struct imagex_command *cmd;
        puts("IMAGEX: Usage:");
        fputs(usage_strings[cmd_type], stdout);
        for_imagex_command(cmd)
@@ -1528,7 +1394,7 @@ static void usage_all()
        puts("IMAGEX: Usage:");
        for (int i = 0; i < ARRAY_LEN(usage_strings); i++)
                fputs(usage_strings[i], stdout);
-       static const char *extra = 
+       static const char *extra =
 "    imagex --help\n"
 "    imagex --version\n"
 "\n"
@@ -1542,7 +1408,7 @@ static void usage_all()
 
 int main(int argc, const char **argv)
 {
-       struct imagex_command *cmd;
+       const struct imagex_command *cmd;
        int ret;
 
        if (argc < 2) {
@@ -1575,10 +1441,3 @@ int main(int argc, const char **argv)
        usage_all();
        return 1;
 }
-/*#ifndef WITH_NTFS_3G*/
-               /*ERROR("wimlib was not compiled with support for NTFS-3g, so we cannot extract");*/
-               /*ERROR("a WIM to a NTFS filesystem while preserving NTFS-specific metadata.");*/
-               /*ERROR("Please apply the WIM to a directory rather than a block device, ");*/
-               /*ERROR("and without the NTFS flag; or compile in support for NTFS-3g.");*/
-               /*return WIMLIB_ERR_UNSUPPORTED;*/
-/*#endif*/