X-Git-Url: https://wimlib.net/git/?a=blobdiff_plain;f=src%2Fxml.c;h=6adba78cc8810b22d6fbcc8e3220c74bb92fe78a;hb=07f515b35e2e0711e999603e7cf66410c9969fa3;hp=a6e745aaf3f09405975077dc880f720b977331ff;hpb=161d3898359e3feb8c96ae220b376ef33c72a1d6;p=wimlib

diff --git a/src/xml.c b/src/xml.c
index a6e745aa..6adba78c 100644
--- a/src/xml.c
+++ b/src/xml.c
@@ -23,18 +23,26 @@
  * along with wimlib; if not, see http://www.gnu.org/licenses/.
  */
 
-#include "dentry.h"
-#include "lookup_table.h"
-#include "timestamp.h"
-#include "wimlib_internal.h"
-#include "xml.h"
+#ifdef HAVE_CONFIG_H
+#  include "config.h"
+#endif
 
-#include <string.h>
+#include "wimlib/dentry.h"
+#include "wimlib/encoding.h"
+#include "wimlib/error.h"
+#include "wimlib/file_io.h"
+#include "wimlib/lookup_table.h"
+#include "wimlib/metadata.h"
+#include "wimlib/resource.h"
+#include "wimlib/timestamp.h"
+#include "wimlib/xml.h"
+
+#include <libxml/encoding.h>
 #include <libxml/parser.h>
 #include <libxml/tree.h>
 #include <libxml/xmlwriter.h>
-#include <libxml/encoding.h>
 #include <limits.h>
+#include <string.h>
 
 /* Structures used to form an in-memory representation of the XML data (other
  * than the raw parse tree from libxml). */
@@ -439,8 +447,8 @@ xml_read_image_info(xmlNode *image_node, struct image_info *image_info)
 	}
 	if (!image_info->name) {
 		tchar *empty_name;
-		WARNING("Image with index %d has no name", image_info->index);
-		empty_name = TMALLOC(1);
+		/*WARNING("Image with index %d has no name", image_info->index);*/
+		empty_name = MALLOC(sizeof(tchar));
 		if (!empty_name)
 			return WIMLIB_ERR_NOMEM;
 		*empty_name = T('\0');
@@ -1211,7 +1219,7 @@ print_image_info(const struct wim_info *wim_info, int image)
 	wim_timestamp_to_str(image_info->creation_time, buf, sizeof(buf));
 	tprintf(T("Creation Time:          %"TS"\n"), buf);
 
-	wim_timestamp_to_str(image_info->creation_time, buf, sizeof(buf));
+	wim_timestamp_to_str(image_info->last_modification_time, buf, sizeof(buf));
 	tprintf(T("Last Modification Time: %"TS"\n"), buf);
 	if (image_info->windows_info_exists)
 		print_windows_info(&image_info->windows_info);
@@ -1221,14 +1229,14 @@ print_image_info(const struct wim_info *wim_info, int image)
 }
 
 void
-libxml_global_init()
+libxml_global_init(void)
 {
 	xmlInitParser();
 	xmlInitCharEncodingHandlers();
 }
 
 void
-libxml_global_cleanup()
+libxml_global_cleanup(void)
 {
 	xmlCleanupParser();
 	xmlCleanupCharEncodingHandlers();
@@ -1316,12 +1324,6 @@ out:
 	return ret;
 }
 
-#define CHECK_RET  ({ 	if (ret < 0)  { \
-				ERROR("Error writing XML data"); \
-				ret = WIMLIB_ERR_WRITE; \
-				goto out_free_text_writer; \
-			} })
-
 /*
  * Writes XML data to a WIM file.
  *
@@ -1397,11 +1399,13 @@ write_xml_data(const struct wim_info *wim_info, int image, int out_fd,
 	DEBUG("Writing <WIM> element");
 
 	ret = xmlTextWriterStartElement(writer, "WIM");
-	CHECK_RET;
+	if (ret < 0)
+		goto out_write_error;
 
 	ret = xmlTextWriterWriteFormatElement(writer, "TOTALBYTES", "%"PRIu64,
 					      total_bytes);
-	CHECK_RET;
+	if (ret < 0)
+		goto out_write_error;
 
 	if (wim_info != NULL) {
 		int first, last;
@@ -1416,17 +1420,24 @@ write_xml_data(const struct wim_info *wim_info, int image, int out_fd,
 		for (int i = first; i <= last; i++) {
 			ret = xml_write_image_info(writer, &wim_info->images[i - 1]);
 			if (ret) {
-				CHECK_RET;
+				if (ret < 0)
+					goto out_write_error;
 				goto out_free_text_writer;
 			}
 		}
 	}
 
 	ret = xmlTextWriterEndElement(writer);
-	CHECK_RET;
+	if (ret < 0)
+		goto out_write_error;
 
 	ret = xmlTextWriterEndDocument(writer);
-	CHECK_RET;
+	if (ret < 0)
+		goto out_write_error;
+
+	ret = xmlTextWriterFlush(writer);
+	if (ret < 0)
+		goto out_write_error;
 
 	DEBUG("Ended XML document");
 
@@ -1443,14 +1454,17 @@ write_xml_data(const struct wim_info *wim_info, int image, int out_fd,
 out_free_text_writer:
 	/* xmlFreeTextWriter will free the attached xmlOutputBuffer. */
 	xmlFreeTextWriter(writer);
-	out_buffer = NULL;
+	goto out;
 out_output_buffer_close:
-	if (out_buffer != NULL)
-		xmlOutputBufferClose(out_buffer);
+	xmlOutputBufferClose(out_buffer);
 out:
 	if (ret == 0)
 		DEBUG("Successfully wrote XML data");
 	return ret;
+out_write_error:
+	ERROR("Error writing XML data");
+	ret = WIMLIB_ERR_WRITE;
+	goto out_free_text_writer;
 }
 
 /* Returns the name of the specified image. */
@@ -1528,13 +1542,16 @@ wimlib_set_image_name(WIMStruct *w, int image, const tchar *name)
 {
 	tchar *p;
 	int i;
+	int ret;
 
 	DEBUG("Setting the name of image %d to %"TS, image, name);
 
-	if (!name || !*name) {
-		ERROR("Must specify a non-empty string for the image name");
-		return WIMLIB_ERR_INVALID_PARAM;
-	}
+	ret = can_modify_wim(w);
+	if (ret)
+		return ret;
+
+	if (name == NULL)
+		name = T("");
 
 	if (image < 1 || image > w->hdr.image_count) {
 		ERROR("%d is not a valid image", image);
@@ -1544,7 +1561,7 @@ wimlib_set_image_name(WIMStruct *w, int image, const tchar *name)
 	for (i = 1; i <= w->hdr.image_count; i++) {
 		if (i == image)
 			continue;
-		if (tstrcmp(w->wim_info->images[i - 1].name, name) == 0) {
+		if (!tstrcmp(w->wim_info->images[i - 1].name, name)) {
 			ERROR("The name \"%"TS"\" is already in use in the WIM!",
 			      name);
 			return WIMLIB_ERR_IMAGE_NAME_COLLISION;
@@ -1566,6 +1583,11 @@ do_set_image_info_str(WIMStruct *w, int image, const tchar *tstr,
 {
 	tchar *tstr_copy;
 	tchar **dest_tstr_p;
+	int ret;
+
+	ret = can_modify_wim(w);
+	if (ret)
+		return ret;
 
 	if (image < 1 || image > w->hdr.image_count) {
 		ERROR("%d is not a valid image", image);