X-Git-Url: https://wimlib.net/git/?a=blobdiff_plain;f=src%2Fmount_image.c;h=a2e09b435e43a60a72db289e0839c747315ceeaa;hb=394c5bd3292c0f3168416c0a5f25989e557b3cfc;hp=128e1736dcb21d3b157a6c7854a486618424f971;hpb=9e2571b03cd9c71d11b3dad9ea5dcfa43f50deb4;p=wimlib diff --git a/src/mount_image.c b/src/mount_image.c index 128e1736..a2e09b43 100644 --- a/src/mount_image.c +++ b/src/mount_image.c @@ -98,11 +98,8 @@ struct wimfs_context { * filesystem anyway. */ u64 next_ino; - /* List of lookup table entries for files in the staging directory */ - struct list_head staging_list; - /* List of inodes in the mounted image */ - struct hlist_head *image_inode_list; + struct list_head *image_inode_list; /* Name and message queue descriptors for message queues between the * filesystem daemon process and the unmount process. These are used @@ -128,7 +125,6 @@ init_wimfs_context(struct wimfs_context *ctx) memset(ctx, 0, sizeof(*ctx)); ctx->unmount_to_daemon_mq = (mqd_t)-1; ctx->daemon_to_unmount_mq = (mqd_t)-1; - INIT_LIST_HEAD(&ctx->staging_list); } #define WIMFS_CTX(fuse_ctx) ((struct wimfs_context*)(fuse_ctx)->private_data) @@ -296,7 +292,7 @@ close_wimfs_fd(struct wimfs_fd *fd) fd->f_inode->i_ino, fd->f_inode->i_num_opened_fds, fd->f_inode->i_num_allocated_fds); ret = lte_put_fd(fd->f_lte, fd); - if (ret != 0) + if (ret) return ret; inode_put_fd(fd->f_inode, fd); @@ -350,7 +346,7 @@ create_dentry(struct fuse_context *fuse_ctx, const char *path, } } dentry_add_child(parent, new); - hlist_add_head(&new->d_inode->i_hlist, wimfs_ctx->image_inode_list); + list_add_tail(&new->d_inode->i_list, wimfs_ctx->image_inode_list); if (dentry_ret) *dentry_ret = new; return 0; @@ -382,7 +378,7 @@ remove_dentry(struct wim_dentry *dentry, lte_decrement_refcnt(lte, lookup_table); } unlink_dentry(dentry); - put_dentry(dentry); + free_dentry(dentry); } static mode_t @@ -646,20 +642,13 @@ extract_resource_to_staging_dir(struct wim_inode *inode, } } - new_lte->refcnt = inode->i_nlink; - new_lte->resource_location = RESOURCE_IN_STAGING_FILE; - new_lte->staging_file_name = staging_file_name; - new_lte->lte_inode = inode; - - if (stream_id == 0) - inode->i_lte = new_lte; - else - for (u16 i = 0; i < inode->i_num_ads; i++) - if (inode->i_ads_entries[i].stream_id == stream_id) - inode->i_ads_entries[i].lte = new_lte; + new_lte->refcnt = inode->i_nlink; + new_lte->resource_location = RESOURCE_IN_STAGING_FILE; + new_lte->staging_file_name = staging_file_name; + new_lte->resource_entry.original_size = size; - lookup_table_insert_unhashed(ctx->wim->lookup_table, new_lte); - list_add_tail(&new_lte->staging_list, &ctx->staging_list); + lookup_table_insert_unhashed(ctx->wim->lookup_table, new_lte, + inode, stream_id); *lte = new_lte; return 0; out_revert_fd_changes: @@ -777,34 +766,6 @@ delete_staging_dir(struct wimfs_context *ctx) return ret; } -static void -inode_update_lte_ptr(struct wim_inode *inode, - struct wim_lookup_table_entry *old_lte, - struct wim_lookup_table_entry *new_lte) -{ - if (inode->i_lte == old_lte) { - inode->i_lte = new_lte; - } else { - for (unsigned i = 0; i < inode->i_num_ads; i++) { - if (inode->i_ads_entries[i].lte == old_lte) { - inode->i_ads_entries[i].lte = new_lte; - break; - } - } - } -} - -static void -free_lte_if_unneeded(struct wim_lookup_table_entry *lte) -{ - - if (wim_resource_size(lte) == 0) { - /* Zero-length stream. No lookup table entry needed. */ - inode_update_lte_ptr(lte->lte_inode, lte, NULL); - free_lookup_table_entry(lte); - } -} - static int inode_close_fds(struct wim_inode *inode) { @@ -830,23 +791,31 @@ rebuild_wim(struct wimfs_context *ctx, int write_flags, int ret; struct wim_lookup_table_entry *lte, *tmp; WIMStruct *w = ctx->wim; + struct wim_image_metadata *imd = wim_get_current_image_metadata(ctx->wim); DEBUG("Closing all staging file descriptors."); - list_for_each_entry_safe(lte, tmp, &ctx->staging_list, staging_list) { - ret = inode_close_fds(lte->lte_inode); - if (ret != 0) + image_for_each_unhashed_stream_safe(lte, tmp, imd) { + ret = inode_close_fds(lte->back_inode); + if (ret) return ret; } DEBUG("Freeing entries for zero-length streams"); - list_for_each_entry_safe(lte, tmp, &ctx->staging_list, staging_list) - free_lte_if_unneeded(lte); + image_for_each_unhashed_stream_safe(lte, tmp, imd) { + wimlib_assert(lte->unhashed); + if (wim_resource_size(lte) == 0) { + print_lookup_table_entry(lte, stderr); + struct wim_lookup_table_entry **back_ptr; + back_ptr = retrieve_lte_pointer(lte); + *back_ptr = NULL; + list_del(<e->unhashed_list); + free_lookup_table_entry(lte); + } + } xml_update_image_info(w, w->current_image); - list_splice(&ctx->staging_list, - &w->image_metadata[w->current_image - 1].unhashed_streams); ret = wimlib_overwrite(w, write_flags, 0, progress_func); - if (ret != 0) + if (ret) ERROR("Failed to commit changes to mounted WIM image"); return ret; } @@ -1694,9 +1663,7 @@ wimfs_link(const char *to, const char *from) struct wim_dentry *from_dentry, *from_dentry_parent; const char *link_name; struct wim_inode *inode; - struct wim_lookup_table_entry *lte; WIMStruct *w = wimfs_get_WIMStruct(); - u16 i; int ret; inode = wim_pathname_to_inode(w, to); @@ -1721,15 +1688,10 @@ wimfs_link(const char *to, const char *from) if (ret) return -ENOMEM; - inode_add_dentry(from_dentry, inode); - from_dentry->d_inode = inode; inode->i_nlink++; - - for (i = 0; i <= inode->i_num_ads; i++) { - lte = inode_stream_lte_resolved(inode, i); - if (lte) - lte->refcnt++; - } + inode_ref_streams(inode); + from_dentry->d_inode = inode; + inode_add_dentry(from_dentry, inode); dentry_add_child(from_dentry_parent, from_dentry); return 0; } @@ -1843,6 +1805,7 @@ wimfs_open(const char *path, struct fuse_file_info *fi) u16 stream_idx; u32 stream_id; struct wimfs_context *ctx = wimfs_get_context(); + struct wim_lookup_table_entry **back_ptr; ret = lookup_resource(ctx->wim, path, get_lookup_flags(ctx), &dentry, <e, &stream_idx); @@ -1851,10 +1814,13 @@ wimfs_open(const char *path, struct fuse_file_info *fi) inode = dentry->d_inode; - if (stream_idx == 0) + if (stream_idx == 0) { stream_id = 0; - else + back_ptr = &inode->i_lte; + } else { stream_id = inode->i_ads_entries[stream_idx - 1].stream_id; + back_ptr = &inode->i_ads_entries[stream_idx - 1].lte; + } /* The file resource may be in the staging directory (read-write mounts * only) or in the WIM. If it's in the staging directory, we need to @@ -1870,7 +1836,9 @@ wimfs_open(const char *path, struct fuse_file_info *fi) <e, size, ctx); if (ret != 0) return ret; + *back_ptr = lte; } + print_lookup_table_entry(lte, stderr); ret = alloc_wimfs_fd(inode, stream_id, lte, &fd, wimfs_ctx_readonly(ctx)); @@ -2239,24 +2207,23 @@ wimfs_truncate(const char *path, off_t size) if (lte == NULL && size == 0) return 0; - inode = dentry->d_inode; - if (stream_idx == 0) - stream_id = 0; - else - stream_id = inode->i_ads_entries[stream_idx - 1].stream_id; - if (lte->resource_location == RESOURCE_IN_STAGING_FILE) { ret = truncate(lte->staging_file_name, size); - if (ret != 0) + if (ret) ret = -errno; + else + lte->resource_entry.original_size = size; } else { /* File in WIM. Extract it to the staging directory, but only * the first @size bytes of it. */ + inode = dentry->d_inode; + if (stream_idx == 0) + stream_id = 0; + else + stream_id = inode->i_ads_entries[stream_idx - 1].stream_id; ret = extract_resource_to_staging_dir(inode, stream_id, <e, size, ctx); } - if (ret == 0) - lte->resource_entry.original_size = size; return ret; } @@ -2359,8 +2326,12 @@ wimfs_write(const char *path, const char *buf, size_t size, return -errno; /* Update file size */ - if (offset + size > fd->f_lte->resource_entry.original_size) + if (offset + size > fd->f_lte->resource_entry.original_size) { + DEBUG("Update file size %"PRIu64 " => %"PRIu64"", + fd->f_lte->resource_entry.original_size, + offset + size); fd->f_lte->resource_entry.original_size = offset + size; + } /* Update timestamps */ touch_inode(fd->f_inode); @@ -2441,7 +2412,6 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, struct wim_lookup_table *joined_tab, *wim_tab_save; struct wim_image_metadata *imd; struct wimfs_context ctx; - struct hlist_node *cur_node; struct wim_inode *inode; DEBUG("Mount: wim = %p, image = %d, dir = %s, flags = %d, ", @@ -2451,7 +2421,7 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, return WIMLIB_ERR_INVALID_PARAM; ret = verify_swm_set(wim, additional_swms, num_additional_swms); - if (ret != 0) + if (ret) return ret; if ((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE) && (wim->hdr.total_parts != 1)) { @@ -2463,7 +2433,7 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, ret = new_joined_lookup_table(wim, additional_swms, num_additional_swms, &joined_tab); - if (ret != 0) + if (ret) return ret; wim_tab_save = wim->lookup_table; wim->lookup_table = joined_tab; @@ -2471,28 +2441,29 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, if (mount_flags & WIMLIB_MOUNT_FLAG_READWRITE) { ret = wim_run_full_verifications(wim); - if (ret != 0) + if (ret) goto out; } + ret = wim_checksum_unhashed_streams(wim); + if (ret) + goto out; + ret = select_wim_image(wim, image); - if (ret != 0) + if (ret) goto out; DEBUG("Selected image %d", image); imd = wim_get_current_image_metadata(wim); - if (imd->root_dentry->refcnt != 1) { + if (imd->refcnt != 1) { ERROR("Cannot mount image that was just exported with " "wimlib_export_image()"); ret = WIMLIB_ERR_INVALID_PARAM; goto out; } - if (imd->inode_list.first) /* May be unneeded? */ - imd->inode_list.first->pprev = &imd->inode_list.first; - if (imd->modified) { ERROR("Cannot mount image that was added " "with wimlib_add_image()"); @@ -2502,7 +2473,7 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, if (mount_flags & WIMLIB_MOUNT_FLAG_READWRITE) { ret = lock_wim(wim, wim->fp); - if (ret != 0) + if (ret) goto out; } @@ -2512,7 +2483,6 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, WIMLIB_MOUNT_FLAG_STREAM_INTERFACE_WINDOWS))) mount_flags |= WIMLIB_MOUNT_FLAG_STREAM_INTERFACE_XATTR; - DEBUG("Initializing struct wimfs_context"); init_wimfs_context(&ctx); ctx.wim = wim; @@ -2520,12 +2490,14 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, ctx.image_inode_list = &imd->inode_list; ctx.default_uid = getuid(); ctx.default_gid = getgid(); + wimlib_assert(list_empty(&imd->unhashed_streams)); + ctx.wim->lookup_table->unhashed_streams = &imd->unhashed_streams; if (mount_flags & WIMLIB_MOUNT_FLAG_STREAM_INTERFACE_WINDOWS) ctx.default_lookup_flags = LOOKUP_FLAG_ADS_OK; DEBUG("Unlinking message queues in case they already exist"); ret = set_message_queue_names(&ctx, dir); - if (ret != 0) + if (ret) goto out_unlock; unlink_message_queues(&ctx); @@ -2563,7 +2535,7 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, if ((mount_flags & WIMLIB_MOUNT_FLAG_READWRITE)) { /* Read-write mount. Make the staging directory */ ret = make_staging_dir(&ctx, staging_dir); - if (ret != 0) + if (ret) goto out_free_dir_copy; } else { /* Read-only mount */ @@ -2596,7 +2568,7 @@ wimlib_mount_image(WIMStruct *wim, int image, const char *dir, * assign inode numbers */ DEBUG("Resolving lookup table entries and assigning inode numbers"); ctx.next_ino = 1; - hlist_for_each_entry(inode, cur_node, &imd->inode_list, i_hlist) { + image_for_each_inode(inode, imd) { inode_resolve_ltes(inode, wim->lookup_table); inode->i_ino = ctx.next_ino++; }