]> wimlib.net Git - wimlib/blobdiff - src/dentry.c
ads entries
[wimlib] / src / dentry.c
index c7c5fb9b9df6f5f9fa5d93263ab652a5d187654d..58782eb865e559606d47ee52ef4a1987b629de38 100644 (file)
@@ -79,7 +79,7 @@ static u64 __dentry_total_length(const struct dentry *dentry, u64 length)
 {
        const struct inode *inode = dentry->inode;
        for (u16 i = 0; i < inode->num_ads; i++)
-               length += ads_entry_total_length(inode->ads_entries[i]);
+               length += ads_entry_total_length(&inode->ads_entries[i]);
        return (length + 7) & ~7;
 }
 
@@ -118,20 +118,58 @@ void stbuf_to_inode(const struct stat *stbuf, struct inode *inode)
        inode->last_access_time = timespec_to_wim_timestamp(&stbuf->st_atim);
 }
 
-
-/* Sets all the timestamp fields of the dentry to the current time. */
-void inode_update_all_timestamps(struct inode *inode)
+#ifdef WITH_FUSE
+/* Transfers file attributes from a struct inode to a `stat' buffer. 
+ *
+ * The lookup table entry tells us which stream in the inode we are statting.
+ * For a named data stream, everything returned is the same as the unnamed data
+ * stream except possibly the size and block count. */
+int inode_to_stbuf(const struct inode *inode, struct lookup_table_entry *lte,
+                  struct stat *stbuf)
 {
-       u64 now = get_wim_timestamp();
-       inode->creation_time    = now;
-       inode->last_access_time = now;
-       inode->last_write_time  = now;
+       if (inode_is_symlink(inode))
+               stbuf->st_mode = S_IFLNK | 0777;
+       else if (inode_is_directory(inode))
+               stbuf->st_mode = S_IFDIR | 0755;
+       else
+               stbuf->st_mode = S_IFREG | 0644;
+
+       stbuf->st_ino   = (ino_t)inode->ino;
+       stbuf->st_nlink = inode->link_count;
+       stbuf->st_uid   = getuid();
+       stbuf->st_gid   = getgid();
+
+       if (lte) {
+               if (lte->resource_location == RESOURCE_IN_STAGING_FILE) {
+                       wimlib_assert(lte->staging_file_name);
+                       struct stat native_stat;
+                       if (stat(lte->staging_file_name, &native_stat) != 0) {
+                               DEBUG("Failed to stat `%s': %m",
+                                     lte->staging_file_name);
+                               return -errno;
+                       }
+                       stbuf->st_size = native_stat.st_size;
+               } else {
+                       stbuf->st_size = wim_resource_size(lte);
+               }
+       } else {
+               stbuf->st_size = 0;
+       }
+
+       stbuf->st_atime   = wim_timestamp_to_unix(inode->last_access_time);
+       stbuf->st_mtime   = wim_timestamp_to_unix(inode->last_write_time);
+       stbuf->st_ctime   = wim_timestamp_to_unix(inode->creation_time);
+       stbuf->st_blocks  = (stbuf->st_size + 511) / 512;
+       return 0;
 }
+#endif
 
+#ifdef WITH_FUSE
 /* Returns the alternate data stream entry belonging to @inode that has the
  * stream name @stream_name. */
 struct ads_entry *inode_get_ads_entry(struct inode *inode,
-                                     const char *stream_name)
+                                     const char *stream_name,
+                                     u16 *idx_ret)
 {
        size_t stream_name_len;
        if (!stream_name)
@@ -140,31 +178,46 @@ struct ads_entry *inode_get_ads_entry(struct inode *inode,
                u16 i = 0;
                stream_name_len = strlen(stream_name);
                do {
-                       if (ads_entry_has_name(inode->ads_entries[i],
+                       if (ads_entry_has_name(&inode->ads_entries[i],
                                               stream_name, stream_name_len))
-                               return inode->ads_entries[i];
+                       {
+                               if (idx_ret)
+                                       *idx_ret = i;
+                               return &inode->ads_entries[i];
+                       }
                } while (++i != inode->num_ads);
        }
        return NULL;
 }
+#endif
 
 
-static struct ads_entry *new_ads_entry(const char *name)
+static int init_ads_entry(struct ads_entry *ads_entry, const char *name)
 {
-       struct ads_entry *ads_entry = CALLOC(1, sizeof(struct ads_entry));
-       if (!ads_entry)
-               return NULL;
-       INIT_LIST_HEAD(&ads_entry->lte_group_list.list);
-       ads_entry->lte_group_list.type = STREAM_TYPE_ADS;
-       if (name && *name) {
-               if (change_ads_name(ads_entry, name)) {
-                       FREE(ads_entry);
-                       return NULL;
-               }
+       int ret = 0;
+       memset(ads_entry, 0, sizeof(*ads_entry));
+       if (name && *name)
+               ret = change_ads_name(ads_entry, name);
+       return ret;
+}
+
+static void destroy_ads_entry(struct ads_entry *ads_entry)
+{
+       FREE(ads_entry->stream_name);
+       FREE(ads_entry->stream_name_utf8);
+}
+
+
+void inode_free_ads_entries(struct inode *inode)
+{
+       if (inode->ads_entries) {
+               for (u16 i = 0; i < inode->num_ads; i++)
+                       destroy_ads_entry(&inode->ads_entries[i]);
+               FREE(inode->ads_entries);
        }
-       return ads_entry;
 }
 
+#if defined(WITH_FUSE) || defined(WITH_NTFS_3G)
 /* 
  * Add an alternate stream entry to an inode and return a pointer to it, or NULL
  * if memory could not be allocated.
@@ -172,10 +225,10 @@ static struct ads_entry *new_ads_entry(const char *name)
 struct ads_entry *inode_add_ads(struct inode *inode, const char *stream_name)
 {
        u16 num_ads;
-       struct ads_entry **ads_entries;
+       struct ads_entry *ads_entries;
        struct ads_entry *new_entry;
 
-       if (inode->num_ads == 0xffff) {
+       if (inode->num_ads >= 0xfffe) {
                ERROR("Too many alternate data streams in one inode!");
                return NULL;
        }
@@ -188,14 +241,43 @@ struct ads_entry *inode_add_ads(struct inode *inode, const char *stream_name)
        }
        inode->ads_entries = ads_entries;
 
-       new_entry = new_ads_entry(stream_name);
-       if (new_entry)
+       new_entry = &inode->ads_entries[num_ads - 1];
+       if (init_ads_entry(new_entry, stream_name) != 0)
                return NULL;
-       inode->num_ads = num_ads;
-       ads_entries[num_ads - 1] = new_entry;
+#ifdef WITH_FUSE
+       new_entry->stream_id = inode->next_stream_id++;
+#endif
        return new_entry;
 }
+#endif
+
+#ifdef WITH_FUSE
+/* Remove an alternate data stream from the inode  */
+void inode_remove_ads(struct inode *inode, u16 idx,
+                     struct lookup_table *lookup_table)
+{
+       struct ads_entry *ads_entry;
+       struct lookup_table_entry *lte;
+
+       ads_entry = &inode->ads_entries[idx];
+
+       wimlib_assert(ads_entry);
+       wimlib_assert(inode->resolved);
+
+       lte = ads_entry->lte;
 
+       if (lte)
+               lte_decrement_refcnt(lte, lookup_table);
+
+       destroy_ads_entry(ads_entry);
+
+       wimlib_assert(inode->num_ads);
+       memcpy(&inode->ads_entries[idx],
+              &inode->ads_entries[idx + 1],
+              (inode->num_ads - idx - 1) * sizeof(inode->ads_entries[0]));
+       inode->num_ads--;
+}
+#endif
 
 /* 
  * Calls a function on all directory entries in a directory tree.  It is called
@@ -212,7 +294,7 @@ int for_dentry_in_tree(struct dentry *root,
        if (ret != 0)
                return ret;
 
-       child = root->children;
+       child = root->inode->children;
 
        if (!child)
                return 0;
@@ -222,7 +304,7 @@ int for_dentry_in_tree(struct dentry *root,
                if (ret != 0)
                        return ret;
                child = child->next;
-       } while (child != root->children);
+       } while (child != root->inode->children);
        return 0;
 }
 
@@ -237,7 +319,7 @@ int for_dentry_in_tree_depth(struct dentry *root,
        struct dentry *child;
        struct dentry *next;
 
-       child = root->children;
+       child = root->inode->children;
        if (child) {
                do {
                        next = child->next;
@@ -245,7 +327,7 @@ int for_dentry_in_tree_depth(struct dentry *root,
                        if (ret != 0)
                                return ret;
                        child = next;
-               } while (child != root->children);
+               } while (child != root->inode->children);
        }
        return visitor(root, arg);
 }
@@ -311,7 +393,7 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
 {
        struct dentry *child;
 
-       child = dentry->children;
+       child = dentry->inode->children;
        dentry->subdir_offset = *subdir_offset_p;
 
        if (child) {
@@ -320,7 +402,7 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
                do {
                        *subdir_offset_p += dentry_correct_total_length(child);
                        child = child->next;
-               } while (child != dentry->children);
+               } while (child != dentry->inode->children);
 
                /* End-of-directory dentry on disk. */
                *subdir_offset_p += 8;
@@ -330,7 +412,7 @@ void calculate_subdir_offsets(struct dentry *dentry, u64 *subdir_offset_p)
                do {
                        calculate_subdir_offsets(child, subdir_offset_p);
                        child = child->next;
-               } while (child != dentry->children);
+               } while (child != dentry->inode->children);
        } else {
                /* On disk, childless directories have a valid subdir_offset
                 * that points to an 8-byte end-of-directory dentry.  Regular
@@ -351,14 +433,14 @@ struct dentry *get_dentry_child_with_name(const struct dentry *dentry,
        struct dentry *child;
        size_t name_len;
        
-       child = dentry->children;
+       child = dentry->inode->children;
        if (child) {
                name_len = strlen(name);
                do {
                        if (dentry_has_name(child, name, name_len))
                                return child;
                        child = child->next;
-               } while (child != dentry->children);
+               } while (child != dentry->inode->children);
        }
        return NULL;
 }
@@ -375,14 +457,14 @@ static struct dentry *get_dentry_relative_path(struct dentry *cur_dir,
        if (*path == '\0')
                return cur_dir;
 
-       child = cur_dir->children;
+       child = cur_dir->inode->children;
        if (child) {
                new_path = path_next_part(path, &base_len);
                do {
                        if (dentry_has_name(child, path, base_len))
                                return get_dentry_relative_path(child, new_path);
                        child = child->next;
-               } while (child != cur_dir->children);
+               } while (child != cur_dir->inode->children);
        }
        return NULL;
 }
@@ -397,6 +479,16 @@ struct dentry *get_dentry(WIMStruct *w, const char *path)
        return get_dentry_relative_path(root, path);
 }
 
+struct inode *wim_pathname_to_inode(WIMStruct *w, const char *path)
+{
+       struct dentry *dentry;
+       dentry = get_dentry(w, path);
+       if (!dentry)
+               return NULL;
+       else
+               return dentry->inode;
+}
+
 /* Returns the dentry that corresponds to the parent directory of @path, or NULL
  * if the dentry is not found. */
 struct dentry *get_parent_dentry(WIMStruct *w, const char *path)
@@ -509,9 +601,9 @@ int print_dentry(struct dentry *dentry, void *lookup_table)
        }
        for (u16 i = 0; i < inode->num_ads; i++) {
                printf("[Alternate Stream Entry %u]\n", i);
-               printf("Name = \"%s\"\n", inode->ads_entries[i]->stream_name_utf8);
+               printf("Name = \"%s\"\n", inode->ads_entries[i].stream_name_utf8);
                printf("Name Length (UTF-16) = %u\n",
-                       inode->ads_entries[i]->stream_name_len);
+                       inode->ads_entries[i].stream_name_len);
                hash = inode_stream_hash(inode, i + 1);
                if (hash) {
                        printf("Hash              = 0x"); 
@@ -584,15 +676,18 @@ err:
        return NULL;
 }
 
-struct dentry *new_dentry_with_inode(const char *name)
+
+static struct dentry *__new_dentry_with_inode(const char *name, bool timeless)
 {
        struct dentry *dentry;
        dentry = new_dentry(name);
        if (dentry) {
-               dentry->inode = new_inode();
+               if (timeless)
+                       dentry->inode = new_timeless_inode();
+               else
+                       dentry->inode = new_inode();
                if (dentry->inode) {
-                       list_add(&dentry->inode_dentry_list,
-                                &dentry->inode->dentry_list);
+                       inode_add_dentry(dentry, dentry->inode);
                } else {
                        free_dentry(dentry);
                        dentry = NULL;
@@ -601,120 +696,74 @@ struct dentry *new_dentry_with_inode(const char *name)
        return dentry;
 }
 
-static void free_ads_entry(struct ads_entry *entry)
+struct dentry *new_dentry_with_timeless_inode(const char *name)
 {
-       if (entry) {
-               FREE(entry->stream_name);
-               FREE(entry->stream_name_utf8);
-               FREE(entry);
-       }
+       return __new_dentry_with_inode(name, true);
 }
 
-
-#ifdef WITH_FUSE
-/* Remove an alternate data stream from a dentry.
- *
- * The corresponding lookup table entry for the stream is NOT changed.
- *
- * @dentry:    The dentry
- * @ads_entry: The alternate data stream entry (it MUST be one of the
- *                ads_entry's in the array dentry->ads_entries).
- */
-void dentry_remove_ads(struct dentry *dentry, struct ads_entry *ads_entry)
+struct dentry *new_dentry_with_inode(const char *name)
 {
-       u16 idx;
-       u16 following;
-
-       wimlib_assert(dentry->num_ads);
-       idx = ads_entry - dentry->ads_entries;
-       wimlib_assert(idx < dentry->num_ads);
-       following = dentry->num_ads - idx - 1;
-
-       destroy_ads_entry(ads_entry);
-       memcpy(ads_entry, ads_entry + 1, following * sizeof(struct ads_entry));
-
-       /* We moved the ADS entries.  Adjust the stream lists. */
-       for (u16 i = 0; i < following; i++) {
-               struct list_head *cur = &ads_entry[i].lte_group_list.list;
-               struct list_head *prev = cur->prev;
-               struct list_head *next;
-               if ((u8*)prev >= (u8*)(ads_entry + 1)
-                   && (u8*)prev < (u8*)(ads_entry + following + 1)) {
-                       cur->prev = (struct list_head*)((u8*)prev - sizeof(struct ads_entry));
-               } else {
-                       prev->next = cur;
-               }
-               next = cur->next;
-               if ((u8*)next >= (u8*)(ads_entry + 1)
-                   && (u8*)next < (u8*)(ads_entry + following + 1)) {
-                       cur->next = (struct list_head*)((u8*)next - sizeof(struct ads_entry));
-               } else {
-                       next->prev = cur;
-               }
-       }
-       dentry->num_ads--;
+       return __new_dentry_with_inode(name, false);
 }
-#endif
 
-static void inode_free_ads_entries(struct inode *inode)
-{
-       if (inode->ads_entries) {
-               for (u16 i = 0; i < inode->num_ads; i++)
-                       free_ads_entry(inode->ads_entries[i]);
-               FREE(inode->ads_entries);
-       }
-}
 
+/* Frees an inode. */
 void free_inode(struct inode *inode)
 {
        if (inode) {
                inode_free_ads_entries(inode);
+       #ifdef WITH_FUSE
+               wimlib_assert(inode->num_opened_fds == 0);
+               FREE(inode->fds);
+       #endif
                FREE(inode);
        }
 }
 
-void put_inode(struct inode *inode)
+/* Decrements link count on an inode and frees it if the link count reaches 0.
+ * */
+struct inode *put_inode(struct inode *inode)
 {
        if (inode) {
                wimlib_assert(inode->link_count);
-               if (--inode->link_count)
-                       free_inode(inode);
+               if (--inode->link_count == 0) {
+               #ifdef WITH_FUSE
+                       if (inode->num_opened_fds == 0)
+               #endif
+                       {
+                               free_inode(inode);
+                               inode = NULL;
+                       }
+               }
        }
+       return inode;
 }
 
-/* Frees a WIM dentry. */
-void free_dentry(struct dentry *dentry)
+/* Frees a WIM dentry. 
+ *
+ * The inode is freed only if its link count is decremented to 0.
+ */
+struct inode *free_dentry(struct dentry *dentry)
 {
        wimlib_assert(dentry);
+       struct inode *inode;
 
        FREE(dentry->file_name);
        FREE(dentry->file_name_utf8);
        FREE(dentry->short_name);
        FREE(dentry->full_path_utf8);
-       put_inode(dentry->inode);
+       inode = put_inode(dentry->inode);
        FREE(dentry);
+       return inode;
 }
 
-/* Partically clones a dentry.
- *
- * Beware:
- *     - memory for file names is not cloned (the pointers are all set to NULL
- *       and the lengths are set to zero)
- *     - next, prev, and children pointers and not touched
- */
-struct dentry *clone_dentry(struct dentry *old)
+void put_dentry(struct dentry *dentry)
 {
-       struct dentry *new = MALLOC(sizeof(struct dentry));
-       if (!new)
-               return NULL;
-       memcpy(new, old, sizeof(struct dentry));
-       new->file_name          = NULL;
-       new->file_name_len      = 0;
-       new->file_name_utf8     = NULL;
-       new->file_name_utf8_len = 0;
-       new->short_name         = NULL;
-       new->short_name_len     = 0;
-       return new;
+       wimlib_assert(dentry);
+       wimlib_assert(dentry->refcnt);
+
+       if (--dentry->refcnt == 0)
+               free_dentry(dentry);
 }
 
 /* 
@@ -729,6 +778,7 @@ static int do_free_dentry(struct dentry *dentry, void *__lookup_table)
        unsigned i;
 
        if (lookup_table) {
+               wimlib_assert(inode->link_count);
                for (i = 0; i <= inode->num_ads; i++) {
                        lte = inode_stream_lte(inode, i, lookup_table);
                        lte_decrement_refcnt(lte, lookup_table);
@@ -773,36 +823,35 @@ void link_dentry(struct dentry *dentry, struct dentry *parent)
 {
        wimlib_assert(dentry_is_directory(parent));
        dentry->parent = parent;
-       if (parent->children) {
+       if (parent->inode->children) {
                /* Not an only child; link to siblings. */
-               dentry->next = parent->children;
-               dentry->prev = parent->children->prev;
+               dentry->next = parent->inode->children;
+               dentry->prev = parent->inode->children->prev;
                dentry->next->prev = dentry;
                dentry->prev->next = dentry;
        } else {
                /* Only child; link to parent. */
-               parent->children = dentry;
+               parent->inode->children = dentry;
                dentry->next = dentry;
                dentry->prev = dentry;
        }
 }
 
 
-/* Unlink a dentry from the directory tree. 
+/* 
+ * Unlink a dentry from the directory tree. 
  *
- * Note: This merely removes it from the in-memory tree structure.  See
- * remove_dentry() in mount.c for a function implemented on top of this one that
- * frees the dentry and implements reference counting for the lookup table
- * entries. */
+ * Note: This merely removes it from the in-memory tree structure.
+ */
 void unlink_dentry(struct dentry *dentry)
 {
        if (dentry_is_root(dentry))
                return;
        if (dentry_is_only_child(dentry)) {
-               dentry->parent->children = NULL;
+               dentry->parent->inode->children = NULL;
        } else {
                if (dentry_is_first_sibling(dentry))
-                       dentry->parent->children = dentry->next;
+                       dentry->parent->inode->children = dentry->next;
                dentry->next->prev = dentry->prev;
                dentry->prev->next = dentry->next;
        }
@@ -915,7 +964,7 @@ void calculate_dir_tree_statistics(struct dentry *root, struct lookup_table *tab
        stats.file_count      = file_count_ret;
        stats.total_bytes     = total_bytes_ret;
        stats.hard_link_bytes = hard_link_bytes_ret;
-       for_lookup_table_entry(table, zero_out_refcnts, NULL);
+       for_lookup_table_entry(table, lte_zero_out_refcnt, NULL);
        for_dentry_in_tree(root, calculate_dentry_statistics, &stats);
 }
 
@@ -964,7 +1013,7 @@ static int read_ads_entries(const u8 *p, struct inode *inode,
                            u64 remaining_size)
 {
        u16 num_ads;
-       struct ads_entry **ads_entries;
+       struct ads_entry *ads_entries;
        int ret;
 
        num_ads = inode->num_ads;
@@ -983,13 +1032,11 @@ static int read_ads_entries(const u8 *p, struct inode *inode,
                size_t utf8_len;
                const u8 *p_save = p;
 
-               cur_entry = new_ads_entry(NULL);
-               if (!cur_entry) {
-                       ret = WIMLIB_ERR_NOMEM;
-                       goto out_free_ads_entries;
-               }
+               cur_entry = &ads_entries[i];
 
-               ads_entries[i] = cur_entry;
+       #ifdef WITH_FUSE
+               ads_entries[i].stream_id = i + 1;
+       #endif
 
                /* Read the base stream entry, excluding the stream name. */
                if (remaining_size < WIM_ADS_ENTRY_DISK_SIZE) {
@@ -1075,10 +1122,13 @@ static int read_ads_entries(const u8 *p, struct inode *inode,
                        remaining_size -= total_length;
        }
        inode->ads_entries = ads_entries;
+#ifdef WITH_FUSE
+       inode->next_stream_id = inode->num_ads + 1;
+#endif
        return 0;
 out_free_ads_entries:
        for (u16 i = 0; i < num_ads; i++)
-               free_ads_entry(ads_entries[i]);
+               destroy_ads_entry(&ads_entries[i]);
        FREE(ads_entries);
        return ret;
 }
@@ -1337,25 +1387,23 @@ out_free_inode:
        return ret;
 }
 
-/* Run some miscellaneous verifications on a WIM dentry */
-int verify_dentry(struct dentry *dentry, void *wim)
+int verify_inode(struct inode *inode, const WIMStruct *w)
 {
-       const WIMStruct *w = wim;
        const struct lookup_table *table = w->lookup_table;
        const struct wim_security_data *sd = wim_const_security_data(w);
-       const struct inode *inode = dentry->inode;
+       const struct dentry *first_dentry = inode_first_dentry(inode);
        int ret = WIMLIB_ERR_INVALID_DENTRY;
 
        /* Check the security ID */
        if (inode->security_id < -1) {
                ERROR("Dentry `%s' has an invalid security ID (%d)",
-                       dentry->full_path_utf8, inode->security_id);
+                       first_dentry->full_path_utf8, inode->security_id);
                goto out;
        }
        if (inode->security_id >= sd->num_entries) {
                ERROR("Dentry `%s' has an invalid security ID (%d) "
                      "(there are only %u entries in the security table)",
-                       dentry->full_path_utf8, inode->security_id,
+                       first_dentry->full_path_utf8, inode->security_id,
                        sd->num_entries);
                goto out;
        }
@@ -1371,9 +1419,40 @@ int verify_dentry(struct dentry *dentry, void *wim)
                        lte = __lookup_resource(table, hash);
                        if (!lte && !is_zero_hash(hash)) {
                                ERROR("Could not find lookup table entry for stream "
-                                     "%u of dentry `%s'", i, dentry->full_path_utf8);
+                                     "%u of dentry `%s'", i, first_dentry->full_path_utf8);
                                goto out;
                        }
+                       if (lte && (lte->real_refcnt += inode->link_count) > lte->refcnt)
+                       {
+                       #ifdef ENABLE_ERROR_MESSAGES
+                               WARNING("The following lookup table entry "
+                                       "has a reference count of %u, but",
+                                       lte->refcnt);
+                               WARNING("We found %zu references to it",
+                                       lte->real_refcnt);
+                               WARNING("(One dentry referencing it is at `%s')",
+                                        first_dentry->full_path_utf8);
+
+                               print_lookup_table_entry(lte);
+                       #endif
+                               /* Guess what!  install.wim for Windows 8
+                                * contains a stream with 2 dentries referencing
+                                * it, but the lookup table entry has reference
+                                * count of 1.  So we will need to handle this
+                                * case and not just make it be an error...  I'm
+                                * just setting the reference count to the
+                                * number of references we found.
+                                * (Unfortunately, even after doing this, the
+                                * reference count could be too low if it's also
+                                * referenced in other WIM images) */
+
+                       #if 1
+                               lte->refcnt = lte->real_refcnt;
+                               WARNING("Fixing reference count");
+                       #else
+                               goto out;
+                       #endif
+                       }
                }
        }
 
@@ -1387,9 +1466,28 @@ int verify_dentry(struct dentry *dentry, void *wim)
        }
        if (num_unnamed_streams > 1) {
                ERROR("Dentry `%s' has multiple (%u) un-named streams", 
-                     dentry->full_path_utf8, num_unnamed_streams);
+                     first_dentry->full_path_utf8, num_unnamed_streams);
                goto out;
        }
+       inode->verified = true;
+       ret = 0;
+out:
+       return ret;
+}
+
+
+/* Run some miscellaneous verifications on a WIM dentry */
+int verify_dentry(struct dentry *dentry, void *wim)
+{
+       const WIMStruct *w = wim;
+       const struct inode *inode = dentry->inode;
+       int ret = WIMLIB_ERR_INVALID_DENTRY;
+
+       if (!dentry->inode->verified) {
+               ret = verify_inode(dentry->inode, w);
+               if (ret != 0)
+                       goto out;
+       }
 
        /* Cannot have a short name but no long name */
        if (dentry->short_name_len && !dentry->file_name_len) {
@@ -1486,14 +1584,14 @@ static u8 *write_dentry(const struct dentry *dentry, u8 *p)
         * read_ads_entries() for comments about the format of the on-disk
         * alternate data stream entries. */
        for (u16 i = 0; i < inode->num_ads; i++) {
-               p = put_u64(p, ads_entry_total_length(inode->ads_entries[i]));
+               p = put_u64(p, ads_entry_total_length(&inode->ads_entries[i]));
                p = put_u64(p, 0); /* Unused */
                hash = inode_stream_hash(inode, i + 1);
                p = put_bytes(p, SHA1_HASH_SIZE, hash);
-               p = put_u16(p, inode->ads_entries[i]->stream_name_len);
-               if (inode->ads_entries[i]->stream_name_len) {
-                       p = put_bytes(p, inode->ads_entries[i]->stream_name_len,
-                                        (u8*)inode->ads_entries[i]->stream_name);
+               p = put_u16(p, inode->ads_entries[i].stream_name_len);
+               if (inode->ads_entries[i].stream_name_len) {
+                       p = put_bytes(p, inode->ads_entries[i].stream_name_len,
+                                        (u8*)inode->ads_entries[i].stream_name);
                        p = put_u16(p, 0);
                }
                p = put_zeroes(p, (8 - (p - orig_p) % 8) % 8);
@@ -1520,12 +1618,12 @@ static u8 *write_dentry_tree_recursive(const struct dentry *parent, u8 *p)
         * recursively writing the directory trees rooted at each of the child
         * dentries, since the on-disk dentries for a dentry's children are
         * always located at consecutive positions in the metadata resource! */
-       child = parent->children;
+       child = parent->inode->children;
        if (child) {
                do {
                        p = write_dentry(child, p);
                        child = child->next;
-               } while (child != parent->children);
+               } while (child != parent->inode->children);
        }
 
        /* write end of directory entry */
@@ -1536,7 +1634,7 @@ static u8 *write_dentry_tree_recursive(const struct dentry *parent, u8 *p)
                do {
                        p = write_dentry_tree_recursive(child, p);
                        child = child->next;
-               } while (child != parent->children);
+               } while (child != parent->inode->children);
        }
        return p;
 }
@@ -1632,7 +1730,7 @@ int read_dentry_tree(const u8 metadata_resource[], u64 metadata_resource_len,
 
                child->parent = dentry;
                prev_child = child;
-               list_add(&child->inode_dentry_list, &child->inode->dentry_list);
+               inode_add_dentry(child, child->inode);
 
                /* If there are children of this child, call this procedure
                 * recursively. */
@@ -1657,6 +1755,6 @@ int read_dentry_tree(const u8 metadata_resource[], u64 metadata_resource_len,
                prev_child->next = first_child;
                first_child->prev = prev_child;
        }
-       dentry->children = first_child;
+       dentry->inode->children = first_child;
        return ret;
 }