Page 1 of 1

AV inside wimlib_add_tree

Posted: Mon Jun 26, 2023 12:15 am
by Dec
I have some code that works fine with dll version 1.13.5. I'm trying to upgrade to version 1.14.1 and now I can see the AV inside wimlib_add_tree. Nothing has changed in my code. I just replaced the dll with the newest version. My code is logging all calls and callbacks, and the logs show the following sequence of calls:

WimLibCreateNewWim
WimLibAddEmptyImage
WimLibGetWimInfo
WimLibRegisterProgressFunction
WimLibAddTree
Callback.OnProgressCallback
Access violation at address 66A08E21 in module 'libwim-15.32.dll'. Read address FFFFFFFF

What can I check to try to get rid of the problem? Detailed logs in attachment.

Re: AV inside wimlib_add_tree

Posted: Mon Jun 26, 2023 1:31 am
by synchronicity
Hi, thanks for reporting this.

I expect that https://wimlib.net/git/?p=wimlib;a=comm ... 99cce11f77 fixes the problem.

Can you check if the attached binary works?

Please note: if my theory is correct, then this problem only occurred in the 32-bit builds. Regardless of whether my fix worked or not, please consider using the 64-bit build instead. It is 2023, after all!

Re: AV inside wimlib_add_tree

Posted: Mon Jun 26, 2023 2:06 am
by Dec
synchronicity wrote: Mon Jun 26, 2023 1:31 amCan you check if the attached binary works?
Yes, this solves the problem. Are you planning to create an official update or should I use this version?
synchronicity wrote: Mon Jun 26, 2023 1:31 amif my theory is correct, then this problem only occurred in the 32-bit builds.
You are right, x64 works fine.
synchronicity wrote: Mon Jun 26, 2023 1:31 amplease consider using the 64-bit build instead.
I use both variant.

Re: AV inside wimlib_add_tree

Posted: Wed Jun 28, 2023 6:11 pm
by synchronicity
It probably will be a month or two before I release v1.14.2. I might post a BETA sooner. You can also just use the binary I attached above (which was built from git commit 4cdfe1f65507, using the GitHub Actions workflow), or do a build yourself using the instructions in README.WINDOWS.

Re: AV inside wimlib_add_tree

Posted: Sat Jul 08, 2023 8:43 pm
by synchronicity
I've uploaded wimlib v1.14.2-BETA1 which includes the fix for this.

Re: AV inside wimlib_add_tree

Posted: Sun Aug 06, 2023 6:26 pm
by synchronicity
This fix was released in wimlib v1.14.2.